onfido 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 27279800cfff5a840ce97b9e8de9dc74a5083ea1c57f8a10b87e5bc2950f1067
-  data.tar.gz: 922fdbde05fe24981a5e2cf6d6be173f6db0c8966521e07a7271c15df3849440
+  metadata.gz: 94d4e590e003b1ff219091a7690385782a3aa1ef7ee46000f185cf183a81702e
+  data.tar.gz: 1961655f50cdf2f8148e83310b2d0bbebd0c3139ed3de5b63f3c001d398b02d3
 SHA512:
-  metadata.gz: 0982bae64d5589a5909f03f92904445ea0f1912c554912a46893b61647756794522b11dbc46bb8e562712572c5459bd8f1a819e3e10d539bbbf6e5e7c077b5be
-  data.tar.gz: 8b741438cefff280b5ad6c1c6a7db958910f78553fd3e7315943a00247b6badc993154991c6866242dd2342eb31f8bc937904672fd4a01594f5feb1f454664d0
+  metadata.gz: 490a955c369dd6934ac60685ef628cc6a821b461efa13113b7e381aa5bd1a6bb958996d1ed2add552f661d18236112a541fb900b2c6a54e09ef9eaa37f2a1346
+  data.tar.gz: 72d9cdadfc3f73c75464cbe7fe7cb36b764ac2c420fa7afb2268e2a5d31b9c1139d5829faa2d9e830a3bd7b02d2ec12203c66e80b80c92947a0be0f58166c7e8

data/.rubocop.yml

@@ -51,3 +51,7 @@ Layout/DotPosition:
 # Allow class and message or instance raises
 Style/RaiseArgs:
   Enabled: false
+
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - "spec/**/*"

data/.travis.yml

@@ -1,17 +1,14 @@
 language: ruby
 
-matrix:
-  allow_failures:
-    - rvm: jruby
-    - rvm: rbx-2
-
 rvm:
-  - 2.2
   - 2.3
   - 2.4
   - 2.5
-  - jruby
-  - rbx-2
+  - 2.6
+
+before_install:
+    - gem update --system
+    - gem install bundler
 
 script:
   - bundle exec rubocop

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## v0.15.0, 4 Feb 2019
+
+- Add Check#find_by_url method (@ctrlaltdylan)
+
 ## v0.14.0, 28 Jan 2019
 
 - Add support for applicant deletion and restore endpoints

data/README.md

@@ -12,7 +12,7 @@ This gem supports both `v1` and `v2` of the Onfido API. Refer to Onfido's [API d
 Add this line to your application's Gemfile:
 
 ```ruby
-gem 'onfido', '~> 0.13.0'
+gem 'onfido', '~> 0.15.0'
 ```
 
 The gem is compatible with Ruby 2.2.0 and onwards. Earlier versions of Ruby have [reached end-of-life](https://www.ruby-lang.org/en/news/2017/04/01/support-of-ruby-2-1-has-ended/), are no longer supported and no longer receive security fixes.
@@ -74,7 +74,7 @@ api.applicant.find('applicant_id')            # => Finds a single applicant
 api.applicant.all                             # => Returns all applicants
 ```
 
-**Note:** Calling api.applicant.destroy adds the applicant and all associated documents, photos, videos, checks, and reports to the deletion queue. They will be deleted 20 days after the request is made. An applicant that is scheduled for deletion can be restored but applicants that have been permanently deleted cannot be restored.
+**Note:** Calling `api.applicant.destroy` adds the applicant and all associated documents, photos, videos, checks, and reports to the deletion queue. They will be deleted 20 days after the request is made. An applicant that is scheduled for deletion can be restored but applicants that have been permanently deleted cannot.
 See https://documentation.onfido.com/#delete-applicant for more information.
 
 #### Documents
@@ -117,6 +117,7 @@ more "reports" on them.
 ```ruby
 api.check.create('applicant_id', type: 'express', reports: [{ name: 'identity' }])
 api.check.find('applicant_id', 'check_id')
+api.check.find_by_url(params[:payload][:object][:href])
 api.check.resume('check_id')
 api.check.all('applicant_id')
 ```

data/lib/onfido/resources/check.rb

@@ -13,6 +13,12 @@ module Onfido
                        "#{querystring}"))
     end
 
+    def find_by_url(url, expand: nil)
+      url_path = url.sub(%r/^https\:\/\/api\.onfido\.com\/v2\//, '')
+      querystring = "&expand=#{expand}" if expand
+      get(url: url_for("#{url_path}?#{querystring}"))
+    end
+
     def all(applicant_id, page: 1, per_page: 20, expand: nil)
       querystring = "page=#{page}&per_page=#{per_page}"
       querystring += "&expand=#{expand}" if expand

data/lib/onfido/version.rb

@@ -1,3 +1,3 @@
 module Onfido
-  VERSION = '0.14.0'.freeze
+  VERSION = '0.15.0'.freeze
 end

data/onfido.gemspec

@@ -23,7 +23,7 @@ Gem::Specification.new do |spec|
   spec.require_paths = ['lib']
   spec.required_ruby_version = ">= 2.2.0"
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'rake', '~> 12.0'
   spec.add_development_dependency 'rspec', '~> 3.1'
   spec.add_development_dependency 'rspec-its', '~> 1.2'

data/spec/integrations/applicant_spec.rb

@@ -114,7 +114,9 @@ describe Onfido::Applicant do
         expect { applicant.restore(applicant_id) }.to raise_error { |error|
           expect(error).to be_a(Onfido::RequestError)
           expect(error.message).to eq('There was a validation error on this request')
-          expect(error.fields).to eq("Applicant #{applicant_id} is not scheduled for deletion")
+          expect(error.fields).to eq(
+            "Applicant a2fb9c62-ab10-4898-a8ec-342c4b552ad5 is not scheduled for deletion"
+          )
         }
       end
     end

data/spec/integrations/check_spec.rb

@@ -30,6 +30,50 @@ describe Onfido::Check do
     end
   end
 
+  describe '#find_by_url' do
+    let(:check_id) { '8546921-123123-123123' }
+
+    context 'partial url' do
+      let(:url) { "applicants/#{applicant_id}/checks/#{check_id}" }
+
+      it 'returns an existing check for the applicant with the partial url' do
+        response = check.find_by_url(url)
+        expect(response['id']).to eq(check_id)
+      end
+
+      it "returns unexpanded reports" do
+        response = check.find_by_url(url)
+        expect(response['reports'].first).to be_a(String)
+      end
+
+      it 'allows you to expand the reports' do
+        response = check.find_by_url(url, expand: "reports")
+        expect(response['reports'].first).to be_a(Hash)
+      end
+    end
+
+    context 'full url' do
+      let(:url) do
+        "https://api.onfido.com/v2/applicants/#{applicant_id}/checks/#{check_id}"
+      end
+
+      it 'returns an existing check for the applicant with the partial url' do
+        response = check.find_by_url(url)
+        expect(response['id']).to eq(check_id)
+      end
+
+      it "returns unexpanded reports" do
+        response = check.find_by_url(url)
+        expect(response['reports'].first).to be_a(String)
+      end
+
+      it 'allows you to expand the reports' do
+        response = check.find_by_url(url, expand: "reports")
+        expect(response['reports'].first).to be_a(Hash)
+      end
+    end
+  end
+
   describe '#all' do
     let(:check_id) { '8546921-123123-123123' }
 

data/spec/support/fixtures/not_scheduled_for_deletion_error.json

@@ -0,0 +1,7 @@
+{
+    "error": {
+        "type": "validation_error",
+        "message": "There was a validation error on this request",
+        "fields": "Applicant a2fb9c62-ab10-4898-a8ec-342c4b552ad5 is not scheduled for deletion"
+    }
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onfido
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - Pericles Theodorou
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-01-28 00:00:00.000000000 Z
+date: 2019-02-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -209,6 +209,7 @@ files:
 - spec/support/fixtures/live_photos.json
 - spec/support/fixtures/live_video.json
 - spec/support/fixtures/live_videos.json
+- spec/support/fixtures/not_scheduled_for_deletion_error.json
 - spec/support/fixtures/report.json
 - spec/support/fixtures/report_type_group.json
 - spec/support/fixtures/report_type_groups.json
@@ -236,8 +237,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.4
+rubygems_version: 3.0.2
 signing_key: 
 specification_version: 4
 summary: A wrapper for Onfido API
@@ -274,6 +274,7 @@ test_files:
 - spec/support/fixtures/live_photos.json
 - spec/support/fixtures/live_video.json
 - spec/support/fixtures/live_videos.json
+- spec/support/fixtures/not_scheduled_for_deletion_error.json
 - spec/support/fixtures/report.json
 - spec/support/fixtures/report_type_group.json
 - spec/support/fixtures/report_type_groups.json