onfido 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 6ade11756020fd962ad312d8ebd50cca72b47df9
-  data.tar.gz: 08d2c3429fb9acff54175a1cb80f9a58fc1357b0
+  metadata.gz: c107bba12384d55217719e5283953f0a0111f927
+  data.tar.gz: 4d77e8f946b6d035e3b126b4d9b01b3807a4c295
 SHA512:
-  metadata.gz: 863ada612067a0e826ead5d97b0eb98043c53bc4fd1d174b00a8b2d173a2ec86a1c3411be7c1721d671131e0c703baa73116a06bdf056158b93f2d8394062fdd
-  data.tar.gz: 51e5078edb94d2457833aed52f4e4f7b249085f2fe5730d7d743f024c8e01c39cfdd584ad3f0560896958676ac88c607a819acbce589d2be4262f38757e74fa0
+  metadata.gz: cef79ba60503372169905e3abf66b2ac4d55b46141a9758abce82cf8a91ed72aa02e6635d7675d7a37280818605b5843f62d47d99a5c72164a850b15282c9559
+  data.tar.gz: adc95bedaa0ef4e1d75e3ee87a21a765383d9e39b4f19b0f7779741c1e65c7b514934d243c7644567933bc25139b61f5eee596a29456bf8d58fcd2fef732fec3

data/.travis.yml

@@ -0,0 +1,16 @@
+language: ruby
+
+matrix:
+  allow_failures:
+    - rvm: jruby
+    - rvm: rbx-2
+
+rvm:
+  - 2.0
+  - 2.1
+  - 2.2
+  - jruby
+  - rbx-2
+
+script:
+  - bundle exec rspec spec

data/CHANGELOG.md

@@ -0,0 +1,3 @@
+## v0.0.4 10 November 2015
+
+- Split out connection errors so they can be automatically retried

data/README.md

@@ -3,7 +3,10 @@
 A wrapper for Onfido's [API](https://onfido.com/documentation#introduction). You should always refer to the documentation for valid API calls.
 
 [![Build Status](https://snap-ci.com/hvssle/onfido/branch/master/build_image)](https://snap-ci.com/hvssle/onfido/branch/master)
-[![Gem Version](https://badge.fury.io/rb/onfido.svg)](http://badge.fury.io/rb/onfido) [!['gitter room'][2]][1]
+[![Gem Version](https://badge.fury.io/rb/onfido.svg)](http://badge.fury.io/rb/onfido)
+[![Build Status](https://travis-ci.org/hvssle/onfido.svg?branch=master)](https://travis-ci.org/hvssle/onfido)
+[!['gitter room'][2]][1]
+
 
   [1]: https://gitter.im/hvssle/onfido
   [2]: https://badges.gitter.im/gitterHQ/developers.png
@@ -27,13 +30,15 @@ Or install it yourself as:
 
 ## Usage
 
-There are 3 configuration options for Onfido, including  your `api_key`, throwing exceptions for failed responses and logging the requests. By default, `throws_exceptions` is set to `true`. If set to `false`, the response body will be returned instead.
+There are 5 configuration options for Onfido, including your `api_key`, throwing exceptions for failed responses and logging the requests. By default, `throws_exceptions` is set to `true`. If set to `false` and Onfido responds with a valid JSON body the response body will be returned instead.
 
 ```ruby
   Onfido.configure do |config|
     config.api_key = 'MY_API_KEY'
     config.logger = Logger.new(STDOUT)
     config.throws_exceptions = false
+    config.open_timeout = 30
+    config.read_timeout = 80
   end
 ```
 
@@ -122,13 +127,31 @@ To search for addresses by postcode
   api.address.all('SE1 4NG')
 ```
 
+### Pagination
+
+Currently, you can paginate over the *applicant* and *check* resources. However, since you can only create 1 check per applicant therefore paginating on the check resource might prove impractical.
+
+By default, both endpoints are fetching records the first 20 records. That is the maximum amount of records you can request per page.
+
+To paginate over *applicants*:
+```ruby
+api = Onfido::API.new
+api.applicant.all(page: 2, per_page: 10)
+```
+
+To paginate over *checks*:
+```
+api = Onfido::API.new
+api.check.all('applicant_id', page: 2, per_page: 10)
+```
+
 ## Error Handling
 
 By default, Onfido will attempt to raise errors returned by the API automatically.
 
 If you set the `throws_exceptions` to false, it will simply return the response body. This allows you to handle errors manually.
 
-If you rescue Onfido::RequestError, you are provided with the error message itself as well as the type of error, response code and fields that have errored. Here's how you might do that:
+If you rescue `Onfido::RequestError`, you are provided with the error message itself as well as the type of error, response code and fields that have errored. Here's how you might do that:
 
 ```ruby
   def create_applicant
@@ -140,6 +163,8 @@ If you rescue Onfido::RequestError, you are provided with the error message itse
   end
 ```
 
+You can also rescue `Onfido::ConnectionError`, which is raised whenever something goes wrong with the connection to Onfido - you may wish to automatically retry these requests.
+
 ### Roadmap
 
 - Improve test coverage with more scenarios

data/lib/onfido.rb

@@ -5,10 +5,9 @@ require 'open-uri'
 
 require 'onfido/version'
 require 'onfido/configuration'
-require 'onfido/request_error'
-require 'onfido/response_handler'
+require 'onfido/errors/request_error'
+require 'onfido/errors/connection_error'
 require 'onfido/null_logger'
-require 'onfido/requestable'
 require 'onfido/resource'
 require 'onfido/address'
 require 'onfido/applicant'

data/lib/onfido/configuration.rb

@@ -1,6 +1,6 @@
 module Onfido
   module Configuration
-    attr_accessor :api_key, :throws_exceptions
+    attr_accessor :api_key, :throws_exceptions, :open_timeout, :read_timeout
 
     def self.extended(base)
       base.reset
@@ -13,6 +13,8 @@ module Onfido
     def reset
       self.api_key = nil
       self.throws_exceptions = true
+      self.open_timeout = 30
+      self.read_timeout = 80
       RestClient.log = nil
     end
 

data/lib/onfido/errors/connection_error.rb

@@ -0,0 +1,4 @@
+module Onfido
+  class ConnectionError < StandardError
+  end
+end

data/lib/onfido/{request_error.rb → errors/request_error.rb}

@@ -19,5 +19,13 @@ specified in the Onfido documentation e.g.
 module Onfido
   class RequestError < StandardError
     attr_accessor :type, :fields, :response_code
+
+    def initialize(message=nil, type: nil, fields: nil, response_code: nil)
+      @type = type
+      @fields = fields
+      @response_code = response_code
+
+      super(message)
+    end
   end
 end

data/lib/onfido/resource.rb

@@ -2,26 +2,53 @@ module Onfido
   class Resource
     VALID_HTTP_METHODS = %i(get post)
 
-    include Requestable
-
     def url_for(path)
       Onfido.endpoint + path
     end
 
-    def method_missing(method, *args)
-      if VALID_HTTP_METHODS.include?(method.to_sym)
+    VALID_HTTP_METHODS.each do |method|
+      define_method method do |*args|
         make_request(
+          method: method.to_sym,
           url: args.first.fetch(:url),
-          payload: build_query(args.first.fetch(:payload)),
-          method: method.to_sym
+          payload: build_query(args.first.fetch(:payload))
         )
+      end
+    end
+
+    private
+
+    def make_request(options)
+      url = options.fetch(:url)
+      payload = options.fetch(:payload)
+      method = options.fetch(:method)
+
+      request_options = {
+        url: url,
+        payload: payload,
+        method: method,
+        headers: headers,
+        open_timeout: Onfido.open_timeout,
+        timeout: Onfido.read_timeout
+      }
+
+      response = RestClient::Request.execute(request_options)
+
+      parse(response)
+    rescue RestClient::ExceptionWithResponse => e
+      if e.response
+        handle_api_error(e.response)
       else
-        super
+        handle_restclient_error(e, url)
       end
+    rescue RestClient::Exception, Errno::ECONNREFUSED => e
+      handle_restclient_error(e, url)
     end
 
-    def respond_to_missing?(method, include_private = false)
-      VALID_HTTP_METHODS.include?(method.to_sym) || super
+    def parse(response)
+      JSON.parse(response.body)
+    rescue JSON::ParserError
+      general_api_error(response.code, response.body)
     end
 
     def headers
@@ -31,8 +58,6 @@ module Onfido
       }
     end
 
-    private
-
     # There seems to be a serialization issue with the HTTP client
     # which does not serialize the payload properly.
     # Have a look here https://gist.github.com/PericlesTheo/cb35139c57107ab3c84a
@@ -44,5 +69,66 @@ module Onfido
         Rack::Utils.build_nested_query(payload)
       end
     end
+
+    def handle_api_error(response)
+      parsed_response = parse(response)
+
+      unless parsed_response["error"]
+        general_api_error(response.code, response.body)
+      end
+
+      if Onfido.throws_exceptions
+        raise RequestError.new(
+          parsed_response["error"]['message'],
+          type: parsed_response["error"]["type"],
+          fields: parsed_response["error"]["fields"],
+          response_code: response.code)
+      else
+        parsed_response
+      end
+    end
+
+    def general_api_error(response_code, response_body)
+      raise RequestError.new(
+        "Invalid response object from API: #{response_body} " \
+        "(HTTP response code was #{response_code})",
+        response_code: response_code
+      )
+    end
+
+    def handle_restclient_error(e, url)
+      connection_message =
+        "Please check your internet connection and try again. " \
+        "If this problem persists, you should let us know at info@onfido.com."
+
+      message =
+        case e
+        when RestClient::RequestTimeout
+          "Could not connect to Onfido (#{url}). #{connection_message}"
+
+        when RestClient::ServerBrokeConnection
+          "The connection to the server (#{url}) broke before the " \
+          "request completed. #{connection_message}"
+
+        when RestClient::SSLCertificateNotVerified
+            "Could not verify Onfido's SSL certificate. Please make sure " \
+            "that your network is not intercepting certificates. " \
+            "(Try going to #{Onfido.endpoint} in your browser.) " \
+            "If this problem persists, let us know at info@onfido.com."
+
+        when SocketError
+            "Unexpected error when trying to connect to Onfido. " \
+            "You may be seeing this message because your DNS is not working. " \
+            "To check, try running 'host onfido.com' from the command line."
+
+        else
+          "Unexpected error communicating with Onfido. " \
+          "If this problem persists, let us know at info@onfido.com."
+        end
+
+      full_message = message + "\n\n(Network error: #{e.message})"
+
+      raise ConnectionError.new(full_message)
+    end
   end
 end

data/lib/onfido/version.rb

@@ -1,3 +1,3 @@
 module Onfido
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/onfido.gemspec

@@ -20,6 +20,7 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 1.7'
   spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'webmock', '~> 1.22'
 
   spec.add_dependency 'rest-client', '~> 1.8.0'
 end

data/spec/integrations/exceptions_spec.rb

@@ -0,0 +1,116 @@
+describe Onfido::Resource do
+  let(:resource) { described_class.new }
+  let(:url) { Onfido.endpoint + path }
+  let(:api_key) { 'some_key' }
+  let(:payload) { { postcode: 'SE1 4NG' } }
+
+
+  before do
+    allow(Onfido).to receive(:api_key).and_return(api_key)
+  end
+
+  context '4xx response' do
+    let(:path) { '4xx_response' }
+
+    context "when 'throws_exceptions' is true" do
+      before { allow(Onfido).to receive(:throws_exceptions).and_return(true) }
+
+      it 'raises a custom error' do
+        expect { resource.get({ url: url, payload: payload }) }.
+          to raise_error(Onfido::RequestError, 'Something went wrong')
+      end
+    end
+
+    context "when 'throws_exceptions' is false" do
+      before { allow(Onfido).to receive(:throws_exceptions).and_return(false) }
+
+      it 'returns the body as a hash' do
+        response = resource.get({ url: url, payload: payload })
+        expect(response['error']).not_to be_nil
+      end
+    end
+  end
+
+  context 'unexpected error format' do
+    let(:path) { 'unexpected_error_format' }
+
+    context "when 'throws_exceptions' is true" do
+      before { allow(Onfido).to receive(:throws_exceptions).and_return(true) }
+
+      it 'raises a custom error' do
+        expect { resource.get({ url: url, payload: payload }) }.
+          to raise_error(Onfido::RequestError, /response code was 400/)
+      end
+    end
+
+    context "when 'throws_exceptions' is false" do
+      before { allow(Onfido).to receive(:throws_exceptions).and_return(false) }
+
+      it 'still raises a custom error' do
+        expect { resource.get({ url: url, payload: payload }) }.
+          to raise_error(Onfido::RequestError, /response code was 400/)
+      end
+    end
+  end
+
+  context 'unparseable JSON' do
+    let(:path) { 'unparseable_response' }
+
+    context "when 'throws_exceptions' is true" do
+      before { allow(Onfido).to receive(:throws_exceptions).and_return(true) }
+
+      it 'raises a custom error' do
+        expect { resource.get({ url: url, payload: payload }) }.
+          to raise_error(Onfido::RequestError, /response code was 504/)
+      end
+    end
+
+    context "when 'throws_exceptions' is false" do
+      before { allow(Onfido).to receive(:throws_exceptions).and_return(false) }
+
+      it 'still raises a custom error' do
+        expect { resource.get({ url: url, payload: payload }) }.
+          to raise_error(Onfido::RequestError, /response code was 504/)
+      end
+    end
+  end
+
+  context 'timeout' do
+    before do
+      allow(RestClient::Request).
+        to receive(:execute).
+        and_raise(RestClient::RequestTimeout)
+    end
+
+    it 'raises a ConnectionError' do
+      expect { resource.get({ url: Onfido.endpoint, payload: payload }) }.
+        to raise_error(Onfido::ConnectionError, /Could not connect/)
+    end
+  end
+
+  context 'broken connection' do
+    before do
+      allow(RestClient::Request).
+        to receive(:execute).
+        and_raise(RestClient::ServerBrokeConnection)
+    end
+
+    it 'raises a ConnectionError' do
+      expect { resource.get({ url: Onfido.endpoint, payload: payload }) }.
+        to raise_error(Onfido::ConnectionError, /connection to the server/)
+    end
+  end
+
+  context "bad SSL certificate" do
+    before do
+      allow(RestClient::Request).
+        to receive(:execute).
+        and_raise(RestClient::SSLCertificateNotVerified.new(nil))
+    end
+
+    it 'raises a ConnectionError' do
+      expect { resource.get({ url: Onfido.endpoint, payload: payload }) }.
+        to raise_error(Onfido::ConnectionError, /SSL certificate/)
+    end
+  end
+end

data/spec/onfido/resource_spec.rb

@@ -25,7 +25,9 @@ describe Onfido::Resource do
         end
       end
     end
+  end
 
+  describe "valid http methods" do
     %i(get post).each do |method|
       context "for supported HTTP method: #{method}" do
         let(:url) { endpoint + path }
@@ -49,13 +51,18 @@ describe Onfido::Resource do
               url: url,
               payload: Rack::Utils.build_query(payload),
               method: method,
-              headers: resource.headers
-            )
-            .and_return(response)
+              headers: resource.send(:headers),
+              open_timeout: 30,
+              timeout: 80
+            ).and_call_original
+
+          WebMock.stub_request(method, url).
+            to_return(body: response.to_json, status: 200)
         end
 
         it 'makes a request to an endpoint' do
-          expect(resource.public_send(method, {url: url, payload: payload})).to eq(response)
+          expect(resource.public_send(method, {url: url, payload: payload})).
+            to eq(response)
         end
       end
     end

data/spec/support/fake_onfido_api.rb

@@ -47,6 +47,16 @@ class FakeOnfidoAPI < Sinatra::Base
     json_response(422, '4xx_response.json')
   end
 
+  get '/v1/unexpected_error_format' do
+    json_response(400, 'unexpected_error_format.json')
+  end
+
+  get '/v1/unparseable_response' do
+    content_type :json
+    status 504
+    ''
+  end
+
   private
 
   def json_response(response_code, file_name)

data/spec/support/fixtures/unexpected_error_format.json

@@ -0,0 +1,3 @@
+{
+  "unexpected": "format"
+}

metadata

@@ -1,55 +1,69 @@
 --- !ruby/object:Gem::Specification
 name: onfido
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Pericles Theodorou
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-22 00:00:00.000000000 Z
+date: 2015-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: '10.0'
+- !ruby/object:Gem::Dependency
+  name: webmock
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.22'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ~>
+      - !ruby/object:Gem::Version
+        version: '1.22'
 - !ruby/object:Gem::Dependency
   name: rest-client
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ~>
       - !ruby/object:Gem::Version
         version: 1.8.0
 description: A wrapper for Onfido API 1.0
@@ -59,9 +73,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".gitignore"
-- ".rspec"
-- ".ruby-version"
+- .gitignore
+- .rspec
+- .travis.yml
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - LICENSE.txt
@@ -74,23 +89,21 @@ files:
 - lib/onfido/check.rb
 - lib/onfido/configuration.rb
 - lib/onfido/document.rb
+- lib/onfido/errors/connection_error.rb
+- lib/onfido/errors/request_error.rb
 - lib/onfido/null_logger.rb
 - lib/onfido/report.rb
-- lib/onfido/request_error.rb
-- lib/onfido/requestable.rb
 - lib/onfido/resource.rb
-- lib/onfido/response_handler.rb
 - lib/onfido/version.rb
 - onfido.gemspec
-- spec/integrations/4xx_response_spec.rb
 - spec/integrations/address_spec.rb
 - spec/integrations/applicant_spec.rb
 - spec/integrations/check_spec.rb
 - spec/integrations/document_spec.rb
+- spec/integrations/exceptions_spec.rb
 - spec/integrations/report_spec.rb
 - spec/onfido/request_error_spec.rb
 - spec/onfido/resource_spec.rb
-- spec/onfido/response_handler_spec.rb
 - spec/onfido_spec.rb
 - spec/spec_helper.rb
 - spec/support/fake_onfido_api.rb
@@ -103,6 +116,7 @@ files:
 - spec/support/fixtures/document.json
 - spec/support/fixtures/report.json
 - spec/support/fixtures/reports.json
+- spec/support/fixtures/unexpected_error_format.json
 homepage: http://github.com/hvssle/onfido
 licenses:
 - MIT
@@ -113,12 +127,12 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - '>='
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
@@ -128,15 +142,14 @@ signing_key:
 specification_version: 4
 summary: A wrapper for Onfido API 1.0
 test_files:
-- spec/integrations/4xx_response_spec.rb
 - spec/integrations/address_spec.rb
 - spec/integrations/applicant_spec.rb
 - spec/integrations/check_spec.rb
 - spec/integrations/document_spec.rb
+- spec/integrations/exceptions_spec.rb
 - spec/integrations/report_spec.rb
 - spec/onfido/request_error_spec.rb
 - spec/onfido/resource_spec.rb
-- spec/onfido/response_handler_spec.rb
 - spec/onfido_spec.rb
 - spec/spec_helper.rb
 - spec/support/fake_onfido_api.rb
@@ -149,3 +162,4 @@ test_files:
 - spec/support/fixtures/document.json
 - spec/support/fixtures/report.json
 - spec/support/fixtures/reports.json
+- spec/support/fixtures/unexpected_error_format.json

data/.ruby-version

@@ -1 +0,0 @@
-2.1.3

data/lib/onfido/requestable.rb

@@ -1,12 +0,0 @@
-module Onfido
-  module Requestable
-    def make_request(options)
-      url = options.fetch(:url)
-      payload = options.fetch(:payload)
-      method = options.fetch(:method)
-      RestClient::Request.execute(url: url, payload: payload, method: method, headers: headers) do |response, *|
-        ResponseHandler.new(response).parse!
-      end
-    end
-  end
-end

data/lib/onfido/response_handler.rb

@@ -1,38 +0,0 @@
-module Onfido
-  class ResponseHandler
-    attr_reader :response
-
-    def initialize(response)
-      @response = response
-    end
-
-    def parse!
-      if Onfido.throws_exceptions && parsed_response["error"]
-        raise request_error
-      else
-        parsed_response
-      end
-    end
-
-    private
-
-    def parsed_response
-      @parsed_response ||=
-        begin
-          JSON.parse(response)
-        rescue JSON::ParserError
-          {
-            'error' => {"message" => "Unparseable response: #{response}"}
-          }
-        end
-    end
-
-    def request_error
-      RequestError.new(parsed_response['error']['message']).tap do |error|
-        error.type = parsed_response['error']["type"]
-        error.fields = parsed_response['error']["fields"]
-        error.response_code = response.code if response.respond_to?(:code)
-      end
-    end
-  end
-end

data/spec/integrations/4xx_response_spec.rb

@@ -1,35 +0,0 @@
-describe Onfido::Resource do
-  let(:resource) { described_class.new }
-  let(:url) { Onfido.endpoint + path }
-  let(:api_key) { 'some_key' }
-  let(:payload) { {postcode: 'SE1 4NG'} }
-
-
-  before do
-    allow(Onfido).to receive(:api_key).and_return(api_key)
-  end
-
-  context 'when a response is a 4xx' do
-    let(:path) { '4xx_response' }
-
-    context "when 'throws_exceptions' is true" do
-      it 'raises a custom error' do
-        expect {
-          resource.get({url: url, payload: payload})
-        }.to raise_error(
-        Onfido::RequestError, 'Something went wrong')
-      end
-    end
-
-    context "when 'throws_exceptions' is false" do
-      before do
-        allow(Onfido).to receive(:throws_exceptions).and_return(false)
-      end
-
-      it 'returns the body as a hash' do
-        response = resource.get({url: url, payload: payload})
-        expect(response['error']).not_to be_nil
-      end
-    end
-  end
-end

data/spec/onfido/response_handler_spec.rb

@@ -1,79 +0,0 @@
-describe Onfido::ResponseHandler do
-  subject(:handler) { described_class.new(response) }
-
-  describe '#parse!' do
-    before do
-      allow(Onfido).to receive(:throws_exceptions).and_return(throws_exceptions)
-    end
-
-    let(:throws_exceptions) { true }
-
-    context 'when the response is successful' do
-      let(:response) { hashified_response.to_json }
-      let(:hashified_response) do
-        {'success' => 'applicant was successfully created'}
-      end
-
-      it 'parses the body and returns it' do
-        expect(handler.parse!).to eq(hashified_response)
-      end
-    end
-
-    context 'when the response has gracefully errored' do
-      let(:response) { hashified_response.to_json }
-      let(:hashified_response) do
-        {
-          'error' => {
-            'message' => 'Authorization error: please re-check your credentials'
-          }
-        }
-      end
-
-      context 'when throw_exceptions configuration is set to true' do
-        it 'raises an error' do
-          expect { handler.parse! }.to raise_error(
-            Onfido::RequestError,
-            'Authorization error: please re-check your credentials'
-          )
-        end
-      end
-
-      context 'when throw_exceptions configuration is set to false' do
-        let(:throws_exceptions) { false }
-
-
-        it 'parses the body and returns it' do
-          expect(handler.parse!).to eq(hashified_response)
-        end
-      end
-    end
-
-    context 'when the response is unparseable' do
-      let(:response) { 'something : wrong' }
-
-      context 'when throw_exceptions configuration is set to true' do
-        it 'raises an error' do
-          expect { handler.parse! }.to raise_error(
-            Onfido::RequestError,
-            'Unparseable response: something : wrong'
-          )
-        end
-      end
-
-      context 'when throw_exceptions configuration is set to false' do
-        let(:throws_exceptions) { false }
-
-
-        it 'parses the body and returns it' do
-          expect(handler.parse!).to eq(
-            {
-              'error' => {
-                'message' => 'Unparseable response: something : wrong'
-              }
-            }
-          )
-        end
-      end
-    end
-  end
-end