oneview-sdk 1.0.0 → 2.0.0

data/lib/oneview-sdk/resource/firmware_bundle.rb

@@ -1,37 +1,36 @@
+# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# You may not use this file except in compliance with the License.
+# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+
 module OneviewSDK
   # Firmware bundle resource implementation
   class FirmwareBundle
     BASE_URI = '/rest/firmware-bundles'.freeze
-    BOUNDARY = '---OneView-SDK-RubyFormBoundaryWzS4H31b7UMbKMCx'.freeze
+    BOUNDARY = '----011000010111000001101001'.freeze
 
-    # Upload a firmware bundle file
-    # @param [OneviewSDK::Client] client
+    # Uploads a firmware bundle file
+    # @param [OneviewSDK::Client] client The client object for the OneView appliance
     # @param [String] file_path
     # @return [OneviewSDK::FirmwareDriver] if the upload was sucessful, return a FirmwareDriver object
-    def self.upload(client, file_path)
-      fail "ERROR: File '#{file_path}' not found!" unless File.file?(file_path)
-      type = case File.extname(file_path)
-             when '.zip' then 'application/x-zip-compressed'
-             when '.exe' then 'application/x-msdownload'
-             else 'application/octet-stream'
-             end
-
-      body = "--#{BOUNDARY}\r\n"
-      body << "Content-Disposition: form-data; name=\"file\"; filename=\"#{File.basename(file_path)}\"\r\n"
-      body << "Content-Type: #{type}\r\n\r\n"
-      body << File.read(file_path)
-      body << "\r\n--#{BOUNDARY}--"
-
-      options = {
-        'Content-Type' => "multipart/form-data; boundary=#{BOUNDARY}",
-        'uploadfilename' => File.basename(file_path),
-        'body' => body
-      }
-
+    def self.add(client, file_path)
+      fail NotFound, "ERROR: File '#{file_path}' not found!" unless File.file?(file_path)
+      options = {}
+      options['Content-Type'] = "multipart/form-data; boundary=#{BOUNDARY}"
+      options['uploadfilename'] = File.basename(file_path)
+      options['body'] = "--#{BOUNDARY}\r\n"
+      options['body'] << "Content-Disposition: form-data; name=\"file\"; filename=\"#{File.basename(file_path)}\"\r\n"
+      options['body'] << "Content-Type: application/octet-stream; Content-Transfer-Encoding: binary\r\n\r\n"
+      options['body'] << "#{IO.binread(file_path)}\r\n--#{BOUNDARY}--"
       response = client.rest_post(BASE_URI, options)
       data = client.response_handler(response)
       OneviewSDK::FirmwareDriver.new(client, data)
     end
-
   end
 end

data/lib/oneview-sdk/resource/firmware_driver.rb

@@ -1,21 +1,33 @@
+# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# You may not use this file except in compliance with the License.
+# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+
 module OneviewSDK
   # Firmware driver resource implementation
   class FirmwareDriver < Resource
     BASE_URI = '/rest/firmware-drivers'.freeze
 
-    def initialize(client, params = {}, api_ver = nil)
-      super
-      # Default values
-      @data['type'] ||= 'firmware-baselines'
-    end
+    # Remove resource from OneView
+    # @return [true] if resource was removed successfully
+    alias remove delete
 
-    def create
-      fail 'Method not available for this resource!'
+    # Method is not available
+    # @raise [OneviewSDK::MethodUnavailable] method is not available
+    def delete
+      unavailable_method
     end
 
+    # Method is not available
+    # @raise [OneviewSDK::MethodUnavailable] method is not available
     def update
-      create
+      unavailable_method
     end
-
   end
 end

data/lib/oneview-sdk/resource/interconnect.rb

@@ -1,35 +1,56 @@
+# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# You may not use this file except in compliance with the License.
+# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+
 module OneviewSDK
   # Interconnect resource implementation
   class Interconnect < Resource
     BASE_URI = '/rest/interconnects'.freeze
     TYPE_URI = '/rest/interconnect-types'.freeze
 
+    # Create a resource object, associate it with a client, and set its properties.
+    # @param [OneviewSDK::Client] client The client object for the OneView appliance
+    # @param [Hash] params The options for this resource (key-value pairs)
+    # @param [Integer] api_ver The api version to use when interracting with this resource.
     def initialize(client, params = {}, api_ver = nil)
       super
     end
 
+    # Method is not available
+    # @raise [OneviewSDK::MethodUnavailable] method is not available
     def create
       unavailable_method
     end
 
+    # Method is not available
+    # @raise [OneviewSDK::MethodUnavailable] method is not available
     def update
       unavailable_method
     end
 
+    # Method is not available
+    # @raise [OneviewSDK::MethodUnavailable] method is not available
     def delete
       unavailable_method
     end
 
-    # Retrieve interconnect types
-    # @param [Client] client http client
+    # Retrieves interconnect types
+    # @param [OneviewSDK::Client] client The client object for the OneView appliance
     def self.get_types(client)
       response = client.rest_get(TYPE_URI)
       response = client.response_handler(response)
       response['members']
     end
 
-    # Retrieve interconnect ype with name
-    # @param [Client] client http client
+    # Retrieves the interconnect type with name
+    # @param [OneviewSDK::Client] client The client object for the OneView appliance
     # @param [String] name Interconnect type name
     # @return [Array] Interconnect type
     def self.get_type(client, name)
@@ -37,7 +58,7 @@ module OneviewSDK
       results.find { |interconnect_type| interconnect_type['name'] == name }
     end
 
-    # Retrieve named servers for this interconnect
+    # Retrieves the named servers for this interconnect
     def name_servers
       response = @client.rest_get(@data['uri'] + '/nameServers')
       response.body
@@ -68,20 +89,19 @@ module OneviewSDK
       response.body
     end
 
-    # Triggers a reset of port protection
+    # Triggers the reset port protection action
     def reset_port_protection
       response = @client.rest_put(@data['uri'] + '/resetportprotection')
       @client.response_handler(response)
     end
 
-    # Update specific attributes of a given interconnect resource
+    # Updates specific attributes for a given interconnect resource
     # @param [String] operation operation to be performed
     # @param [String] path path
     # @param [String] value value
-    def update_attribute(operation, path, value)
+    def patch(operation, path, value)
       response = @client.rest_patch(@data['uri'], 'body' => [{ op: operation, path: path, value: value }])
       @client.response_handler(response)
     end
-
   end
 end

data/lib/oneview-sdk/resource/lig_uplink_set.rb

@@ -1,8 +1,23 @@
+# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# You may not use this file except in compliance with the License.
+# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+
 module OneviewSDK
-  # Uplink Sets  resource implementation to be used in Logical interconnect groups
+  # Uplink sets resource implementation to be used in logical interconnect groups
   class LIGUplinkSet < Resource
     BASE_URI = '/rest/logical-interconnect-groups'.freeze
 
+    # Create a resource object, associate it with a client, and set its properties.
+    # @param [OneviewSDK::Client] client The client object for the OneView appliance
+    # @param [Hash] params The options for this resource (key-value pairs)
+    # @param [Integer] api_ver The api version to use when interracting with this resource.
     def initialize(client, params = {}, api_ver = nil)
       super
       # Default values:
@@ -12,35 +27,15 @@ module OneviewSDK
       @data['networkUris'] ||= []
     end
 
-    # @!group Validates
-
-    VALID_NETWORK_TYPES = %w(FibreChannel Ethernet).freeze
-    # Validate ethernetNetworkType request
-    # @param [String] value FibreChannel, Ethernet
-    def validate_networkType(value)
-      fail 'Invalid network type' unless VALID_NETWORK_TYPES.include?(value)
-      fail 'Attribute missing' if value == 'Ethernet' && !@data['ethernetNetworkType']
-      fail 'Attribute not supported' if value == 'FibreChannel' && @data['ethernetNetworkType']
-    end
-
-    VALID_ETHERNET_NETWORK_TYPES = %w(NotApplicable Tagged Tunnel Unknown Untagged).freeze
-    # Validate ethernetNetworkType request
-    # @param [String] value Notapplicable, Tagged, Tunnel, Unknown, Untagged. Must exist if networkType is 'Ethernet', otherwise shouldn't.
-    def validate_ethernetNetworkType(value)
-      fail 'Invalid ethernetNetworkType' unless VALID_ETHERNET_NETWORK_TYPES.include?(value)
-    end
-
-    # @!endgroup
-
-    # Add existing network to the network list.
+    # Add an existing network to the network list.
     # Ethernet and FibreChannel networks are allowed.
-    # @param [OneviewSDK::Resource] network resource to be added to the list
+    # @param [OneviewSDK::Resource] network The resource to be added to the list
     def add_network(network)
-      fail 'Resource not retrieved from server' unless network['uri']
+      network.retrieve! unless network['uri']
       @data['networkUris'] << network['uri']
     end
 
-    # Specify one uplink passing the VC Bay and the port to be attached.
+    # Specify one uplink passing the virtual connect bay and the port to be attached.
     # @param [Fixnum] bay number to identify the VC
     # @param [String] port to attach the uplink. Allowed D1..D16 and X1..X10
     def add_uplink(bay, port)
@@ -57,7 +52,7 @@ module OneviewSDK
       @data['logicalPortConfigInfos'] << entry
     end
 
-    # Set all params
+    # Sets all params
     # @overload sets networkType first
     def set_all(params = {})
       params = params.data if params.class <= Resource
@@ -77,10 +72,9 @@ module OneviewSDK
       offset = case identifier
                when 'D' then 0
                when 'X' then 16
-               else fail "Port not supported: #{identifier} type not found"
+               else fail InvalidResource, "Port not supported: #{identifier} type not found"
                end
       port.to_i + offset
     end
-
   end
 end

data/lib/oneview-sdk/resource/logical_downlink.rb

@@ -0,0 +1,53 @@
+# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# You may not use this file except in compliance with the License.
+# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+
+module OneviewSDK
+  # Logical downlink resource implementation
+  class LogicalDownlink < Resource
+    BASE_URI = '/rest/logical-downlinks'.freeze
+
+    # Method is not available
+    # @raise [OneviewSDK::MethodUnavailable] method is not available
+    def create
+      unavailable_method
+    end
+
+    # Method is not available
+    # @raise [OneviewSDK::MethodUnavailable] method is not available
+    def update
+      unavailable_method
+    end
+
+    # Method is not available
+    # @raise [OneviewSDK::MethodUnavailable] method is not available
+    def delete
+      unavailable_method
+    end
+
+    # Gets a list of logical downlinks, excluding any existing ethernet network
+    # @param [OneviewSDK::Client] client The client object for the OneView appliance
+    # @return [Array<OneviewSDK::LogicalDownlink] Logical downlink array
+    def self.get_without_ethernet(client)
+      result = []
+      response = client.rest_get(BASE_URI + '/withoutEthernet')
+      members = client.response_handler(response)['members']
+      members.each { |member| result << new(client, member) }
+      result
+    end
+
+    # Gets a logical downlink, excluding any existing ethernet network
+    # @return [OneviewSDK::LogicalDownlink] Logical downlink array
+    def get_without_ethernet
+      response = @client.rest_get(@data['uri'] + '/withoutEthernet')
+      OneviewSDK::LogicalDownlink.new(@client, @client.response_handler(response))
+    end
+  end
+end

data/lib/oneview-sdk/resource/logical_enclosure.rb

@@ -1,31 +1,34 @@
+# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# You may not use this file except in compliance with the License.
+# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+
 module OneviewSDK
   # Logical enclosure resource implementation
   class LogicalEnclosure < Resource
     BASE_URI = '/rest/logical-enclosures'.freeze
 
+    # Create a resource object, associate it with a client, and set its properties.
+    # @param [OneviewSDK::Client] client The client object for the OneView appliance
+    # @param [Hash] params The options for this resource (key-value pairs)
+    # @param [Integer] api_ver The api version to use when interracting with this resource.
     def initialize(client, params = {}, api_ver = nil)
       super
       # Default values
       @data['type'] ||= 'LogicalEnclosure'
     end
 
-    # @!group Validates
-
-    VALID_FABRIC_TYPES = %w(DirectAttach FabricAttach).freeze
-    # Validate fabricType
-    # @param [String] value DirectAttach, FabricAttach
-    # @raise [RuntimeError] if value is not 'DirectAttach' or 'FabricAttach'
-    def validate_fabricType(value)
-      fail 'Invalid fabric type' unless VALID_FABRIC_TYPES.include?(value)
-    end
-
-    # @!endgroup
-
-    # Reapplies the appliance's configuration on enclosures
-    # @raise [RuntimeError] if the client is not set
-    # @raise [RuntimeError] if the uri is not set
-    # @raise [RuntimeError] if the reapply fails
-    # @return [LogicalEnclosure] self
+    # Reapplies the appliance's configuration on the enclosures
+    # @raise [OneviewSDK::IncompleteResource] if the client is not set
+    # @raise [OneviewSDK::IncompleteResource] if the uri is not set
+    # @raise [StandardError] if the reapply fails
+    # @return [OneviewSDK::LogicalEnclosure] self
     def reconfigure
       ensure_client && ensure_uri
       response = @client.rest_put("#{@data['uri']}/configuration", {}, @api_version)
@@ -34,10 +37,10 @@ module OneviewSDK
     end
 
     # Makes this logical enclosure consistent with the enclosure group
-    # @raise [RuntimeError] if the client is not set
-    # @raise [RuntimeError] if the uri is not set
-    # @raise [RuntimeError] if the process fails
-    # @return [Resource] self
+    # @raise [OneviewSDK::IncompleteResource] if the client is not set
+    # @raise [OneviewSDK::IncompleteResource] if the uri is not set
+    # @raise [StandardError] if the process fails
+    # @return [OneviewSDK::LogicalEnclosure] self
     def update_from_group
       ensure_client && ensure_uri
       response = @client.rest_put("#{@data['uri']}/updateFromGroup", {}, @api_version)
@@ -46,9 +49,9 @@ module OneviewSDK
     end
 
     # Get the configuration script
-    # @raise [RuntimeError] if the client is not set
-    # @raise [RuntimeError] if the uri is not set
-    # @raise [RuntimeError] if retrieving fails
+    # @raise [OneviewSDK::IncompleteResource] if the client is not set
+    # @raise [OneviewSDK::IncompleteResource] if the uri is not set
+    # @raise [StandardError] if retrieving fails
     # @return [String] script
     def get_script
       ensure_client && ensure_uri
@@ -57,10 +60,10 @@ module OneviewSDK
     end
 
     # Updates the configuration script for the logical enclosure
-    # @raise [RuntimeError] if the client is not set
-    # @raise [RuntimeError] if the uri is not set
-    # @raise [RuntimeError] if the reapply fails
-    # @return [Resource] self
+    # @raise [OneviewSDK::IncompleteResource] if the client is not set
+    # @raise [OneviewSDK::IncompleteResource] if the uri is not set
+    # @raise [StandardError] if the reapply fails
+    # @return [OneviewSDK::LogicalEnclosure] self
     def set_script(script)
       ensure_client && ensure_uri
       response = @client.rest_put("#{@data['uri']}/script", { 'body' => script }, @api_version)
@@ -69,16 +72,15 @@ module OneviewSDK
     end
 
     # Generates a support dump for the logical enclosure
-    # @raise [RuntimeError] if the client is not set
-    # @raise [RuntimeError] if the uri is not set
-    # @raise [RuntimeError] if the process fails when generating the support dump
-    # @return [Resource] self
+    # @raise [OneviewSDK::IncompleteResource] if the client is not set
+    # @raise [OneviewSDK::IncompleteResource] if the uri is not set
+    # @raise [StandardError] if the process fails when generating the support dump
+    # @return [OneviewSDK::LogicalEnclosure] self
     def support_dump(options)
       ensure_client && ensure_uri
       response = @client.rest_post("#{@data['uri']}/support-dumps", { 'body' => options }, @api_version)
       @client.wait_for(response.header['location'])
       self
     end
-
   end
 end

data/lib/oneview-sdk/resource/logical_interconnect.rb

@@ -1,57 +1,21 @@
+# (C) Copyright 2016 Hewlett Packard Enterprise Development LP
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# You may not use this file except in compliance with the License.
+# You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software distributed
+# under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
+# CONDITIONS OF ANY KIND, either express or implied. See the License for the specific
+# language governing permissions and limitations under the License.
+
 module OneviewSDK
   # Logical interconnect resource implementation
   class LogicalInterconnect < Resource
     BASE_URI = '/rest/logical-interconnects'.freeze
     LOCATION_URI = '/rest/logical-interconnects/locations/interconnects'.freeze
 
-    # @!group Validates
-
-    # Validate ethernet trap categories
-    VALID_ENET_TRAP_CATEGORIES = %w(Other PortStatus PortThresholds).freeze
-    def validate_enet_trap_categories(enet_trap_categories)
-      enet_trap_categories.uniq!
-      enet_trap_categories.each do |cat|
-        fail "Ethernet Trap Category #{cat} is not one of the allowed values: #{VALID_ENET_TRAP_CATEGORIES}" unless
-        VALID_ENET_TRAP_CATEGORIES.include?(cat)
-      end
-    end
-
-    # Validate fc trap categories
-    VALID_FC_TRAP_CATEGORIES = %w(Other PortStatus).freeze
-    def validate_fc_trap_categories(fc_trap_categories)
-      fc_trap_categories.uniq!
-      fc_trap_categories.each do |cat|
-        fail "FC Trap Category #{cat} is not one of the allowed values: #{VALID_FC_TRAP_CATEGORIES}" unless VALID_FC_TRAP_CATEGORIES.include?(cat)
-      end
-    end
-
-    # Validate vcm trap categories
-    VALID_VCM_TRAP_CATEGORIES = %w(Legacy).freeze
-    def validate_vcm_trap_categories(vcm_trap_categories)
-      vcm_trap_categories.uniq!
-      vcm_trap_categories.each do |cat|
-        fail "VCM Trap Category #{cat} is not one of the allowed values: #{VALID_VCM_TRAP_CATEGORIES}" unless VALID_VCM_TRAP_CATEGORIES.include?(cat)
-      end
-    end
-
-    # Validate trap severities
-    VALID_TRAP_SEVERITIES = %w(Critical Info Major Minor Normal Unknown Warning).freeze
-    def validate_trap_severities(trap_severities)
-      trap_severities.uniq!
-      trap_severities.each do |cat|
-        fail "Trap Severities #{cat} is not one of the allowed values: #{VALID_TRAP_SEVERITIES}" unless VALID_TRAP_SEVERITIES.include?(cat)
-      end
-    end
-
-    # Validate snmp trap format
-    VALID_TRAP_FORMATS = %w(SNMPv1 SNMPv2 SNMPv3).freeze
-    def validate_trap_format(trap_format)
-      fail "Trap Format #{trap_format} is not one of the allowed values: #{VALID_TRAP_FORMATS}" unless VALID_TRAP_FORMATS.include?(trap_format)
-    end
-
-    # @!endgroup
-
-    # Create an Interconnect in the desired Bay in a specified enclosure
+    # Creates an Interconnect in the desired bay in a specified enclosure
     # WARN: It does not create the LOGICAL INTERCONNECT itself.
     # It will fail if no interconnect is already present on the specified position
     # @param [Fixnum] bay_number Number of the bay to put the interconnect
@@ -69,9 +33,10 @@ module OneviewSDK
     end
 
     # Deletes an INTERCONNECT
-    # WARN: This won't delete the LOGICAL INTERCONNECT itself, and may cause inconsistency between the enclosure and LIG
-    # @param [Fixnum] bay_number Number of the bay to locate the logical interconnect
-    # @param [OneviewSDK::Resource] enclosure Enclosure to remove the logical interconnect
+    # WARN: This will not delete the LOGICAL INTERCONNECT itself, and may cause inconsistency between the enclosure and LIG
+    # @param [Fixnum] bay_number The bay number to locate the logical interconnect
+    # @param [OneviewSDK::Enclosure] enclosure Enclosure to remove the logical interconnect
+    # @return [OneviewSDK::LogicalInterconnect] self
     def delete(bay_number, enclosure)
       enclosure.ensure_uri
       delete_uri = self.class::LOCATION_URI + "?location=Enclosure:#{enclosure['uri']},Bay:#{bay_number}"
@@ -114,12 +79,12 @@ module OneviewSDK
       internal_networks
     end
 
-    # Updates ethernet settings of the Logical Interconnect
+    # Updates ethernet settings of the logical interconnect
     # @note The attribute is defined inside the instance of the Logical Interconnect
     # @return Updated instance of the Logical Interconnect
     def update_ethernet_settings
       ensure_client && ensure_uri
-      fail 'Please retrieve the Logical Interconnect before trying to update' unless @data['ethernetSettings']
+      fail IncompleteResource, 'Please retrieve the Logical Interconnect before trying to update' unless @data['ethernetSettings']
       update_options = {
         'If-Match' =>  @data['ethernetSettings'].delete('eTag'),
         'body' => @data['ethernetSettings']
@@ -129,7 +94,7 @@ module OneviewSDK
       set_all(body)
     end
 
-    # Updates settings of the Logical Interconnect
+    # Updates settings of the logical interconnect
     # @param options Options to update the Logical Interconnect
     # @return Updated instance of the Logical Interconnect
     def update_settings(options = {})
@@ -169,7 +134,7 @@ module OneviewSDK
     # @note The attribute is defined inside the instance of the Logical Interconnect
     # @return Updated instance of the Logical Interconnect
     def update_port_monitor
-      fail 'Please retrieve the Logical Interconnect before trying to update' unless @data['portMonitor']
+      fail IncompleteResource, 'Please retrieve the Logical Interconnect before trying to update' unless @data['portMonitor']
       update_options = {
         'If-Match' =>  @data['portMonitor'].delete('eTag'),
         'body' => @data['portMonitor']
@@ -183,7 +148,7 @@ module OneviewSDK
     # @note The attribute is defined inside the instance of the Logical Interconnect
     # @return Updated instance of the Logical Interconnect
     def update_qos_configuration
-      fail 'Please retrieve the Logical Interconnect before trying to update' unless @data['qosConfiguration']
+      fail IncompleteResource, 'Please retrieve the Logical Interconnect before trying to update' unless @data['qosConfiguration']
       update_options = {
         'If-Match' =>  @data['qosConfiguration'].delete('eTag'),
         'body' => @data['qosConfiguration']
@@ -197,7 +162,7 @@ module OneviewSDK
     # @note The attribute is defined inside the instance of the Logical Interconnect
     # @return Updated instance of the Logical Interconnect
     def update_telemetry_configuration
-      fail 'Please retrieve the Logical Interconnect before trying to update' unless @data['telemetryConfiguration']
+      fail IncompleteResource, 'Please retrieve the Logical Interconnect before trying to update' unless @data['telemetryConfiguration']
       update_options = {
         'If-Match' =>  @data['telemetryConfiguration'].delete('eTag'),
         'body' => @data['telemetryConfiguration']
@@ -212,7 +177,7 @@ module OneviewSDK
     #   Use helper methods to add the trap destination values: #add_snmp_trap_destination and #generate_trap_options
     # @return Updated instance of the Logical Interconnect
     def update_snmp_configuration
-      fail 'Please retrieve the Logical Interconnect before trying to update' unless @data['snmpConfiguration']
+      fail IncompleteResource, 'Please retrieve the Logical Interconnect before trying to update' unless @data['snmpConfiguration']
       update_options = {
         'If-Match' =>  @data['snmpConfiguration'].delete('eTag'),
         'body' => @data['snmpConfiguration']
@@ -225,10 +190,9 @@ module OneviewSDK
     # It will add one trap destination to the Logical Interconnect SNMP configuration
     # @param trap_format [String] SNMP version for this trap destination, `'SNMPv1'` or `'SNMPv2'` or `'SNMPv3'`
     # @param trap_destination [String] The trap destination IP address or host name
-    # @param community_string [String] Authentication string for the trap destination
+    # @param community_string [String] The Authentication string for the trap destination
     # @param trap_options [Hash] Hash with the options of the trap. Create it using generate_trap_options method
     def add_snmp_trap_destination(trap_destination, trap_format = 'SNMPv1', community_string = 'public', trap_options = {})
-      validate_trap_format(trap_format)
       trap_options['communityString'] = community_string
       trap_options['trapDestination'] = trap_destination
       trap_options['trapFormat'] = trap_format
@@ -245,10 +209,6 @@ module OneviewSDK
     #   can contain, `'Critical'` or `'Info'` or `'Major'` or `'Minor'` or `'Normal'` or `'Unknown'` or `'Warning'`
     # @return [Hash] Contains all trap options for one SNMP destination
     def generate_trap_options(enet_trap_categories = [], fc_trap_categories = [], vcm_trap_categories = [], trap_severities = [])
-      validate_enet_trap_categories(enet_trap_categories)
-      validate_fc_trap_categories(fc_trap_categories)
-      validate_vcm_trap_categories(vcm_trap_categories)
-      validate_trap_severities(trap_severities)
       options = {
         'enetTrapCategories' => enet_trap_categories,
         'vcmTrapCategories' => vcm_trap_categories,
@@ -266,6 +226,11 @@ module OneviewSDK
       @client.response_handler(response)
     end
 
+    # Update firmware
+    # @param [String] command
+    # @param [OneviewSDK::FirmwareDriver] firmware_driver
+    # @param [Hash] firmware_options
+    # @raise [OneviewSDK::IncompleteResource] if the client or uri is not set
     def firmware_update(command, firmware_driver, firmware_options)
       ensure_client && ensure_uri
       firmware_options['command'] = command
@@ -278,6 +243,5 @@ module OneviewSDK
       response = @client.rest_put(@data['uri'] + '/firmware', update_json)
       @client.response_handler(response)
     end
-
   end
 end