onebusaway-sdk 1.1.1 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 0371471d4375b099bc7ec86a863dfe3ef0e45a95adabaa722c8b9bef70000332
-  data.tar.gz: 2f5b6cc659f4fcdd5e9f70146193bd07146cc86e9e831cf3a1d2c5c6fc969793
+  metadata.gz: 30b38f66df90b2ae90875570c2c44acc0cc60014ecd26cd1b65f30144d467229
+  data.tar.gz: 449d160c4f8bb3e8c0ee14c7654c79c49689e30c7e120f2e3c0efddb166cb967
 SHA512:
-  metadata.gz: ce3492cac2e9272658b4b1d76230b1e556932fa301c99d7fdfeb67a39b7a18da046f16a08f2293885b78c632fa80b329a2629614379ac522f3dd14820da5d1ef
-  data.tar.gz: 6b67a81836584cf80d99f44ee2ff1b492e50db77a483b49817555cc8678b811d9d026e4ef06015b7d0412003e4fb7f187b21401f218cd3b8455b1197625310da
+  metadata.gz: 1ab9bc128008fd8089c86c98fabde8d08e54de7a24980d0a684b86775499e70b68448595cb82767f125b342b5e8a62e8d5b311908199c2d8aa277d4a864fafc6
+  data.tar.gz: '084cbd7d39a98d293342444ca5516b9186914b4380372795a11a34fb15987b09b2a347c35c05c8a4c3decdc4a9b0d0104b3ba2a36563b487c572beb393f39611'

data/CHANGELOG.md

@@ -1,5 +1,29 @@
 # Changelog
 
+## 1.1.2 (2025-10-15)
+
+Full Changelog: [v1.1.1...v1.1.2](https://github.com/OneBusAway/ruby-sdk/compare/v1.1.1...v1.1.2)
+
+### Bug Fixes
+
+* always send `filename=...` for multipart requests where a file is expected ([ae0a463](https://github.com/OneBusAway/ruby-sdk/commit/ae0a4631df4a0ba4ebb386e4bcd228977b8554c3))
+* coroutine leaks from connection pool ([5c3a6f1](https://github.com/OneBusAway/ruby-sdk/commit/5c3a6f121a63c3046f39ce62fba651a5e4e57ba8))
+* shorten multipart boundary sep to less than RFC specificed max length ([eee0939](https://github.com/OneBusAway/ruby-sdk/commit/eee0939d23255dbd6b3de367bbba02ea0a346425))
+* should not reuse buffers for `IO.copy_stream` interop ([29dd5d7](https://github.com/OneBusAway/ruby-sdk/commit/29dd5d7e0bcfbaf3027fca84a6338c37131843e6))
+
+
+### Performance Improvements
+
+* faster code formatting ([95c9921](https://github.com/OneBusAway/ruby-sdk/commit/95c99210f84f729076f9c6494a98729946bcb7d9))
+
+
+### Chores
+
+* allow fast-format to use bsd sed as well ([ac285dc](https://github.com/OneBusAway/ruby-sdk/commit/ac285dcaff516a5d8755da3534f83dfa588bcb6d))
+* ignore linter error for tests having large collections ([88b7a09](https://github.com/OneBusAway/ruby-sdk/commit/88b7a092d8bab6f77ee3fdc351e0b7d0fe41713a))
+* improve example values ([c2ea3c6](https://github.com/OneBusAway/ruby-sdk/commit/c2ea3c65ba37c82b323cffafad37b17b10d04c3b))
+* **internal:** codegen related update ([2a3af55](https://github.com/OneBusAway/ruby-sdk/commit/2a3af55696978980ca69da2e42caecf15c72ba2d))
+
 ## 1.1.1 (2025-09-20)
 
 Full Changelog: [v1.1.0...v1.1.1](https://github.com/OneBusAway/ruby-sdk/compare/v1.1.0...v1.1.1)

data/README.md

@@ -17,7 +17,7 @@ To use this gem, install via Bundler by adding the following to your application
 <!-- x-release-please-start-version -->
 
 ```ruby
-gem "onebusaway-sdk", "~> 1.1.1"
+gem "onebusaway-sdk", "~> 1.1.2"
 ```
 
 <!-- x-release-please-end -->

data/lib/onebusaway_sdk/file_part.rb

@@ -38,18 +38,21 @@ module OnebusawaySDK
     def to_yaml(*a) = read.to_yaml(*a)
 
     # @param content [Pathname, StringIO, IO, String]
-    # @param filename [String, nil]
+    # @param filename [Pathname, String, nil]
     # @param content_type [String, nil]
     def initialize(content, filename: nil, content_type: nil)
-      @content = content
+      @content_type = content_type
       @filename =
-        case content
-        in Pathname
-          filename.nil? ? content.basename.to_path : ::File.basename(filename)
+        case [filename, (@content = content)]
+        in [String | Pathname, _]
+          ::File.basename(filename)
+        in [nil, Pathname]
+          content.basename.to_path
+        in [nil, IO]
+          content.to_path
         else
-          filename.nil? ? nil : ::File.basename(filename)
+          filename
         end
-      @content_type = content_type
     end
   end
 end

data/lib/onebusaway_sdk/internal/transport/pooled_net_requester.rb

@@ -134,9 +134,9 @@ module OnebusawaySDK
 
           # rubocop:disable Metrics/BlockLength
           enum = Enumerator.new do |y|
-            with_pool(url, deadline: deadline) do |conn|
-              next if finished
+            next if finished
 
+            with_pool(url, deadline: deadline) do |conn|
               req, closing = self.class.build_request(request) do
                 self.class.calibrate_socket_timeout(conn, deadline)
               end
@@ -149,7 +149,7 @@ module OnebusawaySDK
 
               self.class.calibrate_socket_timeout(conn, deadline)
               conn.request(req) do |rsp|
-                y << [conn, req, rsp]
+                y << [req, rsp]
                 break if finished
 
                 rsp.read_body do |bytes|
@@ -160,6 +160,8 @@ module OnebusawaySDK
                 end
                 eof = true
               end
+            ensure
+              conn.finish if !eof && conn&.started?
             end
           rescue Timeout::Error
             raise OnebusawaySDK::Errors::APITimeoutError.new(url: url, request: req)
@@ -168,16 +170,11 @@ module OnebusawaySDK
           end
           # rubocop:enable Metrics/BlockLength
 
-          conn, _, response = enum.next
+          _, response = enum.next
           body = OnebusawaySDK::Internal::Util.fused_enum(enum, external: true) do
             finished = true
-            tap do
-              enum.next
-            rescue StopIteration
-              nil
-            end
+            loop { enum.next }
           ensure
-            conn.finish if !eof && conn&.started?
             closing&.call
           end
           [Integer(response.code), response, body]

data/lib/onebusaway_sdk/internal/type/file_input.rb

@@ -82,17 +82,20 @@ module OnebusawaySDK
           #
           # @return [Pathname, StringIO, IO, String, Object]
           def dump(value, state:)
-            # rubocop:disable Lint/DuplicateBranch
             case value
+            in StringIO | String
+              # https://datatracker.ietf.org/doc/html/rfc7578#section-4.2
+              # while not required, a filename is recommended, and in practice many servers do expect this
+              OnebusawaySDK::FilePart.new(value, filename: "upload")
             in IO
               state[:can_retry] = false
+              value.to_path.nil? ? OnebusawaySDK::FilePart.new(value, filename: "upload") : value
             in OnebusawaySDK::FilePart if value.content.is_a?(IO)
               state[:can_retry] = false
+              value
             else
+              value
             end
-            # rubocop:enable Lint/DuplicateBranch
-
-            value
           end
 
           # @api private

data/lib/onebusaway_sdk/internal/util.rb

@@ -473,10 +473,9 @@ module OnebusawaySDK
         # @return [Enumerable<String>]
         def writable_enum(&blk)
           Enumerator.new do |y|
-            buf = String.new
             y.define_singleton_method(:write) do
-              self << buf.replace(_1)
-              buf.bytesize
+              self << _1.dup
+              _1.bytesize
             end
 
             blk.call(y)
@@ -566,7 +565,8 @@ module OnebusawaySDK
         #
         # @return [Array(String, Enumerable<String>)]
         private def encode_multipart_streaming(body)
-          boundary = SecureRandom.urlsafe_base64(60)
+          # RFC 1521 Section 7.2.1 says we should have 70 char maximum for boundary length
+          boundary = SecureRandom.urlsafe_base64(46)
 
           closing = []
           strio = writable_enum do |y|

data/lib/onebusaway_sdk/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OnebusawaySDK
-  VERSION = "1.1.1"
+  VERSION = "1.1.2"
 end

data/rbi/onebusaway_sdk/file_part.rbi

@@ -27,7 +27,7 @@ module OnebusawaySDK
     sig do
       params(
         content: T.any(Pathname, StringIO, IO, String),
-        filename: T.nilable(String),
+        filename: T.nilable(T.any(Pathname, String)),
         content_type: T.nilable(String)
       ).returns(T.attached_class)
     end

data/sig/onebusaway_sdk/file_part.rbs

@@ -14,7 +14,7 @@ module OnebusawaySDK
 
     def initialize: (
       Pathname | StringIO | IO | String content,
-      ?filename: String?,
+      ?filename: (Pathname | String)?,
       ?content_type: String?
     ) -> void
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: onebusaway-sdk
 version: !ruby/object:Gem::Version
-  version: 1.1.1
+  version: 1.1.2
 platform: ruby
 authors:
 - Onebusaway SDK
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-09-22 00:00:00.000000000 Z
+date: 2025-10-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: connection_pool