onebox 2.1.8 → 2.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b9885ad2362b97a26732cf64fef583674c58250648f403627aef33e87687f2bb
-  data.tar.gz: 7678e338a3eb5276e53e3f673d230dc67f2b1cdf395adb339f09162f96e4c058
+  metadata.gz: 759d82290c29b9e1e3c97045ca14689dfc0f2f87221c1ce829b12a866abfd8a2
+  data.tar.gz: 5209c14887939549d9737409bd5dff67c2434c5a5f99596d2af93ef56aeaae6b
 SHA512:
-  metadata.gz: 8fe261d1536790c511b437afcf5e6aff632d21f3c4ef47c96c4a3adbf31c6b8f2b07e186323ddb4858a1c37c23d651bd96deeb49feb493c4064c11f2ba5d0d92
-  data.tar.gz: e46b1a057f9f6b351dd96eed98dbcee7209fe5ca9c4c247dbeb715988851a3ac99875e174022f60f08a5848e226f277562be131085dcbfa667544de41da17cd0
+  metadata.gz: 719a0e4e72b2719f8ab0fd71474bfd07ef485c4dcba2c13809d5fbafa86f9b831ebe1aa7a73237c9cde28d7babc472234fa9ae701d9b18aae25621a641c883a0
+  data.tar.gz: f8c0c6c5883c48ea2811940f00c2419438e199c1e9a70761453c9aafdf176404633dc79133fc87d4014ee0e0c74a037ee8ee19b2f9b46cd85ef07a491f64cfe6

data/.github/workflows/ci.yml

@@ -15,24 +15,19 @@ jobs:
     strategy:
       matrix:
         ruby:
-          - 2.4
           - 2.5
           - 2.6
+          - 2.7
+          - 3.0
 
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v2
 
       - name: Setup ruby
-        uses: actions/setup-ruby@v1
+        uses: ruby/setup-ruby@v1
         with:
           ruby-version: ${{ matrix.ruby }}
-          architecture: 'x64'
-
-      - name: Setup bundler
-        run: gem install bundler
-
-      - name: Setup gems
-        run: bundle install
+          bundler-cache: true
 
       - name: Rubocop
         run: bundle exec rubocop

data/lib/onebox/engine/allowlisted_generic_onebox.rb

@@ -286,7 +286,7 @@ module Onebox
         return image_html    if is_image?
         return embedded_html if is_embedded?
         return card_html     if is_card?
-        return article_html  if has_text?
+        return article_html  if (has_text? || is_image_article?)
       end
 
       def is_card?
@@ -301,9 +301,17 @@ module Onebox
       end
 
       def has_text?
+        has_title? && !Onebox::Helpers.blank?(data[:description])
+      end
+
+      def has_title?
         !Onebox::Helpers.blank?(data[:title])
       end
 
+      def is_image_article?
+        has_title? && has_image?
+      end
+
       def is_image?
         data[:type] =~ /photo|image/ &&
         data[:type] !~ /photostream/ &&

data/lib/onebox/engine/github_folder_onebox.rb

@@ -45,8 +45,7 @@ module Onebox
         end
 
         {
-          link: og.url,
-          path_link: url,
+          link: url,
           image: og.image,
           title: Onebox::Helpers.truncate(title, 250),
           path: display_path,

data/lib/onebox/engine/github_issue_onebox.rb

@@ -22,8 +22,7 @@ module Onebox
       end
 
       def data
-
-        @raw ||= ::MultiJson.load(open(url, "Accept" => "application/vnd.github.v3.text+json", read_timeout: timeout)) #custom Accept header so we can get body as text.
+        @raw ||= ::MultiJson.load(URI.open(url, "Accept" => "application/vnd.github.v3.text+json", read_timeout: timeout)) #custom Accept header so we can get body as text.
         body_text = @raw["body_text"]
 
         content_words = body_text.gsub("\n\n", "\n").gsub("\n", "<br>").split(" ") #one pass of removing double newline, then we change \n to <br> and later on we revert it back to \n this is a workaround to avoid losing newlines after we join it back.

data/lib/onebox/engine/instagram_onebox.rb

@@ -7,11 +7,11 @@ module Onebox
       include StandardEmbed
       include LayoutSupport
 
-      matches_regexp(/^https?:\/\/(?:www\.)?(?:instagram\.com|instagr\.am)\/?(?:.*)\/p\/[a-zA-Z\d_-]+/)
+      matches_regexp(/^https?:\/\/(?:www\.)?(?:instagram\.com|instagr\.am)\/?(?:.*)\/(?:p|tv)\/[a-zA-Z\d_-]+/)
       always_https
 
       def clean_url
-        url.scan(/^https?:\/\/(?:www\.)?(?:instagram\.com|instagr\.am)\/?(?:.*)\/p\/[a-zA-Z\d_-]+/).flatten.first
+        url.scan(/^https?:\/\/(?:www\.)?(?:instagram\.com|instagr\.am)\/?(?:.*)\/(?:p|tv)\/[a-zA-Z\d_-]+/).flatten.first
       end
 
       def data

data/lib/onebox/engine/json.rb

@@ -6,7 +6,7 @@ module Onebox
       private
 
       def raw
-        @raw ||= ::MultiJson.load(open(url, read_timeout: timeout))
+        @raw ||= ::MultiJson.load(URI.open(url, read_timeout: timeout))
       end
     end
   end

data/lib/onebox/engine/pubmed_onebox.rb

@@ -11,7 +11,7 @@ module Onebox
       private
 
       def get_xml
-        doc = Nokogiri::XML(open(URI.join(@url, "?report=xml&format=text")))
+        doc = Nokogiri::XML(URI.open(URI.join(@url, "?report=xml&format=text")))
         pre = doc.xpath("//pre")
         Nokogiri::XML("<root>" + pre.text + "</root>")
       end

data/lib/onebox/engine/simplecast_onebox.rb

@@ -8,6 +8,7 @@ module Onebox
 
       matches_regexp(/https?:\/\/(.+)?simplecast.com\/(episodes|s)\/.*/)
       always_https
+      requires_iframe_origins("https://embed.simplecast.com")
 
       def to_html
         get_oembed.html

data/lib/onebox/mixins/git_blob_onebox.rb

@@ -167,7 +167,7 @@ module Onebox
               @raw = "https://render.githubusercontent.com/view/solid?url=" + self.raw_template(m)
 
             else
-              contents = open(self.raw_template(m), read_timeout: timeout).read
+              contents = URI.open(self.raw_template(m), read_timeout: timeout).read
 
               contents_lines = contents.lines           #get contents lines
               contents_lines_size = contents_lines.size #get number of lines

data/lib/onebox/sanitize_config.rb

@@ -10,7 +10,7 @@ class Sanitize
 
       attributes: {
         'a' => RELAXED[:attributes]['a'] + %w(target),
-        'audio' => %w[controls],
+        'audio' => %w[controls controlslist],
         'embed' => %w[height src type width],
         'iframe' => %w[allowfullscreen frameborder height scrolling src width data-original-href data-unsanitized-src],
         'source' => %w[src type],

data/lib/onebox/status_check.rb

@@ -35,7 +35,7 @@ module Onebox
     private
 
     def check
-      res = open(@url, read_timeout: (@options.timeout || Onebox.options.timeout))
+      res = URI.open(@url, read_timeout: (@options.timeout || Onebox.options.timeout))
       @status = res.status.first.to_i
     rescue OpenURI::HTTPError => e
       @status = e.io.status.first.to_i

data/lib/onebox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Onebox
-  VERSION = "2.1.8"
+  VERSION = "2.2.4"
 end

data/onebox.gemspec

@@ -41,5 +41,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'haml', '~> 5.1'
   spec.add_development_dependency 'listen', '~> 2.10.0'
 
-  spec.required_ruby_version = '>=2.4.0'
+  spec.required_ruby_version = '>=2.5.0'
 end

data/templates/githubfolder.mustache

@@ -3,7 +3,7 @@
 <h3><a href='{{link}}' target="_blank" rel="noopener">{{title}}</a></h3>
 
 {{#path}}
-<p><a href='{{path_link}}' target="_blank" rel="noopener">{{path}}</a></p>
+<p><a href='{{link}}' target="_blank" rel="noopener">{{path}}</a></p>
 {{/path}}
 
 {{#description}}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 2.1.8
+  version: 2.2.4
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-12-04 00:00:00.000000000 Z
+date: 2021-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -413,7 +413,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.4.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="