onebox 2.1.4 → 2.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cba7774ebf124a2d110630be26869977c6acf71d1a07603e890d3a1231430834
-  data.tar.gz: fe5de86e2abdc20fee6139c596da13e1249a6d38d9c40a7759adbbaa5065c8f0
+  metadata.gz: 372344282cacdb38dfceab5dfb6c156d7c9fa5ec04cca9cc21eb8502987ce077
+  data.tar.gz: 02a26147e10f54261596572328cf85a758178cda845a20c9999cc1b5f96ffe18
 SHA512:
-  metadata.gz: e9d0e1df1c6d14c4984b30c7b3392d519b0eeec63ee7a34656e3089d9c1bc81e1d7e801660ceb2d4da0ea89a779e64a0cb7cd332485b584a9d6873866dbe8819
-  data.tar.gz: 4c3587d5445c97480c3d5dd4ee514ea9df427d26fb1fed1ace681b95aa6012d79c84323bd915803c4409b21695f4f2f28a6baf6016a8f50dc0f76a65d79be04d
+  metadata.gz: 187c7a40761cea4d784175373600c00c2045d29ba911c8838614bf51b76454ecd7080ee93ca787d6745e69fc9d823b6de0e592746a2ccc30e9a9d55847e86cd4
+  data.tar.gz: f73f392c9451e85e5678dd0eff146092bfc0f3ae6a261eb4dfae02fb6a614976571837f3ec52e512334a4e815c3e3c8f49694179a7a41ec387d7195153cb7810

data/lib/onebox/engine/allowlisted_generic_onebox.rb

@@ -316,7 +316,7 @@ module Onebox
         return true if AllowlistedGenericOnebox.html_providers.include?(data[:provider_name])
         return false unless data[:html]["iframe"]
 
-        fragment = Nokogiri::HTML::fragment(data[:html])
+        fragment = Nokogiri::HTML5::fragment(data[:html])
         src = fragment.at_css('iframe')&.[]("src")
         options[:allowed_iframe_regexes]&.any? { |r| src =~ r }
       end
@@ -367,7 +367,7 @@ module Onebox
       end
 
       def embedded_html
-        fragment = Nokogiri::HTML::fragment(data[:html])
+        fragment = Nokogiri::HTML5::fragment(data[:html])
         fragment.css("img").each { |img| img["class"] = "thumbnail" }
         if iframe = fragment.at_css("iframe")
           iframe.remove_attribute("style")

data/lib/onebox/engine/instagram_onebox.rb

@@ -16,12 +16,26 @@ module Onebox
 
       def data
         og = get_opengraph
-        author_name = og.description.match(/\(@(\w+)\) on Instagram/)[1]
+
+        # There are at least two different versions of the description. e.g.
+        # - "3,227 Likes, 88 Comments - An Account (@user.name) on Instagram: “Look at my picture!”"
+        # - "@user.name posted on their Instagram profile: “Look at my picture!”"
+
+        m = og.description.match(/\(@([\w\.]+)\) on Instagram/)
+        author_name = m[1] if m
+
+        author_name ||= begin
+          m = og.description.match(/^\@([\w\.]+)\ posted/)
+          m[1] if m
+        end
+
+        raise "Author username not found for post #{clean_url}" unless author_name
+
         permalink = clean_url.gsub("/#{author_name}/", "/")
 
         { link: permalink,
           title: "@#{author_name}",
-          image: "#{permalink}/media/?size=l",
+          image: og.image,
           description: Onebox::Helpers.truncate(og.title, 250)
         }
       end

data/lib/onebox/preview.rb

@@ -45,7 +45,7 @@ module Onebox
       return "" unless html
 
       if @options[:max_width]
-        doc = Nokogiri::HTML::fragment(html)
+        doc = Nokogiri::HTML5::fragment(html)
         if doc
           doc.css('[width]').each do |e|
             width = e['width'].to_i

data/lib/onebox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Onebox
-  VERSION = "2.1.4"
+  VERSION = "2.1.5"
 end

data/onebox.gemspec

@@ -33,7 +33,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'fakeweb', '~> 1.3'
   spec.add_development_dependency 'pry', '~> 0.10'
   spec.add_development_dependency 'mocha', '~> 1.1'
-  spec.add_development_dependency 'rubocop-discourse', '~> 2.1.2'
+  spec.add_development_dependency 'rubocop-discourse', '~> 2.4.0'
   spec.add_development_dependency 'twitter', '~> 4.8'
   spec.add_development_dependency 'guard-rspec', '~> 4.2.8'
   spec.add_development_dependency 'sinatra', '~> 1.4'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 2.1.4
+  version: 2.1.5
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2020-10-21 00:00:00.000000000 Z
+date: 2020-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -186,14 +186,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.2
+        version: 2.4.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.2
+        version: 2.4.0
 - !ruby/object:Gem::Dependency
   name: twitter
   requirement: !ruby/object:Gem::Requirement