onebox 1.8.67 → 1.8.68

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 852821c1793b34f5239b51d65cba8c1afa15167f53efb2c9383e2873cfd92acb
-  data.tar.gz: 33e908e022f1df4d2653cf30d1f13f99f6fe215842e940b80b004a78ae2af81a
+  metadata.gz: 8ebcc562d8b0dcc66b83ddd79e1a3bcc47e2202686d8b96417a00e1a28b4bf3e
+  data.tar.gz: d7d3ba019ba3c50c02236b731e64981812cbd08ed51ef903d226fd31a7bc900c
 SHA512:
-  metadata.gz: c04041b664eb183f2c822315ae1b95fb48a15865b55dea17857a80df4c87f1dedad6a77db39251e002e8adb4c65f567899f549b9af0f29e592d480dab369cb37
-  data.tar.gz: 7499c8994ffc0f28db827a19280251f968e8357259dd08efb82583abf9f5258205f17ced26cf5e4f226feaa0c4ef2672649d4f76dd733ee05201353ad7f2d289
+  metadata.gz: 13eb57f76bd7419811a03149467fbf89d3ea4d587fae333e20a28cabd3087c315bf6ba6a08346e59060284b07289f83d4de1d05a678a0d6897a732cac066505b
+  data.tar.gz: 7d32c90c35c3ce018aadbf547b987ed034076ee8bdd15d6d5f90d6f7f6ba2716cc8ab2910d9b07d48acd0247c70bf51331f595b8c35295ae5f08c9892c8b74c8

data/lib/onebox/engine/google_photos_onebox.rb

@@ -19,9 +19,10 @@ module Onebox
 
         def video_html(og)
           escaped_src = ::Onebox::Helpers.normalize_url_for_output(og[:video_secure_url])
+          escaped_image_src = ::Onebox::Helpers.normalize_url_for_output(get_secure_link(og[:image]))
 
           <<-HTML
-            <video width='#{og[:video_width]}' height='#{og[:video_height]}' #{Helpers.title_attr(og)} controls loop>
+            <video width='#{og[:video_width]}' height='#{og[:video_height]}' #{Helpers.title_attr(og)} poster="#{escaped_image_src}" controls loop>
               <source src='#{escaped_src}' type='video/mp4'>
             </video>
           HTML

data/lib/onebox/engine/standard_embed.rb

@@ -122,18 +122,7 @@ module Onebox
           favicon = html_doc.css('link[rel="shortcut icon"], link[rel="icon shortcut"], link[rel="shortcut"], link[rel="icon"]').first
           favicon = favicon.nil? ? nil : (favicon['href'].nil? ? nil : favicon['href'].strip)
 
-          if favicon && !!(favicon =~ /^\/\//)
-            uri = URI(url)
-            favicon = "#{uri.scheme}:#{favicon}"
-          elsif favicon && favicon.match(/^https?:\/\//i).nil?
-            uri = URI(url)
-            favicon = if !favicon.start_with?("/") && uri.path.present?
-              "#{uri.scheme}://#{uri.host.sub(/\/$/, '')}#{uri.path.sub(/\/$/, '')}/#{favicon.sub(/^\//, '')}"
-            else
-              "#{uri.scheme}://#{uri.host.sub(/\/$/, '')}/#{favicon.sub(/^\//, '')}"
-            end
-          end
-          favicon
+          Onebox::Helpers::get_absolute_image_url(favicon, url)
         end
     end
   end

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -218,6 +218,8 @@ module Onebox
 
           # prefer secure URLs
           d[:image] = d[:image_secure_url] || d[:image_url] || d[:thumbnail_url] || d[:image]
+          d[:image] = Onebox::Helpers::get_absolute_image_url(d[:image], @url)
+
           d[:video] = d[:video_secure_url] || d[:video_url] || d[:video]
 
           d[:published_time] = d[:article_published_time] unless Onebox::Helpers.blank?(d[:article_published_time])

data/lib/onebox/helpers.rb

@@ -187,5 +187,19 @@ module Onebox
       url
     end
 
+    def self.get_absolute_image_url(src, url)
+      if src && !!(src =~ /^\/\//)
+        uri = URI(url)
+        src = "#{uri.scheme}:#{src}"
+      elsif src && src.match(/^https?:\/\//i).nil?
+        uri = URI(url)
+        src = if !src.start_with?("/") && uri.path.present?
+          "#{uri.scheme}://#{uri.host.sub(/\/$/, '')}#{uri.path.sub(/\/$/, '')}/#{src.sub(/^\//, '')}"
+        else
+          "#{uri.scheme}://#{uri.host.sub(/\/$/, '')}/#{src.sub(/^\//, '')}"
+        end
+      end
+      src
+    end
   end
 end

data/lib/onebox/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Onebox
-  VERSION = "1.8.67"
+  VERSION = "1.8.68"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.67
+  version: 1.8.68
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-09 00:00:00.000000000 Z
+date: 2018-11-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json