onebox 1.8.39 → 1.8.40

data/spec/lib/onebox/engine/wikimedia_onebox_spec.rb

@@ -1,23 +0,0 @@
-require "spec_helper"
-
-describe Onebox::Engine::WikimediaOnebox do
-  let(:link) { "https://commons.wikimedia.org/wiki/File:Stones_members_montage2.jpg" }
-  let(:api_link) { "https://en.wikipedia.org/w/api.php?action=query&titles=File:Stones_members_montage2.jpg&prop=imageinfo&iilimit=50&iiprop=timestamp|user|url&iiurlwidth=500&format=json" }
-  let(:html) { described_class.new(link).to_html }
-
-  before do
-    fake(api_link, response("wikimedia"))
-  end
-
-  it "has the title" do
-    expect(html).to include("File:Stones members montage2.jpg")
-  end
-
-  it "has the link" do
-    expect(html).to include(link)
-  end
-
-  it "has the image" do
-    expect(html).to include("https://upload.wikimedia.org/wikipedia/commons/a/af/Stones_members_montage2.jpg")
-  end
-end

data/spec/lib/onebox/engine/wikipedia_onebox_spec.rb

@@ -1,21 +0,0 @@
-require "spec_helper"
-
-describe Onebox::Engine::WikipediaOnebox do
-  before(:all) do
-    @link = "http://en.wikipedia.org/wiki/Billy_Jack"
-    fake("https://en.wikipedia.org/wiki/Billy_Jack", response(described_class.onebox_name))
-  end
-
-  include_context "engines"
-  it_behaves_like "an engine"
-
-  describe "#to_html" do
-    it "includes article image" do
-      expect(html).to include("Billy_Jack_poster.jpg")
-    end
-
-    it "includes summary" do
-      expect(html).to include("Billy Jack is a 1971 action/drama")
-    end
-  end
-end

data/spec/lib/onebox/engine/xkcd_spec.rb

@@ -1,27 +0,0 @@
-require "spec_helper"
-
-describe Onebox::Engine::XkcdOnebox do
-  let(:link) { "https://xkcd.com/327/" }
-  let(:api_link) { "https://xkcd.com/327/info.0.json" }
-  let(:html) { described_class.new(link).to_html }
-
-  before do
-    fake(api_link, response("xkcd"))
-  end
-
-  it "has the comic's description" do
-    expect(html).to include("Her daughter is named Help")
-  end
-
-  it "has the comic's title" do
-    expect(html).to include("Exploits of a Mom")
-  end
-
-  it "has the permalink to the comic" do
-    expect(html).to include(link)
-  end
-
-  it "has the comic image" do
-    expect(html).to include("http://imgs.xkcd.com/comics/exploits_of_a_mom.png")
-  end
-end

data/spec/lib/onebox/engine/youku_onebox_spec.rb

@@ -1,13 +0,0 @@
-require 'spec_helper'
-
-describe Onebox::Engine::YoukuOnebox do
-  before do
-    FakeWeb.register_uri(:get, 'http://v.youku.com/v_show/id_XNjM3MzAxNzc2.html', body: response('youku'), content_type: 'text/html')
-    FakeWeb.register_uri(:get, 'http://v.youku.com/player/getPlayList/VideoIDS/XNjM3MzAxNzc2', body: response('youku-meta'), content_type: 'text/html')
-  end
-
-  it 'returns embed as the placeholder' do
-    expect(Onebox.preview('http://v.youku.com/v_show/id_XNjM3MzAxNzc2.html')
-        .placeholder_html).to match(/embed/)
-  end
-end

data/spec/lib/onebox/engine/youtube_onebox_spec.rb

@@ -1,84 +0,0 @@
-require 'spec_helper'
-
-describe Onebox::Engine::YoutubeOnebox do
-  before do
-    fake("https://www.youtube.com/watch?feature=player_embedded&v=21Lk4YiASMo", response("youtube"))
-    fake("https://youtu.be/21Lk4YiASMo", response("youtube"))
-    fake("https://www.youtube.com/channel/UCL8ZULXASCc1I_oaOT0NaOQ", response("youtube-channel"))
-    fake("http://www.youtube.com/user/googlechrome", response("youtube-channel"))
-    fake("https://www.youtube.com/playlist?list=PL5308B2E5749D1696", response("youtube-playlist"))
-    fake("https://www.youtube.com/oembed?format=json&url=https://www.youtube.com/watch?v=21Lk4YiASMo", response("youtube-json"))
-    fake("https://www.youtube.com/oembed?format=json&url=https://www.youtube.com/playlist?list=PL5308B2E5749D1696", response("youtube-list-json"))
-  end
-
-  it "adds wmode=opaque" do
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo').to_s).to match(/wmode=opaque/)
-  end
-
-  it "rewrites URLs for videos to be HTTPS" do
-    # match: plain HTTP and protocol agnostic
-    regex = /(http:|["']\/\/)/
-
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo').to_s).not_to match(regex)
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo').placeholder_html).not_to match(regex)
-    expect(Onebox.preview('https://www.youtube.com/channel/UCL8ZULXASCc1I_oaOT0NaOQ').to_s).not_to match(regex)
-  end
-
-  it "can onebox a channel page" do
-    expect(Onebox.preview('https://www.youtube.com/channel/UCL8ZULXASCc1I_oaOT0NaOQ').to_s).to match(/Google Chrome/)
-  end
-
-  it "can onebox a playlist" do
-    expect(Onebox.preview('https://www.youtube.com/playlist?list=PL5308B2E5749D1696').to_s).to match(/iframe/)
-    placeholder_html = Onebox.preview('https://www.youtube.com/playlist?list=PL5308B2E5749D1696').placeholder_html
-    expect(placeholder_html).to match(/<img/)
-    expect(placeholder_html).to include("The web is what you make of it")
-  end
-
-  it "does not make HTTP requests unless necessary" do
-    # We haven't defined any fixture for requests associated with this ID, so if
-    # any HTTP requests are made fakeweb will complain and the test will fail.
-    Onebox.preview('http://www.youtube.com/watch?v=q39Ce3zDScI').to_s
-  end
-
-  it "does not fail if we cannot get the video ID from the URL" do
-    expect(Onebox.preview('http://www.youtube.com/watch?feature=player_embedded&v=21Lk4YiASMo').to_s).to match(/embed/)
-  end
-
-  it "returns an image as the placeholder" do
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo').placeholder_html).to match(/<img/)
-    expect(Onebox.preview('https://youtu.be/21Lk4YiASMo').placeholder_html).to match(/<img/)
-  end
-
-  it "passes the playlist ID through" do
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&list=UUQau-O2C0kGJpR3_CHBTGbw&index=1').to_s).to match(/UUQau-O2C0kGJpR3_CHBTGbw/)
-  end
-
-  it "filters out nonsense parameters" do
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&potential[]=exploit&potential[]=fun').to_s).not_to match(/potential|exploit|fun/)
-  end
-
-  it "converts time strings into a &start= parameter" do
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&start=3782').to_s).to match(/start=3782/)
-    expect(Onebox.preview('https://www.youtube.com/watch?start=1h3m2s&v=21Lk4YiASMo').to_s).to match(/start=3782/)
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&t=1h3m2s').to_s).to match(/start=3782/)
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&start=1h3m2s').to_s).to match(/start=3782/)
-    expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo#t=1h3m2s').to_s).to match(/start=3782/)
-  end
-
-  it "allows both start and end" do
-    preview = expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&start=2m&end=3m').to_s)
-    preview.to match(/start=120/)
-    preview.to match(/end=180/)
-  end
-
-  it "permits looping videos" do
-    preview = expect(Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&loop').to_s)
-    preview.to match(/loop=1/)
-    preview.to match(/playlist=21Lk4YiASMo/)
-  end
-
-  it "includes title in preview" do
-    expect(Onebox.preview("https://youtu.be/21Lk4YiASMo").placeholder_html).to include("96neko - orange")
-  end
-end

data/spec/lib/onebox/engine_spec.rb

@@ -1,101 +0,0 @@
-require "spec_helper"
-
-describe Onebox::Engine do
-  class OneboxEngineExample
-    include Onebox::Engine
-
-    def to_html
-      "Hello #{link}"
-    end
-
-    def data
-      { foo: raw[:key], url: @url }
-    end
-
-    def raw
-      { key: "value" }
-    end
-  end
-
-  describe "#link" do
-    before { allow(Onebox::View).to receive(:template) { %|this should be a template| } }
-
-    it "escapes `link`" do
-      html = OneboxEngineExample.new(%|http://foo.com/'?a=1&b=2|).to_html
-      expect(html).not_to match(/'/)
-    end
-  end
-
-  describe "#record" do
-    class OneboxEngineRecord
-      include Onebox::Engine
-
-      def data
-        "new content"
-      end
-    end
-
-    it "returns cached value for given url if its url is already in cache" do
-      cache = { "http://example.com" => "old content" }
-      result = OneboxEngineRecord.new("http://example.com", cache).send(:record)
-      expect(result).to eq("old content")
-    end
-
-    it "stores cache value for given url if cache key doesn't exist" do
-      cache = { "http://example.com1" => "old content" }
-      result = OneboxEngineRecord.new("http://example.com", cache).send(:record)
-      expect(result).to eq("new content")
-    end
-  end
-
-  describe '.placeholder_html' do
-    let(:onebox) { OneboxEngineExample.new('http://eviltrout.com') }
-    it "returns `to_html` by default" do
-      expect(onebox.to_html).to eq(onebox.placeholder_html)
-    end
-  end
-
-  describe ".===" do
-    class OneboxEngineTripleEqual
-      include Onebox::Engine
-      @@matcher = /example/
-    end
-    it "returns true if argument matches the matcher" do
-      result = OneboxEngineTripleEqual === URI("http://www.example.com/product/5?var=foo&bar=5")
-      expect(result).to eq(true)
-    end
-  end
-
-  class AlwaysHttpsEngineExample < OneboxEngineExample
-    always_https
-  end
-
-  describe "always_https" do
-    it "never returns a plain http url" do
-      url = 'http://play.google.com/store/apps/details?id=com.google.android.inputmethod.latin'
-      onebox = AlwaysHttpsEngineExample.new(url)
-      result = onebox.to_html
-      expect(result).to_not match(/http(?!s)/)
-      expect(result).to_not match(/['"]\/\//)
-      expect(result).to match(/https/)
-    end
-  end
-end
-
-describe ".onebox_name" do
-  module ScopeForTemplateName
-    class TemplateNameOnebox
-      include Onebox::Engine
-    end
-  end
-
-  let(:onebox_name) { ScopeForTemplateName::TemplateNameOnebox.onebox_name }
-
-  it "should not include the scope" do
-    expect(onebox_name).not_to include("ScopeForTemplateName", "scopefortemplatename")
-  end
-
-  it "should not include the word Onebox" do
-    expect(onebox_name).not_to include("onebox", "Onebox")
-  end
-end

data/spec/lib/onebox/helpers_spec.rb

@@ -1,73 +0,0 @@
-require 'spec_helper'
-
-RSpec.describe Onebox::Helpers do
-  describe '.blank?' do
-    it { expect(described_class.blank?("")).to be(true) }
-    it { expect(described_class.blank?(" ")).to be(true) }
-    it { expect(described_class.blank?("test")).to be(false) }
-    it { expect(described_class.blank?(["test", "testing"])).to be(false) }
-    it { expect(described_class.blank?([])).to be(true) }
-    it { expect(described_class.blank?({})).to be(true) }
-    it { expect(described_class.blank?(nil)).to be(true) }
-    it { expect(described_class.blank?(true)).to be(false) }
-    it { expect(described_class.blank?(false)).to be(true) }
-    it { expect(described_class.blank?(a: 'test')).to be(false) }
-  end
-
-  describe ".truncate" do
-    let(:test_string) { "Chops off on spaces" }
-    it { expect(described_class.truncate(test_string)).to eq(test_string) }
-    it { expect(described_class.truncate(test_string, 5)).to eq("Chops...") }
-    it { expect(described_class.truncate(test_string, 7)).to eq("Chops...") }
-    it { expect(described_class.truncate(test_string, 9)).to eq("Chops off...") }
-    it { expect(described_class.truncate(test_string, 10)).to eq("Chops off...") }
-    it { expect(described_class.truncate(test_string, 100)).to eq("Chops off on spaces") }
-    it { expect(described_class.truncate(" #{test_string} ", 6)).to eq(" Chops...") }
-  end
-
-  describe "fetch_response" do
-    after(:each) do
-      Onebox.options = Onebox::DEFAULTS
-    end
-
-    before do
-      Onebox.options = { max_download_kb: 1 }
-      fake("http://example.com/large-file", response("slides"))
-    end
-
-    it "raises an exception when responses are larger than our limit" do
-      expect {
-        described_class.fetch_response('http://example.com/large-file')
-      }.to raise_error(Onebox::Helpers::DownloadTooLarge)
-    end
-  end
-
-  describe "user_agent" do
-    before do
-      fake("http://example.com/some-resource", body: 'test')
-    end
-
-    context "default" do
-      it "has the Ruby user agent" do
-        described_class.fetch_response('http://example.com/some-resource')
-        expect(FakeWeb.last_request.to_hash['user-agent'][0]).to eq("Ruby")
-      end
-    end
-
-    context "Custom option" do
-      after(:each) do
-        Onebox.options = Onebox::DEFAULTS
-      end
-
-      before do
-        Onebox.options = { user_agent: "EvilTroutBot v0.1" }
-      end
-
-      it "has the custom user agent" do
-        described_class.fetch_response('http://example.com/some-resource')
-        expect(FakeWeb.last_request.to_hash['user-agent'][0]).to eq("EvilTroutBot v0.1")
-      end
-    end
-  end
-
-end

data/spec/lib/onebox/layout_spec.rb

@@ -1,79 +0,0 @@
-require "spec_helper"
-
-describe Onebox::Layout do
-  let(:cache) { Moneta.new(:Memory, expires: true, serializer: :json) }
-  let(:record) { {} }
-  let(:onebox) { described_class.new("amazon", record, cache) }
-  let(:html) { onebox.to_html }
-
-  describe ".template_path" do
-    let(:template_path) { onebox.template_path }
-
-    before(:each) do
-      Onebox.options.load_paths << "directory_a"
-      Onebox.options.load_paths << "directory_b"
-    end
-
-    context "when template exists in directory_b" do
-      before(:each) do
-        allow_any_instance_of(described_class).to receive(:template?) { |_, path| path == "directory_b" }
-      end
-
-      it "returns directory_b" do
-        expect(template_path).to eq("directory_b")
-      end
-    end
-
-    context "when template exists in directory_a" do
-      before(:each) do
-        allow_any_instance_of(described_class).to receive(:template?) { |_, path| path == "directory_a" }
-      end
-
-      it "returns directory_a" do
-        expect(template_path).to eq("directory_a")
-      end
-    end
-
-    context "when template doesn't exist in directory_a or directory_b" do
-      it "returns default path" do
-        expect(template_path).to include("template")
-      end
-    end
-
-    after(:each) do
-      Onebox.options.load_paths.pop(2)
-    end
-  end
-
-  describe "#to_html" do
-    class OneboxEngineLayout
-      include Onebox::Engine
-
-      def data
-        "new content"
-      end
-    end
-
-    it "reads from cache if rendered template is cached" do
-      described_class.new("amazon", record, cache).to_html
-      expect(cache).to receive(:fetch)
-      described_class.new("amazon", record, cache).to_html
-    end
-
-    it "contains layout template" do
-      expect(html).to include(%|class="onebox|)
-    end
-
-    it "contains the view" do
-      record = { link: "foo" }
-      html = described_class.new("amazon", record, cache).to_html
-      expect(html).to include(%|"foo"|)
-    end
-
-    it "rewrites relative image path" do
-      record = { image: "/image.png", link: "https://discourse.org" }
-      klass = described_class.new("whitelistedgeneric", record, cache)
-      expect(klass.view.record[:image]).to include("https://discourse.org")
-    end
-  end
-end

data/spec/lib/onebox/matcher_spec.rb

@@ -1,74 +0,0 @@
-require "spec_helper"
-
-class TestEngine
-  def self.===(uri)
-    true
-  end
-end
-
-describe Onebox::Matcher do
-
-  describe "oneboxed" do
-
-    describe "with a path" do
-      let(:url) { "http://party.time.made.up-url.com/beep/boop" }
-      let(:matcher) { Onebox::Matcher.new(url) }
-
-      it "finds an engine" do
-        matcher.stubs(:ordered_engines).returns([TestEngine])
-        expect(matcher.oneboxed).not_to be_nil
-      end
-    end
-
-    describe "without a path" do
-      let(:url) { "http://party.time.made.up-url.com/" }
-      let(:matcher) { Onebox::Matcher.new(url) }
-
-      it "doesn't find an engine" do
-        matcher.stubs(:ordered_engines).returns([TestEngine])
-        expect(matcher.oneboxed).not_to be_nil
-      end
-    end
-
-    describe "without a path but has a query string" do
-      let(:url) { "http://party.time.made.up-url.com/?article_id=1234" }
-      let(:matcher) { Onebox::Matcher.new(url) }
-
-      it "finds an engine" do
-        matcher.stubs(:ordered_engines).returns([TestEngine])
-        expect(matcher.oneboxed).not_to be_nil
-      end
-    end
-
-    describe "without a path but has a fragment string" do
-      let(:url) { "http://party.time.made.up-url.com/#article_id=1234" }
-      let(:matcher) { Onebox::Matcher.new(url) }
-
-      it "finds an engine" do
-        matcher.stubs(:ordered_engines).returns([TestEngine])
-        expect(matcher.oneboxed).not_to be_nil
-      end
-    end
-
-    describe "with a whitelisted port/scheme" do
-      %w{http://example.com https://example.com http://example.com:80 //example.com}.each do |url|
-        it "finds an engine for '#{url}'" do
-          matcher = Onebox::Matcher.new(url)
-          matcher.stubs(:ordered_engines).returns([TestEngine])
-          expect(matcher.oneboxed).not_to be_nil
-        end
-      end
-    end
-
-    describe "without a whitelisted port/scheme" do
-      %w{http://example.com:21 ftp://example.com}.each do |url|
-        it "doesn't find an engine for '#{url}'" do
-          matcher = Onebox::Matcher.new(url)
-          matcher.stubs(:ordered_engines).returns([TestEngine])
-          expect(matcher.oneboxed).to be_nil
-        end
-      end
-    end
-
-  end
-end