onebox 1.8.27 → 1.8.28

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: '08ae08abe8fd51a365cbd459c4e4f278ea150263'
-  data.tar.gz: 9bf91c3aaf8a4752b834758df951fdb15803490e
+  metadata.gz: f3b06747361df6311e25e403c106292537b5499f
+  data.tar.gz: c7fa7b328a6d65c1cd354a5d2e1fbbf3c7d71e41
 SHA512:
-  metadata.gz: 28ef6d769b53b73850a805c714ac50d7da17c0057141a4b427700f8eec7e00de2c42eafc78259bdf20ab2168c6878cdf4d48ec82c82862aed911de5d52086d92
-  data.tar.gz: 9afca78a39e27f4cb0551c68dad859ac3063ee0ba7d7796798187fc9efd979b97dd7c0efb14f22001f475faf8efc11701f3137c279931139950b81bddb90c3f3
+  metadata.gz: cbf3cc825463f1c8f8a06797fb97697d2b3994f86bbb595b33fa50f7d4bd56f4d815f010eeaa605c8ea2981e28ec1fba280601003e638d1db78604f0d3aba324
+  data.tar.gz: 3f4dd5f712b602a54ca6f2bf3d5387bff3040cb6e95c1a1b11f7c235f933195a1247bdecf4b28280e1a0f909a5213ad5b9c0fbdaacccbbf2946f505e648fa8f0

data/.rubocop.yml

@@ -1,10 +1,10 @@
 AllCops:
   TargetRubyVersion: 2.2
   DisabledByDefault: true
-  Includes:
+  Include:
     - '**/*.gemspec'
     - '**/Rakefile'
-  Excludes: []
+  Exclude: []
 
 
 # Prefer &&/|| over and/or.

data/.travis.yml

@@ -1,4 +1,5 @@
 language: ruby
+sudo: false
 rvm:
   - 2.2
   - 2.3
@@ -9,3 +10,4 @@ notifications:
     on_failure: change
 script:
   - bundle exec rubocop
+  - bundle exec rspec

data/lib/onebox/engine/standard_embed.rb

@@ -119,11 +119,11 @@ module Onebox
           return nil unless html_doc
 
           favicon = html_doc.css('link[rel="shortcut icon"], link[rel="icon shortcut"], link[rel="shortcut"], link[rel="icon"]').first
-          favicon = favicon.nil? ? nil : favicon['href']&.strip
+          favicon = favicon.nil? ? nil : (favicon['href'].nil? ? nil : favicon['href'].strip)
 
           if favicon && favicon.match(/^https?:\/\//i).nil?
             uri = URI(url)
-            favicon = uri.scheme + "://" + uri.host.sub(/\/$/,"") + "/" + favicon.sub(/^\//,"")
+            favicon = uri.scheme + "://" + uri.host.sub(/\/$/, "") + "/" + favicon.sub(/^\//, "")
           end
 
           favicon

data/lib/onebox/helpers.rb

@@ -39,7 +39,7 @@ module Onebox
       og
     end
 
-    def self.fetch_html_doc(url, headers=nil)
+    def self.fetch_html_doc(url, headers = nil)
       response = (fetch_response(url, nil, nil, headers) rescue nil)
       doc = Nokogiri::HTML(response)
 

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.8.27"
+  VERSION = "1.8.28"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.27
+  version: 1.8.28
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-25 00:00:00.000000000 Z
+date: 2017-11-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json