onebox 1.8.22 → 1.8.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1d2051c2eb978bd88a44dfc32babf9c2d321016c
-  data.tar.gz: adfe2fa3bb20664fde2228ef9536149d6a569fad
+  metadata.gz: 584d1054d0ca1dd735a214cebe2b08427bdf3d1a
+  data.tar.gz: 5b070e05e93e822320f5450a70cc993d8f7bc9e3
 SHA512:
-  metadata.gz: 67d4c9de5c5fc3dce490916a598601d14adbb94fafdb200e7f0e282fa1a01b8046c38f884e98dd6f9396d7ad687b364d00013ce7e001c1cb9a3169e5b6fa41d6
-  data.tar.gz: 83f5831a4460bb2a8ae3fb0e002b3b323bc38022a9b184bd7f0a50afee9e09c2e116f267122383ef36f2d694654e4f1885699d3ddac105bbc3d43a12e2b67fb4
+  metadata.gz: 9b7537379a2d5119196364a192d211dc308f7656f4e782bce43f39a73af582a57d96a368bd3056dc6d5ab56d4960d107c9073bfe0a35dc0125801a8a00769a97
+  data.tar.gz: af5cc488f634add8fa6af284068035f30f14c7d85f0983744cc6617e6b238f2ce9b4c8c91d424da73e6aa33cd8dcd30191857eaef9e260b1b9ab8b6a1ec1e10b

data/.rubocop.yml

@@ -1,30 +1,112 @@
 AllCops:
-  # Include gemspec and Rakefile
+  TargetRubyVersion: 2.2
+  DisabledByDefault: true
   Includes:
     - '**/*.gemspec'
     - '**/Rakefile'
   Excludes: []
 
-# Prefer ' strings when you don't need string interpolation or special symbols.
-StringLiterals:
-  Enabled: false
 
-LineLength:
+# Prefer &&/|| over and/or.
+Style/AndOr:
   Enabled: true
-  Max: 180
 
-# Avoid methods longer than 10 lines of code
-MethodLength:
+# Do not use braces for hash literals when they are the last argument of a
+# method call.
+Style/BracesAroundHashParameters:
   Enabled: true
-  CountComments: false  # count full line comments?
-  Max: 10
 
-# Document classes and non-namespace modules.
-Documentation:
-  Enabled: false
+# Align `when` with `case`.
+Layout/CaseIndentation:
+  Enabled: true
 
-CaseEquality:
-  Enabled: false
+# Align comments with method definitions.
+Layout/CommentIndentation:
+  Enabled: true
+
+# No extra empty lines.
+Layout/EmptyLines:
+  Enabled: true
+
+# Use Ruby >= 1.9 syntax for hashes. Prefer { a: :b } over { :a => :b }.
+Style/HashSyntax:
+  Enabled: true
+
+# Two spaces, no tabs (for indentation).
+Layout/IndentationWidth:
+  Enabled: true
+
+Layout/SpaceAfterColon:
+  Enabled: true
+
+Layout/SpaceAfterComma:
+  Enabled: true
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  Enabled: true
+
+Layout/SpaceAroundKeyword:
+  Enabled: true
+
+Layout/SpaceAroundOperators:
+  Enabled: true
+
+Layout/SpaceBeforeFirstArg:
+    Enabled: true
+
+# Defining a method with parameters needs parentheses.
+Style/MethodDefParentheses:
+  Enabled: true
+
+# Use `foo {}` not `foo{}`.
+Layout/SpaceBeforeBlockBraces:
+  Enabled: true
+
+# Use `foo { bar }` not `foo {bar}`.
+Layout/SpaceInsideBlockBraces:
+  Enabled: true
+
+# Use `{ a: 1 }` not `{a:1}`.
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: true
+
+Layout/SpaceInsideParens:
+  Enabled: true
+
+# Detect hard tabs, no hard tabs.
+Layout/Tab:
+  Enabled: true
+
+# Blank lines should not have any spaces.
+Layout/TrailingBlankLines:
+  Enabled: true
+
+# No trailing whitespace.
+Layout/TrailingWhitespace:
+  Enabled: true
+
+Lint/Debugger:
+  Enabled: true
+
+Lint/BlockAlignment:
+  Enabled: true
+
+# Align `end` with the matching keyword or starting expression except for
+# assignments, where it should be aligned with the LHS.
+Lint/EndAlignment:
+  Enabled: true
+  EnforcedStyleAlignWith: variable
+
+# Use my_method(my_arg) not my_method( my_arg ) or my_method my_arg.
+Lint/RequireParentheses:
+  Enabled: true
+
+Layout/MultilineMethodCallIndentation:
+  Enabled: true
+  EnforcedStyle: indented
+
+Layout/AlignHash:
+  Enabled: true
 
-ClassVars:
+Bundler/OrderedGems:
   Enabled: false

data/.travis.yml

@@ -1,7 +1,11 @@
 language: ruby
 rvm:
-  - 2.3.1
+  - 2.2
+  - 2.3
+  - 2.4
 notifications:
   email:
     on_success: change
     on_failure: change
+script:
+  - bundle exec rubocop

data/CHANGELOG.md

@@ -1,3 +1,9 @@
+## 1.8.23
+
+  * added public message about ruby support (2.2 and above)
+  * mark all avatars being returned as onebox-avatar
+  * twitter returns larger avatars for retina
+
 ## 1.6.6
 
   * SECURITY: normalize url for audio/video oneboxes

data/Guardfile

@@ -1,8 +1,6 @@
 guard :rspec, cmd: 'bundle exec rspec' do
   watch(%r{^spec/.+_spec\.rb$})
-  watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
-  watch('spec/spec_helper.rb')  { "spec" }
-
-  watch(%r{^spec/support/(.+)\.rb$})                  { "spec" }
+  watch(%r{^lib/(.+)\.rb$})               { |m| "spec/lib/#{m[1]}_spec.rb" }
+  watch('spec/spec_helper.rb')            { "spec" }
+  watch(%r{^spec/support/(.+)\.rb$})      { "spec" }
 end
-

data/README.md

@@ -71,6 +71,13 @@ preview = Onebox.preview(url)
 "#{preview}" == preview.to_s #=> true
 ```
 
+Ruby Support
+------------
+
+The onebox library is supported on all "officially" supported versions of Ruby.
+
+This means you must be on Ruby 2.2 or above for it to work.
+
 Development Preview Interface
 -----------------------------
 

data/Rakefile

@@ -20,7 +20,7 @@ YARD::Rake::YardocTask.new do |config|
 end
 
 desc "Default: run tests and generate docs"
-task :default => [ :spec, :yard ]
+task default: [ :spec, :yard ]
 
 task :server do
   require 'onebox/web'

data/lib/onebox/engine.rb

@@ -26,7 +26,6 @@ module Onebox
       @options
     end
 
-
     def initialize(link, cache = nil, timeout = nil)
       @options = DEFAULT
       class_name = self.class.name.split("::").last.to_s
@@ -82,13 +81,13 @@ module Onebox
     end
 
     def link
-      @url.gsub(/['\"&<>]/, {
+      @url.gsub(/['\"&<>]/,
         "'" => '&#39;',
         '&' => '&amp;',
         '"' => '&quot;',
         '<' => '&lt;',
         '>' => '&gt;',
-      })
+      )
     end
 
     def always_https?

data/lib/onebox/engine/amazon_onebox.rb

@@ -23,7 +23,10 @@ module Onebox
       end
 
       def http_params
-        {'User-Agent' => 'Mozilla/5.0 (iPhone; CPU iPhone OS 5_0_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A405 Safari/7534.48.3'}
+        {
+          'User-Agent' =>
+          'Mozilla/5.0 (iPhone; CPU iPhone OS 5_0_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A405 Safari/7534.48.3'
+        }
       end
 
       private
@@ -61,7 +64,6 @@ module Onebox
         result[:by_info] = raw.at("#by-line")
         result[:by_info] = Onebox::Helpers.clean(result[:by_info].inner_html) if result[:by_info]
 
-
         # get item price (Amazon markup is inconsistent, deal with it)
         result[:price] =
           if raw.css("#priceblock_ourprice .restOfPrice")[0] && raw.css("#priceblock_ourprice .restOfPrice")[0].inner_text
@@ -73,7 +75,7 @@ module Onebox
           end
 
         summary = raw.at("#productDescription")
-        result[:description] = og[:description] || summary.inner_text
+        result[:description] = og[:description] || (summary && summary.inner_text)
         result
       end
     end

data/lib/onebox/engine/douban_onebox.rb

@@ -12,7 +12,7 @@ module Onebox
         def data
           {
             link: link,
-            title: raw.css('title').text.gsub("\n",'').strip(),
+            title: raw.css('title').text.gsub("\n", '').strip(),
             image: raw.css('img[rel*="v:"]').first['src'],
             description: raw.css('meta[name=description]').first['content'],
           }

data/lib/onebox/engine/github_blob_onebox.rb

@@ -9,18 +9,17 @@ module Onebox
       EXPAND_NONE = 0b0
 
       DEFAULTS = {
-              :EXPAND_ONE_LINER => EXPAND_AFTER|EXPAND_BEFORE, #set how to expand a one liner. user EXPAND_NONE to disable expand
-              :LINES_BEFORE => 10,
-              :LINES_AFTER => 10,
-              :SHOW_LINE_NUMBER => true,
-              :MAX_LINES => 20,
-              :MAX_CHARS => 5000
+        EXPAND_ONE_LINER: EXPAND_AFTER | EXPAND_BEFORE, #set how to expand a one liner. user EXPAND_NONE to disable expand
+        LINES_BEFORE: 10,
+        LINES_AFTER: 10,
+        SHOW_LINE_NUMBER: true,
+        MAX_LINES: 20,
+        MAX_CHARS: 5000
       }
 
       matches_regexp(/^https?:\/\/(www\.)?github\.com.*\/blob\//)
       always_https
 
-
       def initialize(link, cache = nil, timeout = nil)
         super link, cache , timeout
         #merge engine options from global Onebox.options interface
@@ -31,20 +30,20 @@ module Onebox
 
         # Define constant after merging options set in Onebox.options
         # We can define constant automatically.
-        options.each_pair {|constant_name,value|
+        options.each_pair do |constant_name, value|
           constant_name_u = constant_name.to_s.upcase
-              if constant_name_u == constant_name.to_s
-                #define a constant if not already defined
-                self.class.const_set  constant_name_u.to_sym , options[constant_name_u.to_sym]  unless self.class.const_defined? constant_name_u.to_sym
-              end
-        }
+          if constant_name_u == constant_name.to_s
+            #define a constant if not already defined
+            self.class.const_set constant_name_u.to_sym , options[constant_name_u.to_sym]  unless self.class.const_defined? constant_name_u.to_sym
+          end
+        end
       end
 
       private
-      @selected_lines_array  = nil
+      @selected_lines_array = nil
       @selected_one_liner = 0
-      def calc_range(m,contents_lines_size)
-        #author Lidlanca  09/15/2014
+
+      def calc_range(m, contents_lines_size)
         truncated = false
         from = /\d+/.match(m[:from])             #get numeric should only match a positive interger
         to   = /\d+/.match(m[:to])               #get numeric should only match a positive interger
@@ -66,7 +65,7 @@ module Onebox
           #we can technically return here
         end
 
-        from, to = [from,to].sort                                #enforce valid range.  [from < to]
+        from, to = [from, to].sort                                #enforce valid range.  [from < to]
         from = 1 if from > contents_lines_size                   #if "from" out of TOP bound set to 1st line
         to   = contents_lines_size if to > contents_lines_size   #if "to" is out of TOP bound set to last line.
 
@@ -88,30 +87,31 @@ module Onebox
           end
         end
 
-        if to-from > MAX_LINES && !one_liner  #if exceed the MAX_LINES limit correct unless range was produced by one_liner which it expand setting will allow exceeding the line limit
+        if to - from > MAX_LINES && !one_liner  #if exceed the MAX_LINES limit correct unless range was produced by one_liner which it expand setting will allow exceeding the line limit
           truncated = true
-         to = from + MAX_LINES-1
+         to = from + MAX_LINES - 1
         end
 
-        {:from               => from,                 #calculated from
-         :from_minus_one    => from-1,                #used for getting currect ol>li numbering with css used in template
-         :to                 => to,                   #calculated to
-         :one_liner          => one_liner,            #boolean if a one-liner
-         :selected_one_liner => @selected_one_liner,  #if a one liner is provided we create a reference for it.
-         :range_provided     => range_provided,       #boolean if range provided
-         :truncated          => truncated}
+        {
+          from: from,                               #calculated from
+          from_minus_one: from - 1,                   #used for getting currect ol>li numbering with css used in template
+          to: to,                                   #calculated to
+          one_liner: one_liner,                     #boolean if a one-liner
+          selected_one_liner: @selected_one_liner,  #if a one liner is provided we create a reference for it.
+          range_provided: range_provided,           #boolean if range provided
+          truncated: truncated
+        }
       end
 
       #minimize/compact leading indentation while preserving overall indentation
-      def removeLeadingIndentation  str
-        #author Lidlanca 2014
-        min_space=100
+      def removeLeadingIndentation(str)
+        min_space = 100
         a_lines = str.lines
-        a_lines.each {|l|
+        a_lines.each do |l|
           l = l.chomp("\n")  # remove new line
-          m = l.match /^[ ]*/ # find leading spaces 0 or more
-          unless m.nil? || l.size==m[0].size || m[0].size==0 # no match | only spaces in line | empty line
-            m_str_length  = m[0].size
+          m = l.match(/^[ ]*/) # find leading spaces 0 or more
+          unless m.nil? || l.size == m[0].size || m[0].size == 0 # no match | only spaces in line | empty line
+            m_str_length = m[0].size
             if m_str_length <= 1  # minimum space is 1 or nothing we can break we found our minimum
               min_space = m_str_length
               break #stop iteration
@@ -122,32 +122,29 @@ module Onebox
           else
             next # SKIP no match or line is only spaces
           end
-        }
-        a_lines.each {|l|
+        end
+        a_lines.each do |l|
           re = Regexp.new "^[ ]{#{min_space}}"  #match the minimum spaces of the line
           l.gsub!(re, "")
-        }
+        end
         a_lines.join
       end
 
-      def line_number_helper(lines,start,selected)
-        #author Lidlanca  09/15/2014
+      def line_number_helper(lines, start, selected)
         lines = removeLeadingIndentation(lines.join).lines # A little ineffeicent we could modify  removeLeadingIndentation to accept array and return array, but for now it is only working with a string
-        hash_builder =[]
+        hash_builder = []
         output_builder = []
-        lines.map.with_index { |line,i|
-          lnum = (i.to_i+start)
-          hash_builder.push({:line_number => lnum, :data=> line.gsub("\n",""), :selected=> (selected==lnum)? true: false} )
+        lines.map.with_index { |line, i|
+          lnum = (i.to_i + start)
+          hash_builder.push(line_number: lnum, data: line.gsub("\n", ""), selected: (selected == lnum) ? true : false)
           output_builder.push "#{lnum}: #{line}"
         }
-        {:output=>output_builder.join(), :array=>hash_builder}
+        { output: output_builder.join(), array: hash_builder }
       end
 
-
       def raw
-        options_id = self.class.name.split("::").last.to_s  #get class name without module namespace
-
         return @raw if @raw
+
         m = @url.match(/github\.com\/(?<user>[^\/]+)\/(?<repo>[^\/]+)\/blob\/(?<sha1>[^\/]+)\/(?<file>[^#]+)(#(L(?<from>[^-]*)(-L(?<to>.*))?))?/mi)
 
         if m
@@ -161,26 +158,25 @@ module Onebox
           contents_lines = contents.lines           #get contents lines
           contents_lines_size = contents_lines.size #get number of lines
 
-          cr = calc_range(m,contents_lines_size)    #calculate the range of lines for output
-            selected_one_liner = cr[:selected_one_liner] #if url is a one-liner calc_range will return it
-            # puts "SELECTED LINE" + cr[:selected_one_liner].to_s
-            from           = cr[:from]
-            to             = cr[:to]
-            @truncated     = cr[:truncated]
-            range_provided = cr[:range_provided]
-            one_liner      = cr[:one_liner]
-            @cr_results = cr
+          cr = calc_range(m, contents_lines_size)    #calculate the range of lines for output
+          selected_one_liner = cr[:selected_one_liner] #if url is a one-liner calc_range will return it
+          from           = cr[:from]
+          to             = cr[:to]
+          @truncated     = cr[:truncated]
+          range_provided = cr[:range_provided]
+          @cr_results = cr
+
           if range_provided       #if a range provided (single line or more)
             if SHOW_LINE_NUMBER
-              lines_result = line_number_helper(contents_lines[from-1..to-1], from, selected_one_liner)  #print code with prefix line numbers in case range provided
+              lines_result = line_number_helper(contents_lines[(from - 1)..(to - 1)], from, selected_one_liner)  #print code with prefix line numbers in case range provided
               contents = lines_result[:output]
               @selected_lines_array = lines_result[:array]
             else
-              contents = contents_lines[from-1..to-1].join()
+              contents = contents_lines[(from - 1)..(to - 1)].join()
             end
 
           else
-            contents = contents_lines[from-1..to-1].join()
+            contents = contents_lines[(from - 1)..(to - 1)].join()
           end
 
           if contents.length > MAX_CHARS    #truncate content chars to limits
@@ -193,18 +189,20 @@ module Onebox
       end
 
       def data
-        @data ||= {title: link.sub(/^https?\:\/\/github\.com\//, ''),
-                   link: link,
-                   # IMPORTANT NOTE: All of the other class variables are populated
-                   #     as *side effects* of the `raw` method! They must all appear
-                   #     AFTER the call to `raw`! Don't get bitten by this like I did!
-                   content: raw,
-                   lang: "lang-#{@lang}",
-                   lines:  @selected_lines_array ,
-                   has_lines: !@selected_lines_array.nil?,
-                   selected_one_liner: @selected_one_liner,
-                   cr_results:@cr_results,
-                   truncated: @truncated}
+        @data ||= {
+          title: link.sub(/^https?\:\/\/github\.com\//, ''),
+          link: link,
+          # IMPORTANT NOTE: All of the other class variables are populated
+          #     as *side effects* of the `raw` method! They must all appear
+          #     AFTER the call to `raw`! Don't get bitten by this like I did!
+          content: raw,
+          lang: "lang-#{@lang}",
+          lines:  @selected_lines_array ,
+          has_lines: !@selected_lines_array.nil?,
+          selected_one_liner: @selected_one_liner,
+          cr_results: @cr_results,
+          truncated: @truncated
+        }
       end
 
     end

data/lib/onebox/engine/github_issue_onebox.rb

@@ -16,33 +16,32 @@ module Onebox
       private
 
       def match
-         @match ||= @url.match(/^http(?:s)?:\/\/(?:www\.)?(?:(?:\w)+\.)?github\.com\/(?<org>.+)\/(?<repo>.+)\/(?<type>issues)\/(?<item_id>[\d]+)/)
+        @match ||= @url.match(/^http(?:s)?:\/\/(?:www\.)?(?:(?:\w)+\.)?github\.com\/(?<org>.+)\/(?<repo>.+)\/(?<type>issues)\/(?<item_id>[\d]+)/)
       end
 
       def data
 
-        @raw ||= ::MultiJson.load(open(url,"Accept"=>"application/vnd.github.v3.text+json",:read_timeout=>timeout )) #custom Accept header so we can get body as text.
-        body_text=  @raw["body_text"]
+        @raw ||= ::MultiJson.load(open(url, "Accept" => "application/vnd.github.v3.text+json", read_timeout: timeout)) #custom Accept header so we can get body as text.
+        body_text = @raw["body_text"]
 
-
-        content_words = body_text.gsub("\n\n","\n").gsub("\n","<br>").split(" ") #one pass of removing double newline, then we change \n to <br> and later on we revert it back to \n this is a workaround to avoid losing newlines after we join it back.
+        content_words = body_text.gsub("\n\n", "\n").gsub("\n", "<br>").split(" ") #one pass of removing double newline, then we change \n to <br> and later on we revert it back to \n this is a workaround to avoid losing newlines after we join it back.
         max_words = 20
         short_content =  content_words[0..max_words].join(" ")
         short_content << "..." if content_words.length > max_words
 
         ulink = URI(link)
-        status_color = {"open"=>"#6cc644","closed"=>"#bd2c00","merged"=>"#6e5494"}
-        result = { link: @url,
-                   title: "Issue: " + @raw["title"],
-                   content: short_content.gsub("<br>","\n"),
-                   labels: @raw["labels"],
-                   user: @raw['user'],
-                   created_at: @raw['created_at'].split("T")[0], #get only date for now
-                   closed_at: (@raw['closed_at'].nil? ? "" : @raw['closed_at'].split("T")[0]),
-                   closed_by: @raw['closed_by'],
-                   avatar: "https://avatars1.githubusercontent.com/u/#{@raw['user']['id']}?v=2&s=96",
-                   domain: "#{ulink.host}/#{ulink.path.split('/')[1]}/#{ulink.path.split('/')[2]}",
-                  }
+        {
+          link: @url,
+          title: "Issue: " + @raw["title"],
+          content: short_content.gsub("<br>", "\n"),
+          labels: @raw["labels"],
+          user: @raw['user'],
+          created_at: @raw['created_at'].split("T")[0], #get only date for now
+          closed_at: (@raw['closed_at'].nil? ? "" : @raw['closed_at'].split("T")[0]),
+          closed_by: @raw['closed_by'],
+          avatar: "https://avatars1.githubusercontent.com/u/#{@raw['user']['id']}?v=2&s=96",
+          domain: "#{ulink.host}/#{ulink.path.split('/')[1]}/#{ulink.path.split('/')[2]}",
+        }
       end
     end
   end

data/lib/onebox/engine/google_maps_onebox.rb

@@ -6,7 +6,7 @@ module Onebox
       class << self
         def ===(other)
           if other.kind_of? URI
-            @@matchers && @@matchers.any? {|m| other.to_s =~ m[:regexp] }
+            @@matchers && @@matchers.any? { |m| other.to_s =~ m[:regexp] }
           else
             super
           end
@@ -15,7 +15,7 @@ module Onebox
         private
 
         def matches_regexp(key, regexp)
-          (@@matchers ||= []) << {key: key, regexp: regexp}
+          (@@matchers ||= []) << { key: key, regexp: regexp }
         end
       end
 

data/lib/onebox/engine/google_play_app_onebox.rb

@@ -9,7 +9,6 @@ module Onebox
         MAX_DESCRIPTION_CHARS: 500
       }
 
-
       matches_regexp Regexp.new("^https?://play\\.(?:(?:\\w)+\\.)?(google)\\.com(?:/)?/store/apps/")
       always_https
 
@@ -24,8 +23,8 @@ module Onebox
           description: raw.css(".text-body div").inner_text[0..DEFAULTS[:MAX_DESCRIPTION_CHARS]].chop + "...",
           price: raw.css(".price.buy meta[itemprop=price]").first["content"]
         }
-        if result[:price] == "0" then
-            result[:price] = "Free"
+        if result[:price] == "0"
+          result[:price] = "Free"
         end
         result
       end

data/lib/onebox/engine/html.rb

@@ -9,7 +9,7 @@ module Onebox
       end
 
       def raw
-        @raw ||= Nokogiri::HTML(open(url, {read_timeout: timeout}.merge(http_params)).read)
+        @raw ||= Nokogiri::HTML(open(url, { read_timeout: timeout }.merge(http_params)).read)
       end
 
       def html?

data/lib/onebox/engine/pdf_onebox.rb

@@ -10,7 +10,6 @@ module Onebox
       private
 
       def data
-        html_entities = HTMLEntities.new
         pdf_info = get_pdf_info
         raise "Unable to read pdf file: #{@url}" if pdf_info.nil?
 

data/lib/onebox/engine/pubmed_onebox.rb

@@ -15,9 +15,9 @@ module Onebox
       end
 
       def authors_of_xml(xml)
-        initials = xml.css("Initials").map{|x| x.content}
-        last_names = xml.css("LastName").map{|x| x.content}
-        author_list = (initials.zip(last_names)).map{|i,l| i + " " + l}
+        initials = xml.css("Initials").map { |x| x.content }
+        last_names = xml.css("LastName").map { |x| x.content }
+        author_list = (initials.zip(last_names)).map { |i, l| i + " " + l }
         if author_list.length > 1 then
           author_list[-2] = author_list[-2] + " and " + author_list[-1]
           author_list.pop
@@ -26,22 +26,22 @@ module Onebox
       end
 
       def date_of_xml(xml)
-        date_arr = (xml.css("PubDate").children).map{|x| x.content}
-        date_arr = date_arr.select{|s| !s.match(/^\s+$/)}
-        date_arr = (date_arr.map{|s| s.split}).flatten
+        date_arr = (xml.css("PubDate").children).map { |x| x.content }
+        date_arr = date_arr.select { |s| !s.match(/^\s+$/) }
+        date_arr = (date_arr.map { |s| s.split }).flatten
         date_arr.sort.reverse.join(" ") # Reverse sort so month before year.
       end
 
       def data
-         xml = get_xml()
-         {
-         title: xml.css("ArticleTitle").text,
-         authors: authors_of_xml(xml),
-         journal: xml.css("Title").text,
-         abstract: xml.css("AbstractText").text,
-         date: date_of_xml(xml),
-         link: @url,
-         pmid: match[:pmid]
+        xml = get_xml()
+        {
+          title: xml.css("ArticleTitle").text,
+          authors: authors_of_xml(xml),
+          journal: xml.css("Title").text,
+          abstract: xml.css("AbstractText").text,
+          date: date_of_xml(xml),
+          link: @url,
+          pmid: match[:pmid]
         }
       end
 

data/lib/onebox/engine/stack_exchange_onebox.rb

@@ -7,10 +7,10 @@ module Onebox
 
       def self.domains
         %w(stackexchange.com stackoverflow.com superuser.com serverfault.com askubuntu.com stackapps.com mathoverflow.net)
-            .map { |domain| Regexp.escape(domain) }
+          .map { |domain| Regexp.escape(domain) }
       end
 
-      matches_regexp /^https?:\/\/(?:(?:(?<subsubdomain>\w*)\.)?(?<subdomain>\w*)\.)?(?<domain>#{domains.join('|')})\/((?:questions|q)\/(?<question_id>\d*)(\/.*\/(?<answer_id1>\d*))?|(a\/(?<answer_id2>\d*)))/
+      matches_regexp(/^https?:\/\/(?:(?:(?<subsubdomain>\w*)\.)?(?<subdomain>\w*)\.)?(?<domain>#{domains.join('|')})\/((?:questions|q)\/(?<question_id>\d*)(\/.*\/(?<answer_id1>\d*))?|(a\/(?<answer_id2>\d*)))/)
 
       def always_https?
         uri.host.split('.').length <= 3

data/lib/onebox/engine/standard_embed.rb

@@ -119,7 +119,7 @@ module Onebox
           html_doc.css('meta').each do |m|
             if (m["property"] && m["property"][/^twitter:(.+)$/i]) || (m["name"] && m["name"][/^twitter:(.+)$/i])
               value = (m["content"] || m["value"]).to_s
-              twitter[$1.tr('-:','_').to_sym] ||= value unless Onebox::Helpers::blank?(value)
+              twitter[$1.tr('-:' , '_').to_sym] ||= value unless Onebox::Helpers::blank?(value)
             end
           end
 

data/lib/onebox/engine/twitch_clips_onebox.rb

@@ -3,7 +3,7 @@ require_relative '../mixins/twitch_onebox'
 class Onebox::Engine::TwitchClipsOnebox
 
   def self.twitch_regexp
-	  /^https?:\/\/clips\.twitch\.tv\/([a-zA-Z0-9_]+\/?[^#\?\/]+)/
+    /^https?:\/\/clips\.twitch\.tv\/([a-zA-Z0-9_]+\/?[^#\?\/]+)/
   end
   include Onebox::Mixins::TwitchOnebox
 

data/lib/onebox/engine/twitch_video_onebox.rb

@@ -3,8 +3,9 @@ require_relative '../mixins/twitch_onebox'
 class Onebox::Engine::TwitchVideoOnebox
 
   def self.twitch_regexp
-	  /^https?:\/\/(?:www\.)?twitch\.tv\/videos\/([0-9]+)/
+    /^https?:\/\/(?:www\.)?twitch\.tv\/videos\/([0-9]+)/
   end
+
   include Onebox::Mixins::TwitchOnebox
 
   def query_params

data/lib/onebox/engine/twitter_status_onebox.rb

@@ -5,7 +5,7 @@ module Onebox
       include LayoutSupport
       include HTML
 
-      matches_regexp /^https?:\/\/(mobile\.|www\.)?twitter\.com\/.+?\/status(es)?\/\d+(\/(video|photo)\/\d?+)?+\/?$/
+      matches_regexp(/^https?:\/\/(mobile\.|www\.)?twitter\.com\/.+?\/status(es)?\/\d+(\/(video|photo)\/\d?+)?+\/?$/)
       always_https
 
       private
@@ -84,9 +84,9 @@ module Onebox
 
       def avatar
         if twitter_api_credentials_present?
-          access(:user, :profile_image_url_https)
-        else
-          twitter_data[:image].gsub!('400x400', 'normal') if twitter_data[:image]
+          access(:user, :profile_image_url_https).sub('normal', '400x400')
+        elsif twitter_data[:image]
+          twitter_data[:image]
         end
       end
 

data/lib/onebox/engine/wechat_mp_onebox.rb

@@ -22,19 +22,19 @@ module Onebox
       private
 
       def extract_script_value(var_name)
-        if (script_elem = raw.css("script").select{|script| script.inner_text.include? "var #{var_name} = "}) && script_elem.any?
+        if (script_elem = raw.css("script").select { |script| script.inner_text.include? "var #{var_name} = " }) && script_elem.any?
           e = Nokogiri::HTML(script_elem[0].inner_text.match(/var\s+#{Regexp.quote(var_name)}\s+=\s+"(.*?)";/)[1])
-          return CGI::unescapeHTML(e.text.scan(/(?:\\x([a-f0-9]{2}))|(.)/i).map { |x| x[0] ? [x[0].to_i(16)].pack('U'): x[1] }.join)
+          return CGI::unescapeHTML(e.text.scan(/(?:\\x([a-f0-9]{2}))|(.)/i).map { |x| x[0] ? [x[0].to_i(16)].pack('U') : x[1] }.join)
         end
       end
-      
+
       # TODO need to handle hotlink protection from wechat
       def image
         if banner_image = extract_script_value("msg_cdn_url")
           return banner_image
         end
 
-        if (main_image = raw.css("img").select{|img| not img['class']}) && main_image.any?
+        if (main_image = raw.css("img").select { |img| not img['class'] }) && main_image.any?
           attributes = main_image.first.attributes
 
           return attributes["data-src"].to_s if attributes["data-src"]

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -165,7 +165,7 @@ module Onebox
       end
 
       def self.host_matches(uri, list)
-        !!list.find {|h| %r((^|\.)#{Regexp.escape(h)}$).match(uri.host) }
+        !!list.find { |h| %r((^|\.)#{Regexp.escape(h)}$).match(uri.host) }
       end
 
       def self.probable_discourse(uri)

data/lib/onebox/engine/wikipedia_onebox.rb

@@ -17,8 +17,8 @@ module Onebox
         # Detect section Hash in the url and retrive the related paragraphs.  if no hash provided the first few paragraphs will be used
         # Author Lidlanca
         # Date 9/8/2014
-        if ( m_url_hash = @url.match /#([^\/?]+)/ ) #extract url hash
-          m_url_hash_name= m_url_hash[1]
+        if (m_url_hash = @url.match(/#([^\/?]+)/)) #extract url hash
+          m_url_hash_name = m_url_hash[1]
         end
 
         unless m_url_hash.nil?
@@ -35,7 +35,7 @@ module Onebox
             # div tag is commonly used as an assets wraper in an article section. often as the first element holding an image.
             # ul support will imporve the output generated for a section with a list as the main content (for example: an Author Bibliography, A musician Discography, etc)
             first_p_found = nil
-            while ( ((next_sibling = cur_element.next_sibling).name =~ /p|text|div|ul/) || first_p_found.nil? ) do  #from section header get the next sibling until it is a breaker tag
+            while (((next_sibling = cur_element.next_sibling).name =~ /p|text|div|ul/) || first_p_found.nil?) do  #from section header get the next sibling until it is a breaker tag
               cur_element = next_sibling
               if (cur_element.name == "p" || cur_element.name == "ul") #we treat a list as we detect a p to avoid showing
                 first_p_found = true
@@ -53,11 +53,11 @@ module Onebox
             break if cnt >= paras.size
             text << " " unless cnt == 0
 
-            if paras[cnt].name =="ul" #Handle UL tag. Generate a textual ordered list (1.item | 2.item | 3.item). Unfourtently no newline allowed in output
-              li_index=1
+            if paras[cnt].name == "ul" #Handle UL tag. Generate a textual ordered list (1.item | 2.item | 3.item). Unfourtently no newline allowed in output
+              li_index = 1
               list_items = []
-              paras[cnt].children.css("li").each {|li| list_items.push "#{li_index}." + li.inner_text ; li_index+=1}
-              paragraph =  (list_items.join " |\n ")[0..Onebox::LayoutSupport.max_text]
+              paras[cnt].children.css("li").each { |li| list_items.push "#{li_index}." + li.inner_text ; li_index += 1 }
+              paragraph = (list_items.join " |\n ")[0..Onebox::LayoutSupport.max_text]
             else
               paragraph = paras[cnt].inner_text[0..Onebox::LayoutSupport.max_text]
             end

data/lib/onebox/engine/youtube_onebox.rb

@@ -105,7 +105,7 @@ module Onebox
         end
 
         def embed_params
-          p = {'feature' => 'oembed', 'wmode' => 'opaque'}
+          p = { 'feature' => 'oembed', 'wmode' => 'opaque' }
 
           p['list'] = list_id if list_id
 

data/lib/onebox/file_type_finder.rb

@@ -52,14 +52,14 @@ module Onebox
       # First check against the known lists of "special" files and extensions.
       return @extensionless_files[lower_name] if @extensionless_files.has_key?(lower_name)
 
-      @long_file_types.each { |extension,type|
+      @long_file_types.each { |extension, type|
         return type if lower_name.end_with?(extension)
       }
 
       # Otherwise, just split on the last ".",
       # but add one so we don't return the "." itself.
       dot_spot = lower_name.rindex(".")
-      return lower_name[(dot_spot+1)..-1] if dot_spot
+      return lower_name[(dot_spot + 1)..-1] if dot_spot
 
       # If we couldn't figure it out from the name,
       # let the highlighter figure it out from the content.

data/lib/onebox/helpers.rb

@@ -6,12 +6,12 @@ module Onebox
     def self.symbolize_keys(hash)
       return {} if hash.nil?
 
-      hash.inject({}){|result, (key, value)|
+      hash.inject({}) do |result, (key, value)|
         new_key = key.is_a?(String) ? key.to_sym : key
         new_value = value.is_a?(Hash) ? symbolize_keys(value) : value
         result[new_key] = new_value
         result
-      }
+      end
     end
 
     def self.clean(html)
@@ -26,7 +26,7 @@ module Onebox
       doc.css('meta').each do |m|
         if (m["property"] && m["property"][/^og:(.+)$/i]) || (m["name"] && m["name"][/^og:(.+)$/i])
           value = (m["content"] || m["value"]).to_s
-          og[$1.tr('-:','_').to_sym] ||= value unless Onebox::Helpers::blank?(value)
+          og[$1.tr('-:', '_').to_sym] ||= value unless Onebox::Helpers::blank?(value)
         end
       end
 
@@ -39,7 +39,7 @@ module Onebox
       og
     end
 
-    def self.fetch_response(location, limit=nil, domain=nil, headers=nil)
+    def self.fetch_response(location, limit = nil, domain = nil, headers = nil)
 
       limit ||= 5
       limit = Onebox.options.redirect_limit if limit > Onebox.options.redirect_limit
@@ -123,18 +123,18 @@ module Onebox
       conv = [ 'B', 'KB', 'MB', 'GB', 'TB', 'PB', 'EB' ];
       scale = 1024;
 
-      ndx=1
-      if( size < 2*(scale**ndx)  ) then
-        return "#{(size)} #{conv[ndx-1]}"
+      ndx = 1
+      if (size < 2 * (scale**ndx)) then
+        return "#{(size)} #{conv[ndx - 1]}"
       end
-      size=size.to_f
-      [2,3,4,5,6,7].each do |i|
-        if (size < 2*(scale**i)) then
-          return "#{'%.2f' % (size/(scale**(i-1)))} #{conv[i-1]}"
+      size = size.to_f
+      [2, 3, 4, 5, 6, 7].each do |i|
+        if (size < 2 * (scale**i)) then
+          return "#{'%.2f' % (size / (scale**(i - 1)))} #{conv[i - 1]}"
         end
       end
-      ndx=7
-      return "#{'%.2f' % (size/(scale**(ndx-1)))} #{conv[ndx-1]}"
+      ndx = 7
+      return "#{'%.2f' % (size / (scale**(ndx - 1)))} #{conv[ndx - 1]}"
     end
 
     def self.click_to_scroll_div(width = 690, height = 400)
@@ -150,7 +150,7 @@ module Onebox
     end
 
     def self.truncate(string, length = 50)
-      string.size > length ? string[0...(string.rindex(" ", length)||length)] + "..." : string
+      string.size > length ? string[0...(string.rindex(" ", length) || length)] + "..." : string
     end
 
     def self.title_attr(meta)

data/lib/onebox/sanitize_config.rb

@@ -30,7 +30,7 @@ class Sanitize
           a_tag = env[:node]
           a_tag['href'] ||= '#'
           if a_tag['href'] =~ %r{^(?:[a-z]+:)?//}
-            a_tag['rel']    = 'nofollow noopener'
+            a_tag['rel'] = 'nofollow noopener'
           else
             a_tag.remove_attribute('target')
           end

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.8.22"
+  VERSION = "1.8.23"
 end

data/onebox.gemspec

@@ -1,3 +1,5 @@
+# frozen-string-literal: true
+
 # coding: utf-8
 lib = File.expand_path('../lib', __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
@@ -40,4 +42,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency 'sinatra-contrib', '~> 1.4'
   spec.add_development_dependency 'haml', '~> 4.0'
   spec.add_development_dependency 'listen', '~> 2.10.0'
+
+  spec.required_ruby_version = '>=2.2.0'
 end

data/spec/lib/onebox/engine/amazon_onebox_spec.rb

@@ -2,7 +2,6 @@ require "spec_helper"
 
 describe Onebox::Engine::AmazonOnebox do
 
-
   context "regular amazon page" do
     before do
       @link = "https://www.amazon.com/Knit-Noro-Accessories-Colorful-Little/dp/193609620X"

data/spec/lib/onebox/engine/google_maps_onebox_spec.rb

@@ -56,7 +56,7 @@ describe Onebox::Engine::GoogleMapsOnebox do
   end
 
   let(:data) { Onebox::Helpers.symbolize_keys(subject.send(:data)) }
-  let(:link) {|example| URLS[example.metadata[:urltype] || :short][:test] }
+  let(:link) { |example| URLS[example.metadata[:urltype] || :short][:test] }
 
   include_context "an engine", urltype: :short
 

data/spec/lib/onebox/engine/pdf_onebox_spec.rb

@@ -8,8 +8,8 @@ describe Onebox::Engine::PdfOnebox do
   let(:no_filesize_html) { described_class.new(no_content_length_link).to_html }
 
   before do
-    FakeWeb.register_uri(:head, link, :content_length => "335562")
-    FakeWeb.register_uri(:head, no_content_length_link, :content_length => nil)
+    FakeWeb.register_uri(:head, link, content_length: "335562")
+    FakeWeb.register_uri(:head, no_content_length_link, content_length: nil)
   end
 
   describe "#to_html" do

data/spec/lib/onebox/engine/pubmed_onebox_spec.rb

@@ -76,4 +76,3 @@ describe Onebox::Engine::PubmedOnebox do
     end
   end
 end
-

data/spec/lib/onebox/engine/stack_exchange_onebox_spec.rb

@@ -39,7 +39,7 @@ describe Onebox::Engine::StackExchangeOnebox do
 
   {
       'long URL' => 'http://stackoverflow.com/questions/17992553/concept-behind-these-four-lines-of-tricky-c-code',
-      'short URL'=> 'http://stackoverflow.com/q/17992553'
+      'short URL' => 'http://stackoverflow.com/q/17992553'
   }.each do |name, url|
     describe "question with #{name}" do
       before(:all) do
@@ -68,7 +68,7 @@ describe Onebox::Engine::StackExchangeOnebox do
 
   {
       'long URL' => 'http://stackoverflow.com/questions/17992553/concept-behind-these-four-lines-of-tricky-c-code/17992906#17992906',
-      'short URL'=> 'http://stackoverflow.com/a/17992906'
+      'short URL' => 'http://stackoverflow.com/a/17992906'
   }.each do |name, url|
     describe "answer with #{name}" do
       before(:all) do
@@ -94,4 +94,4 @@ describe Onebox::Engine::StackExchangeOnebox do
       end
     end
   end
-end
+end

data/spec/lib/onebox/engine/twitter_status_onebox_spec.rb

@@ -28,7 +28,7 @@ describe Onebox::Engine::TwitterStatusOnebox do
     end
 
     it "includes user avatar" do
-      expect(html).to include("732349210264133632/RTNgZLrm_normal.jpg")
+      expect(html).to include("732349210264133632/RTNgZLrm_400x400.jpg")
     end
   end
 

data/spec/lib/onebox/engine/wechat_mp_onebox_spec.rb

@@ -2,7 +2,7 @@ require "spec_helper"
 
 describe Onebox::Engine::WechatMpOnebox do
 
-  let(:link) {"https://mp.weixin.qq.com/s?__biz=MjM5NjM4MDAxMg==&mid=2655075181&idx=1&sn=7c58f17de2c687f4763f17359ecc6e72&chksm=bd5fb76e8a283e7856cae30a74e905a18d9511e81c047b6e12390889de15976fb2c297b04106#rd"}
+  let(:link) { "https://mp.weixin.qq.com/s?__biz=MjM5NjM4MDAxMg==&mid=2655075181&idx=1&sn=7c58f17de2c687f4763f17359ecc6e72&chksm=bd5fb76e8a283e7856cae30a74e905a18d9511e81c047b6e12390889de15976fb2c297b04106#rd" }
   let(:html) { described_class.new(link).to_html }
 
   describe "#to_html" do
@@ -13,11 +13,11 @@ describe Onebox::Engine::WechatMpOnebox do
     it "has the article's title" do
       expect(html).to include("不是月光宝盒，但也能回到过去")
     end
-  
+
     it "has the article's description" do
       expect(html).to include("你知道吗？从今天起，公众号后台编辑文章时可以……")
     end
-  
+
     it "has the article's author" do
       expect(html).to include("微信派")
     end

data/spec/lib/onebox/helpers_spec.rb

@@ -8,21 +8,21 @@ RSpec.describe Onebox::Helpers do
     it { expect(described_class.blank?(["test", "testing"])).to be(false) }
     it { expect(described_class.blank?([])).to be(true) }
     it { expect(described_class.blank?({})).to be(true) }
-    it { expect(described_class.blank?({a: 'test'})).to be(false) }
     it { expect(described_class.blank?(nil)).to be(true) }
     it { expect(described_class.blank?(true)).to be(false) }
     it { expect(described_class.blank?(false)).to be(true) }
+    it { expect(described_class.blank?(a: 'test')).to be(false) }
   end
 
   describe ".truncate" do
     let(:test_string) { "Chops off on spaces" }
     it { expect(described_class.truncate(test_string)).to eq(test_string) }
-    it { expect(described_class.truncate(test_string,5)).to eq("Chops...") }
-    it { expect(described_class.truncate(test_string,7)).to eq("Chops...") }
-    it { expect(described_class.truncate(test_string,9)).to eq("Chops off...") }
-    it { expect(described_class.truncate(test_string,10)).to eq("Chops off...") }
-    it { expect(described_class.truncate(test_string,100)).to eq("Chops off on spaces") }
-    it { expect(described_class.truncate(" #{test_string} ",6)).to eq(" Chops...") }
+    it { expect(described_class.truncate(test_string, 5)).to eq("Chops...") }
+    it { expect(described_class.truncate(test_string, 7)).to eq("Chops...") }
+    it { expect(described_class.truncate(test_string, 9)).to eq("Chops off...") }
+    it { expect(described_class.truncate(test_string, 10)).to eq("Chops off...") }
+    it { expect(described_class.truncate(test_string, 100)).to eq("Chops off on spaces") }
+    it { expect(described_class.truncate(" #{test_string} ", 6)).to eq(" Chops...") }
   end
 
   describe "fetch_response" do
@@ -44,7 +44,7 @@ RSpec.describe Onebox::Helpers do
 
   describe "user_agent" do
     before do
-      fake("http://example.com/some-resource", :body => 'test')
+      fake("http://example.com/some-resource", body: 'test')
     end
 
     context "default" do

data/spec/lib/onebox/layout_spec.rb

@@ -16,7 +16,7 @@ describe Onebox::Layout do
 
     context "when template exists in directory_b" do
       before(:each) do
-        allow_any_instance_of(described_class).to receive(:template?) { |_,path| path == "directory_b" }
+        allow_any_instance_of(described_class).to receive(:template?) { |_, path| path == "directory_b" }
       end
 
       it "returns directory_b" do
@@ -26,7 +26,7 @@ describe Onebox::Layout do
 
     context "when template exists in directory_a" do
       before(:each) do
-        allow_any_instance_of(described_class).to receive(:template?) { |_,path| path == "directory_a" }
+        allow_any_instance_of(described_class).to receive(:template?) { |_, path| path == "directory_a" }
       end
 
       it "returns directory_a" do

data/templates/stackexchange.mustache

@@ -1,6 +1,6 @@
 {{#owner.profile_image}}
   <a href="{{owner.link}}" target="_blank">
-    <img alt="{{owner.display_name}}" src="{{owner.profile_image}}" class="thumbnail">
+    <img alt="{{owner.display_name}}" src="{{owner.profile_image}}" class="thumbnail onebox-avatar">
   </a>
 {{/owner.profile_image}}
 <h4>

data/templates/twitterstatus.mustache

@@ -1,4 +1,4 @@
-{{#avatar}}<img src="{{avatar}}" class="thumbnail">{{/avatar}}
+{{#avatar}}<img src="{{avatar}}" class="thumbnail onebox-avatar">{{/avatar}}
 <h4>
   <a href='{{link}}' target='_blank'>
     {{title}}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.22
+  version: 1.8.23
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-11-03 00:00:00.000000000 Z
+date: 2017-11-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -516,7 +516,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 2.2.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -611,3 +611,4 @@ test_files:
 - spec/lib/onebox_spec.rb
 - spec/spec_helper.rb
 - spec/support/html_spec_helper.rb
+has_rdoc: