onebox 1.8.16 → 1.8.17

data/spec/lib/onebox/engine/cloudapp_onebox_spec.rb

@@ -0,0 +1,26 @@
+require "spec_helper"
+
+describe Onebox::Engine::CloudAppOnebox do
+  before do
+    fake("https://cl.ly/0m2a2u2k440O", response("cloudapp-gif"))
+    fake("https://cl.ly/0T0c2J3S373X", response("cloudapp-mp4"))
+    fake("https://cl.ly/2C0E1V451J0C", response("cloudapp-jpg"))
+    fake("https://cl.ly/1x1f2g253l03", response("cloudapp-others"))
+  end
+
+  it "supports gif" do
+    expect(Onebox.preview('https://cl.ly/0m2a2u2k440O').to_s).to match(/<img/)
+  end
+
+  it "supports mp4" do
+    expect(Onebox.preview('https://cl.ly/0T0c2J3S373X').to_s).to match(/<video/)
+  end
+
+  it "supports jpg" do
+    expect(Onebox.preview('https://cl.ly/2C0E1V451J0C').to_s).to match(/<img/)
+  end
+
+  it "links to other formats" do
+    expect(Onebox.preview('https://cl.ly/1x1f2g253l03').to_s).to match(/<a/)
+  end
+end

data/spec/lib/onebox/engine/wechat_mp_onebox_spec.rb

@@ -0,0 +1,26 @@
+require "spec_helper"
+
+describe Onebox::Engine::WechatMpOnebox do
+
+  let(:link) {"https://mp.weixin.qq.com/s?__biz=MjM5NjM4MDAxMg==&mid=2655075181&idx=1&sn=7c58f17de2c687f4763f17359ecc6e72&chksm=bd5fb76e8a283e7856cae30a74e905a18d9511e81c047b6e12390889de15976fb2c297b04106#rd"}
+  let(:html) { described_class.new(link).to_html }
+
+  describe "#to_html" do
+    before do
+      fake("https://mp.weixin.qq.com/s?__biz=MjM5NjM4MDAxMg==&mid=2655075181&idx=1&sn=7c58f17de2c687f4763f17359ecc6e72&chksm=bd5fb76e8a283e7856cae30a74e905a18d9511e81c047b6e12390889de15976fb2c297b04106", response("wechat-mp"))
+    end
+
+    it "has the article's title" do
+      expect(html).to include("不是月光宝盒，但也能回到过去")
+    end
+  
+    it "has the article's description" do
+      expect(html).to include("你知道吗？从今天起，公众号后台编辑文章时可以……")
+    end
+  
+    it "has the article's author" do
+      expect(html).to include("微信派")
+    end
+  end
+
+end

data/spec/lib/onebox/engine/whitelisted_generic_onebox_spec.rb

@@ -97,20 +97,39 @@ describe Onebox::Engine::WhitelistedGenericOnebox do
     end
   end
 
-  describe "uses canonical link" do
-    let(:mobile_url) { "http://m.imdb.com/title/tt0944947" }
-    let(:canonical_url) { "http://www.imdb.com/title/tt0944947/" }
-    before do
-      fake(mobile_url, response('imdb_mobile'))
-      fake(canonical_url, response('imdb'))
+  describe 'canonical link' do
+    context 'uses canonical link if available' do
+      let(:mobile_url) { "http://m.imdb.com/title/tt0944947" }
+      let(:canonical_url) { "http://www.imdb.com/title/tt0944947/" }
+      before do
+        fake(mobile_url, response('imdb_mobile'))
+        fake(canonical_url, response('imdb'))
+      end
+
+      it 'fetches opengraph data from canonical link' do
+        onebox = described_class.new(mobile_url)
+        expect(onebox.to_html).not_to be_nil
+        expect(onebox.to_html).to include("Game of Thrones")
+        expect(onebox.to_html).to include("Nine noble families fight for control over the mythical lands of Westeros")
+        expect(onebox.to_html).to include("https://images-na.ssl-images-amazon.com/images/M/MV5BMjE3NTQ1NDg1Ml5BMl5BanBnXkFtZTgwNzY2NDA0MjI@._V1_UY1200_CR90,0,630,1200_AL_.jpg")
+      end
     end
 
-    it 'fetches opengraph data from canonical link' do
-      onebox = described_class.new(mobile_url)
-      expect(onebox.to_html).not_to be_nil
-      expect(onebox.to_html).to include("Game of Thrones")
-      expect(onebox.to_html).to include("Nine noble families fight for control over the mythical lands of Westeros")
-      expect(onebox.to_html).to include("https://images-na.ssl-images-amazon.com/images/M/MV5BMjE3NTQ1NDg1Ml5BMl5BanBnXkFtZTgwNzY2NDA0MjI@._V1_UY1200_CR90,0,630,1200_AL_.jpg")
+    context 'does not use canonical link for Discourse topics' do
+      let(:discourse_topic_url) { "https://meta.discourse.org/t/congratulations-most-stars-in-2013-github-octoverse/12483" }
+      let(:discourse_topic_reply_url) { "https://meta.discourse.org/t/congratulations-most-stars-in-2013-github-octoverse/12483/2" }
+      before do
+        fake(discourse_topic_url, response('discourse_topic'))
+        fake(discourse_topic_reply_url, response('discourse_topic_reply'))
+      end
+
+      it 'fetches opengraph data from original link' do
+        onebox = described_class.new(discourse_topic_reply_url)
+        expect(onebox.to_html).not_to be_nil
+        expect(onebox.to_html).to include("Congratulations, most stars in 2013 GitHub Octoverse!")
+        expect(onebox.to_html).to include("Thanks for that link and thank you -- and everyone else who is contributing to the project!")
+        expect(onebox.to_html).to include("https://cdn-enterprise.discourse.org/meta/user_avatar/meta.discourse.org/codinghorror/200/5297_1.png")
+      end
     end
   end
 

data/templates/wechatmp.mustache

@@ -0,0 +1,4 @@
+<h3><a href='{{link}}' target='_blank'>{{title}}</a></h3>
+{{#by_info}}<b>{{by_info}}</b>{{/by_info}}
+<p>{{description}}</p>
+

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.16
+  version: 1.8.17
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-07-20 00:00:00.000000000 Z
+date: 2017-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -333,6 +333,7 @@ files:
 - lib/onebox/engine/audio_onebox.rb
 - lib/onebox/engine/audioboom_onebox.rb
 - lib/onebox/engine/bandcamp_onebox.rb
+- lib/onebox/engine/cloudapp_onebox.rb
 - lib/onebox/engine/coub_onebox.rb
 - lib/onebox/engine/douban_onebox.rb
 - lib/onebox/engine/five_hundred_px_onebox.rb
@@ -373,6 +374,7 @@ files:
 - lib/onebox/engine/typeform_onebox.rb
 - lib/onebox/engine/video_onebox.rb
 - lib/onebox/engine/vimeo_onebox.rb
+- lib/onebox/engine/wechat_mp_onebox.rb
 - lib/onebox/engine/whitelisted_generic_onebox.rb
 - lib/onebox/engine/wikimedia_onebox.rb
 - lib/onebox/engine/wikipedia_onebox.rb
@@ -396,7 +398,13 @@ files:
 - onebox.gemspec
 - spec/fixtures/amazon-og.response
 - spec/fixtures/amazon.response
+- spec/fixtures/cloudapp-gif.response
+- spec/fixtures/cloudapp-jpg.response
+- spec/fixtures/cloudapp-mp4.response
+- spec/fixtures/cloudapp-others.response
 - spec/fixtures/dailymail.response
+- spec/fixtures/discourse_topic.response
+- spec/fixtures/discourse_topic_reply.response
 - spec/fixtures/douban.response
 - spec/fixtures/gfycat.response
 - spec/fixtures/githubblob.response
@@ -418,6 +426,7 @@ files:
 - spec/fixtures/stackexchange-question.response
 - spec/fixtures/twitterstatus.response
 - spec/fixtures/video.response
+- spec/fixtures/wechat-mp.response
 - spec/fixtures/wikimedia.response
 - spec/fixtures/wikipedia.response
 - spec/fixtures/wikipediaredirected.response
@@ -430,6 +439,7 @@ files:
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
 - spec/lib/onebox/engine/audio_onebox_spec.rb
+- spec/lib/onebox/engine/cloudapp_onebox_spec.rb
 - spec/lib/onebox/engine/douban_onebox_spec.rb
 - spec/lib/onebox/engine/gfycat_onebox_spec.rb
 - spec/lib/onebox/engine/github_blob_onebox_spec.rb
@@ -452,6 +462,7 @@ files:
 - spec/lib/onebox/engine/twitch_video_onebox_spec.rb
 - spec/lib/onebox/engine/twitter_status_onebox_spec.rb
 - spec/lib/onebox/engine/video_onebox_spec.rb
+- spec/lib/onebox/engine/wechat_mp_onebox_spec.rb
 - spec/lib/onebox/engine/whitelisted_generic_onebox_spec.rb
 - spec/lib/onebox/engine/wikimedia_onebox_spec.rb
 - spec/lib/onebox/engine/wikipedia_onebox_spec.rb
@@ -482,6 +493,7 @@ files:
 - templates/pubmed.mustache
 - templates/stackexchange.mustache
 - templates/twitterstatus.mustache
+- templates/wechatmp.mustache
 - templates/whitelistedgeneric.mustache
 - templates/wikimedia.mustache
 - templates/wikipedia.mustache
@@ -519,7 +531,13 @@ summary: A gem for turning URLs into previews.
 test_files:
 - spec/fixtures/amazon-og.response
 - spec/fixtures/amazon.response
+- spec/fixtures/cloudapp-gif.response
+- spec/fixtures/cloudapp-jpg.response
+- spec/fixtures/cloudapp-mp4.response
+- spec/fixtures/cloudapp-others.response
 - spec/fixtures/dailymail.response
+- spec/fixtures/discourse_topic.response
+- spec/fixtures/discourse_topic_reply.response
 - spec/fixtures/douban.response
 - spec/fixtures/gfycat.response
 - spec/fixtures/githubblob.response
@@ -541,6 +559,7 @@ test_files:
 - spec/fixtures/stackexchange-question.response
 - spec/fixtures/twitterstatus.response
 - spec/fixtures/video.response
+- spec/fixtures/wechat-mp.response
 - spec/fixtures/wikimedia.response
 - spec/fixtures/wikipedia.response
 - spec/fixtures/wikipediaredirected.response
@@ -553,6 +572,7 @@ test_files:
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
 - spec/lib/onebox/engine/audio_onebox_spec.rb
+- spec/lib/onebox/engine/cloudapp_onebox_spec.rb
 - spec/lib/onebox/engine/douban_onebox_spec.rb
 - spec/lib/onebox/engine/gfycat_onebox_spec.rb
 - spec/lib/onebox/engine/github_blob_onebox_spec.rb
@@ -575,6 +595,7 @@ test_files:
 - spec/lib/onebox/engine/twitch_video_onebox_spec.rb
 - spec/lib/onebox/engine/twitter_status_onebox_spec.rb
 - spec/lib/onebox/engine/video_onebox_spec.rb
+- spec/lib/onebox/engine/wechat_mp_onebox_spec.rb
 - spec/lib/onebox/engine/whitelisted_generic_onebox_spec.rb
 - spec/lib/onebox/engine/wikimedia_onebox_spec.rb
 - spec/lib/onebox/engine/wikipedia_onebox_spec.rb