RubyGems - onebox - Versions diffs - 1.8.1 → 1.8.2 - Mend

onebox 1.8.1 → 1.8.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (12) hide show

checksums.yaml +4 -4
data/lib/onebox/engine/pubmed_onebox.rb +5 -5
data/lib/onebox/engine/twitter_status_onebox.rb +2 -2
data/lib/onebox/helpers.rb +4 -4
data/lib/onebox/version.rb +1 -1
data/spec/fixtures/pubmed-electronic-xml.response +175 -0
data/spec/fixtures/pubmed-electronic.response +307 -0
data/spec/fixtures/pubmed-xml.response +1 -1
data/spec/fixtures/twitterstatus.response +1530 -3724
data/spec/lib/onebox/engine/pubmed_onebox_spec.rb +46 -0
data/spec/lib/onebox/engine/twitter_status_onebox_spec.rb +130 -51
metadata +8 -3

data/spec/lib/onebox/engine/pubmed_onebox_spec.rb CHANGED Viewed

@@ -29,5 +29,51 @@ describe Onebox::Engine::PubmedOnebox do
   it "has the URL to the resource" do
     expect(html).to include(link)
   end
+  context "Pubmed electronic print" do
+    let(:link) { "http://www.ncbi.nlm.nih.gov/pubmed/24737116" }
+    let(:xml_link) { "http://www.ncbi.nlm.nih.gov/pubmed/24737116?report=xml&format=text" }
+    let(:html) { described_class.new(link).to_html }
+    before do
+      fake(link, response("pubmed-electronic"))
+      fake(xml_link, response("pubmed-electronic-xml"))
+    end
+    it "has the paper's title" do
+      expect(html).to include("Cushingoid facies on (18)F-FDG PET/CT.")
+    end
+    it "has the paper's author" do
+      expect(html).to include("van Rheenen")
+    end
+    it "has the paper's date" do
+      expect(html).to include("Jul 2014")
+    end
+    it "has the URL to the resource" do
+      expect(html).to include(link)
+    end
+  end
+  context "regex URI match" do
+    it "matches on specific articles" do
+      expect(match("http://www.ncbi.nlm.nih.gov/pubmed/7288891")).to eq true
+    end
+    it "does not match on search" do
+      expect(match("http://www.ncbi.nlm.nih.gov/pubmed/?term=rheenen+r")).to eq false
+    end
+    it "does not match on the root" do
+      expect(match("http://www.ncbi.nlm.nih.gov/pubmed/")).to eq false
+    end
+    def match(url)
+      Onebox::Engine::PubmedOnebox === URI(url)
+    end
+  end
 end

data/spec/lib/onebox/engine/twitter_status_onebox_spec.rb CHANGED Viewed

@@ -15,10 +15,9 @@ describe Onebox::Engine::TwitterStatusOnebox do
     #   expect(html).to include("http://www.peers.org/action/peers-pledgea")
     # end
-    # TODO: weird spec..
-    # it "includes timestamp" do
-    #   expect(html).to include("6:59 PM - 1 Aug 13")
-    # end
+    it "gets the correct timestamp" do
+      expect(onebox.send(:timestamp)).to eq("6:59 PM - 1 Aug 2013")
+    end
     it "includes name" do
       expect(html).to include("Vyki Englert")
@@ -29,7 +28,7 @@ describe Onebox::Engine::TwitterStatusOnebox do
     end
     it "includes user avatar" do
-      expect(html).to include("568244395007168512/qQVXa2Ql_normal.jpeg")
+      expect(html).to include("732349210264133632/RTNgZLrm_normal.jpg")
     end
   end
@@ -42,52 +41,9 @@ describe Onebox::Engine::TwitterStatusOnebox do
   context "with twitter client" do
     before(:each) do
       @twitter_client = double("TwitterClient")
-      allow(@twitter_client).to receive("status") do
-        {
-          created_at: "Fri Aug 02 01:59:30 +0000 2013",
-          id: 363_116_819_147_538_433,
-          id_str: "363116819147538433",
-          text:
-            "I'm a sucker for pledges.  @Peers Pledge #sharingeconomy http://t.co/T4Sc47KAzh",
-          source:
-            "<a href=\"http://twitter.com/tweetbutton\" rel=\"nofollow\">Tweet Button</a>",
-          user:
-            { id: 1_087_064_150,
-              id_str: "1087064150",
-              name: "Vyki Englert",
-              screen_name: "vyki_e",
-              location: "Los Angeles, CA",
-              description: "I am woman, hear me #RoR.",
-              url: "http://t.co/umZG76wmv2",
-              protected: false,
-              followers_count: 249,
-              friends_count: 907,
-              listed_count: 6,
-              created_at: "Sun Jan 13 19:53:00 +0000 2013",
-              favourites_count: 506,
-              statuses_count: 926,
-              lang: "en",
-              contributors_enabled: false,
-              is_translator: false,
-              profile_image_url:
-                "http://pbs.twimg.com/profile_images/568244395007168512/qQVXa2Ql_normal.jpeg",
-              profile_image_url_https:
-                "https://pbs.twimg.com/profile_images/568244395007168512/qQVXa2Ql_normal.jpeg",
-              following: true,
-              follow_request_sent: false,
-              notifications: nil },
-          geo: nil,
-          coordinates: nil,
-          place: nil,
-          contributors: nil,
-          retweet_count: 0,
-          favorite_count: 0,
-          favorited: false,
-          retweeted: false,
-          possibly_sensitive: false,
-          lang: "en"
-        }
-      end
+      allow(@twitter_client).to receive("status")
+        .and_return mockTwitterAPIReponse
       allow(@twitter_client).to receive("prettify_tweet") do
         "I'm a sucker for pledges.  <a href='https://twitter.com/Peers' target='_blank'>@Peers</a> Pledge <a href='https://twitter.com/search?q=%23sharingeconomy' target='_blank'>#sharingeconomy</a> <a target='_blank' href='http://www.peers.org/action/peers-pledgea/'>peers.org/action/peers-p…</a>"
       end
@@ -105,4 +61,127 @@ describe Onebox::Engine::TwitterStatusOnebox do
     it_behaves_like "an engine"
     it_behaves_like "#to_html"
   end
+  def mockTwitterAPIReponse
+    {
+      created_at: "Fri Aug 02 01:59:30 +0000 2013",
+      id: 363116819147538400,
+      id_str: "363116819147538433",
+      text: "I'm a sucker for pledges. @Peers Pledge #sharingeconomy http://t.co/T4Sc47KAzh",
+      truncated: false,
+      entities:  {
+        hashtags:  [
+           {
+            text: "sharingeconomy",
+            indices:  [
+              41,
+              56
+            ]
+          }
+        ],
+        symbols:  [],
+        user_mentions:  [
+           {
+            screen_name: "peers",
+            name: "Peers",
+            id: 1428357889,
+            id_str: "1428357889",
+            indices:  [
+              27,
+              33
+            ]
+          }
+        ],
+        urls:  [
+           {
+            url: "http://t.co/T4Sc47KAzh",
+            expanded_url: "http://www.peers.org/action/peers-pledgea/",
+            display_url: "peers.org/action/peers-p…",
+            indices:  [
+              57,
+              79
+            ]
+          }
+        ]
+      },
+      source: "<a href=\"https://dev.twitter.com/docs/tfw\" rel=\"nofollow\">Twitter for Websites</a>",
+      in_reply_to_status_id: nil,
+      in_reply_to_status_id_str: nil,
+      in_reply_to_user_id: nil,
+      in_reply_to_user_id_str: nil,
+      in_reply_to_screen_name: nil,
+      user:  {
+        id: 1087064150,
+        id_str: "1087064150",
+        name: "Vyki Englert",
+        screen_name: "vyki_e",
+        location: "Los Angeles, CA",
+        description: "Rides bikes, writes code, likes maps. @CompilerLA / @CityGrows / Brigade Captain @HackforLA",
+        url: "http://t.co/YCAP3asRG1",
+        entities:  {
+          url:  {
+            urls:  [
+               {
+                url: "http://t.co/YCAP3asRG1",
+                expanded_url: "http://www.compiler.la",
+                display_url: "compiler.la",
+                indices:  [
+                  0,
+                  22
+                ]
+              }
+            ]
+          },
+          description:  {
+            urls:  []
+          }
+        },
+        protected: false,
+        followers_count: 1128,
+        friends_count: 2244,
+        listed_count: 83,
+        created_at: "Sun Jan 13 19:53:00 +0000 2013",
+        favourites_count: 2928,
+        utc_offset: -25200,
+        time_zone: "Pacific Time (US & Canada)",
+        geo_enabled: true,
+        verified: false,
+        statuses_count: 3295,
+        lang: "en",
+        contributors_enabled: false,
+        is_translator: false,
+        is_translation_enabled: false,
+        profile_background_color: "ACDED6",
+        profile_background_image_url: "http://abs.twimg.com/images/themes/theme18/bg.gif",
+        profile_background_image_url_https: "https://abs.twimg.com/images/themes/theme18/bg.gif",
+        profile_background_tile: false,
+        profile_image_url: "http://pbs.twimg.com/profile_images/732349210264133632/RTNgZLrm_normal.jpg",
+        profile_image_url_https: "https://pbs.twimg.com/profile_images/732349210264133632/RTNgZLrm_normal.jpg",
+        profile_banner_url: "https://pbs.twimg.com/profile_banners/1087064150/1424315468",
+        profile_link_color: "4E99D1",
+        profile_sidebar_border_color: "EEEEEE",
+        profile_sidebar_fill_color: "F6F6F6",
+        profile_text_color: "333333",
+        profile_use_background_image: true,
+        has_extended_profile: false,
+        default_profile: false,
+        default_profile_image: false,
+        following: false,
+        follow_request_sent: false,
+        notifications: false
+      },
+      geo: nil,
+      coordinates: nil,
+      place: nil,
+      contributors: nil,
+      is_quote_status: false,
+      retweet_count: 0,
+      favorite_count: 0,
+      favorited: false,
+      retweeted: false,
+      possibly_sensitive: false,
+      possibly_sensitive_appealable: false,
+      lang: "en"
+    }
+  end
 end

metadata CHANGED Viewed

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.8.1
+  version: 1.8.2
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2017-02-08 00:00:00.000000000 Z
+date: 2017-02-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -396,6 +396,8 @@ files:
 - spec/fixtures/image.response
 - spec/fixtures/meetup.response.html
 - spec/fixtures/meetup_oembed.response
+- spec/fixtures/pubmed-electronic-xml.response
+- spec/fixtures/pubmed-electronic.response
 - spec/fixtures/pubmed-xml.response
 - spec/fixtures/pubmed.response
 - spec/fixtures/slides.response
@@ -489,7 +491,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project:
-rubygems_version: 2.6.8
+rubygems_version: 2.6.7
 signing_key:
 specification_version: 4
 summary: A gem for turning URLs into previews.
@@ -505,6 +507,8 @@ test_files:
 - spec/fixtures/image.response
 - spec/fixtures/meetup.response.html
 - spec/fixtures/meetup_oembed.response
+- spec/fixtures/pubmed-electronic-xml.response
+- spec/fixtures/pubmed-electronic.response
 - spec/fixtures/pubmed-xml.response
 - spec/fixtures/pubmed.response
 - spec/fixtures/slides.response
@@ -554,3 +558,4 @@ test_files:
 - spec/lib/onebox_spec.rb
 - spec/spec_helper.rb
 - spec/support/html_spec_helper.rb
+has_rdoc: