onebox 1.5.5 → 1.5.6

data/spec/lib/onebox/engine/github_gist_onebox_spec.rb

@@ -1,23 +1,67 @@
-# Broken for now
-#
-# require "spec_helper"
-# 
-# describe Onebox::Engine::GithubGistOnebox do
-#   before(:all) do
-#     @link = "https://gist.github.com/anikalindtner/153044e9bea3331cc103"
-#     @uri = "https://api.github.com/gists/153044e9bea3331cc103"
-#   end
-# 
-#   include_context "engines"
-#   it_behaves_like "an engine"
-# 
-#   describe "#to_html" do
-#     it "includes sha" do
-#       expect(html).to include("153044e9bea3331cc103")
-#     end
-# 
-#     it "includes script" do
-#       expect(html).to include("script")
-#     end
-#   end
-# end
+require "spec_helper"
+
+describe Onebox::Engine::GithubGistOnebox do
+  before(:all) do
+    @link = "https://gist.github.com/karreiro/208fdd59fc4b4c39283b"
+    fake("https://api.github.com/gists/208fdd59fc4b4c39283b", response(described_class.onebox_name))
+  end
+
+  include_context "engines"
+  it_behaves_like "an engine"
+
+  describe "#data" do
+    let(:gist_files) { data[:gist_files] }
+
+    it 'includes contents with 10 lines at most' do
+      gist_files.each do |gist_file|
+        truncated_lines = gist_file.content.split("\n").size
+        expect(truncated_lines).to be < 10
+      end
+    end
+  end
+
+  describe "#to_html" do
+    describe 'when Gist API responds correctly' do
+      it "includes the link to original page" do
+        expect(html).to include("https://gist.github.com/karreiro/208fdd59fc4b4c39283b")
+      end
+
+      it "includes three files" do
+        expect(html).to include("0.rb")
+        expect(html).to include("1.js")
+        expect(html).to include("2.md")
+      end
+
+      it "does not include truncated files" do
+        expect(html).not_to include("3.java")
+      end
+
+      it "includes gist contents" do
+        expect(html).to include("3.times { puts &quot;Gist API test.&quot; }")
+        expect(html).to include("console.log(&quot;Hey! ;)&quot;)")
+        expect(html).to include("#### Hey, this is a test!")
+      end
+
+      it "does not include gist contents from truncated files" do
+        expect(html).not_to include("System.out.println(&quot;Wow! This is a test!&quot;);")
+      end
+    end
+
+    describe 'when the rate limit has been reached' do
+      before(:all) do
+        FakeWeb.register_uri(:get, "https://api.github.com/gists/208fdd59fc4b4c39283b", status: 403)
+      end
+
+      it "includes the link to original page" do
+        expect(html).to include("https://gist.github.com/karreiro/208fdd59fc4b4c39283b")
+      end
+
+      it "does not include any file" do
+        expect(html).not_to include("0.rb")
+        expect(html).not_to include("1.js")
+        expect(html).not_to include("2.md")
+        expect(html).not_to include("3.java")
+      end
+    end
+  end
+end

data/spec/lib/onebox/engine/youku_onebox_spec.rb

@@ -0,0 +1,13 @@
+require 'spec_helper'
+
+describe Onebox::Engine::YoukuOnebox do
+  before do
+    FakeWeb.register_uri(:get, 'http://v.youku.com/v_show/id_XNjM3MzAxNzc2.html', body: response('youku'), content_type: 'text/html')
+    FakeWeb.register_uri(:get, 'http://v.youku.com/player/getPlayList/VideoIDS/XNjM3MzAxNzc2', body: response('youku-meta'), content_type: 'text/html')
+  end
+
+  it 'returns an image as the placeholder' do
+    Onebox.preview('http://v.youku.com/v_show/id_XNjM3MzAxNzc2.html')
+        .placeholder_html.should match(/<img/)
+  end
+end

data/spec/lib/onebox_spec.rb

@@ -29,7 +29,7 @@ describe Onebox do
   end
 
   describe "templates" do
-    let(:ignored)  { ["templates/_layout.mustache", "templates/githubgist.mustache"] }
+    let(:ignored)  { ["templates/_layout.mustache"] }
     let(:templates) { Dir["templates/*.mustache"] - ignored }
 
     def expect_templates_to_not_match(text)

data/templates/githubgist.mustache

@@ -0,0 +1,12 @@
+<h4><a href="{{link}}" target="_blank">{{link}}</a></h4>
+{{#gist_files}}
+<h5>{{filename}}</h5>
+<pre><code class='{{language}}'>{{content}}</code></pre>
+{{#truncated?}}This file has been truncated. <a href="{{link}}" target="_blank">show original</a>{{/truncated?}}
+{{/gist_files}}
+
+<p>
+{{#truncated_files?}}
+  There are more than three files. <a href="{{link}}" target="_blank">show original</a>
+{{/truncated_files?}}
+</p>

data/templates/googleplayapp.mustache

@@ -1,4 +1,5 @@
-<h3>{{developer}}</h3>
+<h3>{{title}}</h3>
+<h4>{{developer}}</h4>
 <img src="{{image}}" class="thumbnail"/>
 <p>{{description}}</p>
 <em>{{price}}</em>

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.5.5
+  version: 1.5.6
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-14 00:00:00.000000000 Z
+date: 2014-12-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -263,7 +263,9 @@ files:
 - lib/onebox/engine/video_onebox.rb
 - lib/onebox/engine/whitelisted_generic_onebox.rb
 - lib/onebox/engine/wikipedia_onebox.rb
+- lib/onebox/engine/youku_onebox.rb
 - lib/onebox/engine/youtube_onebox.rb
+- lib/onebox/file_type_finder.rb
 - lib/onebox/helpers.rb
 - lib/onebox/layout.rb
 - lib/onebox/layout_support.rb
@@ -277,6 +279,7 @@ files:
 - spec/fixtures/douban.response
 - spec/fixtures/githubblob.response
 - spec/fixtures/githubcommit.response
+- spec/fixtures/githubgist.response
 - spec/fixtures/githubpullrequest.response
 - spec/fixtures/googleplayapp.response
 - spec/fixtures/image.response
@@ -287,6 +290,8 @@ files:
 - spec/fixtures/video.response
 - spec/fixtures/wikipedia.response
 - spec/fixtures/wikipediaredirected.response
+- spec/fixtures/youku-meta.response
+- spec/fixtures/youku.response
 - spec/fixtures/youtube-channel.response
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
@@ -307,6 +312,7 @@ files:
 - spec/lib/onebox/engine/video_onebox_spec.rb
 - spec/lib/onebox/engine/whitelisted_generic_onebox_spec.rb
 - spec/lib/onebox/engine/wikipedia_onebox_spec.rb
+- spec/lib/onebox/engine/youku_onebox_spec.rb
 - spec/lib/onebox/engine/youtube_onebox_spec.rb
 - spec/lib/onebox/engine_spec.rb
 - spec/lib/onebox/layout_spec.rb
@@ -320,6 +326,7 @@ files:
 - templates/douban.mustache
 - templates/githubblob.mustache
 - templates/githubcommit.mustache
+- templates/githubgist.mustache
 - templates/githubissue.mustache
 - templates/githubpullrequest.mustache
 - templates/googleplayapp.mustache
@@ -358,6 +365,7 @@ test_files:
 - spec/fixtures/douban.response
 - spec/fixtures/githubblob.response
 - spec/fixtures/githubcommit.response
+- spec/fixtures/githubgist.response
 - spec/fixtures/githubpullrequest.response
 - spec/fixtures/googleplayapp.response
 - spec/fixtures/image.response
@@ -368,6 +376,8 @@ test_files:
 - spec/fixtures/video.response
 - spec/fixtures/wikipedia.response
 - spec/fixtures/wikipediaredirected.response
+- spec/fixtures/youku-meta.response
+- spec/fixtures/youku.response
 - spec/fixtures/youtube-channel.response
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
@@ -388,6 +398,7 @@ test_files:
 - spec/lib/onebox/engine/video_onebox_spec.rb
 - spec/lib/onebox/engine/whitelisted_generic_onebox_spec.rb
 - spec/lib/onebox/engine/wikipedia_onebox_spec.rb
+- spec/lib/onebox/engine/youku_onebox_spec.rb
 - spec/lib/onebox/engine/youtube_onebox_spec.rb
 - spec/lib/onebox/engine_spec.rb
 - spec/lib/onebox/layout_spec.rb