onebox 1.5.28 → 1.5.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 093e38bc01cea645ba23458783b5241c1dc6b07a
-  data.tar.gz: 6cb6ee768bc2d23584d607eabe906dd69b4ac2bc
+  metadata.gz: a71d37f0f18224ffa7a1161bb5fc58c53f42fc75
+  data.tar.gz: 90800a259664e555697a877640a2ac8df6808c4f
 SHA512:
-  metadata.gz: 88823288324ddc7a9ad375d5694563cd6ada8dd4524344c7f9c2cfa36f45dd8dd82ee1ecf99bfa3a742333a07440245693d98ae524e76981f99b6a86ca68de3e
-  data.tar.gz: 013064b0aedd3086abcd8a7f36d81fc205191941524e6a5897e8549dcfda5890bda58cffdc022cfee3c4838a2564b9e63c9a2da7a7e8601e46a8e54750bbaa49
+  metadata.gz: 458dcddb5eff58050b98c494d91d07bf374c9bf93fe74885e7bd367c76e52cef590bb2d52ea9636e8d03017b16746fd1621d692e537b0ed23d98afadd9c8a4a7
+  data.tar.gz: bf58d969638057be027a8e4f87dd7fea74cf4bc5886d588e64e616b7cd2e413f8d0eba3f0408410f45b0fbbc46795a05e40db68acbefdf57e5112afdfd2e4e19

data/lib/onebox/engine/soundcloud_onebox.rb

@@ -8,7 +8,8 @@ module Onebox
       always_https
 
       def to_html
-        get_oembed_data[:html].gsub!('height="400"', 'height="250"')
+        oembed_data = get_oembed_data[:html]
+        oembed_data.gsub!('visual=true', 'visual=false') || oembed_data
       end
 
       def placeholder_html
@@ -17,8 +18,16 @@ module Onebox
 
       private
 
+      def set?
+        url =~ /\/sets\//
+      end
+
       def get_oembed_data
-        Onebox::Helpers.symbolize_keys(::MultiJson.load(Onebox::Helpers.fetch_response("https://soundcloud.com/oembed.json?url=#{url}").body))
+        if set?
+          Onebox::Helpers.symbolize_keys(::MultiJson.load(Onebox::Helpers.fetch_response("https://soundcloud.com/oembed.json?url=#{url}").body))
+        else
+          Onebox::Helpers.symbolize_keys(::MultiJson.load(Onebox::Helpers.fetch_response("https://soundcloud.com/oembed.json?url=#{url}&maxheight=166").body))
+        end
       end
     end
   end

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -239,7 +239,9 @@ module Onebox
         data_hash[:image] = raw.images.first if raw.images && raw.images.first
         data_hash[:type] = raw.type if raw.type
 
-        if raw.metadata && raw.metadata[:video] && raw.metadata[:video].first
+        if raw.metadata && raw.metadata[:"video:secure_url"] && raw.metadata[:"video:secure_url"].first
+          data_hash[:video] = raw.metadata[:"video:secure_url"].first
+        elsif raw.metadata && raw.metadata[:video] && raw.metadata[:video].first
           data_hash[:video] = raw.metadata[:video].first
         end
 

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.5.28"
+  VERSION = "1.5.29"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.5.28
+  version: 1.5.29
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-19 00:00:00.000000000 Z
+date: 2015-12-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -431,7 +431,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.4.8
 signing_key: 
 specification_version: 4
 summary: A gem for turning URLs into previews.
@@ -488,3 +488,4 @@ test_files:
 - spec/lib/onebox_spec.rb
 - spec/spec_helper.rb
 - spec/support/html_spec_helper.rb
+has_rdoc: