onebox 1.5.18 → 1.5.19

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d1ad782f96ff776d0d2266234a1a35c728fda673
-  data.tar.gz: f6f790cb45621ec73844872684e855de29142484
+  metadata.gz: 1251f4223fba52393994afd37464bd4871ca7d50
+  data.tar.gz: 8d08a396a69afd7444ed606b680f62455b9ca772
 SHA512:
-  metadata.gz: f5fccca33ea465d18f16ccd6d277f96065a07c20c9d807efdd7e59e85f28c8846267cea1f8ea763f0c909f8395eb8ba01d5c2f2f22250c18587879762e520f83
-  data.tar.gz: e3b611db4ce5d131643102aa3642047a092ca0f16223329a367f02c4407c075fc9af1ab2949098fb7162c79c558a3e60d7c3455ce21675c62599602b9399d089
+  metadata.gz: 45b4ac31ab8c0d9d8f27e4b2a05ac356e03138631ddf3a357fa1a38ada58ff9178ea07b8893ac364beb2206331d6b5a8d53cba19f69531a7bb0e6284f6e0ff0e
+  data.tar.gz: 9161833850d7f2ef5434866c13900203f8d91efc3b62f93988e852184d1a265f4171bac87ba466a77fc324bcd3b26db056f18de5162dbf925314e2e81f518e9b

data/lib/onebox/engine.rb

@@ -143,3 +143,4 @@ require_relative "engine/youku_onebox"
 require_relative "engine/douban_onebox"
 require_relative "engine/whitelisted_generic_onebox"
 require_relative "engine/pubmed_onebox"
+require_relative "engine/soundcloud_onebox"

data/lib/onebox/engine/soundcloud_onebox.rb

@@ -0,0 +1,24 @@
+module Onebox
+  module Engine
+    class SoundCloudOnebox
+      include Engine
+      include StandardEmbed
+
+      matches_regexp(/^https?:\/\/.*soundcloud\.com/)
+
+      def to_html
+        get_oembed_data[:html].gsub!('height="400"', 'height="250"')
+      end
+
+      def placeholder_html
+        "<img src='#{get_oembed_data[:thumbnail_url]}'>"
+      end
+
+      private
+
+      def get_oembed_data
+        Onebox::Helpers.symbolize_keys(::MultiJson.load(Onebox::Helpers.fetch_response("http://soundcloud.com/oembed.json?url=#{url}").body))
+      end
+    end
+  end
+end

data/lib/onebox/engine/twitter_status_onebox.rb

@@ -18,7 +18,7 @@ module Onebox
       end
 
       def raw
-        if client
+        if client && !client.twitter_credentials_missing?
           @raw ||= OpenStruct.new(client.status(match[:id]).to_hash)
         else
           super

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -91,7 +91,6 @@ module Onebox
           screenr.com
           scribd.com
           slideshare.net
-          soundcloud.com
           sourceforge.net
           speakerdeck.com
           spotify.com

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.5.18"
+  VERSION = "1.5.19"
 end

data/spec/lib/onebox/engine/twitter_status_onebox_spec.rb

@@ -94,6 +94,9 @@ describe Onebox::Engine::TwitterStatusOnebox do
       allow(@twitter_client).to receive("prettify_tweet") do
         "I'm a sucker for pledges.  <a href='https://twitter.com/Peers' target='_blank'>@Peers</a> Pledge <a href='https://twitter.com/search?q=%23sharingeconomy' target='_blank'>#sharingeconomy</a> <a target='_blank' href='http://www.peers.org/action/peers-pledgea/'>peers.org/action/peers-p…</a>"
       end
+      allow(@twitter_client).to receive("twitter_credentials_missing?") do
+        false
+      end
       Onebox.options = { twitter_client: @twitter_client }
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.5.18
+  version: 1.5.19
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-08 00:00:00.000000000 Z
+date: 2015-05-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -301,6 +301,7 @@ files:
 - lib/onebox/engine/image_onebox.rb
 - lib/onebox/engine/json.rb
 - lib/onebox/engine/pubmed_onebox.rb
+- lib/onebox/engine/soundcloud_onebox.rb
 - lib/onebox/engine/stack_exchange_onebox.rb
 - lib/onebox/engine/standard_embed.rb
 - lib/onebox/engine/twitter_status_onebox.rb