onebox 1.4.4 → 1.4.5

data/spec/lib/onebox/engine/youtube_onebox_spec.rb

@@ -3,15 +3,35 @@ require 'spec_helper'
 describe Onebox::Engine::YoutubeOnebox do
   before do
     fake("http://www.youtube.com/watch?feature=player_embedded&v=21Lk4YiASMo", response("youtube"))
-    fake("http://www.youtube.com/oembed?format=json&url=http%3A%2F%2Fwww.youtube.com%2Fwatch%3Fv%3D21Lk4YiASMo", response("youtube-json"))
+    fake("https://www.youtube.com/channel/UCL8ZULXASCc1I_oaOT0NaOQ", response("youtube-channel"))
   end
 
   it "adds wmode=opaque" do
-    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo').to_s.should match(/wmode=opaque/)
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo')
+    .to_s.should match(/wmode=opaque/)
   end
 
-  it "rewrites URLs to be agnostic" do
-    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo').to_s.should match(/"\/\//)
+  it "rewrites URLs for videos to be HTTPS" do
+    # match: plain HTTP and protocol agnostic
+    regex = /(http:|["']\/\/)/
+
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo')
+    .to_s.should_not match(regex)
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo')
+    .placeholder_html.should_not match(regex)
+    Onebox.preview('https://www.youtube.com/channel/UCL8ZULXASCc1I_oaOT0NaOQ')
+    .to_s.should_not match(regex)
+  end
+
+  it "can onebox a channel page" do
+    Onebox.preview('https://www.youtube.com/channel/UCL8ZULXASCc1I_oaOT0NaOQ')
+    .to_s.should match(/Google Chrome/)
+  end
+
+  it "can onebox a playlist" do
+    pending('no opengraph on playlists, needs special handling')
+
+    Onebox.preview('https://www.youtube.com/playlist?list=PL5308B2E5749D1696').to_s
   end
 
   it "does not make HTTP requests unless necessary" do
@@ -21,11 +41,49 @@ describe Onebox::Engine::YoutubeOnebox do
   end
 
   it "does not fail if we cannot get the video ID from the URL" do
-    Onebox.preview('http://www.youtube.com/watch?feature=player_embedded&v=21Lk4YiASMo').to_s.should match(/embed/)
+    # TODO this test no longer makes sense - the video ID is successfully retrieved and no fakeweb request is made
+    Onebox.preview('http://www.youtube.com/watch?feature=player_embedded&v=21Lk4YiASMo')
+    .to_s.should match(/embed/)
   end
 
   it "returns an image as the placeholder" do
-    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo').placeholder_html.should match(/<img/)
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo')
+    .placeholder_html.should match(/<img/)
+  end
+
+  it "passes the playlist ID through" do
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&list=UUQau-O2C0kGJpR3_CHBTGbw&index=1')
+    .to_s.should match(/UUQau-O2C0kGJpR3_CHBTGbw/)
+  end
+
+  it "filters out nonsense parameters" do
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&potential[]=exploit&potential[]=fun')
+    .to_s.should_not match(/potential|exploit|fun/)
+  end
+
+  it "converts time strings into a &start= parameter" do
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&start=3782')
+    .to_s.should match(/start=3782/)
+    Onebox.preview('https://www.youtube.com/watch?start=1h3m2s&v=21Lk4YiASMo')
+    .to_s.should match(/start=3782/)
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&t=1h3m2s')
+    .to_s.should match(/start=3782/)
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&start=1h3m2s')
+    .to_s.should match(/start=3782/)
+    Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo#t=1h3m2s')
+    .to_s.should match(/start=3782/)
+  end
+
+  it "allows both start and end" do
+    preview = Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&start=2m&end=3m').to_s
+    preview.should match(/start=120/)
+    preview.should match(/end=180/)
+  end
+
+  it "permits looping videos" do
+    preview = Onebox.preview('https://www.youtube.com/watch?v=21Lk4YiASMo&loop').to_s
+    preview.should match(/loop=1/)
+    preview.should match(/playlist=21Lk4YiASMo/)
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.4.4
+  version: 1.4.5
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-08 00:00:00.000000000 Z
+date: 2014-08-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -284,7 +284,7 @@ files:
 - spec/fixtures/video.response
 - spec/fixtures/wikipedia.response
 - spec/fixtures/wikipediaredirected.response
-- spec/fixtures/youtube-json.response
+- spec/fixtures/youtube-channel.response
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
 - spec/lib/onebox/engine/audio_onebox_spec.rb
@@ -342,7 +342,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.11
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: A gem for turning URLs into previews.
@@ -361,7 +361,7 @@ test_files:
 - spec/fixtures/video.response
 - spec/fixtures/wikipedia.response
 - spec/fixtures/wikipediaredirected.response
-- spec/fixtures/youtube-json.response
+- spec/fixtures/youtube-channel.response
 - spec/fixtures/youtube.response
 - spec/lib/onebox/engine/amazon_onebox_spec.rb
 - spec/lib/onebox/engine/audio_onebox_spec.rb

data/spec/fixtures/youtube-json.response

@@ -1 +0,0 @@
-{"author_url": "http:\/\/www.youtube.com\/user\/korotto5810", "version": "1.0", "title": "96neko - orange", "author_name": "korotto5810", "provider_url": "http:\/\/www.youtube.com\/", "thumbnail_width": 480, "width": 480, "provider_name": "YouTube", "thumbnail_height": 360, "height": 270, "type": "video", "thumbnail_url": "http:\/\/i1.ytimg.com\/vi\/21Lk4YiASMo\/hqdefault.jpg", "html": "\u003ciframe width=\"480\" height=\"270\" src=\"http:\/\/www.youtube.com\/embed\/21Lk4YiASMo?feature=oembed\" frameborder=\"0\" allowfullscreen\u003e\u003c\/iframe\u003e"}