onebox 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3a7bb8f501bd1571f0ebb6d05de268c7a25bfaf4
-  data.tar.gz: a9d916c58f10fd69906578734bc50ade5fedf9b3
+  metadata.gz: 977d0987e9df9956d13b5fd9b4ea2836970950cc
+  data.tar.gz: a41dccd090afb43672b7569a9fc6d0b9cb514839
 SHA512:
-  metadata.gz: 76f0c2bbcf0aa381da8b934f12b00397d56eda73460409fd6837def9df358849f75ec1e257a21509cca5868a8b2415507a62dbb5ba5164668eb978ee4b302895
-  data.tar.gz: c407ceea8eb7cec34d382469f708310862784264bf42793b502e8818dc4e5c689e0bc78df3cb29fec9ee583bc00b062d440c065a0cb4144baf799eb2cae2c185
+  metadata.gz: 95c60583f27f77785ebcd5727a73d374383bded0639dfeb51812ef08a04733aaa720737ca589be7c36f23075a705b56bf9220d797b2a3c3f218b335fa7b18b07
+  data.tar.gz: f5ab7b01db74e545f60623e964344a52a68c8574a7b6aa7962ad3b44edd0716bf9c7f2b2e23e10ace38ab86157fca8b8c48fd14ecf9ab32669e9be179cdd1c98

data/lib/onebox/engine/amazon_onebox.rb

@@ -6,13 +6,17 @@ module Onebox
       include HTML
 
 
-      matches_regexp(/^http:\/\/(?:www)\.amazon\.(com|ca)/)
+      matches_regexp(/^http:\/\/(?:www)\.amazon\.(?<tld>com|ca|de|it|es|fr|co\.jp|co\.uk|cn|in|com\.br)\//)
 
       def url
-        return "http://www.amazon.com/gp/aw/d/" + URI::encode(match[:id]) if match && match[:id]
+        return "http://www.amazon.#{tld}/gp/aw/d/" + URI::encode(match[:id]) if match && match[:id]
         @url
       end
 
+      def tld
+        @tld || @@matcher.match(@url)["tld"]
+      end
+
       def http_params
         {'User-Agent' => 'Mozilla/5.0 (iPhone; CPU iPhone OS 5_0_1 like Mac OS X) AppleWebKit/534.46 (KHTML, like Gecko) Version/5.1 Mobile/9A405 Safari/7534.48.3'}
       end

data/lib/onebox/engine/standard_embed.rb

@@ -32,7 +32,7 @@ module Onebox
       private
 
       def parse_open_graph(html, url)
-        og = Struct.new(:url, :type, :title, :description, :images, :metadata).new
+        og = Struct.new(:url, :type, :title, :description, :images, :metadata, :html).new
         og.url = url
         og.images = []
         og.metadata = {}

data/lib/onebox/engine/whitelisted_generic_onebox.rb

@@ -69,6 +69,7 @@ module Onebox
           liveleak.com
           lessonplanet.com
           mashable.com
+          meetup.com
           mlb.com
           myspace.com
           nba.com

data/lib/onebox/engine/youtube_onebox.rb

@@ -30,7 +30,7 @@ module Onebox
           html = "<iframe width=\"480\" height=\"270\" src=\"https://www.youtube.com/embed/#{video_id}?feature=oembed\" frameborder=\"0\" allowfullscreen></iframe>"
         else
           # Fall back to making HTTP requests.
-          html = raw[:html]
+          html = raw[:html] || ""
         end
 
         rewrite_agnostic(append_params(html))

data/lib/onebox/version.rb

@@ -1,3 +1,3 @@
 module Onebox
-  VERSION = "1.3.2"
+  VERSION = "1.3.3"
 end

data/spec/lib/onebox/engine/amazon_onebox_spec.rb

@@ -9,6 +9,57 @@ describe Onebox::Engine::AmazonOnebox do
   include_context "engines"
   it_behaves_like "an engine"
 
+  describe "works with international domains" do
+
+    def check_link(tdl, link)
+      onebox_cls = Onebox::Matcher.new(link).oneboxed
+      expect(onebox_cls).to_not be(nil)
+      expect(onebox_cls.new(link).url).to include("http://www.amazon.#{tdl}")
+    end
+
+    it "matches canadian domains" do
+      resp = check_link("ca", "http://www.amazon.ca/Too-Much-Happiness-Alice-Munro-ebook/dp/B0031TZ98K/")
+
+    end
+
+    it "matches german domains" do
+      check_link("de", "http://www.amazon.de/Buddenbrooks-Verfall-einer-Familie-Roman/dp/3596294312/")
+    end
+
+    it "matches uk domains" do
+      check_link("co.uk", "http://www.amazon.co.uk/Pygmalion-George-Bernard-Shaw/dp/1420925237/")
+    end
+
+    it "matches japanese domains" do
+      check_link("co.jp", "http://www.amazon.co.jp/%E9%9B%AA%E5%9B%BD-%E6%96%B0%E6%BD%AE%E6%96%87%E5%BA%AB-%E3%81%8B-1-1-%E5%B7%9D%E7%AB%AF-%E5%BA%B7%E6%88%90/dp/4101001014/")
+    end
+
+    it "matches chinese domains" do
+      check_link("cn", "http://www.amazon.cn/%E5%AD%99%E5%AD%90%E5%85%B5%E6%B3%95-%E5%AD%99%E8%86%91%E5%85%B5%E6%B3%95-%E5%AD%99%E6%AD%A6/dp/B0011C40FC/")
+    end
+
+    it "matches french domains" do
+      check_link("fr", "http://www.amazon.fr/Les-Mots-autres-%C3%A9crits-autobiographiques/dp/2070114147/")
+    end
+
+    it "matches italian domains" do
+      check_link("it", "http://www.amazon.it/Tutte-poesie-Salvatore-Quasimodo/dp/8804520477/")
+    end
+
+    it "matches spanish domains" do
+      check_link("es", "http://www.amazon.es/familia-Pascual-Duarte-Camilo-Jos%C3%A9-ebook/dp/B00EJRTKTW/")
+    end
+
+    it "matches brasilian domains" do
+      check_link("com.br", "http://www.amazon.com.br/A-p%C3%A1tria-chuteiras-Nelson-Rodrigues-ebook/dp/B00J2B414Y/")
+    end
+
+    it "matches indian domains" do
+      check_link("in", "http://www.amazon.in/Fireflies-Rabindranath-Tagore/dp/9381523169/")
+    end
+
+  end
+
   describe "#to_html" do
     it "includes image" do
       expect(html).to include("img")

data/spec/spec_helper.rb

@@ -1,8 +1,3 @@
-require "coveralls"
-Coveralls.wear! do
-  add_filter "/spec/"
-end
-
 require "rspec"
 require "pry"
 require "fakeweb"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onebox
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - Joanna Zeta
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-25 00:00:00.000000000 Z
+date: 2014-05-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json