onebox 1.1.0 → 1.2.0

data/spec/lib/onebox/engine/amazon_onebox_spec.rb

@@ -3,35 +3,20 @@ require "spec_helper"
 describe Onebox::Engine::AmazonOnebox do
   before(:all) do
     @link = "http://www.amazon.com/Knit-Noro-Accessories-Colorful-Little/dp/193609620X"
-    fake(@link, response(described_class.template_name))
+    @uri = "http://www.amazon.com/gp/aw/d/193609620X"
   end
-  before(:each) { Onebox.defaults.cache.clear }
-
-  let(:link) { @link }
 
+  include_context "engines"
   it_behaves_like "an engine"
 
   describe "#to_html" do
-    let(:html) { described_class.new(link).to_html }
-
-    it "returns the product title" do
-      expect(html).to include("Knit Noro: Accessories: 30 Colorful Little Knits [Hardcover]")
-    end
-
-    it "returns the product image" do
-      expect(html).to include("61mI3YmHVnL._BO2,204,203,200_PIsitb-sticker-arrow-click,TopRight,35,-76_AA300_SH20_OU01_.jpg")
+    it "includes image" do
+      expect(html).to include("img")
     end
 
-    it "returns the product description" do
+    it "includes description" do
       expect(html).to include("Using only the finest natural materials and ecologically sound")
     end
 
-    it "returns the product price" do
-      expect(html).to include("$18.77")
-    end
-
-    it "returns the product URL" do
-      expect(html).to include(link)
-    end
   end
 end

data/spec/lib/onebox/engine/classic_google_maps_onebox_spec.rb

@@ -0,0 +1,28 @@
+require "spec_helper"
+
+describe Onebox::Engine::ClassicGoogleMapsOnebox do
+  describe 'long form url' do
+    before do
+      @link = "https://maps.google.ca/maps?q=Eiffel+Tower,+Avenue+Anatole+France,+Paris,+France&hl=en&sll=43.656878,-79.32085&sspn=0.932941,1.50238&oq=eiffel+&t=m&z=17&iwloc=A"
+    end
+
+    include_context "engines"
+    it_behaves_like "an engine"
+
+    describe "#to_html" do
+      it "embeds the iframe to display the map" do
+        expect(html).to include("iframe")
+      end
+    end
+  end
+
+  describe 'short form url' do
+    let(:long_url) { "https://maps.google.ca/maps?q=Brooklyn+Bridge,+Brooklyn,+NY,+United+States&hl=en&sll=43.656878,-79.32085&sspn=0.932941,1.50238&oq=brooklyn+bridge&t=m&z=17&iwloc=A" }
+
+    it "retrieves the long form url" do
+      onebox = described_class.new("http://goo.gl/maps/XffUa")
+      onebox.expects(:get_long_url).once.returns(long_url)
+      expect(onebox.url).to eq(long_url)
+    end
+  end
+end

data/spec/lib/onebox/engine/github_blob_onebox_spec.rb

@@ -1,30 +1,21 @@
 require "spec_helper"
 
 describe Onebox::Engine::GithubBlobOnebox do
-  let(:link) { "https://github.com/discourse/discourse/blob/master/lib/oneboxer/github_blob_onebox.rb" }
-  before do
-    fake(link, response("githubblob"))
+  before(:all) do
+    @link = "https://github.com/discourse/discourse/blob/master/lib/oneboxer/github_blob_onebox.rb"
+    fake("https://raw.github.com/discourse/discourse/master/lib/oneboxer/github_blob_onebox.rb", response(described_class.onebox_name))
   end
 
+  include_context "engines"
   it_behaves_like "an engine"
 
   describe "#to_html" do
-    let(:html) { described_class.new(link).to_html }
-
-    it "has file name" do
+    it "includes file name" do
       expect(html).to include("github_blob_onebox.rb")
     end
 
-    it "has number of lines" do
-      expect(html).to include("50")
-    end
-
-    it "has blob contents" do
+    it "includes blob contents" do
       expect(html).to include("module Oneboxer")
     end
-
-    it "has URL" do
-      expect(html).to include(link)
-    end
   end
 end

data/spec/lib/onebox/engine/github_commit_onebox_spec.rb

@@ -3,59 +3,51 @@ require "spec_helper"
 describe Onebox::Engine::GithubCommitOnebox do
   before(:all) do
     @link = "https://github.com/discourse/discourse/commit/803d023e2307309f8b776ab3b8b7e38ba91c0919"
-    fake(@link, response(described_class.template_name))
+    @uri = "https://api.github.com/repos/discourse/discourse/commits/803d023e2307309f8b776ab3b8b7e38ba91c0919"
   end
-  before(:each) { Onebox.defaults.cache.clear }
-
-  let(:link) { @link }
 
+  include_context "engines"
   it_behaves_like "an engine"
 
   describe "#to_html" do
-    let(:html) { described_class.new(link).to_html }
-
-    it "has repo owner" do
+    it "includes owner" do
       expect(html).to include("discourse")
     end
 
-    it "has repo name" do
+    it "includes repository name" do
       expect(html).to include("discourse")
     end
 
-    it "has commit sha" do
+    it "includes commit sha" do
       expect(html).to include("803d023e2307309f8b776ab3b8b7e38ba91c0919")
     end
 
-    it "has commit author gravatar" do
+    it "includes commit author gravatar" do
       expect(html).to include("2F7d3010c11d08cf990b7614d2c2ca9098.png")
     end
 
-    it "has commit message" do
+    it "includes commit message" do
       expect(html).to include("Fixed GitHub auth")
     end
 
-    it "has commit author" do
+    it "includes commit author" do
       expect(html).to include("SamSaffron")
     end
 
-    it "has commit time and date" do
-      expect(html).to include("2013-08-02T02:16:44Z")
+    it "includes commit time and date" do
+      expect(html).to include("02:03AM - 02 Aug 13")
     end
 
-    it "has number of files changed" do
-      expect(html).to include("1 changed file")
+    it "includes number of files changed" do
+      expect(html).to include("1 file")
     end
 
-    it "has number of additions" do
+    it "includes number of additions" do
       expect(html).to include("18 additions")
     end
 
-    it "has number of deletions" do
+    it "includes number of deletions" do
       expect(html).to include("2 deletions")
     end
-
-    it "has URL" do
-      expect(html).to include(link)
-    end
   end
 end

data/spec/lib/onebox/engine/github_gist_onebox_spec.rb

@@ -3,27 +3,19 @@ require "spec_helper"
 describe Onebox::Engine::GithubGistOnebox do
   before(:all) do
     @link = "https://gist.github.com/anikalindtner/153044e9bea3331cc103"
-    fake(@link, response(described_class.template_name))
+    @uri = "https://api.github.com/gists/153044e9bea3331cc103"
   end
-  before(:each) { Onebox.defaults.cache.clear }
-
-  let(:link) { @link }
 
+  include_context "engines"
   it_behaves_like "an engine"
 
   describe "#to_html" do
-    let(:html) { described_class.new(link).to_html }
-
-    it "has raw file contents" do
-      expect(html).to include("# Create a new blog post on GitHub")
-    end
-
-    it "has author" do
-      expect(html).to include("anikalindtner")
+    it "includes sha" do
+      expect(html).to include("153044e9bea3331cc103")
     end
 
-    it "has URL" do
-      expect(html).to include(link)
+    it "includes script" do
+      expect(html).to include("script")
     end
   end
 end

data/spec/lib/onebox/engine/github_pullrequest_onebox_spec.rb

@@ -1,58 +1,46 @@
 require "spec_helper"
 
 describe Onebox::Engine::GithubPullRequestOnebox do
-  let(:link) { "https://github.com/discourse/discourse/pull/1253/" }
-  before do
-    fake(link, response("githubpullrequest"))
+  before(:all) do
+    @link = "https://github.com/discourse/discourse/pull/1253/"
+    @uri = "https://api.github.com/repos/discourse/discourse/pulls/1253"
+    fake(@uri, response(described_class.onebox_name))
   end
 
+  include_context "engines"
   it_behaves_like "an engine"
 
   describe "#to_html" do
-    let(:html) { described_class.new(link).to_html }
-
-    it "has pull request author" do
+    it "includes pull request author" do
       expect(html).to include("jamesaanderson")
     end
 
-    it "has pull request title" do
-      expect(html).to include("Add audio onebox")
-    end
-
-    it "has repo name" do
+    it "includes repository name" do
       expect(html).to include("discourse")
     end
 
-    it "has commit author gravatar" do
+    it "includes commit author gravatar" do
       expect(html).to include("b3e9977094ce189bbb493cf7f9adea21")
     end
 
-    it "has commit description" do
-      expect(html).to include("8168")
+    it "includes commit time and date" do
+      expect(html).to include("02:05AM - 26 Jul 13")
     end
 
-    it "has commit time and date" do
-      expect(html).to include("2013-07-26T02:05:53Z")
-    end
-
-    it "has number of commits" do
+    it "includes number of commits" do
       expect(html).to include("1")
     end
 
-    it "has number of files changed" do
+    it "includes number of files changed" do
       expect(html).to include("4")
     end
 
-    it "has number of additions" do
+    it "includes number of additions" do
       expect(html).to include("19")
     end
 
-    it "has number of deletions" do
+    it "includes number of deletions" do
       expect(html).to include("1")
     end
-
-    it "has URL" do
-      expect(html).to include(link)
-    end
   end
 end

data/spec/lib/onebox/engine/google_play_app_onebox_spec.rb

@@ -0,0 +1,28 @@
+require "spec_helper"
+
+describe Onebox::Engine::GooglePlayAppOnebox do
+  before(:all) do
+    @link = "https://play.google.com/store/apps/details?id=com.hulu.plus&hl=en"
+  end
+
+  include_context "engines"
+  it_behaves_like "an engine"
+
+  describe "#to_html" do
+    it "has developer" do
+      expect(html).to include("Hulu")
+    end
+
+    it "has image" do
+      expect(html).to include("JH08z41G8hlCw=w300-rw")
+    end
+
+    it "has description" do
+      expect(html).to include("Instantly watch current TV shows")
+    end
+
+    it "has price" do
+      expect(html).to include("Free")
+    end
+  end
+end

data/spec/lib/onebox/engine/html_spec.rb

@@ -2,12 +2,10 @@ require "spec_helper"
 
 describe Onebox::Engine::HTML do
   before(:all) do
-    @link = "http://example.com"
-    fake(@link, response("example"))
+    @link = "http://amazon.com"
+    fake(@link, response("amazon"))
   end
-  before(:each) { Onebox.defaults.cache.clear }
-
-  let(:link) { @link }
+  before(:each) { Onebox.options.cache.clear }
 
   describe "#raw" do
     class OneboxEngineHTML
@@ -20,7 +18,7 @@ describe Onebox::Engine::HTML do
     end
 
     it "returns a Nokogiri object that has a css method" do
-      object = OneboxEngineHTML.new("http://example.com").send(:raw)
+      object = OneboxEngineHTML.new("http://amazon.com").send(:raw)
       expect(object).to respond_to(:css)
     end
   end

data/spec/lib/onebox/engine/json_spec.rb

@@ -2,12 +2,10 @@ require "spec_helper"
 
 describe Onebox::Engine::JSON do
   before(:all) do
-    @link = "http://gist.github.com"
-    fake(@link, response("githubgist"))
+    @link = "http://stackoverflow.com"
+    fake(@link, response("stackexchange"))
   end
-  before(:each) { Onebox.defaults.cache.clear }
-
-  let(:link) { @link }
+  before(:each) { Onebox.options.cache.clear }
 
   describe "#raw" do
     class OneboxEngineJSON
@@ -20,7 +18,7 @@ describe Onebox::Engine::JSON do
     end
 
     it "returns a hash" do
-      object = OneboxEngineJSON.new("http://gist.github.com").send(:raw)
+      object = OneboxEngineJSON.new(@link).send(:raw)
       expect(object).to be_a(Hash)
     end
   end

data/spec/lib/onebox/engine/stack_exchange_onebox_spec.rb

@@ -3,28 +3,15 @@ require "spec_helper"
 describe Onebox::Engine::StackExchangeOnebox do
   before(:all) do
     @link = "http://stackoverflow.com/questions/17992553/concept-behind-these-four-lines-of-tricky-c-code"
-    fake(@link, response(described_class.template_name))
+    fake("http://api.stackexchange.com/2.1/questions/17992553?site=stackoverflow", response(described_class.onebox_name))
   end
-  before(:each) { Onebox.defaults.cache.clear }
-
-  let(:link) { @link }
 
+  include_context "engines"
   it_behaves_like "an engine"
 
   describe "#to_html" do
-    let(:html) { described_class.new(link).to_html }
-
-    it "returns the question title" do
-      expect(html).to include("Concept behind these 4 lines of tricky C++ code")
-    end
-
-    it "returns the question" do
-      expect(html).to include("Why does this code gives output C++Sucks? Can anyone explain the concept behind it?")
-    end
-
-    it "returns the question URL" do
-      expect(html).to include(link)
+    it "includes question" do
+      expect(html).to include("Concept behind these four lines of tricky C++ code")
     end
   end
 end
-

data/spec/lib/onebox/engine/twitter_status_onebox_spec.rb

@@ -0,0 +1,103 @@
+require "spec_helper"
+
+describe Onebox::Engine::TwitterStatusOnebox do
+  before(:all) do
+    @link = "https://twitter.com/vyki_e/status/363116819147538433"
+  end
+
+  shared_examples_for "#to_html" do
+    it "includes tweet" do
+      expect(html).to include("I'm a sucker for pledges.")
+    end
+
+    it "includes timestamp" do
+      pending
+      expect(html).to include("6:59 PM - 1 Aug 13")
+    end
+
+    it "includes username" do
+      expect(html).to include("vyki_e")
+    end
+
+    it "includes user avatar" do
+      expect(html).to include("39b969d32a10b2437563e246708c8f9d_normal.jpeg")
+    end
+
+    it "includes tweet favorite count" do
+      pending
+      expect(html).to include("")
+    end
+
+    it "includes retweet count" do
+      pending
+      expect(html).to include("")
+    end
+  end
+
+  context "with html" do
+    include_context "engines"
+    it_behaves_like "an engine"
+    it_behaves_like "#to_html"
+  end
+
+  context "with twitter client" do
+    before(:each) do
+      @twitter_client = double("TwitterClient")
+      @twitter_client.stub("status") do
+        {
+          created_at: "Fri Aug 02 01:59:30 +0000 2013",
+          id: 363_116_819_147_538_433,
+          id_str: "363116819147538433",
+          text:
+            "I'm a sucker for pledges.  @Peers Pledge #sharingeconomy http://t.co/T4Sc47KAzh",
+          source:
+            "<a href=\"http://twitter.com/tweetbutton\" rel=\"nofollow\">Tweet Button</a>",
+          user:
+            { id: 1_087_064_150,
+              id_str: "1087064150",
+              name: "Vyki Englert",
+              screen_name: "vyki_e",
+              location: "Los Angeles, CA",
+              description: "I am woman, hear me #RoR.",
+              url: "http://t.co/umZG76wmv2",
+              protected: false,
+              followers_count: 249,
+              friends_count: 907,
+              listed_count: 6,
+              created_at: "Sun Jan 13 19:53:00 +0000 2013",
+              favourites_count: 506,
+              statuses_count: 926,
+              lang: "en",
+              contributors_enabled: false,
+              is_translator: false,
+              profile_image_url:
+                "http://pbs.twimg.com/profile_images/3518892092/39b969d32a10b2437563e246708c8f9d_normal.jpeg",
+              profile_image_url_https:
+                "https://pbs.twimg.com/profile_images/3518892092/39b969d32a10b2437563e246708c8f9d_normal.jpeg",
+              following: true,
+              follow_request_sent: false,
+              notifications: nil },
+          geo: nil,
+          coordinates: nil,
+          place: nil,
+          contributors: nil,
+          retweet_count: 0,
+          favorite_count: 0,
+          favorited: false,
+          retweeted: false,
+          possibly_sensitive: false,
+          lang: "en"
+        }
+      end
+      Onebox.options = { twitter_client: @twitter_client }
+    end
+
+    after(:each) do
+      Onebox.options = { twitter_client: nil }
+    end
+
+    include_context "engines"
+    it_behaves_like "an engine"
+    it_behaves_like "#to_html"
+  end
+end