one_signal 1.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ea70b55c5209ae2e1d55b7b24728dbe125031707
-  data.tar.gz: e7c77d266e4ea20bc0cc7650925c0fc2a214bc47
+  metadata.gz: 4d0c9f33f989591f7d6ab3631d728a25468bd25e
+  data.tar.gz: eb95288dede0228e6ed8a625bc4a6a9048e2e221
 SHA512:
-  metadata.gz: f20b6d9543e7c9dd390cd138475ee339ffb5d8eea96a7fd6a932990a80ab789589bbcd77c50bc01d76e15c5280b8725932ef4a22fbc511e375c92d4decc49886
-  data.tar.gz: c1f3aef54be919fc7ec8216d5793c8cf1ee4538aa5888e85f340b5953a79a1d93b50dda07c20a4699b83883ded0ad07365258978526ab29686a987d791d1af16
+  metadata.gz: 8d3e910a05cb29cf3df627caa26ca3cd4262bb86241669105a3dcd4e1004b5d28f4a0834a18a5d4d4ea4e6797c0a745604204f8cb509973226d3f33be5174b61
+  data.tar.gz: eb4182003d2cd13fa8f25dbe3102d9279476fb9b2848c74a67d3d88b18f22b34538f19496ea48f2e97f1dd365de00194234f53c5c3ed23c47bcf35db10bc958f

data/.travis.yml

@@ -1,5 +1,6 @@
 language: ruby
 
 rvm:
+  - 2.0
   - 2.1
   - 2.2

data/CHANGELOG.txt

@@ -1,3 +1,7 @@
+=== 1.1.0 2016-04-08
+
+* Add compatibility with Ruby 2.0
+
 === 1.0.0 2016-02-23
 
 * Update Player#csv_export for API consistency

data/README.md

@@ -56,7 +56,7 @@ The return value of each method is a `Net::HTTPResponse`.
 
 ```ruby
 - OneSignal::Player.all(params:)
-- OneSignal::Player.csv_export(app_id:)
+- OneSignal::Player.csv_export(params:)
 - OneSignal::Player.get(id:)
 - OneSignal::Player.create(params:)
 - OneSignal::Player.create_session(id:, params:)

data/lib/one_signal/app.rb

@@ -18,7 +18,7 @@ module OneSignal
       return response
     end
 
-    def self.get(id:)
+    def self.get(id: "")
       uri_string = @@base_uri
       uri_string += "/apps"
       uri_string += "/#{id}"
@@ -51,7 +51,7 @@ module OneSignal
       return response
     end
     
-    def self.update(id:, params: {})
+    def self.update(id: "", params: {})
       uri_string = @@base_uri
       uri_string += "/apps"
       uri_string += "/#{id}"

data/lib/one_signal/notification.rb

@@ -18,7 +18,7 @@ module OneSignal
       return response
     end
 
-    def self.get(id:, params:)
+    def self.get(id: "", params: {})
       uri_string = @@base_uri
       uri_string += "/notifications"
       uri_string += "/#{id}"
@@ -49,7 +49,7 @@ module OneSignal
       return response
     end
 
-    def self.update(id:, params: {})
+    def self.update(id: "", params: {})
       uri_string = @@base_uri
       uri_string += "/notifications"
       uri_string += "/#{id}"
@@ -66,7 +66,7 @@ module OneSignal
       return response
     end
 
-    def self.delete(id:, params:)
+    def self.delete(id: "", params: {})
       uri_string = @@base_uri
       uri_string += "/notifications"
       uri_string += "/#{id}"
@@ -85,21 +85,26 @@ module OneSignal
 
     private
 
-    def self.handle_error(uri:, params:, response:)
+    def self.handle_error(uri: nil, params: {}, response: nil)
       msg = "Create Notification error - uri: #{uri} params: #{params}"
+      unless response.nil?
+        code = response.code
+        body = response.body
+      end
       if is_no_recipients_error(response: response)
         raise NoRecipientsError.new(message: msg,
-                                    http_status: response.code,
-                                    http_body: response.body)
+                                    http_status: code,
+                                    http_body: body)
       else
         raise OneSignalError.new(message: msg,
-                                 http_status: response.code,
-                                 http_body: response.body)
+                                 http_status: code,
+                                 http_body: body)
       end
     end
 
-    def self.is_no_recipients_error(response:)
-      return false if response.code != '400' ||
+    def self.is_no_recipients_error(response: nil)
+      return false if response.nil? ||
+                      response.code != '400' ||
                       response.body.nil?
 
       body = JSON.parse(response.body)

data/lib/one_signal/one_signal.rb

@@ -43,7 +43,9 @@ module OneSignal
       @@read_timeout
     end
 
-    def self.http_object(uri:)
+    def self.http_object(uri: nil)
+      return nil if uri.nil?
+
       http = Net::HTTP.new(uri.host, uri.port)
       http.use_ssl = uri.scheme == 'https'
       http.open_timeout = @@open_timeout
@@ -51,49 +53,61 @@ module OneSignal
       return http
     end
 
-    def self.send_post_request(uri:, body:)
+    def self.send_post_request(uri: nil, body: nil)
+      return nil if uri.nil?
+
       request = Net::HTTP::Post.new(uri.request_uri)
       request.body = body.to_json
       request = request_with_headers(request: request)
       
       http = http_object(uri: uri)
 
-      response = http.request(request)
+      return http.request(request)
     end
 
-    def self.send_delete_request(uri:, params: {})
+    def self.send_delete_request(uri: nil, params: {})
+      return nil if uri.nil?
+
       uri.query = URI.encode_www_form(params) unless params.nil?
       request = Net::HTTP::Delete.new(uri.request_uri)
       request = request_with_headers(request: request)
       
       http = http_object(uri: uri)
 
-      response = http.request(request)
+      return http.request(request)
     end
 
-    def self.send_put_request(uri:, body:)
+    def self.send_put_request(uri: nil, body: nil)
+      return nil if uri.nil?
+
       request = Net::HTTP::Put.new(uri.request_uri)
       request.body = body.to_json
       request = request_with_headers(request: request)
       
       http = http_object(uri: uri)
 
-      response = http.request(request)
+      return http.request(request)
     end
 
-    def self.send_get_request(uri:, params: {})
+    def self.send_get_request(uri: nil, params: {})
+      return nil if uri.nil?
+
       uri.query = URI.encode_www_form(params) unless params.nil?
       request = Net::HTTP::Get.new(uri.request_uri)
       request = request_with_headers(request: request)
       
       http = http_object(uri: uri)
 
-      response = http.request(request)
+      return http.request(request)
     end
 
     private
 
-    def self.ensure_http_status(response:, status:, method_name:, uri:, params:)
+    def self.ensure_http_status(response: nil, status: nil, method_name: "", uri: "", params: {})
+      if response.nil? || status.nil?
+        raise OneSignalError.new(message: "Please provide a response (#{response}) and a status (#{status})")
+      end
+
       if response.code != status.to_s
         msg = "#{self.name}##{method_name} error - uri: #{uri} params: #{params}"
         raise OneSignalError.new(message: msg,
@@ -102,7 +116,9 @@ module OneSignal
       end
     end
 
-    def self.request_with_headers(request:)
+    def self.request_with_headers(request: nil)
+      return nil if request.nil?
+
       request.add_field("Content-Type", "application/json")
       request.add_field("Authorization", "Basic #{self.auth_key}")
       return request

data/lib/one_signal/player.rb

@@ -2,7 +2,7 @@ module OneSignal
 
   class Player < OneSignal
 
-    def self.csv_export(params:)
+    def self.csv_export(params: {})
       uri_string = @@base_uri
       uri_string += "/players/csv_export"
       uri = URI.parse(uri_string)
@@ -34,7 +34,7 @@ module OneSignal
       return response
     end
 
-    def self.get(id:)
+    def self.get(id: "")
       uri_string = @@base_uri
       uri_string += "/players"
       uri_string += "/#{id}"
@@ -67,7 +67,7 @@ module OneSignal
       return response
     end
 
-    def self.create_session(id:, params: {})
+    def self.create_session(id: "", params: {})
       uri_string = @@base_uri
       uri_string += "/players"
       uri_string += "/#{id}"
@@ -85,7 +85,7 @@ module OneSignal
       return response
     end
 
-    def self.create_purchase(id:, params: {})
+    def self.create_purchase(id: "", params: {})
       uri_string = @@base_uri
       uri_string += "/players"
       uri_string += "/#{id}"
@@ -103,7 +103,7 @@ module OneSignal
       return response
     end
 
-    def self.create_focus(id:, params: {})
+    def self.create_focus(id: "", params: {})
       uri_string = @@base_uri
       uri_string += "/players"
       uri_string += "/#{id}"
@@ -121,7 +121,7 @@ module OneSignal
       return response
     end
 
-    def self.update(id:, params: {})
+    def self.update(id: "", params: {})
       uri_string = @@base_uri
       uri_string += "/players"
       uri_string += "/#{id}"

data/lib/one_signal/version.rb

@@ -1,3 +1,3 @@
 module OneSignal
-  VERSION = "1.0.0"
+  VERSION = "1.1.0"
 end

data/one_signal.gemspec

@@ -1,7 +1,7 @@
 require File.expand_path('lib/one_signal/version')
 
 Gem::Specification.new do |s|
-  s.required_ruby_version = '>= 2.1.0'
+  s.required_ruby_version = '>= 2.0.0'
   s.add_development_dependency 'rake', '~> 10.4'
   s.add_development_dependency 'mocha', '~> 1.1'
   s.add_development_dependency 'dotenv', '~> 2.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: one_signal
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Thomas Balthazar
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-23 00:00:00.000000000 Z
+date: 2016-04-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -107,7 +107,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.0.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="