onceover 4.0.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 62ace64dee90c811ed79a0d4e8388711ce808b7fef7c9ebb6f7ab1103293de73
-  data.tar.gz: 50c3ace5d24af8b240763e4d84699c7dd57d27d64908ddd1049914707b61aede
+  metadata.gz: 13b36f4288ac28fad2e2dacae0a53bbac7e9d060607172b291f8dba9c7fe11c9
+  data.tar.gz: 5f492f55c749369cb49367670868379fd540b28cd30349849f2e5cd122139ce1
 SHA512:
-  metadata.gz: 12bac2ebf77efff73c73d61a07432158e0ed6cf7ca5750fa31e55443ad5267b0dc1cc2f9bc58c0f026a72b8a8797f9b02b1783505122619e99b39888b166aea9
-  data.tar.gz: 45bd8b4b2f9a1c8922ff44a964fa62567c7f0a63bf1cd785b0c5d49976f14cb299b16c43dd0af44d145a452c7544d484a47b2e7dd22331645cdd015d0ab8a31d
+  metadata.gz: e2c829ee671937eef47fdf2ee390547bfe1b4aff450508f415fe455a05e9f10cf17095dfc01aa0253182b652e26929c15303346fbbcd9e7db497fb8f2cc1c00b
+  data.tar.gz: 25485562b7c19edce1fd0aa3808d2071612583b52508c96a5c056c89cb1e6eab84cc0f7433df168982f3df307bb88069b2a724a465796ee870c27cd1178648f9

data/.github/workflows/release.yaml

@@ -1,32 +1,106 @@
-name: Release
+---
+name: Gem Release
 
 on:
   push:
     tags:
       - '*'
 
+permissions: {}
+
 jobs:
-  release:
-    runs-on: ubuntu-latest
+  build-release:
+    # Prevent releases from forked repositories
     if: github.repository_owner == 'voxpupuli'
+    name: Build the gem
+    runs-on: ubuntu-24.04
     steps:
       - uses: actions/checkout@v4
-      - name: Install Ruby 3.3
+      - name: Install Ruby
         uses: ruby/setup-ruby@v1
         with:
-          ruby-version: '3.3'
-        env:
-          BUNDLE_WITHOUT: release:development:rubocop
+          ruby-version: 'ruby'
       - name: Build gem
+        shell: bash
         run: gem build --verbose *.gemspec
+      - name: Upload gem to GitHub cache
+        uses: actions/upload-artifact@v4
+        with:
+          name: gem-artifact
+          path: '*.gem'
+          retention-days: 1
+          compression-level: 0
+
+  create-github-release:
+    needs: build-release
+    name: Create GitHub release
+    runs-on: ubuntu-24.04
+    permissions:
+      contents: write # clone repo and create release
+    steps:
+      - name: Download gem from GitHub cache
+        uses: actions/download-artifact@v4
+        with:
+          name: gem-artifact
+      - name: Create Release
+        shell: bash
+        env:
+          GH_TOKEN: ${{ github.token }}
+        run: gh release create --repo ${{ github.repository }} ${{ github.ref_name }} --generate-notes *.gem
+
+  release-to-github:
+    needs: build-release
+    name: Release to GitHub
+    runs-on: ubuntu-24.04
+    permissions:
+      packages: write # publish to rubygems.pkg.github.com
+    steps:
+      - name: Download gem from GitHub cache
+        uses: actions/download-artifact@v4
+        with:
+          name: gem-artifact
+      - name: Publish gem to GitHub packages
+        run: gem push --host https://rubygems.pkg.github.com/${{ github.repository_owner }} *.gem
+        env:
+          GEM_HOST_API_KEY: ${{ secrets.GITHUB_TOKEN }}
+
+  release-to-rubygems:
+    needs: build-release
+    name: Release gem to rubygems.org
+    runs-on: ubuntu-24.04
+    environment: release # recommended by rubygems.org
+    permissions:
+      id-token: write # rubygems.org authentication
+    steps:
+      - name: Download gem from GitHub cache
+        uses: actions/download-artifact@v4
+        with:
+          name: gem-artifact
+      - uses: rubygems/configure-rubygems-credentials@v1.0.0
       - name: Publish gem to rubygems.org
+        shell: bash
         run: gem push *.gem
-        env:
-          GEM_HOST_API_KEY: '${{ secrets.RUBYGEMS_AUTH_TOKEN }}'
-      - name: Setup GitHub packages access
+
+  release-verification:
+    name: Check that all releases are done
+    runs-on: ubuntu-24.04
+    permissions:
+      contents: read # minimal permissions that we have to grant
+    needs:
+      - create-github-release
+      - release-to-github
+      - release-to-rubygems
+    steps:
+      - name: Download gem from GitHub cache
+        uses: actions/download-artifact@v4
+        with:
+          name: gem-artifact
+      - name: Install Ruby
+        uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: 'ruby'
+      - name: Wait for release to propagate
+        shell: bash
         run: |
-          mkdir -p ~/.gem
-          echo ":github: Bearer ${{ secrets.GITHUB_TOKEN }}" >> ~/.gem/credentials
-          chmod 0600 ~/.gem/credentials
-      - name: Publish gem to GitHub packages
-        run: gem push --key github --host https://rubygems.pkg.github.com/voxpupuli *.gem
+          gem install rubygems-await
+          gem await *.gem

data/.github/workflows/tests.yaml

@@ -28,12 +28,10 @@ jobs:
           - windows-latest
           - ubuntu-latest
           - macos-latest
+          - ubuntu-24.04-arm
         puppet:
-          - "~> 7.0"
           - "~> 8.0"
         include:
-          - puppet: "~> 7.0"
-            ruby: 2.7
           - puppet: "~> 8.0"
             ruby: 3.2
 

data/.rubocop.yml

@@ -1,5 +1,13 @@
 ---
 inherit_from: .rubocop_todo.yml
 
-inherit_gem:
-  voxpupuli-rubocop: rubocop.yml
+AllCops:
+  NewCops: enable
+  DisplayCopNames: true
+  ExtraDetails: true
+  DisplayStyleGuide: true
+  TargetRubyVersion: 3.2
+  Exclude:
+    - vendor/**/*
+    - .vendor/**/*
+    - spec/fixtures/**/*

data/.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-11-14 22:59:32 UTC using RuboCop version 1.67.0.
+# on 2025-06-27 14:03:27 UTC using RuboCop version 1.50.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
@@ -40,7 +40,7 @@ Layout/IndentationWidth:
 
 # Offense count: 12
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment, AllowRBSInlineAnnotation.
+# Configuration parameters: AllowDoxygenCommentStyle, AllowGemfileRubyComment.
 Layout/LeadingCommentSpace:
   Exclude:
     - 'lib/onceover/beaker/spec_helper.rb'
@@ -87,9 +87,8 @@ Layout/SpaceAroundBlockParameters:
 
 # Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator, EnforcedStyleForRationalLiterals.
+# Configuration parameters: AllowForAlignment, EnforcedStyleForExponentOperator.
 # SupportedStylesForExponentOperator: space, no_space
-# SupportedStylesForRationalLiterals: space, no_space
 Layout/SpaceAroundOperators:
   Exclude:
     - 'lib/onceover/controlrepo.rb'
@@ -165,7 +164,7 @@ Layout/TrailingEmptyLines:
     - 'features/step_definitions/formatter.rb'
     - 'features/support/env.rb'
 
-# Offense count: 8
+# Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowInHeredoc.
 Layout/TrailingWhitespace:
@@ -173,7 +172,6 @@ Layout/TrailingWhitespace:
     - 'features/step_definitions/common.rb'
     - 'features/step_definitions/formatter.rb'
     - 'lib/onceover/node.rb'
-    - 'lib/onceover/rspec/formatters.rb'
     - 'lib/onceover/testconfig.rb'
 
 # Offense count: 3
@@ -190,12 +188,6 @@ Lint/ErbNewArguments:
   Exclude:
     - 'lib/onceover/rake_tasks.rb'
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Lint/RedundantCopDisableDirective:
-  Exclude:
-    - 'onceover.gemspec'
-
 # Offense count: 10
 # This cop supports safe autocorrection (--autocorrect).
 Lint/RedundantStringCoercion:
@@ -219,7 +211,7 @@ Lint/UnderscorePrefixedVariableName:
 
 # Offense count: 20
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Exclude:
     - 'lib/onceover/cli.rb'
@@ -233,97 +225,62 @@ Lint/UnusedBlockArgument:
 
 # Offense count: 8
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
 Lint/UnusedMethodArgument:
   Exclude:
     - 'lib/onceover/beaker.rb'
     - 'lib/onceover/rspec/formatters.rb'
 
 # Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect.
 Lint/UselessAssignment:
   Exclude:
     - 'lib/onceover/rspec/formatters.rb'
     - 'lib/onceover/runner.rb'
 
-# Offense count: 3
-# Configuration parameters: AllowedNames.
-# AllowedNames: module_parent
-Naming/ClassAndModuleCamelCase:
-  Exclude:
-    - 'features/support/cache_helper.rb'
-    - 'features/support/command_helper.rb'
-    - 'features/support/controlrepo_helper.rb'
-
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RedundantBlockCall:
-  Exclude:
-    - 'lib/onceover/controlrepo.rb'
+# Offense count: 37
+# Configuration parameters: AllowedMethods, AllowedPatterns, CountRepeatedAttributes.
+Metrics/AbcSize:
+  Max: 156
 
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: AllowRegexpMatch.
-Performance/RedundantEqualityComparisonBlock:
-  Exclude:
-    - 'lib/onceover/group.rb'
-    - 'lib/onceover/test.rb'
+# Offense count: 5
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
+# AllowedMethods: refine
+Metrics/BlockLength:
+  Max: 51
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RedundantMatch:
-  Exclude:
-    - 'lib/onceover/deploy.rb'
+# Offense count: 2
+# Configuration parameters: CountBlocks.
+Metrics/BlockNesting:
+  Max: 4
 
 # Offense count: 6
-# This cop supports safe autocorrection (--autocorrect).
-Performance/RegexpMatch:
-  Exclude:
-    - 'Rakefile'
-    - 'features/step_definitions/run.rb'
-    - 'lib/onceover/beaker.rb'
-    - 'lib/onceover/controlrepo.rb'
-    - 'lib/onceover/deploy.rb'
+# Configuration parameters: CountComments, CountAsOne.
+Metrics/ClassLength:
+  Max: 494
 
-# Offense count: 1
-# This cop supports safe autocorrection (--autocorrect).
-Performance/ReverseEach:
-  Exclude:
-    - 'lib/onceover/deploy.rb'
-
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-Performance/StringInclude:
-  Exclude:
-    - 'lib/onceover/beaker.rb'
-    - 'lib/onceover/deploy.rb'
-
-# Offense count: 3
-# This cop supports safe autocorrection (--autocorrect).
-Performance/StringReplacement:
-  Exclude:
-    - 'lib/onceover/cli/plugins.rb'
-    - 'lib/onceover/testconfig.rb'
+# Offense count: 15
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/CyclomaticComplexity:
+  Max: 31
 
-# Offense count: 1
-# Configuration parameters: Prefixes, AllowedPatterns.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/onceover/controlrepo_spec.rb'
+# Offense count: 51
+# Configuration parameters: CountComments, CountAsOne, AllowedMethods, AllowedPatterns.
+Metrics/MethodLength:
+  Max: 110
 
-# Offense count: 1
-# Configuration parameters: AssignmentOnly.
-RSpec/InstanceVariable:
-  Exclude:
-    - 'spec/onceover/controlrepo_spec.rb'
+# Offense count: 15
+# Configuration parameters: AllowedMethods, AllowedPatterns.
+Metrics/PerceivedComplexity:
+  Max: 33
 
-# Offense count: 2
-# This cop supports safe autocorrection (--autocorrect).
-Rake/Desc:
+# Offense count: 3
+# Configuration parameters: AllowedNames.
+# AllowedNames: module_parent
+Naming/ClassAndModuleCamelCase:
   Exclude:
-    - 'Rakefile'
+    - 'features/support/cache_helper.rb'
+    - 'features/support/command_helper.rb'
+    - 'features/support/controlrepo_helper.rb'
 
 # Offense count: 2
 Security/Eval:
@@ -341,7 +298,7 @@ Security/Open:
   Exclude:
     - 'features/support/controlrepo_helper.rb'
 
-# Offense count: 44
+# Offense count: 43
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: separated, grouped
@@ -443,7 +400,7 @@ Style/EmptyCaseCondition:
 
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: AutoCorrect, EnforcedStyle, AllowComments.
+# Configuration parameters: EnforcedStyle, AllowComments.
 # SupportedStyles: empty, nil, both
 Style/EmptyElse:
   Exclude:
@@ -487,17 +444,17 @@ Style/GuardClause:
     - 'lib/onceover/testconfig.rb'
 
 # Offense count: 1
-# This cop supports unsafe autocorrection (--autocorrect-all).
+# This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowSplatArgument.
 Style/HashConversion:
   Exclude:
     - 'features/support/cache_helper.rb'
 
-# Offense count: 40
+# Offense count: 42
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, EnforcedShorthandSyntax, UseHashRocketsWithSymbolValues, PreferHashRocketsForNonAlnumEndingSymbols.
 # SupportedStyles: ruby19, hash_rockets, no_mixed_keys, ruby19_no_mixed_keys
-# SupportedShorthandSyntax: always, never, either, consistent, either_consistent
+# SupportedShorthandSyntax: always, never, either, consistent
 Style/HashSyntax:
   Exclude:
     - 'lib/onceover/beaker.rb'
@@ -507,7 +464,9 @@ Style/HashSyntax:
     - 'lib/onceover/cli/show.rb'
     - 'lib/onceover/cli/update.rb'
     - 'lib/onceover/controlrepo.rb'
+    - 'lib/onceover/deploy.rb'
     - 'lib/onceover/logger.rb'
+    - 'lib/onceover/rake_tasks.rb'
 
 # Offense count: 4
 # This cop supports unsafe autocorrection (--autocorrect-all).
@@ -522,7 +481,7 @@ Style/IfInsideElse:
   Exclude:
     - 'lib/onceover/controlrepo.rb'
 
-# Offense count: 19
+# Offense count: 18
 # This cop supports safe autocorrection (--autocorrect).
 Style/IfUnlessModifier:
   Exclude:
@@ -551,14 +510,6 @@ Style/MixinUsage:
     - 'lib/onceover/controlrepo.rb'
     - 'lib/onceover/testconfig.rb'
 
-# Offense count: 3
-# This cop supports unsafe autocorrection (--autocorrect-all).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: literals, strict
-Style/MutableConstant:
-  Exclude:
-    - 'lib/onceover/rspec/formatters.rb'
-
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: AllowedMethods.
@@ -659,6 +610,12 @@ Style/RedundantPercentQ:
     - 'features/step_definitions/init.rb'
     - 'features/step_definitions/run.rb'
 
+# Offense count: 2
+# This cop supports safe autocorrection (--autocorrect).
+Style/RedundantRegexpCharacterClass:
+  Exclude:
+    - 'lib/onceover/controlrepo.rb'
+
 # Offense count: 2
 # This cop supports safe autocorrection (--autocorrect).
 Style/RedundantRegexpEscape:
@@ -755,7 +712,7 @@ Style/StringConcatenation:
     - 'lib/onceover/rspec/formatters.rb'
     - 'lib/onceover/runner.rb'
 
-# Offense count: 98
+# Offense count: 95
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
@@ -781,38 +738,30 @@ Style/SymbolProc:
 
 # Offense count: 4
 # This cop supports safe autocorrection (--autocorrect).
-# Configuration parameters: EnforcedStyle, AllowSafeAssignment.
-# SupportedStyles: require_parentheses, require_no_parentheses, require_parentheses_when_complex
-Style/TernaryParentheses:
+# Configuration parameters: EnforcedStyleForMultiline.
+# SupportedStylesForMultiline: comma, consistent_comma, no_comma
+Style/TrailingCommaInArguments:
   Exclude:
-    - 'lib/onceover/beaker/spec_helper.rb'
-    - 'lib/onceover/controlrepo.rb'
-    - 'lib/onceover/deploy.rb'
+    - 'lib/onceover/rspec/formatters.rb'
+    - 'lib/onceover/vendored_modules.rb'
 
-# Offense count: 13
+# Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
-Style/TrailingCommaInArguments:
+Style/TrailingCommaInArrayLiteral:
   Exclude:
-    - 'lib/onceover/controlrepo.rb'
-    - 'lib/onceover/logger.rb'
-    - 'lib/onceover/runner.rb'
-    - 'lib/onceover/testconfig.rb'
-    - 'spec/onceover/controlrepo_spec.rb'
+    - 'lib/onceover/deploy.rb'
 
-# Offense count: 10
+# Offense count: 7
 # This cop supports safe autocorrection (--autocorrect).
 # Configuration parameters: EnforcedStyleForMultiline.
 # SupportedStylesForMultiline: comma, consistent_comma, no_comma
 Style/TrailingCommaInHashLiteral:
   Exclude:
-    - 'features/support/cache_helper.rb'
-    - 'lib/onceover/controlrepo.rb'
-    - 'lib/onceover/logger.rb'
-    - 'lib/onceover/test.rb'
-    - 'lib/onceover/testconfig.rb'
-    - 'spec/onceover/controlrepo_spec.rb'
+    - 'lib/onceover/beaker.rb'
+    - 'lib/onceover/beaker/spec_helper.rb'
+    - 'lib/onceover/rspec/formatters.rb'
 
 # Offense count: 1
 # This cop supports safe autocorrection (--autocorrect).

data/CHANGELOG.md

@@ -1,8 +1,29 @@
 # Changelog
 
-## [4.0.0](https://github.com/voxpupuli/onceover/tree/4.0.0) (2024-11-21)
+## [v5.0.0](https://github.com/voxpupuli/onceover/tree/v5.0.0) (2025-06-27)
 
-[Full Changelog](https://github.com/voxpupuli/onceover/compare/v3.22.0...4.0.0)
+[Full Changelog](https://github.com/voxpupuli/onceover/compare/v4.0.0...v5.0.0)
+
+**Breaking changes:**
+
+- Update: switch to openvox gem, remove puppetlabs\_spec\_helper gem, update gem dependencies, require Ruby 3.2+ [\#354](https://github.com/voxpupuli/onceover/pull/354) ([rwaffen](https://github.com/rwaffen))
+
+**Implemented enhancements:**
+
+- Add ARM runner to CI [\#347](https://github.com/voxpupuli/onceover/pull/347) ([bastelfreak](https://github.com/bastelfreak))
+
+**Closed issues:**
+
+- be more clear where/how to generate factssets [\#351](https://github.com/voxpupuli/onceover/issues/351)
+
+**Merged pull requests:**
+
+- docs: add info about trusted facts/data to README.md of factsets dir [\#352](https://github.com/voxpupuli/onceover/pull/352) ([rwaffen](https://github.com/rwaffen))
+- Fix example on how to pull facts from puppetdb [\#345](https://github.com/voxpupuli/onceover/pull/345) ([tuxmea](https://github.com/tuxmea))
+
+## [v4.0.0](https://github.com/voxpupuli/onceover/tree/v4.0.0) (2024-11-21)
+
+[Full Changelog](https://github.com/voxpupuli/onceover/compare/v3.22.0...v4.0.0)
 
 **Breaking changes:**
 
@@ -993,15 +1014,15 @@
 
 ## [v2.0.1](https://github.com/voxpupuli/onceover/tree/v2.0.1) (2015-11-16)
 
-[Full Changelog](https://github.com/voxpupuli/onceover/compare/2.0.0...v2.0.1)
+[Full Changelog](https://github.com/voxpupuli/onceover/compare/v2.0.0...v2.0.1)
 
-## [2.0.0](https://github.com/voxpupuli/onceover/tree/2.0.0) (2015-11-11)
+## [v2.0.0](https://github.com/voxpupuli/onceover/tree/v2.0.0) (2015-11-11)
 
-[Full Changelog](https://github.com/voxpupuli/onceover/compare/v2.0.0...2.0.0)
+[Full Changelog](https://github.com/voxpupuli/onceover/compare/2.0.0...v2.0.0)
 
-## [v2.0.0](https://github.com/voxpupuli/onceover/tree/v2.0.0) (2015-11-11)
+## [2.0.0](https://github.com/voxpupuli/onceover/tree/2.0.0) (2015-11-11)
 
-[Full Changelog](https://github.com/voxpupuli/onceover/compare/1.1.1...v2.0.0)
+[Full Changelog](https://github.com/voxpupuli/onceover/compare/1.1.1...2.0.0)
 
 ## [1.1.1](https://github.com/voxpupuli/onceover/tree/1.1.1) (2015-11-10)
 

data/Gemfile

@@ -4,9 +4,7 @@ gemspec
 
 gem 'pry-coolline', '> 0.0', '< 1.0.0'
 
-if ENV['PUPPET_VERSION']
-  gem 'puppet', ENV['PUPPET_VERSION']
-end
+gem 'openvox', ENV['PUPPET_VERSION'] || '~> 8'
 
 group :test do
   # Required for the final controlrepo tests

data/README.md

@@ -338,7 +338,7 @@ puppet facts > fact_set_name.json
 
 Its recommended to run this on each of the types of nodes that you run in your infrastructure to have good coverage.
 
-If you are using [Trusted Facts](#trusted-facts) or [Trusted External Data](#trusted-external-data) and can use the [PE client tools](https://puppet.com/docs/pe/latest/installing_pe_client_tools.html) you can generate a factset which contains this information by running:
+If you are using [Trusted Facts](#trusted-facts) or [Trusted External Data](#trusted-external-data) run the following on a primary, compiler or host with the [PE client tools](https://puppet.com/docs/pe/latest/installing_pe_client_tools.html):
 
 ```shell
 puppet facts --terminus puppetdb > fact_set_name.json
@@ -347,7 +347,7 @@ puppet facts --terminus puppetdb > fact_set_name.json
 or
 
 ```shell
-puppet facts --terminus puppetdb <node certname> > fact_set_name.json
+puppet facts find <node certname> --terminus puppetdb > fact_set_name.json
 ```
 
 Factsets are named based on their filename, i.e. `myfactset` in `onceover.yaml` refers `spec/factsets/myfactset.json`

data/Rakefile

@@ -2,6 +2,7 @@ require 'rubygems/tasks'
 require 'rspec/core/rake_task'
 require 'cucumber/rake/task'
 require 'puppet/version'
+require 'voxpupuli/test/rake'
 Gem::Tasks.new
 
 def windows?
@@ -63,9 +64,9 @@ task :fixtures do
 end
 
 begin
-  require 'voxpupuli/rubocop/rake'
+  require 'voxpupuli/test/rake'
 rescue LoadError
-  # the voxpupuli-rubocop gem is optional
+  # the voxpupuli-test gem is optional
 end
 
 begin
@@ -79,6 +80,8 @@ else
     config.user = 'voxpupuli'
     config.project = 'onceover'
     gem_version = Gem::Specification.load("#{config.project}.gemspec").version
-    config.future_release = gem_version
+    config.future_release = "v#{gem_version}"
   end
 end
+
+PuppetSyntax.exclude_paths = ['vendor/**/*', 'templates/**/*', 'spec/fixtures/**/*']

data/features/zzz_run.feature

@@ -69,7 +69,7 @@ Feature: Run rspec and acceptance test suites
   Scenario: Running tests that fail to compile
     Given control repo "function_mocking"
     When I run onceover command "run spec" with class "role::fail"
-    Then I should see message pattern "failed"
+    Then I should see message pattern "Syntax error at 'is'"
     And Onceover should exit 1
 
   Scenario: Run with a custom Puppetfile

data/lib/onceover/rake_tasks.rb

@@ -1,5 +1,6 @@
 require 'onceover/controlrepo'
 require 'pathname'
+require 'voxpupuli/test/rake'
 
 @repo   = nil
 @config = nil

data/lib/onceover/rspec/formatters.rb

@@ -1,5 +1,7 @@
 require 'rspec'
+require 'rspec-puppet'
 require 'pathname'
+require 'English'
 
 class OnceoverFormatter
   RSpec::Core::Formatters.register(
@@ -279,7 +281,7 @@ class OnceoverFormatterParallel < OnceoverFormatter
       # Read all files and merge them
       errs.merge(YAML.load_file(file)) {|key, oldval, newval| [oldval, newval].flatten }
     end
-  
+
     # Delete files from the disk
     files.each { |f| File.delete(f) }
 

data/lib/onceover/runner.rb

@@ -92,8 +92,8 @@ class Onceover
           result = run_command(@command_prefix.strip.split, 'rake', 'parallel_spec')
         else
           require 'io/console'
-          logger.debug "Running #{@command_prefix}rake spec_standalone from #{@repo.tempdir}"
-          result = run_command(@command_prefix.strip.split, 'rake', 'spec_standalone')
+          logger.debug "Running #{@command_prefix}rake spec:standalone from #{@repo.tempdir}"
+          result = run_command(@command_prefix.strip.split, 'rake', 'spec:standalone')
         end
 
         # Reset env to previous state if we modified it
@@ -118,7 +118,7 @@ class Onceover
 
       Dir.chdir(@repo.tempdir) do
         #`bundle install --binstubs`
-        #`bin/rake spec_standalone`
+        #`bin/rake spec:standalone`
         logger.debug "Running #{@command_prefix}rake acceptance from #{@repo.tempdir}"
         result = run_command(@command_prefix.strip.split, 'rake', 'acceptance')
       end

data/lib/onceover/vendored_modules.rb

@@ -49,7 +49,7 @@ class Onceover
       # Get the entire file tree of the puppetlabs/puppet-agent repository
       # https://docs.github.com/en/rest/git/trees?apiVersion=2022-11-28#get-a-tree
       puppet_agent_tree = query_or_cache(
-        "https://api.github.com/repos/puppetlabs/puppet-agent/git/trees/#{@puppet_version}",
+        "https://api.github.com/repos/OpenVoxProject/openvox-agent/git/trees/#{@puppet_version}",
         { recursive: true },
         component_cache('repo_tree'),
       )

data/onceover.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift File.expand_path('lib', __dir__)
 
 Gem::Specification.new do |s| # rubocop:disable Gemspec/RequireMFA
   s.name        = "onceover"
-  s.version     = "4.0.0"
+  s.version     = "5.0.0"
   s.authors     = ["Dylan Ratcliffe", 'Vox Pupuli']
   s.email       = ["voxpupuli@groups.io"]
   s.homepage    = "https://github.com/voxpupuli/onceover"
@@ -17,25 +17,24 @@ Gem::Specification.new do |s| # rubocop:disable Gemspec/RequireMFA
   s.bindir       = 'bin'
   s.executables  = 'onceover'
 
-  s.required_ruby_version = Gem::Requirement.new('>= 2.7')
+  s.required_ruby_version = Gem::Requirement.new('>= 3.2')
 
   # Runtime dependencies, but also probably dependencies of requiring projects
-  s.add_dependency 'backticks', '>= 1.0.2'
-  s.add_dependency 'colored', '>= 1.2'
-  s.add_dependency 'cri', '>= 2.6'
-  s.add_dependency 'deep_merge', '>= 1.0.0'
-  s.add_dependency 'git'
-  s.add_dependency 'logging', '>= 2.0.0'
-  s.add_dependency 'multi_json', '>= 1.10'
-  s.add_dependency 'parallel_tests', ">= 2.0.0"
-  s.add_dependency 'puppet', '>=4.0'
-  s.add_dependency 'puppetlabs_spec_helper', ">= 0.4.0"
-  s.add_dependency 'r10k', '>=2.1.0'
-  s.add_dependency 'rake', '>= 10.0.0'
-  s.add_dependency 'rspec', '>= 3.0.0'
-  s.add_dependency 'rspec_junit_formatter', '>= 0.2.0'
-  s.add_dependency 'rspec-puppet', ">= 2.4.0"
-  s.add_dependency 'terminal-table', '>= 1.8.0'
-  s.add_dependency 'versionomy', '>= 0.5.0'
-  s.add_development_dependency 'voxpupuli-rubocop', '~> 3.0.0'
+  s.add_dependency 'backticks', '~> 1.0'
+  s.add_dependency 'colored', '~> 1.2'
+  s.add_dependency 'cri', '~> 2.6'
+  s.add_dependency 'deep_merge', '~> 1.0'
+  s.add_dependency 'git', '~> 3.1'
+  s.add_dependency 'logging', '~> 2.0'
+  s.add_dependency 'multi_json', '~> 1.10'
+  s.add_dependency 'openvox', '~> 8.0'
+  s.add_dependency 'parallel_tests', '~> 5.3'
+  s.add_dependency 'r10k', '~> 5.0'
+  s.add_dependency 'rake', '~> 13.3'
+  s.add_dependency 'rspec', '~> 3.0'
+  s.add_dependency 'rspec_junit_formatter', '~> 0.6'
+  s.add_dependency 'rspec-puppet', '~> 5.0'
+  s.add_dependency 'terminal-table', '~> 4.0'
+  s.add_dependency 'versionomy', '~> 0.5'
+  s.add_dependency 'voxpupuli-test', '~> 11.0'
 end

data/spec/fixtures/controlrepos/puppet_controlrepo/Gemfile

@@ -16,7 +16,7 @@ else
 end
 
 gem 'hiera-eyaml'
-gem 'puppet', ENV['PUPPET_version'] || '~> 8'
+gem 'openvox', ENV['PUPPET_version'] || '~> 8'
 
 # Require by telegraf module
 gem 'toml-rb'

data/spec/fixtures/controlrepos/puppet_controlrepo/Rakefile

@@ -1,4 +1,4 @@
-require 'puppetlabs_spec_helper/rake_tasks'
+require 'voxpupuli/test/rake'
 
 #desc "Run acceptance tests"
 #RSpec::Core::RakeTask.new(:acceptance) do |t|

data/templates/factsets_README.md.erb

@@ -1,7 +1,10 @@
 # Factsets
 
-This directory is where we put any custom factsets that we want to use. They can be generated by running `puppet facts` on the target system.
+This directory is where we put any custom factsets that we want to use.
+They can be generated by running `puppet facts` on the target system.
+
+If you are using Trusted Facts or Trusted External Data see: <https://github.com/voxpupuli/onceover#factsets>
 
 **Hot tip:** If you already have factsets in here when you run `onceover init` they will be picked up and added to the config file Automatically
 
-More info: https://github.com/voxpupuli/onceover#factsets
+More info: <https://github.com/voxpupuli/onceover#factsets>

data/templates/spec_helper.rb.erb

@@ -2,7 +2,6 @@ RSpec.configure do |c|
   c.mock_with :rspec
 end
 
-require 'puppetlabs_spec_helper/module_spec_helper'
 require 'rspec_junit_formatter'
 require 'onceover/rspec/formatters'
 

data/templates/testconfig_Rakefile.erb

@@ -1,6 +1,6 @@
-require 'puppetlabs_spec_helper/rake_tasks'
+require 'voxpupuli/test/rake'
 
 desc "Run acceptance tests"
 RSpec::Core::RakeTask.new(:acceptance) do |t|
   t.pattern = 'spec/acceptance'
-end
+end

metadata

@@ -1,268 +1,253 @@
 --- !ruby/object:Gem::Specification
 name: onceover
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Dylan Ratcliffe
 - Vox Pupuli
-autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-11-21 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backticks
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.2
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: colored
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.2'
 - !ruby/object:Gem::Dependency
   name: cri
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.6'
 - !ruby/object:Gem::Dependency
   name: deep_merge
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: '1.0'
 - !ruby/object:Gem::Dependency
   name: git
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.1'
 - !ruby/object:Gem::Dependency
   name: logging
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '2.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.0.0
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.10'
 - !ruby/object:Gem::Dependency
-  name: parallel_tests
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: 2.0.0
-- !ruby/object:Gem::Dependency
-  name: puppet
+  name: openvox
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
-  name: puppetlabs_spec_helper
+  name: parallel_tests
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: '5.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.4.0
+        version: '5.3'
 - !ruby/object:Gem::Dependency
   name: r10k
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.1.0
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.0.0
+        version: '13.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 10.0.0
+        version: '13.3'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '3.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rspec_junit_formatter
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.2.0
+        version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rspec-puppet
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.0
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: terminal-table
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: '4.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 1.8.0
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: versionomy
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.5.0
+        version: '0.5'
 - !ruby/object:Gem::Dependency
-  name: voxpupuli-rubocop
+  name: voxpupuli-test
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
-  type: :development
+        version: '11.0'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 3.0.0
+        version: '11.0'
 description: Automatically generates tests for your Puppet code
 email:
 - voxpupuli@groups.io
@@ -592,7 +577,6 @@ homepage: https://github.com/voxpupuli/onceover
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -600,15 +584,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.7'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key: 
+rubygems_version: 3.6.7
 specification_version: 4
 summary: Testing tools for Puppet controlrepos
 test_files: []