onceover 3.20.0 → 3.22.0

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/factsets/Windows_Server-2012r2-64.json

@@ -0,0 +1,165 @@
+{
+  "name": "win-e5k8tm30719",
+  "values": {
+    "choco_install_path": "C:\\choco",
+    "agent_specified_environment": "production",
+    "architecture": "x64",
+    "dhcp_servers": {
+      "Ethernet": "10.0.2.2",
+      "system": "10.0.2.2"
+    },
+    "dmi": {
+      "manufacturer": "innotek GmbH",
+      "product": {
+        "name": "VirtualBox",
+        "serial_number": "0"
+      }
+    },
+    "env_windows_installdir": "C:\\Program Files\\Puppet Labs\\Puppet",
+    "facterversion": "3.1.1",
+    "fqdn": "WIN-E5K8TM30719",
+    "hardwareisa": "x64",
+    "hardwaremodel": "x86_64",
+    "hostname": "WIN-E5K8TM30719",
+    "id": "WIN-E5K8TM30719\\vagrant",
+    "identity": {
+      "user": "WIN-E5K8TM30719\\vagrant"
+    },
+    "interfaces": "Ethernet",
+    "ipaddress": "10.0.2.15",
+    "ipaddress6": "fe80::a180:36e0:3a6e:1005%12",
+    "ipaddress6_Ethernet": "fe80::a180:36e0:3a6e:1005%12",
+    "ipaddress_Ethernet": "10.0.2.15",
+    "is_virtual": true,
+    "kernel": "windows",
+    "kernelmajversion": "6.3",
+    "kernelrelease": "6.3.9600",
+    "kernelversion": "6.3.9600",
+    "macaddress": "08:00:27:81:38:FA",
+    "macaddress_Ethernet": "08:00:27:81:38:FA",
+    "manufacturer": "innotek GmbH",
+    "memory": {
+      "system": {
+        "available": "1.42 GiB",
+        "available_bytes": 1521610752,
+        "capacity": "29.13%",
+        "total": "2.00 GiB",
+        "total_bytes": 2147012608,
+        "used": "596.43 MiB",
+        "used_bytes": 625401856
+      }
+    },
+    "memoryfree": "1.42 GiB",
+    "memoryfree_mb": 1451.12109375,
+    "memorysize": "2.00 GiB",
+    "memorysize_mb": 2047.55078125,
+    "mtu_Ethernet": 1500,
+    "netmask": "255.255.255.0",
+    "netmask6": "ffff:ffff:ffff:ffff::",
+    "netmask6_Ethernet": "ffff:ffff:ffff:ffff::",
+    "netmask_Ethernet": "255.255.255.0",
+    "network": "10.0.2.0",
+    "network6": "fe80::%12",
+    "network6_Ethernet": "fe80::%12",
+    "network_Ethernet": "10.0.2.0",
+    "networking": {
+      "dhcp": "10.0.2.2",
+      "fqdn": "WIN-E5K8TM30719",
+      "hostname": "WIN-E5K8TM30719",
+      "interfaces": {
+        "Ethernet": {
+          "bindings": [
+            {
+              "address": "10.0.2.15",
+              "netmask": "255.255.255.0",
+              "network": "10.0.2.0"
+            }
+          ],
+          "bindings6": [
+            {
+              "address": "fe80::a180:36e0:3a6e:1005%12",
+              "netmask": "ffff:ffff:ffff:ffff::",
+              "network": "fe80::%12"
+            }
+          ],
+          "dhcp": "10.0.2.2",
+          "ip": "10.0.2.15",
+          "ip6": "fe80::a180:36e0:3a6e:1005%12",
+          "mac": "08:00:27:81:38:FA",
+          "mtu": 1500,
+          "netmask": "255.255.255.0",
+          "netmask6": "ffff:ffff:ffff:ffff::",
+          "network": "10.0.2.0",
+          "network6": "fe80::%12"
+        }
+      },
+      "ip": "10.0.2.15",
+      "ip6": "fe80::a180:36e0:3a6e:1005%12",
+      "mac": "08:00:27:81:38:FA",
+      "mtu": 1500,
+      "netmask": "255.255.255.0",
+      "netmask6": "ffff:ffff:ffff:ffff::",
+      "network": "10.0.2.0",
+      "network6": "fe80::%12",
+      "primary": "Ethernet"
+    },
+    "operatingsystem": "windows",
+    "operatingsystemmajrelease": "2012 R2",
+    "operatingsystemrelease": "2012 R2",
+    "os": {
+      "architecture": "x64",
+      "family": "windows",
+      "hardware": "x86_64",
+      "name": "windows",
+      "release": {
+        "full": "2012 R2",
+        "major": "2012 R2"
+      },
+      "windows": {
+        "system32": "C:\\Windows\\system32"
+      }
+    },
+    "osfamily": "windows",
+    "path": "C:/Program Files/Puppet Labs/Puppet/facter/bin;C:\\Program Files\\Puppet Labs\\Puppet\\puppet\\bin;C:\\Program Files\\Puppet Labs\\Puppet\\facter\\bin;C:\\Program Files\\Puppet Labs\\Puppet\\hiera\\bin;C:\\Program Files\\Puppet Labs\\Puppet\\mcollective\\bin;C:\\Program Files\\Puppet Labs\\Puppet\\bin;C:\\Program Files\\Puppet Labs\\Puppet\\sys\\ruby\\bin;C:\\Program Files\\Puppet Labs\\Puppet\\sys\\tools\\bin;C:\\Windows\\system32;C:\\Windows;C:\\Windows\\System32\\Wbem;C:\\Windows\\System32\\WindowsPowerShell\\v1.0\\;C:\\Program Files (x86)\\Git\\cmd;C:\\Program Files (x86)\\Git\\bin;C:\\Program Files\\Puppet Labs\\Puppet\\bin",
+    "physicalprocessorcount": 1,
+    "processor0": "Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz",
+    "processorcount": 1,
+    "processors": {
+      "count": 1,
+      "isa": "x64",
+      "models": [
+        "Intel(R) Core(TM) i7-4850HQ CPU @ 2.30GHz"
+      ],
+      "physicalcount": 1
+    },
+    "productname": "VirtualBox",
+    "puppetversion": "4.2.3",
+    "ruby": {
+      "platform": "x64-mingw32",
+      "sitedir": "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/site_ruby/2.1.0",
+      "version": "2.1.7"
+    },
+    "rubyplatform": "x64-mingw32",
+    "rubysitedir": "C:/Program Files/Puppet Labs/Puppet/sys/ruby/lib/ruby/site_ruby/2.1.0",
+    "rubyversion": "2.1.7",
+    "serialnumber": "0",
+    "system32": "C:\\Windows\\system32",
+    "system_uptime": {
+      "days": 0,
+      "hours": 0,
+      "seconds": 287,
+      "uptime": "0:04 hours"
+    },
+    "timezone": "Coordinated Universal Time",
+    "uptime": "0:04 hours",
+    "uptime_days": 0,
+    "uptime_hours": 0,
+    "uptime_seconds": 287,
+    "virtual": "virtualbox",
+    "clientcert": "win-e5k8tm30719",
+    "clientversion": "4.2.3",
+    "clientnoop": false
+  },
+  "timestamp": "2015-11-19T01:47:05.215450000+00:00",
+  "expiration": "2015-11-19T02:17:05.215450000+00:00"
+}

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/hiera.yaml

@@ -0,0 +1,18 @@
+---
+version: 5
+defaults:  # Used for any hierarchy level that omits these keys.
+  data_hash: yaml_data
+  datadir: ../data
+
+hierarchy:
+  - name: "Per-node data"                   # Human-readable name.
+    path: "nodes/%{trusted.certname}.yaml"  # File path, relative to datadir.
+                                   # ^^^ IMPORTANT: include the file extension!
+  - name: "Per-Environment"
+    path: "environments/%{agent_specified_environment}.yaml"
+
+  - name: "Per-Datacenter"
+    path: "datacenter/%{datacenter}.yaml"
+
+  - name: "Common Data"
+    path: "common.yaml"

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/matchers/file_matchers.rb

@@ -0,0 +1,16 @@
+RSpec::Matchers.define :satisfy_file_resource_requirements do
+  match do |catalog|
+    @missing_param = catalogue.resources.map do |resource|
+      next if !(resource.type == 'File')
+        if resource[:mode]
+          if resource[:mode] =~ /777|\d.*7$/
+            "Found use of unsafe file mode for file #{resource}, mode: #{resource[:mode]}"
+          end
+        end
+      end.compact
+      @missing_param.empty?
+    end
+  failure_message do |str|
+    @missing_param.join("\n")
+  end
+end

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/onceover.yaml

@@ -0,0 +1,54 @@
+classes:
+  - "/role::/"
+
+nodes:
+  - CentOS-7.0-64
+  - CentOS-7.0-64-master
+  - CentOS-7.0-64-openstack
+  - Windows_Server-2008r2-64
+  - Windows_Server-2012r2-64
+
+node_groups:
+  centos:
+    - CentOS-7.0-64
+    - CentOS-7.0-64-master
+  windows:
+    - Windows_Server-2008r2-64
+    - Windows_Server-2012r2-64
+  master:
+    - CentOS-7.0-64-master
+
+class_groups:
+  master_classes:
+    - "role::compile::balancer"
+    - "role::compile::master"
+  windows_classes:
+    - /windows/
+  linux_classes:
+    include: "all_classes"
+    exclude: "windows_classes"
+
+test_matrix:
+  # Main spec tests for all CentOS roles
+  - centos:
+      classes:
+        include: "linux_classes"
+        exclude: "master_classes"
+      tests: "spec"
+  # Master based spec tests
+  - master:
+      classes: "master_classes"
+      tests: "spec"
+      tags: "master"
+
+functions:
+  puppetdb_query:
+    returns: []
+  pe_compiling_server_version:
+    returns: "2019.2.1"
+  pe_build_version:
+    returns: "2019.2.1"
+  pe_empty:
+    returns: false
+  pe_join:
+    returns: ""

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/pre_conditions/site.pp

@@ -0,0 +1,150 @@
+# We are not going to actually have this service anywhere on our servers but
+# our code needs to refresh it. This is to trck puppet into doing nothing
+
+# $servername = 'somemaster.puppetlabs.com' # Workaround for the lack of a master
+$choco_install_path = 'C:\\foo'
+$chocolateyversion = '0.10.10'
+unless $concat_basedir {
+  $concat_basedir = '/opt/puppetlabs/puppet/share/concat' # Workaround for lack of concat facts
+}
+service { 'pe-puppetserver':
+  ensure     => 'running',
+  enable     => false,
+  hasrestart => false, # Force Puppet to use start and stop to restart
+  start      => 'echo "Start"', # This will always work
+  stop       => 'echo "Stop"', # This will also always work
+  hasstatus  => false, # Force puppet to use our command for status
+  status     => 'echo "Status"', # This will always exit 0 and therefor Puppet will think the service is running
+  provider   => 'base',
+}
+
+service { 'pe-console-services':
+  ensure     => 'running',
+  enable     => true,
+}
+
+package { 'pe-puppetserver':
+  ensure => present,
+}
+
+user { 'puppet':
+  ensure => present,
+}
+
+group { 'puppet':
+  ensure => present,
+}
+
+$gnupg_installed = true
+
+class puppet_enterprise (
+  $puppet_master_host = 'puppet-server',
+) {}
+include puppet_enterprise
+class puppet_enterprise::params (
+  $localcacert = '',
+) {}
+include puppet_enterprise::params
+class pe_repo::platform::windows_i386 {}
+class pe_repo::platform::windows_x86_64 {}
+class pe_repo::platform::el_6_x86_64 {}
+define puppet_enterprise::trapperkeeper::pe_service () {}
+define puppet_enterprise::trapperkeeper::bootstrap_cfg ($namespace, $container) { }
+class puppet_enterprise::master::file_sync (
+  $puppet_master_host,
+  $master_of_masters_certname,
+  $localcacert,
+  $puppetserver_jruby_puppet_master_code_dir,
+  $puppetserver_webserver_ssl_port,
+  $storage_service_disabled,
+) {}
+define pe_hocon_setting ($path, $value, $setting, $type = '') {}
+define puppet_enterprise::trapperkeeper::java_args ($java_args, $enable_gc_logging) {}
+define puppet_enterprise::trapperkeeper::webserver_settings ($container,$ssl_listen_address,$ssl_listen_port,$default_server = false) {}
+class pe_postgresql::globals (
+  $user                 = undef,
+  $group                = undef,
+  $client_package_name  = undef,
+  $contrib_package_name = undef,
+  $server_package_name  = undef,
+  $service_name         = undef,
+  $default_database     = undef,
+  $version              = undef,
+  $bindir               = undef,
+  $datadir              = undef,
+  $confdir              = undef,
+  $psql_path            = undef,
+  $needs_initdb         = undef,
+  $pg_hba_conf_defaults = undef,
+) {}
+class pe_postgresql::server (
+  $listen_addresses        = undef,
+  $ip_mask_allow_all_users = undef,
+  $package_ensure          = undef,
+) {}
+class pe_postgresql::server::contrib (
+  $package_ensure = undef,
+) {}
+class pe_postgresql::client (
+    $package_ensure = undef,
+) {}
+define pe_postgresql::server::database (
+  $owner = undef,
+) {}
+define pe_postgresql::server::tablespace (
+  $location = undef,
+) {}
+define pe_postgresql::server::db (
+  $user       = undef,
+  $password   = undef,
+  $tablespace = undef,
+) {}
+define pe_concat (
+  $owner          = undef,
+  $group          = undef,
+  $force          = undef,
+  $mode           = undef,
+  $warn           = undef,
+  $ensure_newline = undef,
+) {}
+define pe_postgresql::server::pg_hba_rule (
+  $database    = undef,
+  $user        = undef,
+  $type        = undef,
+  $auth_method = undef,
+  $order       = undef,
+) {}
+define pe_postgresql::server::config_entry (
+  $value = undef,
+) {}
+define puppet_enterprise::pg::cert_whitelist_entry (
+  $user                          = undef,
+  $database                      = undef,
+  $allowed_client_certname       = undef,
+  $pg_ident_conf_path            = undef,
+  $ip_mask_allow_all_users_ssl   = undef,
+  $ipv6_mask_allow_all_users_ssl = undef,
+) {}
+class pe_postgresql::server::install {}
+include pe_postgresql::server::install
+class pe_postgresql::server::initdb {}
+include pe_postgresql::server::initdb
+class pe_postgresql::server::reload {}
+include pe_postgresql::server::reload
+if $onceover_class == 'role::cd4pe' {
+  package { 'postgresql-server': }
+}
+
+define pe_puppet_authorization::rule (
+  $path                  = undef,
+  $match_request_path    = undef,
+  $match_request_type    = undef,
+  $match_request_method  = undef,
+  $allow                 = undef,
+  $allow_unauthenticated = undef,
+  $sort_order            = undef,
+) {}
+
+function pe_union  ($param, $param2) { [$param, $param2] }
+function pe_sort   ($param)          { [1,2,3] }
+function pe_unique ($param)          { [1,2,3] }

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/r10k.yaml

@@ -0,0 +1,2 @@
+---
+pool_size: 20

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/shared_examples/helper.rb

@@ -0,0 +1,91 @@
+require 'spec_helper'
+
+shared_examples_for 'test_linux' do |fact_set|
+
+  describe "SOE Checks" do
+
+    it do
+      is_expected.to contain_package('tree').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('vim').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('git').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('htop').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('zlib').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('zlib-devel').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('jq').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('ruby').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('ruby-devel').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('multitail').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('haveged').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('cmake').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('tmux').with(
+        'ensure'  => 'latest',
+      )
+    end
+
+    it do
+      is_expected.to contain_package('unzip').with(
+        'ensure'  => 'latest',
+      )
+    end
+  end
+end

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/unit/00_parse_spec.rb

@@ -0,0 +1,76 @@
+#
+# This set of tests is for syntax validation, It runs through all of the
+# Puppet, Ruby and ERB code in the repositories and validates it with it's
+# relevant validator.
+#
+# If we want to change the scope of these tests the following variables can be
+# modified to change which files are in scope:
+#   - puppet_search_path
+#   - ruby_search_path
+#   - erb_search_path
+#   - epp_search_path
+#
+# All paths are relative the the .onceover temporary directory which is created
+# as part of a normal Onceover run
+require 'puppet'
+
+# Tell Puppet where to find our code. This is relative to the .onceover directory
+Puppet.initialize_settings(['--codedir ./etc/puppetlabs/code'])
+
+# Create a Puppet environment that we can interact with
+env = Puppet.lookup(:current_environment)
+loaders = Puppet::Pops::Loaders.new(env)
+
+# Where to search fort files to syntax validate
+puppet_search_path = './etc/puppetlabs/code/environments/production/site-modules/*/{manifests,functions,types}/**/*.pp'
+ruby_search_path   = './etc/puppetlabs/code/environments/production/site-modules/*/lib/**/*.rb'
+erb_search_path    = './etc/puppetlabs/code/environments/production/site-modules/**/*.erb'
+epp_search_path    = './etc/puppetlabs/code/environments/production/site-modules/**/*.epp'
+
+describe "When checking Puppet syntax", syntax: true do
+  Dir[puppet_search_path].each do |manifest|
+    context manifest do
+      it "should be valid Puppet syntax" do
+        Puppet.override({ :loaders => loaders }, 'For Puppet parser validate') do
+          validation_environment = env.override_with(:manifest => manifest)
+          expect(validation_environment.check_for_reparse).to be_nil
+          expect(validation_environment.known_resource_types.clear).to match_array []
+        end
+      end
+    end
+  end
+end
+
+describe "When checking Ruby syntax", syntax: true do
+  Dir[ruby_search_path].each do |ruby_file|
+    context ruby_file do
+      it "should be valid Ruby syntax" do
+        expect(`ruby -c #{ruby_file}`).to match(/Syntax OK/) unless ruby_file =~ /spec\/fixtures/
+      end
+    end
+  end
+end
+
+describe "When checking ERB syntax", syntax: true do
+  Dir[erb_search_path].each do |template|
+    context template do
+      it "should be valid ERB syntax" do
+        expect(`erb -P -x -T '-' #{template} | ruby -c`).to match(/Syntax OK/)
+      end
+    end
+  end
+end
+
+describe "When checking EPP syntax", syntax: true do
+  before(:all) do
+    @parser = Puppet::Pops::Parser::EvaluatingParser::EvaluatingEppParser.new()
+  end
+
+  Dir[epp_search_path].each do |template|
+    context template do
+      it "should be valid EPP syntax" do
+        expect{@parser.parse_file(template)}.not_to raise_error
+      end
+    end
+  end
+end

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/unit/01_linting_spec_example.rb

@@ -0,0 +1,69 @@
+#
+# The following set of tests is designed to enforce style in the Puppet code.
+# This may be coming from the Puppet style guide as in the puppet-lint tests
+# or may be arbitrarily defined. Anything that relates to how the
+# code is written should go in this file
+#
+require 'puppet-lint'
+
+# Create a single linter object to save time
+linter = PuppetLint.new
+
+# --- Begin Settings ---
+#
+manifest_search_path = './etc/puppetlabs/code/environments/production/site/*/manifests/**/*.pp'
+
+# Options passed to puppet-lint
+# See http://puppet-lint.com/checks/
+linter.configuration.ignore_paths = ["spec/**/*.pp", "pkg/**/*.pp"]
+# I would like to enable this soon
+linter.configuration.send('disable_documentation')
+# We just don't care about this stuff
+linter.configuration.send('disable_80chars')
+linter.configuration.send('disable_140chars')
+# linter.configuration.send('disable_names_containing_uppercase')
+#linter.configuration.send('disable_double_quoted_strings')
+#linter.configuration.send('disable_variable_scope')
+#linter.configuration.send('disable_slash_comments')
+#linter.configuration.send('disable_autoloader_layout')
+#linter.configuration.send('disable_star_comments')
+#linter.configuration.send('disable_variables_not_enclosed')
+#linter.configuration.send('disable_arrow_alignment')
+#linter.configuration.send('disable_trailing_whitespace')
+# At the moment this is broken, identifying local variables
+# in iterations as top level. Can surround the code block
+# with the following comments:
+# lint:ignore:variable_scope
+# lint:endignore
+
+# Set up the Linter error message, this is not normally required but
+# in this instance it was cutting off useful information so we are
+# creating a custom error message/
+def format_error(problems)
+  problems.map do |problem|
+    problem.keep_if do |k,v|
+      [:message,:line,:column,:check].include?(k)
+    end
+  end.to_yaml
+end
+
+
+# --- End Settings ---
+require 'yaml'
+
+describe "When checking Puppet Style" do
+  Dir[manifest_search_path].each do |manifest|
+    context manifest do
+      it "should follow the style guide" do
+        linter.file = manifest
+        expect(linter.run).to be nil
+
+	      # Get all of the problems that were not ignored
+        problems = linter.problems.reject {|r| r[:kind] == :ignored }
+
+        # Expect there to be no problems, but also format the errors nicely
+        expect(problems).to match_array([]), format_error(problems)
+      end
+    end
+  end
+end

data/spec/fixtures/controlrepos/puppet_controlrepo/spec/unit/03_puppetfile_spec_example.rb

@@ -0,0 +1,35 @@
+#
+# This set of tests ensures that the Puppetfile has been written correctly
+# Anything relating to the syntax or content of the Puppetfile should be
+# in this file
+#
+require 'r10k/puppetfile'
+
+describe "The Puppetfile" do
+  # Load in the Puppetfile using the r10k gem
+  # This handles all of the parsing for us so that we don't need to write
+  # complicated regular expressions or anything like that.
+  @puppetfile = R10K::Puppetfile.new('./etc/puppetlabs/code/environments/production')
+  @puppetfile.load!
+
+  @puppetfile.modules.each do |current_module|
+    describe current_module.name do
+      #require 'pry'
+      #binding.pry
+      it "should be pinned to a version" do
+        if current_module.is_a? R10K::Module::Git
+          # It should be pinned to a version or commit
+          semver_regex = /^v?\d+\.?\d*\.*\w*$/
+          commit_regex = /^[0-9a-f]{7,40}$/
+          expect(current_module.version).to match Regexp.union(semver_regex,commit_regex)
+        else
+          # If it's a forge module it should not be pinned to latest
+          expect(current_module.instance_variable_get('@args')).not_to eq(:latest)
+          # It should also not have blank args
+          expect(current_module.instance_variable_get('@args')).not_to eq(nil)
+        end
+      end
+    end
+  end
+
+end