onceover 3.16.0 → 3.18.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 57310f1e8ec36d6e3351a76138baf7c0e548cf76a78de52accf4f0a19af89bb8
-  data.tar.gz: 69038c881071e8a0f3db773363b06e2f0fd99b9b62f7eb8b9311eed547a45bd7
+  metadata.gz: 994971aad52879b6500defdb15dd34f2959d1ec86112712e3fb9c02f1b25ff27
+  data.tar.gz: 9de0f213683ad7c635f6bde6e233de5c0b7a5a52e9947f8ccf7ae8fdb78b3819
 SHA512:
-  metadata.gz: c9565bd5f7002ff26528dd080cb1c5de2ea7a7c2579a80036bde8764a7be92351e8006ccf6e97e44e97e57936d48628bc67d4e5e2515b49d1733f062bccfc2c0
-  data.tar.gz: 4042c79024be1863c725e97a88e7812320a3aa5a010e2cea47cc687e59397c1cdac384722c9f4832d79c101fb3b0fff4f0a64e4193ada4a0cfaf402ed959bc81
+  metadata.gz: d078f45a54c3ec3df4a76907979c460825ccf5436be101524640f6e523272196564fb138431e7e96c7c67a3b291640f35f1de237edf952083a1e2e494c95bcf3
+  data.tar.gz: edc3120fab568247708a2810fe01074ee6f00c87bf894fa74cdfa3e5478c8a8a21312a60d7f6862b0c615cb377df71eea7506a84aa997a2529c349f0f2b260e7

data/README.md

@@ -2,7 +2,9 @@
 
 *The gateway drug to automated infrastructure testing with Puppet*
 
-Onceover is a tool to automatically run basic tests on an entire Puppet controlrepo. It includes automatic parsing of the `Puppetfile`, `environment.conf` and others in order to run stop silly mistakes ever reaching your Puppet Master!
+Onceover is a tool to automatically run basic tests on an entire Puppet controlrepo. It includes automatic parsing of the `Puppetfile`, `environment.conf` and others in order to stop silly mistakes ever reaching your Puppet Master!
+
+**🍺🥳 New in v3.17.1: Heaps more Windows fixes! Windows code is now more likely to compile on Non-Windows.**
 
 ## Table of Contents
 
@@ -14,6 +16,7 @@ Onceover is a tool to automatically run basic tests on an entire Puppet controlr
     - [factsets](#factsets)
     - [Hiera Data](#hiera-data)
     - [r10k](#r10k)
+      - [r10k Config](#r10k-config)
   - [Spec testing](#spec-testing)
     - [Adding your own spec tests](#adding-your-own-spec-tests)
   - [Using Workarounds](#using-workarounds)
@@ -228,13 +231,20 @@ It's important to note that in order to reference a group using the *include/exc
 
 One or many tags that tests in this group should be tagged with. This allows you to run only certain tests using the `--tags` command line parameter. **NOTE:** Custom spec tests will always be run as they are not subject to tags
 
+**include_spec_files** *Default: [**/*]*
+
+Glob to select additionnal files to be run during `onceover` spec tests.
+
+Default is to select all files located in the repo spec directory, usually `spec/`.
+If you have some RSpec tests that depend on a different RSpec configuration than `onceover` or want, for example, to have a different job in your CI to run your own unit tests, you can use this option to select which spec files to run during `onceover` spec tests.
+
 ### factsets
 
 This gem comes with a few pre-canned factsets. These are listed under the `nodes` sections of `onceover.yaml` when you run `onceover init`. You can also add your own factsets by putting them in:
 
 `spec/factsets/*.json`
 
-Factsets are used by the controlrepo gem to generate spec tests, which compile a given class against a certain set of facts. To create these factsets all we need to do is log onto a real machine that has puppet installed and run:
+Factsets are used by the onceover gem to generate spec tests, which compile a given class against a certain set of facts. To create these factsets all we need to do is log onto a real machine that has puppet installed and run:
 
 `puppet facts`
 
@@ -275,6 +285,51 @@ It is also worth noting that any hiera hierarchies that are based on custom fact
 
 ### r10k
 
+Organisations often reference modules from their own git servers in the `Puppetfile`, like this:
+
+```
+mod "puppetlabs-apache",
+  :git => "https://git.megacorp.com/pup/puppetlabs-apache.git",
+  :tag => "v5.4.0"
+```
+
+Under the hood, Onceover uses r10k to download the modules in your `Puppetfile`. If you get errors downloading modules from Git, its because `r10k`'s call to your underlying `git` command has failed. Onceover tells you the command that `r10k` tried to run, so if you get an error like this:
+
+```
+INFO     -> Updating module /Users/dylan/control-repo/.onceover/etc/puppetlabs/code/environments
+/production/modules/apache
+ERROR    -> Command exited with non-zero exit code:
+Command: git --git-dir /Users/dylan/.r10k/git/ssh---git.megacorp.com-pup-puppetlabs_apache.git fetch origin --prune
+Stderr:
+ssh_askpass: exec(/usr/bin/ssh-askpass): No such file or directory
+Host key verification failed.
+
+fatal: Could not read from remote repository.
+
+Please make sure you have the correct access rights
+and the repository exists.
+Exit code: 128
+```
+
+Then the approach to debug it would be to run the command that Onceover suggested:
+
+```
+git --git-dir /Users/dylan/.r10k/git/ssh---git.megacorp.com-pup-puppetlabs_apache.git fetch origin --prune
+```
+
+In this case, running the command interactively gives us a prompt to add the server to our `~/.ssh/known_hosts` file, which fixes the problem permanently:
+
+```
+$ git --git-dir /Users/dylan/.r10k/git/ssh---git.megacorp.com-pup-puppetlabs_apache.git fetch origin --prune
+The authenticity of host 'git.megacorp.com (123.456.789.101)' can't be established.
+...
+Warning: Permanently added 'git.megacorp.com,123.456.789.101' (RSA) to the list of known hosts.
+```
+
+The other way to resolve this would have been to install the `ssh_askpass` program, but this can spam the screen with modal dialogs on some platforms.
+
+#### r10k Config
+
 If you have custom r10k config that you want to use, place the `r10k.yaml` file in one of the following locations:
 
 - `{repo root}/r10k.yaml`
@@ -652,4 +707,7 @@ Cheers to all of those who helped out:
   - @raphink
   - @tequeter
   - @alexjfisher
+  - @smortex
+  - @16c7x
+  - @neomilium
 

data/factsets/Ubuntu-18.04-64.json

@@ -0,0 +1,556 @@
+{
+  "name": "ubuntu-bionic.lan.asio",
+  "values": {
+    "aio_agent_version": "6.14.0",
+    "architecture": "amd64",
+    "augeas": {
+      "version": "1.12.0"
+    },
+    "augeasversion": "1.12.0",
+    "bios_release_date": "12/01/2006",
+    "bios_vendor": "innotek GmbH",
+    "bios_version": "VirtualBox",
+    "blockdevice_sda_model": "HARDDISK",
+    "blockdevice_sda_size": 10737418240,
+    "blockdevice_sda_vendor": "VBOX",
+    "blockdevice_sdb_model": "HARDDISK",
+    "blockdevice_sdb_size": 10485760,
+    "blockdevice_sdb_vendor": "VBOX",
+    "blockdevices": "sdb,sda",
+    "boardmanufacturer": "Oracle Corporation",
+    "boardproductname": "VirtualBox",
+    "boardserialnumber": "0",
+    "chassistype": "Other",
+    "dhcp_servers": {
+      "enp0s3": "10.0.2.2",
+      "system": "10.0.2.2"
+    },
+    "disks": {
+      "sda": {
+        "model": "HARDDISK",
+        "size": "10.00 GiB",
+        "size_bytes": 10737418240,
+        "vendor": "VBOX"
+      },
+      "sdb": {
+        "model": "HARDDISK",
+        "size": "10.00 MiB",
+        "size_bytes": 10485760,
+        "vendor": "VBOX"
+      }
+    },
+    "dmi": {
+      "bios": {
+        "release_date": "12/01/2006",
+        "vendor": "innotek GmbH",
+        "version": "VirtualBox"
+      },
+      "board": {
+        "manufacturer": "Oracle Corporation",
+        "product": "VirtualBox",
+        "serial_number": "0"
+      },
+      "chassis": {
+        "type": "Other"
+      },
+      "manufacturer": "innotek GmbH",
+      "product": {
+        "name": "VirtualBox",
+        "serial_number": "0",
+        "uuid": "2C7D24ED-FB7D-4B4C-BC4B-B9FC32C8BDC3"
+      }
+    },
+    "domain": "lan.asio",
+    "facterversion": "3.14.9",
+    "filesystems": "btrfs,ext2,ext3,ext4,iso9660,squashfs,vfat",
+    "fips_enabled": false,
+    "fqdn": "ubuntu-bionic.lan.asio",
+    "gid": "root",
+    "hardwareisa": "x86_64",
+    "hardwaremodel": "x86_64",
+    "hostname": "ubuntu-bionic",
+    "hypervisors": {
+      "virtualbox": {
+        "revision": "133895",
+        "version": "6.0.14"
+      }
+    },
+    "id": "root",
+    "identity": {
+      "gid": 0,
+      "group": "root",
+      "privileged": true,
+      "uid": 0,
+      "user": "root"
+    },
+    "interfaces": "enp0s3,lo",
+    "ipaddress": "10.0.2.15",
+    "ipaddress6": "fe80::bb:7dff:fee8:e923",
+    "ipaddress6_enp0s3": "fe80::bb:7dff:fee8:e923",
+    "ipaddress6_lo": "::1",
+    "ipaddress_enp0s3": "10.0.2.15",
+    "ipaddress_lo": "127.0.0.1",
+    "is_virtual": true,
+    "kernel": "Linux",
+    "kernelmajversion": "4.15",
+    "kernelrelease": "4.15.0-54-generic",
+    "kernelversion": "4.15.0",
+    "load_averages": {
+      "15m": 0.1,
+      "1m": 0.31,
+      "5m": 0.23
+    },
+    "lsbdistcodename": "bionic",
+    "lsbdistdescription": "Ubuntu 18.04.2 LTS",
+    "lsbdistid": "Ubuntu",
+    "lsbdistrelease": "18.04",
+    "lsbmajdistrelease": "18.04",
+    "macaddress": "02:bb:7d:e8:e9:23",
+    "macaddress_enp0s3": "02:bb:7d:e8:e9:23",
+    "manufacturer": "innotek GmbH",
+    "memory": {
+      "system": {
+        "available": "776.53 MiB",
+        "available_bytes": 814247936,
+        "capacity": "21.19%",
+        "total": "985.26 MiB",
+        "total_bytes": 1033121792,
+        "used": "208.73 MiB",
+        "used_bytes": 218873856
+      }
+    },
+    "memoryfree": "776.53 MiB",
+    "memoryfree_mb": 776.52734375,
+    "memorysize": "985.26 MiB",
+    "memorysize_mb": 985.26171875,
+    "mountpoints": {
+      "/": {
+        "available": "8.14 GiB",
+        "available_bytes": 8742756352,
+        "capacity": "15.32%",
+        "device": "/dev/sda1",
+        "filesystem": "ext4",
+        "options": [
+          "rw",
+          "relatime",
+          "data=ordered"
+        ],
+        "size": "9.63 GiB",
+        "size_bytes": 10340794368,
+        "used": "1.47 GiB",
+        "used_bytes": 1581260800
+      },
+      "/dev": {
+        "available": "480.22 MiB",
+        "available_bytes": 503545856,
+        "capacity": "0%",
+        "device": "udev",
+        "filesystem": "devtmpfs",
+        "options": [
+          "rw",
+          "nosuid",
+          "relatime",
+          "size=491744k",
+          "nr_inodes=122936",
+          "mode=755"
+        ],
+        "size": "480.22 MiB",
+        "size_bytes": 503545856,
+        "used": "0 bytes",
+        "used_bytes": 0
+      },
+      "/dev/hugepages": {
+        "available": "0 bytes",
+        "available_bytes": 0,
+        "capacity": "100%",
+        "device": "hugetlbfs",
+        "filesystem": "hugetlbfs",
+        "options": [
+          "rw",
+          "relatime",
+          "pagesize=2M"
+        ],
+        "size": "0 bytes",
+        "size_bytes": 0,
+        "used": "0 bytes",
+        "used_bytes": 0
+      },
+      "/dev/mqueue": {
+        "available": "0 bytes",
+        "available_bytes": 0,
+        "capacity": "100%",
+        "device": "mqueue",
+        "filesystem": "mqueue",
+        "options": [
+          "rw",
+          "relatime"
+        ],
+        "size": "0 bytes",
+        "size_bytes": 0,
+        "used": "0 bytes",
+        "used_bytes": 0
+      },
+      "/dev/pts": {
+        "available": "0 bytes",
+        "available_bytes": 0,
+        "capacity": "100%",
+        "device": "devpts",
+        "filesystem": "devpts",
+        "options": [
+          "rw",
+          "nosuid",
+          "noexec",
+          "relatime",
+          "gid=5",
+          "mode=620",
+          "ptmxmode=000"
+        ],
+        "size": "0 bytes",
+        "size_bytes": 0,
+        "used": "0 bytes",
+        "used_bytes": 0
+      },
+      "/dev/shm": {
+        "available": "492.63 MiB",
+        "available_bytes": 516558848,
+        "capacity": "0%",
+        "device": "tmpfs",
+        "filesystem": "tmpfs",
+        "options": [
+          "rw",
+          "nosuid",
+          "nodev"
+        ],
+        "size": "492.63 MiB",
+        "size_bytes": 516558848,
+        "used": "0 bytes",
+        "used_bytes": 0
+      },
+      "/run": {
+        "available": "97.93 MiB",
+        "available_bytes": 102690816,
+        "capacity": "0.60%",
+        "device": "tmpfs",
+        "filesystem": "tmpfs",
+        "options": [
+          "rw",
+          "nosuid",
+          "noexec",
+          "relatime",
+          "size=100892k",
+          "mode=755"
+        ],
+        "size": "98.53 MiB",
+        "size_bytes": 103313408,
+        "used": "608.00 KiB",
+        "used_bytes": 622592
+      },
+      "/run/lock": {
+        "available": "5.00 MiB",
+        "available_bytes": 5242880,
+        "capacity": "0%",
+        "device": "tmpfs",
+        "filesystem": "tmpfs",
+        "options": [
+          "rw",
+          "nosuid",
+          "nodev",
+          "noexec",
+          "relatime",
+          "size=5120k"
+        ],
+        "size": "5.00 MiB",
+        "size_bytes": 5242880,
+        "used": "0 bytes",
+        "used_bytes": 0
+      },
+      "/run/user/1000": {
+        "available": "98.52 MiB",
+        "available_bytes": 103309312,
+        "capacity": "0%",
+        "device": "tmpfs",
+        "filesystem": "tmpfs",
+        "options": [
+          "rw",
+          "nosuid",
+          "nodev",
+          "relatime",
+          "size=100888k",
+          "mode=700",
+          "uid=1000",
+          "gid=1000"
+        ],
+        "size": "98.52 MiB",
+        "size_bytes": 103309312,
+        "used": "0 bytes",
+        "used_bytes": 0
+      },
+      "/sys/fs/cgroup": {
+        "available": "492.63 MiB",
+        "available_bytes": 516558848,
+        "capacity": "0%",
+        "device": "tmpfs",
+        "filesystem": "tmpfs",
+        "options": [
+          "ro",
+          "nosuid",
+          "nodev",
+          "noexec",
+          "mode=755"
+        ],
+        "size": "492.63 MiB",
+        "size_bytes": 516558848,
+        "used": "0 bytes",
+        "used_bytes": 0
+      },
+      "/vagrant": {
+        "available": "122.93 GiB",
+        "available_bytes": 131996221440,
+        "capacity": "85.01%",
+        "device": "vagrant",
+        "filesystem": "vboxsf",
+        "options": [
+          "rw",
+          "nodev",
+          "relatime",
+          "iocharset=utf8",
+          "uid=1000",
+          "gid=1000"
+        ],
+        "size": "820.33 GiB",
+        "size_bytes": 880824786944,
+        "used": "697.40 GiB",
+        "used_bytes": 748828565504
+      },
+      "/var/lib/lxcfs": {
+        "available": "0 bytes",
+        "available_bytes": 0,
+        "capacity": "100%",
+        "device": "lxcfs",
+        "filesystem": "fuse.lxcfs",
+        "options": [
+          "rw",
+          "nosuid",
+          "nodev",
+          "relatime",
+          "user_id=0",
+          "group_id=0",
+          "allow_other"
+        ],
+        "size": "0 bytes",
+        "size_bytes": 0,
+        "used": "0 bytes",
+        "used_bytes": 0
+      }
+    },
+    "mtu_enp0s3": 1500,
+    "mtu_lo": 65536,
+    "netmask": "255.255.255.0",
+    "netmask6": "ffff:ffff:ffff:ffff::",
+    "netmask6_enp0s3": "ffff:ffff:ffff:ffff::",
+    "netmask6_lo": "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",
+    "netmask_enp0s3": "255.255.255.0",
+    "netmask_lo": "255.0.0.0",
+    "network": "10.0.2.0",
+    "network6": "fe80::",
+    "network6_enp0s3": "fe80::",
+    "network6_lo": "::1",
+    "network_enp0s3": "10.0.2.0",
+    "network_lo": "127.0.0.0",
+    "networking": {
+      "dhcp": "10.0.2.2",
+      "domain": "lan.asio",
+      "fqdn": "ubuntu-bionic.lan.asio",
+      "hostname": "ubuntu-bionic",
+      "interfaces": {
+        "enp0s3": {
+          "bindings": [
+            {
+              "address": "10.0.2.15",
+              "netmask": "255.255.255.0",
+              "network": "10.0.2.0"
+            }
+          ],
+          "bindings6": [
+            {
+              "address": "fe80::bb:7dff:fee8:e923",
+              "netmask": "ffff:ffff:ffff:ffff::",
+              "network": "fe80::"
+            }
+          ],
+          "dhcp": "10.0.2.2",
+          "ip": "10.0.2.15",
+          "ip6": "fe80::bb:7dff:fee8:e923",
+          "mac": "02:bb:7d:e8:e9:23",
+          "mtu": 1500,
+          "netmask": "255.255.255.0",
+          "netmask6": "ffff:ffff:ffff:ffff::",
+          "network": "10.0.2.0",
+          "network6": "fe80::",
+          "scope6": "link"
+        },
+        "lo": {
+          "bindings": [
+            {
+              "address": "127.0.0.1",
+              "netmask": "255.0.0.0",
+              "network": "127.0.0.0"
+            }
+          ],
+          "bindings6": [
+            {
+              "address": "::1",
+              "netmask": "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",
+              "network": "::1"
+            }
+          ],
+          "ip": "127.0.0.1",
+          "ip6": "::1",
+          "mtu": 65536,
+          "netmask": "255.0.0.0",
+          "netmask6": "ffff:ffff:ffff:ffff:ffff:ffff:ffff:ffff",
+          "network": "127.0.0.0",
+          "network6": "::1",
+          "scope6": "host"
+        }
+      },
+      "ip": "10.0.2.15",
+      "ip6": "fe80::bb:7dff:fee8:e923",
+      "mac": "02:bb:7d:e8:e9:23",
+      "mtu": 1500,
+      "netmask": "255.255.255.0",
+      "netmask6": "ffff:ffff:ffff:ffff::",
+      "network": "10.0.2.0",
+      "network6": "fe80::",
+      "primary": "enp0s3",
+      "scope6": "link"
+    },
+    "operatingsystem": "Ubuntu",
+    "operatingsystemmajrelease": "18.04",
+    "operatingsystemrelease": "18.04",
+    "os": {
+      "architecture": "amd64",
+      "distro": {
+        "codename": "bionic",
+        "description": "Ubuntu 18.04.2 LTS",
+        "id": "Ubuntu",
+        "release": {
+          "full": "18.04",
+          "major": "18.04"
+        }
+      },
+      "family": "Debian",
+      "hardware": "x86_64",
+      "name": "Ubuntu",
+      "release": {
+        "full": "18.04",
+        "major": "18.04"
+      },
+      "selinux": {
+        "enabled": false
+      }
+    },
+    "osfamily": "Debian",
+    "partitions": {
+      "/dev/sda1": {
+        "filesystem": "ext4",
+        "label": "cloudimg-rootfs",
+        "mount": "/",
+        "partuuid": "654c6dc7-01",
+        "size": "10.00 GiB",
+        "size_bytes": 10736352768,
+        "uuid": "8de716dd-d9b2-477f-b818-bb0b1eb036ce"
+      }
+    },
+    "path": "/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/snap/bin:/opt/puppetlabs/bin",
+    "physicalprocessorcount": 1,
+    "processor0": "Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz",
+    "processor1": "Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz",
+    "processorcount": 2,
+    "processors": {
+      "count": 2,
+      "isa": "x86_64",
+      "models": [
+        "Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz",
+        "Intel(R) Core(TM) i7-6820HQ CPU @ 2.70GHz"
+      ],
+      "physicalcount": 1
+    },
+    "productname": "VirtualBox",
+    "puppetversion": "6.14.0",
+    "ruby": {
+      "platform": "x86_64-linux",
+      "sitedir": "/opt/puppetlabs/puppet/lib/ruby/site_ruby/2.5.0",
+      "version": "2.5.7"
+    },
+    "rubyplatform": "x86_64-linux",
+    "rubysitedir": "/opt/puppetlabs/puppet/lib/ruby/site_ruby/2.5.0",
+    "rubyversion": "2.5.7",
+    "scope6": "link",
+    "scope6_enp0s3": "link",
+    "scope6_lo": "host",
+    "selinux": false,
+    "serialnumber": "0",
+    "ssh": {
+      "dsa": {
+        "fingerprints": {
+          "sha1": "SSHFP 2 1 7024118ae71eead4750a74d458472e89e38c7e7c",
+          "sha256": "SSHFP 2 2 e5606c7ee1cf32f5591b42c98a9bc87d27cef4bc75c7802cd3f22bcb39333656"
+        },
+        "key": "AAAAB3NzaC1kc3MAAACBAPemHtx92WDon/zDA0oaO5wWOXCUx45+6X9QxJugdryqG3RV0J/ZkKhayANq7NO1GeC3/3EC8celhsHyZFILEEJpFPzW32053dVnOZ6JyQCGb4JKFaCH7DjVnZLlTPyqvraykF3beEhp7dArSpsgsIURJLDRvE3PJdd9DDNtOapXAAAAFQC27/RqfyRjrjSOjNrfsqLm6GoT0QAAAIAJm6rGXMlZ+xNfPfVHsugGNP7BdcFLSWnUGaBQ+51FGkRdVesun6HF5A9/TNBfQ6U2k1BE8Qtc3H8uHrwenIQKyWuhVejvpYVD3NA6hztMWYiidiQ7Ji0O3qkPv4CY5QhlmyPit1gR4aly/fG1H8p+J/XbwrJXMtfR6ND3OXbeYwAAAIEAzDOkrJJgq5f+oPSVaOOmvbNdJ0B003fTyJEH+2yCm3q41O7vakoWv9Qt9mH7T/ivqwMK3yzk1eIpozx8TPU1aOQC3OyehoEXXFY6U5Jcgp0K8WUvVgnC47hAKBkf562aGdWftWNu4GkjI6wcNtZqkeVN/wyazilHRF9GyPdsvHg=",
+        "type": "ssh-dss"
+      },
+      "ecdsa": {
+        "fingerprints": {
+          "sha1": "SSHFP 3 1 aa6b8ac4bccb5afded59e2bf680cc151bbb27ef9",
+          "sha256": "SSHFP 3 2 4ee2dc2ded938a37ef44de4fd3f3add478abfe272f0a50dc7dbb1f9a4839ca99"
+        },
+        "key": "AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBF02SaI3oPW6CVWEvzDuf/XqaUF+OAr4RKNW3hAR8RRBSDEjQGdoejQEYP8lEFa1KeVlkJYnvgrPYwxVSUI6hUA=",
+        "type": "ecdsa-sha2-nistp256"
+      },
+      "ed25519": {
+        "fingerprints": {
+          "sha1": "SSHFP 4 1 a20e01cf434a802607e1aff21e621dd3ada6499f",
+          "sha256": "SSHFP 4 2 569917b95c5299fe3cdd1cc4a37166d1e81106a22bb75a15b99bb8694b2ac8c4"
+        },
+        "key": "AAAAC3NzaC1lZDI1NTE5AAAAIHmh1Z/od2mbHDUkAL2bXswdwp43dPXQOKo9DA8AUDO1",
+        "type": "ssh-ed25519"
+      },
+      "rsa": {
+        "fingerprints": {
+          "sha1": "SSHFP 1 1 3bc833bc8e3e259da03d37aa0c0244ae98f30622",
+          "sha256": "SSHFP 1 2 f27f0e09326c1c8abc2b0691bc6444b77781c0a21e9d99933492f269e5163346"
+        },
+        "key": "AAAAB3NzaC1yc2EAAAADAQABAAABAQCw+QuEhOY+IrmAaG1/PgO0nyxYY0VYilhjcM5daSKb61z+XBmBuAsgVxWaQ815OxlwYQunPJZlKnaXZ8yTlnjk8eekxvWnoSLtqKZWW1+RfMyy6n6MyXdno1mwez+5HG3tThC63xE4EWbmKH+fsWuNT2ZpQ49fuWnG8sObv/66QLyCjt+KHMpy9ClHjpYli+0hFhdHTwxGo9H/r4I2En9rBcTy3nQZhZGm1FFh6xnHxnSGm02r2fhsk2x0kw9K1pA7IFtr31hBOu5Po5CJBVJQBd1TEozmNELl2ZISmT0HK3sIV4AG/FmFEsd9+63ST5BbeurlcOEzvxudDJmuroZX",
+        "type": "ssh-rsa"
+      }
+    },
+    "sshdsakey": "AAAAB3NzaC1kc3MAAACBAPemHtx92WDon/zDA0oaO5wWOXCUx45+6X9QxJugdryqG3RV0J/ZkKhayANq7NO1GeC3/3EC8celhsHyZFILEEJpFPzW32053dVnOZ6JyQCGb4JKFaCH7DjVnZLlTPyqvraykF3beEhp7dArSpsgsIURJLDRvE3PJdd9DDNtOapXAAAAFQC27/RqfyRjrjSOjNrfsqLm6GoT0QAAAIAJm6rGXMlZ+xNfPfVHsugGNP7BdcFLSWnUGaBQ+51FGkRdVesun6HF5A9/TNBfQ6U2k1BE8Qtc3H8uHrwenIQKyWuhVejvpYVD3NA6hztMWYiidiQ7Ji0O3qkPv4CY5QhlmyPit1gR4aly/fG1H8p+J/XbwrJXMtfR6ND3OXbeYwAAAIEAzDOkrJJgq5f+oPSVaOOmvbNdJ0B003fTyJEH+2yCm3q41O7vakoWv9Qt9mH7T/ivqwMK3yzk1eIpozx8TPU1aOQC3OyehoEXXFY6U5Jcgp0K8WUvVgnC47hAKBkf562aGdWftWNu4GkjI6wcNtZqkeVN/wyazilHRF9GyPdsvHg=",
+    "sshecdsakey": "AAAAE2VjZHNhLXNoYTItbmlzdHAyNTYAAAAIbmlzdHAyNTYAAABBBF02SaI3oPW6CVWEvzDuf/XqaUF+OAr4RKNW3hAR8RRBSDEjQGdoejQEYP8lEFa1KeVlkJYnvgrPYwxVSUI6hUA=",
+    "sshed25519key": "AAAAC3NzaC1lZDI1NTE5AAAAIHmh1Z/od2mbHDUkAL2bXswdwp43dPXQOKo9DA8AUDO1",
+    "sshfp_dsa": "SSHFP 2 1 7024118ae71eead4750a74d458472e89e38c7e7c\nSSHFP 2 2 e5606c7ee1cf32f5591b42c98a9bc87d27cef4bc75c7802cd3f22bcb39333656",
+    "sshfp_ecdsa": "SSHFP 3 1 aa6b8ac4bccb5afded59e2bf680cc151bbb27ef9\nSSHFP 3 2 4ee2dc2ded938a37ef44de4fd3f3add478abfe272f0a50dc7dbb1f9a4839ca99",
+    "sshfp_ed25519": "SSHFP 4 1 a20e01cf434a802607e1aff21e621dd3ada6499f\nSSHFP 4 2 569917b95c5299fe3cdd1cc4a37166d1e81106a22bb75a15b99bb8694b2ac8c4",
+    "sshfp_rsa": "SSHFP 1 1 3bc833bc8e3e259da03d37aa0c0244ae98f30622\nSSHFP 1 2 f27f0e09326c1c8abc2b0691bc6444b77781c0a21e9d99933492f269e5163346",
+    "sshrsakey": "AAAAB3NzaC1yc2EAAAADAQABAAABAQCw+QuEhOY+IrmAaG1/PgO0nyxYY0VYilhjcM5daSKb61z+XBmBuAsgVxWaQ815OxlwYQunPJZlKnaXZ8yTlnjk8eekxvWnoSLtqKZWW1+RfMyy6n6MyXdno1mwez+5HG3tThC63xE4EWbmKH+fsWuNT2ZpQ49fuWnG8sObv/66QLyCjt+KHMpy9ClHjpYli+0hFhdHTwxGo9H/r4I2En9rBcTy3nQZhZGm1FFh6xnHxnSGm02r2fhsk2x0kw9K1pA7IFtr31hBOu5Po5CJBVJQBd1TEozmNELl2ZISmT0HK3sIV4AG/FmFEsd9+63ST5BbeurlcOEzvxudDJmuroZX",
+    "system_uptime": {
+      "days": 0,
+      "hours": 0,
+      "seconds": 336,
+      "uptime": "0:05 hours"
+    },
+    "timezone": "UTC",
+    "uptime": "0:05 hours",
+    "uptime_days": 0,
+    "uptime_hours": 0,
+    "uptime_seconds": 336,
+    "uuid": "2C7D24ED-FB7D-4B4C-BC4B-B9FC32C8BDC3",
+    "virtual": "virtualbox",
+    "clientcert": "ubuntu-bionic.lan.asio",
+    "clientversion": "6.14.0",
+    "clientnoop": false
+  },
+  "timestamp": "2020-04-29T09:42:42.131094744+00:00",
+  "expiration": "2020-04-29T10:12:42.131454548+00:00"
+}
+

data/factsets/Windows_Server-2008r2-64.json

@@ -162,6 +162,7 @@
     "staging_http_get": "powershell",
     "staging_windir": "C:\\ProgramData\\staging",
     "system32": "C:\\Windows\\system32",
+    "choco_install_path": "C:\\ProgramData\\chocolatey",
     "system_uptime": {
       "days": 0,
       "hours": 0,

data/factsets/Windows_Server-2012r2-64.json

@@ -143,6 +143,7 @@
     "rubyversion": "2.1.7",
     "serialnumber": "0",
     "system32": "C:\\Windows\\system32",
+    "choco_install_path": "C:\\ProgramData\\chocolatey",
     "system_uptime": {
       "days": 0,
       "hours": 0,

data/factsets/windows-10-64.json

@@ -83,6 +83,7 @@
     "rubysitedir": "C:/tools/ruby24/lib/ruby/site_ruby/2.4.0",
     "rubyversion": "2.4.3",
     "system32": "C:\\Windows\\system32",
+    "choco_install_path": "C:\\ProgramData\\chocolatey",
     "system_uptime": {
       "seconds": 1113359,
       "hours": 309,
@@ -100,4 +101,4 @@
   },
   "timestamp": "2018-12-10T21:43:07.468533000+00:00",
   "expiration": "2018-12-10T22:13:07.468533000+00:00"
-}
+}

data/features/step_definitions/common.rb

@@ -37,6 +37,17 @@ When(/^I run onceover command "([^"]*)" with class "([^"]*)"$/)  do |command, cl
   @cmd.run
 end
 
+# The below can be used to skip tests if they only work on one os
+When(/^test osfamily is "(\w*)"$/) do |osfamily|
+  require 'facter'
+  pending unless Facter.value(:os)['family'] == osfamily
+end
+
+When(/^test osfamily is not "(\w*)"$/) do |osfamily|
+  require 'facter'
+  pending if Facter.value(:os)['family'] == osfamily
+end
+
 Then(/^I see help for commands: "([^"]*)"$/) do |commands|
   # Get chunk of output between COMMANDS and OPTION, there should be help section
   commands_help = @cmd.output[/COMMANDS(.*)OPTIONS/m, 1]

data/features/windows.feature

@@ -0,0 +1,30 @@
+@windows
+Feature: Run onceover with windows 
+  Onceover should allow to run rspec and acceptance test for all profvile and role classes
+  or for any part of them. Use should set if he wants to see only summary of tests or full
+  log info.
+
+  Background:
+    Given onceover executable
+
+  Scenario: Run with common Windows code
+    Given control repo "windows"
+    When I run onceover command "run spec" with class "role::users"
+    Then I should not see any errors
+
+  Scenario: Run with common Windows code without workarounds
+    Given existing control repo "windows"
+    When I run onceover command "run spec --no_workarounds" with class "role::users"
+    And test osfamily is not "windows"
+    Then Onceover should exit 1
+
+  Scenario: Compiling a windows role with groups that is valid should compile
+    Given control repo "windows"
+    When I run onceover command "run spec" with class "role::groups"
+    Then I should not see any errors
+  
+  Scenario: Compiling a windows role with users that is valid should compile
+    Given control repo "windows"
+    When I run onceover command "run spec" with class "role::users"
+    Then I should not see any errors
+  

data/lib/onceover/cli/run.rb

@@ -42,6 +42,7 @@ This includes deploying using r10k and running all custom tests.
 
             optional :p, :parallel, 'Runs spec tests in parallel. This increases speed at the cost of poorly formatted logs and irrelevant junit output.'
             optional nil, :format, 'Which RSpec formatter to use, valid options are: documentation, progress, FailureCollector, OnceoverFormatter. You also specify this multiple times', multiple: true, default: :defaults
+            optional nil, :no_workarounds, 'Disables workarounds that have been added for convenience to get around common RSPec issues such as https://github.com/rodjek/rspec-puppet/issues/665'
 
             run do |opts, args, cmd|
               repo = Onceover::Controlrepo.new(opts)

data/lib/onceover/controlrepo.rb

@@ -206,7 +206,7 @@ class Onceover
     end
 
     def print_puppetfile_table
-      require 'table_print'
+      require 'terminal-table'
       require 'versionomy'
       require 'colored'
       require 'r10k/puppetfile'
@@ -221,48 +221,44 @@ class Onceover
       threads      = []
       puppetfile.modules.each do |mod|
         threads << Thread.new do
-          return_hash = {}
+          row = []
           logger.debug "Loading data for #{mod.full_name}"
-          return_hash[:full_name] = mod.full_name
+          row << mod.full_name
           if mod.is_a?(R10K::Module::Forge)
-            return_hash[:current_version] = mod.expected_version
-            return_hash[:latest_version] = mod.v3_module.current_release.version
-            return_hash[:endorsement] = mod.v3_module.endorsement
+            row << mod.expected_version
+            row << mod.v3_module.current_release.version
+
+            current = Versionomy.parse(mod.expected_version)
+            latest = Versionomy.parse(mod.v3_module.current_release.version)
+            row << if current.major < latest.major
+                     "Major".red
+                   elsif current.minor < latest.minor
+                     "Minor".yellow
+                   elsif current.tiny < latest.tiny
+                     "Tiny".green
+                   else
+                     "No".green
+                   end
+
+            row << mod.v3_module.endorsement
             superseded_by = mod.v3_module.superseded_by
-            return_hash[:superseded_by] = superseded_by.nil? ? '' : superseded_by[:slug]
-            current = Versionomy.parse(return_hash[:current_version])
-            latest = Versionomy.parse(return_hash[:latest_version])
-            if current.major < latest.major
-              return_hash[:out_of_date] = "Major".red
-            elsif current.minor < latest.minor
-              return_hash[:out_of_date] = "Minor".yellow
-            elsif current.tiny < latest.tiny
-              return_hash[:out_of_date] = "Tiny".green
-            else
-              return_hash[:out_of_date] = "No".green
-            end
+            row << (superseded_by.nil? ? '' : superseded_by[:slug])
           else
-            return_hash[:current_version] = "N/A"
-            return_hash[:latest_version]  = "N/A"
-            return_hash[:out_of_date]     = "N/A"
-            return_hash[:endorsement]     = "N/A"
-            return_hash[:superseded_by]   = "N/A"
+            row << "N/A"
+            row << "N/A"
+            row << "N/A"
+            row << "N/A"
+            row << "N/A"
           end
-          output_array << return_hash
+          output_array << row
         end
       end
 
       threads.map(&:join)
 
-      tp(
-        output_array,
-        {:full_name       => {:display_name => "Full Name"}},
-        {:current_version => {:display_name => "Current Version"}},
-        {:latest_version  => {:display_name => "Latest Version"}},
-        {:out_of_date     => {:display_name => "Out of Date?"}},
-        {:endorsement     => {:display_name => "Endorsement"}},
-        {:superseded_by   => {:display_name => "Superseded by"}}
-      )
+      output_array.sort_by! { |line| line[0] }
+
+      puts Terminal::Table.new(headings: ["Full Name", "Current Version", "Latest Version", "Out of Date?", "Endorsement", "Superseded by"], rows: output_array)
     end
 
     def update_puppetfile

data/lib/onceover/runner.rb

@@ -24,8 +24,8 @@ class Onceover
       FileUtils.mkdir_p("#{@repo.tempdir}/spec/classes")
       FileUtils.mkdir_p("#{@repo.tempdir}/spec/acceptance/nodesets")
 
-      # Copy our entire spec directory over
-      FileUtils.cp_r("#{@repo.spec_dir}", "#{@repo.tempdir}")
+      # Copy specified spec files over
+      @config.copy_spec_files(@repo)
 
       # Create the Rakefile so that we can take advantage of the existing tasks
       @config.write_rakefile(@repo.tempdir, "spec/classes/**/*_spec.rb")
@@ -87,10 +87,11 @@ class Onceover
         #`bin/rake spec_standalone`
         if @config.opts[:parallel]
           logger.debug "Running #{@command_prefix}rake parallel_spec from #{@repo.tempdir}"
-          result = Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'parallel_spec').join
+          result = run_command(@command_prefix.strip.split, 'rake', 'parallel_spec')
         else
+          require 'io/console'
           logger.debug "Running #{@command_prefix}rake spec_standalone from #{@repo.tempdir}"
-          result = Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'spec_standalone').join
+          result = run_command(@command_prefix.strip.split, 'rake', 'spec_standalone')
         end
 
         # Reset env to previous state if we modified it
@@ -117,11 +118,20 @@ class Onceover
         #`bundle install --binstubs`
         #`bin/rake spec_standalone`
         logger.debug "Running #{@command_prefix}rake acceptance from #{@repo.tempdir}"
-        result = Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'acceptance').join
+        result = run_command(@command_prefix.strip.split, 'rake', 'acceptance')
       end
 
       # Finally exit and preserve the exit code
       exit result.status.exitstatus
     end
+
+    def run_command(*args)
+      begin
+        STDERR.raw! if STDERR.isatty
+        result = Backticks::Runner.new(interactive: true).run(args.flatten).join
+      ensure
+        STDERR.cooked! if STDERR.isatty
+      end
+    end
   end
 end

data/lib/onceover/testconfig.rb

@@ -47,9 +47,10 @@ class Onceover
       @acceptance_tests  = []
       @opts              = opts
       @mock_functions    = config['functions']
-      @before_conditions = config['before']
+      @before_conditions = config['before'] || []
       @after_conditions  = config['after']
       @strict_variables  = opts[:strict_variables] ? 'yes' : 'no'
+      @included_specs    = [config['include_spec_files'] || ['**/*']].flatten
       
       # Set dynamic defaults for format
       if Array(opts[:format]) == [:defaults]
@@ -236,6 +237,19 @@ class Onceover
       )
     end
 
+    def copy_spec_files(repo)
+      source_files = @included_specs.map { |glob| Dir.glob "#{repo.spec_dir}/#{glob}" }.flatten.uniq
+      source_files.each do |source_file|
+        target_file = File.join(repo.tempdir, 'spec', source_file.sub(/^#{repo.spec_dir}/, ''))
+        if File.directory?(source_file)
+          FileUtils.cp_r source_file, target_file unless File.exists? target_file
+        else
+          FileUtils.mkdir_p File.dirname target_file
+          FileUtils.cp source_file, target_file
+        end
+      end
+    end
+
     def create_fixtures_symlinks(repo)
       logger.debug "Creating fixtures symlinks"
       FileUtils.rm_rf("#{repo.tempdir}/spec/fixtures/modules")

data/onceover.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "onceover"
-  s.version     = "3.16.0"
+  s.version     = "3.18.0"
   s.authors     = ["Dylan Ratcliffe"]
   s.email       = ["dylan.ratcliffe@puppet.com"]
   s.homepage    = "https://github.com/dylanratcliffe/onceover"
@@ -34,7 +34,7 @@ Gem::Specification.new do |s|
   s.add_runtime_dependency 'rspec', '>= 3.0.0'
   s.add_runtime_dependency 'rspec-puppet', ">= 2.4.0"
   s.add_runtime_dependency 'rspec_junit_formatter', '>= 0.2.0'
-  s.add_runtime_dependency 'table_print', '>= 1.0.0'
+  s.add_runtime_dependency 'terminal-table', '>= 1.8.0'
   s.add_runtime_dependency 'versionomy', '>= 0.5.0'
 
 end

data/spec/fixtures/controlrepos/windows/Gemfile

@@ -0,0 +1,3 @@
+source 'https://rubygems.org'
+
+gem 'onceover'

data/spec/fixtures/controlrepos/windows/Puppetfile

@@ -0,0 +1,3 @@
+forge "http://forge.puppetlabs.com"
+
+mod 'puppetlabs-acl', '3.1.1'

data/spec/fixtures/controlrepos/windows/environment.conf

@@ -0,0 +1 @@
+modulepath = site-modules:modules:$basemodulepath

data/spec/fixtures/controlrepos/windows/site-modules/role/manifests/acl.pp

@@ -0,0 +1,12 @@
+class role::acl {
+  # ACL often causes failures such as this:
+  # https://github.com/rodjek/rspec-puppet/issues/665
+  #
+  # Onceover should handle this out of the box
+  acl { 'L:\\SQLBackup':
+    inherit_parent_permissions => false,
+    permissions                => [
+      { 'identity' => 'foo', 'rights' => ['read'] }
+    ],
+  }
+}

data/spec/fixtures/controlrepos/windows/site-modules/role/manifests/groups.pp

@@ -0,0 +1,8 @@
+# Class: role::groups
+#
+#
+class role::groups {
+  group {'Administrators':
+    members => ['foo'],
+  }
+}

data/spec/fixtures/controlrepos/windows/site-modules/role/manifests/users.pp

@@ -0,0 +1,9 @@
+# Class: role::users
+#
+#
+class role::users {
+  user { 'dylan':
+    ensure => 'present',
+    groups => ['Administrators'],
+  }
+}

data/spec/fixtures/controlrepos/windows/site/role/manifests/groups.pp

@@ -0,0 +1,8 @@
+# Class: role::groups
+#
+#
+class role::groups {
+  group {'Administrators':
+    members => ['foo'],
+  }
+}

data/spec/fixtures/controlrepos/windows/site/role/manifests/users.pp

@@ -0,0 +1,9 @@
+# Class: role::users
+#
+#
+class role::users {
+  user { 'dylan':
+    ensure => 'present',
+    groups => ['Administrators'],
+  }
+}

data/spec/fixtures/controlrepos/windows/spec/onceover.yaml

@@ -0,0 +1,24 @@
+# Classes to be tested
+classes:
+  - /role::/
+
+# Nodes to tests classes on, this refers to a 'factset' or 'nodeset'
+# depending on whether you are running 'spec' or 'acceptance' tests
+nodes:
+  - Windows_Server-2012r2-64
+  - windows-10-64
+  - Windows_Server-2008r2-64
+
+# You can group classes here to save typing
+class_groups:
+
+# You can group nodes here to save typing
+# We have created a 'non_windows_nodes' group because we can't
+# give you Windows vagrant boxes to test with because licensing,
+# we can give you fact sets though so go crazy with spec testing!
+node_groups:
+
+test_matrix:
+  - all_nodes:
+      classes: "all_classes"
+      tests: "spec"

data/templates/test_spec.rb.erb

@@ -29,6 +29,7 @@ describe "<%= cls.name %>" do
     end
 <% end -%>
 
+<% unless opts[:no_workarounds] -%>
     before :each do
       # Curtrently there is some code within Puppet that will try to execute
       # commands when compiling a catalog even though it shouldn't. One example is
@@ -41,7 +42,66 @@ describe "<%= cls.name %>" do
       unless File.exist? expected_null_file
         allow(Puppet::Util::Execution).to receive(:execute).and_raise(Puppet::ExecutionFailure.new("Onceover caused this"))
       end
+
+      # The windows ACL module causes issues when compiled on other platforms
+      # These are detailed in the following ticket:
+      #   https://github.com/rodjek/rspec-puppet/issues/665
+      #
+      # The below should work around this common issue
+      if Puppet::Type.type(:acl)
+        allow_any_instance_of(Puppet::Type.type(:acl).provider(:windows)).to receive(:validate)
+        allow_any_instance_of(Puppet::Type.type(:acl).provider(:windows)).to receive(:respond_to?).with(:get_account_name).and_return(false)
+        allow_any_instance_of(Puppet::Type.type(:acl).provider(:windows)).to receive(:respond_to?).with(:get_group_name).and_return(false)
+        allow_any_instance_of(Puppet::Type.type(:acl).provider(:windows)).to receive(:respond_to?).with(:validate).and_return(true)
+      end
+
+      # The windows_adsi provider also has an issue where the contructor takes
+      # a different number of arguments depending on whether the ADSI
+      # underlying connectivity exists. This causes the following error:
+      #
+      #      wrong number of arguments (given 1, expected 0)
+      #
+      # This fixes that if we aren't using Windows
+      begin
+        # Test to see if this works without modification
+        require 'puppet/util/windows'
+        require 'puppet/util/windows/adsi'
+        Puppet::Util::Windows::ADSI.computer_name
+      rescue LoadError, StandardError
+        # Declare an entire mocked module because for some reason we can't load it unless we are on Windows
+        module Puppet::Util::Windows
+          module ADSI
+            class ADSIObject; end
+            class User < ADSIObject; end
+            class UserProfile; end
+            class Group < ADSIObject; end
+          end
+          module File; end
+          module Registry
+          end
+          module SID
+            class Principal; end
+          end
+          class EventLog; end
+        end
+
+        # Mock commonly used things
+        allow(Puppet::Util::Windows::SID).to receive(:name_to_sid).and_return('S-1-5-32-544')
+        allow(Puppet::Util::Windows::SID).to receive(:name_to_principal).and_return(nil)
+        
+        allow_any_instance_of(Puppet::Util::Windows::ADSI::User).to receive(:initialize)
+        allow_any_instance_of(Puppet::Util::Windows::ADSI::User).to receive(:groups).and_return([])
+        allow_any_instance_of(Puppet::Util::Windows::ADSI::User).to receive(:name_sid_hash).and_return({})
+
+        # Group instance methods
+        allow_any_instance_of(Puppet::Util::Windows::ADSI::Group).to receive(:members).and_return([])
+        allow_any_instance_of(Puppet::Util::Windows::ADSI::Group).to receive(:members_sids).and_return([])
+        
+        # Class methods
+        allow(Puppet::Util::Windows::ADSI::Group).to receive(:name_sid_hash).and_return({})
+      end
     end
+<% end -%>
 
 <% if @after_conditions -%>
     after :each do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: onceover
 version: !ruby/object:Gem::Version
-  version: 3.16.0
+  version: 3.18.0
 platform: ruby
 authors:
 - Dylan Ratcliffe
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2020-04-21 00:00:00.000000000 Z
+date: 2020-07-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: backticks
@@ -235,19 +235,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: 0.2.0
 - !ruby/object:Gem::Dependency
-  name: table_print
+  name: terminal-table
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.8.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 1.0.0
+        version: 1.8.0
 - !ruby/object:Gem::Dependency
   name: versionomy
   requirement: !ruby/object:Gem::Requirement
@@ -299,6 +299,7 @@ files:
 - factsets/Ubuntu-12.04-64.json
 - factsets/Ubuntu-14.04-32.json
 - factsets/Ubuntu-14.04-64.json
+- factsets/Ubuntu-18.04-64.json
 - factsets/Windows_Server-2008r2-64.json
 - factsets/Windows_Server-2012r2-64.json
 - factsets/solaris-10_u9-sparc-64.json
@@ -309,7 +310,6 @@ files:
 - features/formatting.feature
 - features/help.feature
 - features/init.feature
-- features/run.feature
 - features/show.feature
 - features/step_definitions/cache.rb
 - features/step_definitions/common.rb
@@ -320,6 +320,8 @@ files:
 - features/support/command_helper.rb
 - features/support/controlrepo_helper.rb
 - features/support/env.rb
+- features/windows.feature
+- features/zzz_run.feature
 - lib/onceover/beaker.rb
 - lib/onceover/beaker/spec_helper.rb
 - lib/onceover/class.rb
@@ -388,6 +390,15 @@ files:
 - spec/fixtures/controlrepos/function_mocking/site/role/manifests/test_new_functions.pp
 - spec/fixtures/controlrepos/function_mocking/spec/onceover.yaml
 - spec/fixtures/controlrepos/minimal/environment.conf
+- spec/fixtures/controlrepos/windows/Gemfile
+- spec/fixtures/controlrepos/windows/Puppetfile
+- spec/fixtures/controlrepos/windows/environment.conf
+- spec/fixtures/controlrepos/windows/site-modules/role/manifests/acl.pp
+- spec/fixtures/controlrepos/windows/site-modules/role/manifests/groups.pp
+- spec/fixtures/controlrepos/windows/site-modules/role/manifests/users.pp
+- spec/fixtures/controlrepos/windows/site/role/manifests/groups.pp
+- spec/fixtures/controlrepos/windows/site/role/manifests/users.pp
+- spec/fixtures/controlrepos/windows/spec/onceover.yaml
 - spec/onceover/controlrepo_spec.rb
 - spec/spec_helper.rb
 - templates/.fixtures.yml.erb
@@ -407,7 +418,7 @@ homepage: https://github.com/dylanratcliffe/onceover
 licenses:
 - Apache-2.0
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -422,9 +433,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
+rubyforge_project:
 rubygems_version: 2.7.6.2
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Testing tools for Puppet controlrepos
 test_files: []