onceover 3.11.0 → 3.11.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 71d240d281209575819137b3b4a0d8128d049d8df9482bc679f2915107f74a40
-  data.tar.gz: add61e481be9978f6dc492eb351d0f3b43d248119d3b94b98132c7323495e52a
+  metadata.gz: 0de0a768f2e22ad3164a270df1a526f814f6ddc21e8333cebca698e55cab3425
+  data.tar.gz: f1eca8504701aaedd2a84b5e949ad3defd013a190014f2276d93bde738216d2b
 SHA512:
-  metadata.gz: ea96a764d79607406e3c89fd0aea91b568c70902ba88b1d30cc7cf2619eb7a204a43764dd12abc74cca7cf25ad5d79dcd18e0dd02ad3a2689b6e9363b1db4d4e
-  data.tar.gz: d35d26e20dbc980b22775784e1a3945c0251cf2f554fc320ae3ce24ed113d39c21b25aec37353e5d177e29ea0c47a3d7ddf7af16e305e2a36f8e7295239e68bd
+  metadata.gz: d06d28ae8e4bf7065ed9a25caa4b9f98dcab8fd5f825c84dccc501bce4274752cd35590b44d8c245b314b6b023f552a6a1adab0a084d9d2a109178b97df1baf5
+  data.tar.gz: 6bf9cb7ca6c63c9557e433e597e73b0e7a8c0c9cb1dda28552ca9fce366d6ecfff01c36854e34fe300b392c0d6ca91817f513bcb056ce2332d33d10c36441da9

data/features/run.feature

@@ -52,6 +52,12 @@ Feature: Run rspec and acceptance test suites
     When I run onceover command "run spec" with class "role::test_new_functions"
     Then I should not see any errors
 
+  Scenario: Running tests that fail to compile
+    Given control repo "function_mocking"
+    When I run onceover command "run spec" with class "role::fail"
+    Then I should see message pattern "failed"
+    And Onceover should exit 1
+
   # This test is a full test using my controlrepo. It should remain at the end because it takes ages
   Scenario: Run advanced spec tests
     Given control repo "puppet_controlrepo"

data/features/step_definitions/common.rb

@@ -51,6 +51,10 @@ Then(/^I should not see any errors$/) do
   expect(@cmd.success?).to be true
 end
 
+Then(/^Onceover should exit (\d+)$/) do |code|
+  expect(@cmd.exit_code).to eq code.to_i
+end
+
 Then(/^I should see error with message pattern "([^"]*)"$/) do |err_msg_regexp|
   expect(@cmd.success?).to be false
   puts @cmd.output

data/features/support/command_helper.rb

@@ -18,6 +18,10 @@ class Command_Helper
     return @result.success?
   end
 
+  def exit_code
+    @result.exitstatus
+  end
+
   def generate_command
     controlrepo_param = @controlrepo ? "--path #{File.expand_path(@controlrepo.root_folder)}" : ''
     return "#{@executable} #{@command} #{controlrepo_param}"

data/lib/onceover/runner.rb

@@ -79,10 +79,10 @@ class Onceover
         #`bin/rake spec_standalone`
         if @config.opts[:parallel]
           logger.debug "Running #{@command_prefix}rake parallel_spec from #{@repo.tempdir}"
-          Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'parallel_spec').join
+          result = Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'parallel_spec').join
         else
           logger.debug "Running #{@command_prefix}rake spec_standalone from #{@repo.tempdir}"
-          Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'spec_standalone').join
+          result = Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'spec_standalone').join
         end
         # TODO: Refactor this to be much nicer
         if @config.formatters.include? 'FailureCollector'
@@ -94,6 +94,9 @@ class Onceover
             puts 'No failures detected'
           end
         end
+
+        # Finally exit and preserve the exit code
+        exit result.status.exitstatus
       end
     end
 
@@ -104,8 +107,11 @@ class Onceover
         #`bundle install --binstubs`
         #`bin/rake spec_standalone`
         logger.debug "Running #{@command_prefix}rake acceptance from #{@repo.tempdir}"
-        Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'acceptance').join
+        result = Backticks::Runner.new(interactive:true).run(@command_prefix.strip.split, 'rake', 'acceptance').join
       end
+
+      # Finally exit and preserve the exit code
+      exit result.status.exitstatus
     end
   end
 end

data/onceover.gemspec

@@ -4,7 +4,7 @@ $LOAD_PATH.unshift File.expand_path("../lib", __FILE__)
 
 Gem::Specification.new do |s|
   s.name        = "onceover"
-  s.version     = "3.11.0"
+  s.version     = "3.11.1"
   s.authors     = ["Dylan Ratcliffe"]
   s.email       = ["dylan.ratcliffe@puppet.com"]
   s.homepage    = "https://github.com/dylanratcliffe/onceover"

data/spec/fixtures/controlrepos/function_mocking/site/role/manifests/fail.pp

@@ -0,0 +1,7 @@
+# Class: role::fail
+#
+#
+class role::fail {
+  user ( derp, this is not valid )
+  how do Puppet?
+}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: onceover
 version: !ruby/object:Gem::Version
-  version: 3.11.0
+  version: 3.11.1
 platform: ruby
 authors:
 - Dylan Ratcliffe
@@ -411,6 +411,7 @@ files:
 - spec/fixtures/controlrepos/function_mocking/site/profile/functions/fail_puppet.pp
 - spec/fixtures/controlrepos/function_mocking/site/profile/lib/puppet/functions/profile/fail_ruby.rb
 - spec/fixtures/controlrepos/function_mocking/site/profile/manifests/base.pp
+- spec/fixtures/controlrepos/function_mocking/site/role/manifests/fail.pp
 - spec/fixtures/controlrepos/function_mocking/site/role/manifests/test_data_return.pp
 - spec/fixtures/controlrepos/function_mocking/site/role/manifests/test_new_functions.pp
 - spec/fixtures/controlrepos/function_mocking/spec/onceover.yaml