onceover-codequality 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 05b4b045d5c1f2c0629b1491cbb69b297e0cf81febbc48e9ea0f0a3257f94ca5
-  data.tar.gz: d185ea9bdb68f25b039c0fa075029af670e74b53269d44618b14bdca75e60b54
+  metadata.gz: fe144a873aa69c717b5753eb7a3b4abb152c591141f592d19561b3a438d5e492
+  data.tar.gz: 35d0b274abb8378261972c94814aa05bf9c85f0f6db98dbbaae2ab1ea29c7689
 SHA512:
-  metadata.gz: ffca9f5955db6be466d3d62400c07123bf00c07f05685263abd3f269604f872ab83907a22dac60f87a0c24f12ccfb6ff9571d83d7b60f2e5295a095b1c891390
-  data.tar.gz: d282f5b85bb63312bd89747f3c1c64a317830405b368c3faf44057f18c137d01ba3c7bbce444db34dc56051942eb160e239d71b784f6f7ad284a5ee145ed2d5c
+  metadata.gz: f4b9529fcf02d3ae4b769a4a09723216f94c7aa78d3461dd8fa33b9bd562ddf6dd061732102977c4916fc55544cff9eb8e6624402aaa1e0e92398d32baa50437
+  data.tar.gz: a99f4b38979decc2f7fc9295e9374a9cd15db03a906bdfa46f15491ab63562f88248b4ec513be7b0fb42e8f7496d7799ccdc898bba38f2da3c5b477899f7fcb4

data/README.md

@@ -57,6 +57,11 @@ $ onceover run codequality --no_puppetfile
 $ onceover run codequality --no_doc
 ```
 
+**Use custom lint settings**
+Create a file `puppet-lint.rc` in the directory you run `onceover codequality`
+from and it will be automatically used by Puppet Lint. If missing, the built-in
+defaults from `lib/onceover/codequality/lint.rb` will be used. 
+
 
 ## Sample output
 

data/lib/onceover/codequality/cli.rb

@@ -28,6 +28,15 @@ class Onceover
               no_puppetfile = opts[:no_puppetfile] || false
               html_docs = opts[:html_docs] || false
               status = true
+
+              if ! no_syntax
+                logger.info "Checking syntax..."
+                if ! Onceover::CodeQuality::Syntax.puppet
+                  status = false
+                  logger.error "Syntax test failed, see previous errors"
+                end
+              end
+
               if ! no_lint
                 logger.info "Checking for lint..."
                 if ! Onceover::CodeQuality::Lint.puppet
@@ -44,14 +53,6 @@ class Onceover
                 end
               end
 
-              if ! no_syntax
-                logger.info "Checking syntax..."
-                if ! Onceover::CodeQuality::Syntax.puppet
-                  status = false
-                  logger.error "Syntax test failed, see previous errors"
-                end
-              end
-
               if ! no_docs
                 logger.info "Generating documentation..."
                 if ! Onceover::CodeQuality::Docs.puppet_strings(html_docs)

data/lib/onceover/codequality/lint.rb

@@ -7,14 +7,19 @@ class Onceover
         "manifests",
       ].concat(Dir.glob('site/*').select {|f| File.directory? f})
 
-      LINT_OPTIONS = [
-        "--relative",
-        "--fail-on-warnings",
-        "--no-double_quoted_strings-check",
-        "--no-80chars-check",
-        "--no-variable_scope-check",
-        "--no-quoted_booleans-check",
-      ]
+      # use our default options unless user has created own settings
+      if ! File.exist? ".puppet-lint.rc"
+        LINT_OPTIONS = [
+          "--relative",
+          "--fail-on-warnings",
+          "--no-double_quoted_strings-check",
+          "--no-80chars-check",
+          "--no-variable_scope-check",
+          "--no-quoted_booleans-check",
+        ].freeze
+      else
+        LINT_OPTIONS = [].freeze
+      end
 
       def self.puppet
         status = true

data/lib/onceover/codequality/version.rb

@@ -1,5 +1,5 @@
 class Onceover
   module CodeQuality
-    VERSION = "0.3.0"
+    VERSION = "0.4.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: onceover-codequality
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Declarative Systems
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-08-27 00:00:00.000000000 Z
+date: 2018-11-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler