once 0.0.1 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8172b01a3e28f6aaa417166e71b88c7172596863
-  data.tar.gz: 0ea53bf46f8db4fde91bccfecc8d070fb8a1df1b
+  metadata.gz: bc1dc66aa1467c67d46b20d62737dce0c95dc307
+  data.tar.gz: 18db88e365f371eab21b2bca55348e2db40d1f68
 SHA512:
-  metadata.gz: 88f0716b9fe70077e28bece1c4225a75becc08d0931ddcc768e12b401ddabcbe9355c24f4ce947c6b3bc86f30a8912ff078d12508b33041ea1a2fcb6caf9b3ce
-  data.tar.gz: 84235be3a2ad656371f0a430e5f0531ef5d7b9f3c5bec50ce0b93cf7d1fe57443134852635adc1f335bd14c78555d813f399f86254c1d57961e9472747034349
+  metadata.gz: 1c3ef2cc6f39da8ee988767b3af06872086ced4f20639d4c356ca7893169e328d73bad675aa3b227ea3993695d8ec90c6351ecd98c65ad695001aab0c5d8e25f
+  data.tar.gz: c79340580c1018db34d175055d48170a3300388e03b84c5d205456da408512fbdcc5213ec2512aa39cb61999e609075d28f553aed2920e52b845527298206031

data/.ruby-gemset

@@ -0,0 +1 @@
+once

data/CHANGELOG.md

@@ -0,0 +1,6 @@
+## 0.0.3
+* Atomic setex insted of set and expire commands individually
+* Return results of the executed block
+
+## 0.0.1
+* Initial release

data/lib/once.rb

@@ -13,7 +13,7 @@ require 'digest'
 #     .. stuff that should happen only once ..
 #   end
 #
-# The combination of the name and params makes the check unique. So typically it would be the 
+# The combination of the name and params makes the check unique. So typically it would be the
 # command you're executing, plus the params to that command
 module Once
   DEFAULT_TIME = 3600 # seconds
@@ -37,12 +37,17 @@ module Once
       hash = Digest::MD5.hexdigest(params.inspect)
       redis_key = "uniquecheck:#{name}:#{hash}"
 
+      perform(redis_key, &block).tap do
+        redis.setex(redis_key, within, true)
+      end
+    end
+
+    private
+
+    def perform(redis_key, &block)
       unless redis.exists(redis_key)
         block.call
       end
-
-      redis.set(redis_key, true)
-      redis.expire(redis_key, within)
     end
   end
 end

data/lib/once/version.rb

@@ -1,3 +1,3 @@
 module Once
-  VERSION = "0.0.1"
+  VERSION = "0.0.3"
 end

data/spec/once_spec.rb

@@ -8,7 +8,7 @@ describe Once do
     Once.redis = Redis.new
   end
 
-  let(:thing_to_execute)  { double(execute: nil) }
+  let(:thing_to_execute)  { double(execute: "foo") }
   let(:params) {{foo: "bar"}}
 
   it "executes the given command" do
@@ -19,6 +19,12 @@ describe Once do
     thing_to_execute.should have_received(:execute).once
   end
 
+  it "returns the result of the command" do
+    described_class.do(name: "mycheck", params: params) do
+      thing_to_execute.execute
+    end.should == "foo"
+  end
+
   it "executes when called from within different namespaces" do
     described_class.do(name: "mycheck1", params: params) do
       thing_to_execute.execute

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: once
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.3
 platform: ruby
 authors:
 - Yan Pritzker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-17 00:00:00.000000000 Z
+date: 2015-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -88,7 +88,9 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".ruby-gemset"
 - ".ruby-version"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md