once-ler 1.2.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 494ac049dd247bc5578276f65940cc08171bf71002937bfe3c8f14514433bdc5
-  data.tar.gz: 701e2e2d48d4243ea0d6ddc43f94f870d9ae36b8ec61330f17e45e8e47b0cdf8
+  metadata.gz: cd1f2be3add85a6cc1457b6c839adb76fbeb2f61269cfe1b4235824f0a93261d
+  data.tar.gz: 8b843468d5fcd8706126e2471865c438df311942aa438b26b263361f9eace2d3
 SHA512:
-  metadata.gz: 6fa2391255b52c952b8fe9976310f937b2bf79a3e69836b2d10948faadee764ca9e92efa5d42aa14a31eee5b9b0a83cf7ee1c340caad79846f20cd321c937447
-  data.tar.gz: 6758091868cddcb4bf47d1e8122440e11ece9b58cb022e586dc142f9bcd629a4354645f71d102d9247c83dba27b22dce4abbc1b18ce37ac9f4d6af50a363c5c1
+  metadata.gz: 9fb8e9cd8a0186d980b0679609457c621fdca31018ced649fa0ae685cf2a9de5df1e0233ff4ed420aee873bc2f61b827d763a7eb45d0203d289a5039d0e61fd8
+  data.tar.gz: 0d2b59543918dfa2bda68a96a81ee68e9aab2f97ce74d7911a00a59e53eefaf2de87ec59f4cb6895015bd5ae5aefb57027e0b4058bfaa1bfb8c1e7f294a5b9c0

data/README.md

@@ -129,8 +129,7 @@ of activerecord callbacks/inserts/updates.
 ## Caveats
 
 * If you are doing anything database-y, you need to use transactional
-  tests (either via `use_transactional_fixtures=true`, or something like
-  [database_cleaner](https://github.com/DatabaseCleaner/database_cleaner))
+  test via `use_transactional_fixtures=true`
 * Your once'd blocks should have no side effects other than database
   statements, return values, and instance variables.
 * Your return values and instance variables:

data/lib/onceler/basic_helpers.rb

@@ -113,21 +113,6 @@ module Onceler
         superclass.onceler
       end
 
-      # Set this if you have multiple (or different) conns you will be
-      # once-ler'ing. Can either be an enumerable, or a proc that returns
-      # one. Note that if given a proc, it will only be called once (the
-      # first time it's needed) and cached after that.
-      #
-      # context "Foo" do
-      #   self.onceler_connections = -> { [Foo.connection] }
-      #   ...
-      attr_writer :onceler_connections
-      def onceler_connections
-        @onceler_connections ||= [ActiveRecord::Base.connection]
-        @onceler_connections = instance_eval(&@onceler_connections) if @onceler_connections.respond_to?(:call)
-        @onceler_connections
-      end
-
       private
 
       def add_onceler_hooks!

data/lib/onceler/recorder.rb

@@ -1,16 +1,7 @@
 require "onceler/recordable"
-require "onceler/transactions"
 
 module Onceler
   class << self
-    def open_transactions
-      @open_transactions ||= 0
-    end
-
-    def open_transactions=(val)
-      @open_transactions = val
-    end
-
     attr_accessor :recording
 
     def recording?
@@ -19,8 +10,6 @@ module Onceler
   end
 
   class Recorder
-    include Transactions
-
     attr_accessor :tape
 
     def initialize(group_class)
@@ -61,8 +50,8 @@ module Onceler
 
     def record!
       Onceler.recording = true
-      begin_transactions!
       @tape = @group_class.new
+      @tape.setup_fixtures
       @tape.send :extend, Recordable
       @tape.copy_from(parent_tape) if parent_tape
 
@@ -92,7 +81,7 @@ module Onceler
 
     def reset!
       run_before_hooks(:reset)
-      rollback_transactions!
+      @tape&.teardown_fixtures
       run_after_hooks(:reset)
     end
 
@@ -135,25 +124,6 @@ module Onceler
         instance.instance_variable_set(key, value)
       end
     end
-
-    def transactional_connections
-      @group_class.onceler_connections
-    end
-
-    def begin_transactions!
-      Onceler.open_transactions += 1
-      transactional_connections.each do |connection|
-        begin_transaction(connection)
-      end
-    end
-
-    def rollback_transactions!
-      transactional_connections.each do |connection|
-        rollback_transaction(connection)
-      end
-    ensure
-      Onceler.open_transactions -= 1
-    end
   end
 
   class Recording

data/lib/onceler.rb

@@ -4,11 +4,3 @@ require "rubygems"
 require "onceler/basic_helpers"
 require "onceler/configuration"
 require "onceler/extensions/active_record"
-
-if defined?(DatabaseCleaner)
-  unless !DatabaseCleaner.const_defined?("VERSION") ||
-    Gem::Requirement.new(">= 1.7").satisfied_by?(Gem::Version.new(DatabaseCleaner::VERSION))
-    raise "Onceler in only compatible with DatabaseCleaner >= 1.7."
-  end
-  require "onceler/extensions/database_cleaner"
-end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: once-ler
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 2.0.0
 platform: ruby
 authors:
 - Jon Jensen
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-07-13 00:00:00.000000000 Z
+date: 2022-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,7 +16,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.2'
@@ -26,7 +26,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '5.2'
+        version: '6.0'
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.2'
@@ -44,6 +44,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '3.6'
+- !ruby/object:Gem::Dependency
+  name: rspec-rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '4.0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -86,11 +100,8 @@ files:
 - lib/onceler/basic_helpers.rb
 - lib/onceler/configuration.rb
 - lib/onceler/extensions/active_record.rb
-- lib/onceler/extensions/database_cleaner.rb
 - lib/onceler/recordable.rb
 - lib/onceler/recorder.rb
-- lib/onceler/transactions.rb
-- lib/onceler/transactions/active_record.rb
 homepage: http://github.com/instructure/once-ler
 licenses:
 - MIT
@@ -110,7 +121,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: 2.6.0
 requirements: []
-rubygems_version: 3.2.15
+rubygems_version: 3.1.4
 signing_key:
 specification_version: 4
 summary: rspec supercharger

data/lib/onceler/extensions/database_cleaner.rb

@@ -1,13 +0,0 @@
-require "database_cleaner/active_record/transaction"
-
-class DatabaseCleaner::ActiveRecord::Transaction
-  include ::Onceler::Transactions
-
-  def start
-    begin_transaction(connection_class.connection)
-  end
-
-  def clean
-    rollback_transaction(connection_class.connection)
-  end
-end

data/lib/onceler/transactions/active_record.rb

@@ -1,11 +0,0 @@
-module Onceler
-  module Transactions
-    def begin_transaction(conn)
-      conn.begin_transaction joinable: false
-    end
-
-    def rollback_transaction(conn)
-      conn.rollback_transaction
-    end
-  end
-end

data/lib/onceler/transactions.rb

@@ -1,2 +0,0 @@
-require "active_record"
-require "onceler/transactions/active_record"