once-ler 0.0.6 → 0.0.7

data/README.md

@@ -60,6 +60,12 @@ RSpec.configure do |c|
 end
 ```
 
+## How much of a speedup will I get?
+
+YMMV, it depends on how bad your `let`s/`before`s are. For example,
+adding once-ler to a subset of [canvas-lms](https://github.com/instructure/canvas-lms)'s
+model specs (spec/models/a*) **reduces their runtime by 40%**.
+
 ## How does it work?
 
 Any `before(:once)`/`let_once` blocks will run just once for the current

data/lib/onceler/basic_helpers.rb

@@ -76,30 +76,16 @@ module Onceler
 
       def create_onceler!
         add_onceler_hooks!
-        Recorder.new(parent_onceler)
+        Recorder.new(self)
       end
 
-      # make sure we have access to subsequently added methods when
-      # recording (not just `lets'). note that this really only works
-      # for truly functional methods with no external dependencies. e.g.
-      # methods that add stubs or set instance variables will not work
-      # while recording
-      def method_added(method_name)
-        return if method_name == @current_let_once
-        return if !@onceler
-        proxy = onceler.helper_proxy ||= new
-        onceler.helper_methods[method_name] ||= Proc.new do |*args|
-          proxy.send method_name, *args
-        end
-      end
-
-      private
-
       def parent_onceler
         return unless superclass.respond_to?(:onceler)
         superclass.onceler
       end
 
+      private
+
       def add_onceler_hooks!
         before(:all) do |group|
           Onceler.configuration.run_callbacks(:record, :before)

data/lib/onceler/configuration.rb

@@ -8,14 +8,6 @@ module Onceler
   end
 
   class Configuration
-    def modules
-      @modules ||= []
-    end
-
-    def include(mod)
-      modules << mod
-    end
-
     def before(scope, &block)
       callbacks[scope][:before] << block
     end

data/lib/onceler/{blank_tape.rb → recordable.rb}

@@ -1,9 +1,11 @@
 module Onceler
-  class BlankTape
-    def initialize(modules)
-      modules.each { |mod| extend mod }
-      @__retvals = {}
-      @__retvals_recorded = {} # we might override an inherited one, so we need to differentiate
+  module Recordable
+    def self.extended(instance)
+      instance.instance_eval do
+        @__retvals = {}
+        @__retvals_recorded = {} # we might override an inherited one, so we need to differentiate
+        @__ignore_ivars = instance_variables
+      end
     end
 
     def __prepare_recording(recording)
@@ -23,10 +25,12 @@ module Onceler
     end
 
     def __ivars
-      ivars = instance_variables - [:@__retvals, :@__retvals_recorded]
+      ivars = instance_variables - @__ignore_ivars
       ivars.inject({}) do |hash, key|
-        val = instance_variable_get(key)
-        hash[key] = val
+        if key.to_s !~ /\A@__/
+          val = instance_variable_get(key)
+          hash[key] = val
+        end
         hash
       end
     end
@@ -35,12 +39,6 @@ module Onceler
       @__data ||= Marshal.dump([__ivars, @__retvals])
     end
 
-    def copy(mixins)
-      copy = self.class.new(mixins)
-      copy.copy_from(self)
-      copy
-    end
-
     def copy_from(other)
       ivars, @__retvals = Marshal.load(other.__data)
       ivars.each do |key, value|

data/lib/onceler/recorder.rb

@@ -1,4 +1,4 @@
-require "onceler/blank_tape"
+require "onceler/recordable"
 require "onceler/transactions"
 
 module Onceler
@@ -7,8 +7,8 @@ module Onceler
 
     attr_accessor :tape, :helper_proxy
 
-    def initialize(parent)
-      @parent = parent
+    def initialize(group_class)
+      @group_class = group_class
       @recordings = []
       @named_recordings = []
     end
@@ -28,8 +28,11 @@ module Onceler
 
     def record!
       begin_transactions!
-      @tape = @parent ? @parent.tape.copy(mixins) : BlankTape.new(mixins)
-      proxy_recordable_methods!
+      @tape = @group_class.new
+      @tape.send :extend, Recordable
+      if parent = @group_class.parent_onceler
+        @tape.copy_from(parent.tape)
+      end
 
       # we don't know the order named recordings will be called (or if
       # they'll call each other), so prep everything first
@@ -46,37 +49,6 @@ module Onceler
       rollback_transactions!
     end
 
-    def proxy_recordable_methods!
-      # the proxy is used to run non-recordable methods that may be called
-      # by ones are recording. since the former could in turn call more of
-      # the latter, we need to proxy the other way too
-      return unless helper_proxy
-      methods = @named_recordings
-      reverse_proxy = @tape
-      helper_proxy.instance_eval do
-        methods.each do |method|
-          define_singleton_method(method) { reverse_proxy.send(method) }
-        end
-      end
-    end
-
-    def helper_methods
-      @helper_methods ||= {}
-    end
-
-    def mixins
-      mixins = (@parent ? @parent.mixins : Onceler.configuration.modules).dup
-      if methods = @helper_methods
-        mixin = Module.new do
-          methods.each do |key, method|
-            define_method(key, &method)
-          end
-        end
-        mixins.push mixin
-      end
-      mixins
-    end
-
     def reconsitute_data!
       @ivars, @retvals = Marshal.load(@data)
       identity_map = {}

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: once-ler
 version: !ruby/object:Gem::Version
-  version: 0.0.6
+  version: 0.0.7
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-28 00:00:00.000000000 Z
+date: 2014-06-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -54,13 +54,13 @@ files:
 - lib/once-ler.rb
 - lib/onceler/ambitious_helpers.rb
 - lib/onceler/basic_helpers.rb
-- lib/onceler/blank_tape.rb
 - lib/onceler/configuration.rb
 - lib/onceler/extensions/active_record.rb
 - lib/onceler/extensions/active_record_3_0.rb
 - lib/onceler/extensions/active_record_3_2.rb
 - lib/onceler/extensions/active_record_4_0.rb
 - lib/onceler/extensions/active_record_4_1.rb
+- lib/onceler/recordable.rb
 - lib/onceler/recorder.rb
 - lib/onceler/transactions/active_record_3.rb
 - lib/onceler/transactions/active_record_4.rb