on_the_spot 1.1.0 → 1.1.2

data/app/assets/javascripts/on_the_spot.js

@@ -3,6 +3,6 @@
 // now you can use just write
 //    javascript_include_tag :on_the_spot
 //
-//= require jquery.jeditable.mini.js
+//= require jquery.jeditable.js
 //= require jquery.jeditable.checkbox.js
 //= require on_the_spot_code

data/app/assets/javascripts/on_the_spot_code.js

@@ -1,4 +1,6 @@
-$(document).on("ready page:load turbolinks:load", function() {
+
+function generalOnTheSpotInitializer() {
+    //console.log("Init-on-the-spot ...")
 
     $(".on_the_spot_editing").mouseover(function() {
 		$(this).addClass('on_the_spot_over');
@@ -6,9 +8,19 @@ $(document).on("ready page:load turbolinks:load", function() {
     $(".on_the_spot_editing").mouseout(function() {
 		$(this).removeClass('on_the_spot_over');
     });
+
     $('.on_the_spot_editing').each(initializeOnTheSpot);
+}
+
+if (typeof Turbolinks == "undefined") {
+    $(function() {
+        generalOnTheSpotInitializer();
+    });
+} else {
+    $(document).on("turbolinks:load", generalOnTheSpotInitializer )
+}
+
 
-});
 
 function initializeOnTheSpot(n){
     var el            = $(this),

data/lib/on_the_spot/on_the_spot_helpers.rb

@@ -81,11 +81,9 @@ module OnTheSpot
     end
 
     def convert_array_to_json(id_value_array, selected_id)
-      conv_arr = id_value_array.map{|idv| "'#{idv[0]}':'#{escape_javascript(idv[1])}'" }
-      result = "{ #{conv_arr.join(', ')}"
-      result += ", 'selected':'#{ selected_id.to_s}'" unless selected_id.nil?
-      result += "}"
-      result
+      result = id_value_array.to_h
+      result['selected'] = selected_id unless selected_id.nil?
+      result.to_json
     end
 
   end

data/on_the_spot.gemspec

@@ -2,18 +2,18 @@
 # DO NOT EDIT THIS FILE DIRECTLY
 # Instead, edit Jeweler::Tasks in Rakefile, and run 'rake gemspec'
 # -*- encoding: utf-8 -*-
-# stub: on_the_spot 1.1.0 ruby lib
+# stub: on_the_spot 1.1.2 ruby lib
 
 Gem::Specification.new do |s|
-  s.name = "on_the_spot"
-  s.version = "1.1.0"
+  s.name = "on_the_spot".freeze
+  s.version = "1.1.2"
 
-  s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
-  s.require_paths = ["lib"]
-  s.authors = ["Nathan Van der Auwera"]
-  s.date = "2018-03-18"
-  s.description = "Unobtrusive in place editing, using jEditable; only works in Rails 3"
-  s.email = "nathan@dixis.com"
+  s.required_rubygems_version = Gem::Requirement.new(">= 0".freeze) if s.respond_to? :required_rubygems_version=
+  s.require_paths = ["lib".freeze]
+  s.authors = ["Nathan Van der Auwera".freeze]
+  s.date = "2018-05-25"
+  s.description = "Unobtrusive in place editing, using jEditable; only works in Rails 3".freeze
+  s.email = "nathan@dixis.com".freeze
   s.extra_rdoc_files = [
     "LICENSE",
     "README.markdown"
@@ -24,7 +24,6 @@ Gem::Specification.new do |s|
     ".rspec",
     ".travis.yml",
     "Gemfile",
-    "Gemfile.lock",
     "History.md",
     "LICENSE",
     "README.markdown",
@@ -32,6 +31,7 @@ Gem::Specification.new do |s|
     "VERSION",
     "app/assets/css/on_the_spot.css",
     "app/assets/javascripts/jquery.jeditable.checkbox.js",
+    "app/assets/javascripts/jquery.jeditable.js",
     "app/assets/javascripts/jquery.jeditable.mini.js",
     "app/assets/javascripts/on_the_spot.js",
     "app/assets/javascripts/on_the_spot_code.js",
@@ -82,27 +82,27 @@ Gem::Specification.new do |s|
     "spec/on_the_spot_spec.rb",
     "spec/spec_helper.rb"
   ]
-  s.homepage = "http://github.com/nathanvda/on_the_spot"
-  s.licenses = ["MIT"]
-  s.rubygems_version = "2.4.5"
-  s.summary = "unobtrusive in place editing"
+  s.homepage = "http://github.com/nathanvda/on_the_spot".freeze
+  s.licenses = ["MIT".freeze]
+  s.rubygems_version = "2.6.14".freeze
+  s.summary = "unobtrusive in place editing".freeze
 
   if s.respond_to? :specification_version then
     s.specification_version = 4
 
     if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
-      s.add_development_dependency(%q<rspec>, [">= 2.6.0"])
-      s.add_development_dependency(%q<actionpack>, [">= 3.0.0"])
-      s.add_runtime_dependency(%q<json_pure>, [">= 1.4.6"])
+      s.add_development_dependency(%q<rspec>.freeze, [">= 2.6.0"])
+      s.add_development_dependency(%q<actionpack>.freeze, [">= 3.0.0"])
+      s.add_runtime_dependency(%q<json_pure>.freeze, [">= 1.4.6"])
     else
-      s.add_dependency(%q<rspec>, [">= 2.6.0"])
-      s.add_dependency(%q<actionpack>, [">= 3.0.0"])
-      s.add_dependency(%q<json_pure>, [">= 1.4.6"])
+      s.add_dependency(%q<rspec>.freeze, [">= 2.6.0"])
+      s.add_dependency(%q<actionpack>.freeze, [">= 3.0.0"])
+      s.add_dependency(%q<json_pure>.freeze, [">= 1.4.6"])
     end
   else
-    s.add_dependency(%q<rspec>, [">= 2.6.0"])
-    s.add_dependency(%q<actionpack>, [">= 3.0.0"])
-    s.add_dependency(%q<json_pure>, [">= 1.4.6"])
+    s.add_dependency(%q<rspec>.freeze, [">= 2.6.0"])
+    s.add_dependency(%q<actionpack>.freeze, [">= 3.0.0"])
+    s.add_dependency(%q<json_pure>.freeze, [">= 1.4.6"])
   end
 end
 

data/spec/generators/install_generator_spec.rb

@@ -15,18 +15,18 @@ describe OnTheSpot::Generators::InstallGenerator do
   context "in rails 3.0" do
     context "with no arguments" do
       before(:each) do
-        Rails.stub(:version) { '3.0.8' }
+        allow(Rails).to receive(:version) { '3.0.8' }
         prepare_destination
         run_generator
       end
 
       it "stubs the version correctly" do
-        Rails.version[0..2].should == "3.0"
+        expect(Rails.version[0..2]).to eq("3.0")
       end
 
       it "stubs the version correctly" do
         test_version = (Rails.version[0..2].to_f >= 3.1)
-        test_version.should be_false
+        expect(test_version).to eq(false)
       end
 
       ['on_the_spot.js', 'jquery.jeditable.mini.js', 'jquery.jeditable.checkbox.js'].each do |js_file|
@@ -44,7 +44,7 @@ describe OnTheSpot::Generators::InstallGenerator do
   context "in rails 3.1" do
     context "with no arguments" do
       before(:each) do
-        Rails.stub(:version) { '3.1.0' }
+        allow(Rails).to receive(:version) { '3.1.0' }
         prepare_destination
         run_generator
       end

data/spec/on_the_spot_spec.rb

@@ -3,7 +3,7 @@ require 'on_the_spot/on_the_spot_helpers'
 
 require 'action_controller'
 
-describe "OnTheSpot" do
+RSpec.describe "OnTheSpot" do
   describe "Helpers" do
     before(:each) do
 
@@ -18,151 +18,151 @@ describe "OnTheSpot" do
 
     context "lookup values from array" do
       it "should find value abc for key 1" do
-        @tester.lookup_display_value(@test_array_nr, 1).should == 'abc'
+        expect(@tester.lookup_display_value(@test_array_nr, 1)).to eq('abc')
       end
 
       it "should find value <value2> for key key2" do
-        @tester.lookup_display_value(@test_array_str, 'key2').should == 'value2'
+        expect(@tester.lookup_display_value(@test_array_str, 'key2')).to eq('value2')
       end
 
       it "should return an empty string if key does not exist" do
-        @tester.lookup_display_value(@test_array_str, 'key1').should == ''
+        expect(@tester.lookup_display_value(@test_array_str, 'key1')).to eq('')
       end
 
       it "can handle single quotes normally" do
-        @tester.lookup_display_value(@test_array_nr, 4).should == "Freddy's Nightmare"
+        expect(@tester.lookup_display_value(@test_array_nr, 4)).to eq("Freddy's Nightmare")
       end
 
     end
 
     context "convert array to json" do
       it "should convert correctly" do
-        @tester.convert_array_to_json(@test_array_nr, 1).should == "{ '1':'abc', '2':'def', '3':'ghi', '4':'Freddy\\'s Nightmare', 'selected':'1'}"
+        expect(@tester.convert_array_to_json(@test_array_nr, 1)).to eq("{\"1\":\"abc\",\"2\":\"def\",\"3\":\"ghi\",\"4\":\"Freddy's Nightmare\",\"selected\":1}")
       end
 
       it "convert an array containing an item with single quotes to valid JSON" do
         test_array_with_single_quote = [[1, "tree"], [2, "bike"], [3, "John's hat"]]
         json_str = @tester.convert_array_to_json(test_array_with_single_quote, 1)
-        json_str.should == "{ '1':'tree', '2':'bike', '3':'John\\'s hat', 'selected':'1'}"
+        expect(json_str).to  eq("{\"1\":\"tree\",\"2\":\"bike\",\"3\":\"John's hat\",\"selected\":1}")
       end
     end
 
     context "the helpers" do
       before(:each) do
-        @dummy = mock()
-        @dummy.stub!(:content).and_return('test')
-        @dummy.stub!(:id).and_return('123')
-        @tester.should_receive(:t).with('on_the_spot.ok').and_return("ok")
-        @tester.should_receive(:t).with('on_the_spot.cancel').and_return("cancel")
-        @tester.should_receive(:t).with('on_the_spot.tooltip').and_return("tooltip")
+        @dummy = double()
+        allow(@dummy).to receive(:content).and_return('test')
+        allow(@dummy).to receive(:id).and_return('123')
+        expect(@tester).to receive(:t).with('on_the_spot.ok').and_return("ok")
+        expect(@tester).to receive(:t).with('on_the_spot.cancel').and_return("cancel")
+        expect(@tester).to receive(:t).with('on_the_spot.tooltip').and_return("tooltip")
       end
 
       context "with standard route" do
         before(:each) do
-          @tester.should_receive(:url_for).with({:action => 'update_attribute_on_the_spot'}).and_return('/bla')
+          expect(@tester).to receive(:url_for).with({:action => 'update_attribute_on_the_spot'}).and_return('/bla')
         end
 
         it "makes the correct html for an edit-field" do
           @result = @tester.on_the_spot_edit @dummy, :content
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\">test</span>")
         end
 
         it "makes the correct html for an edit-field with text selected on click" do
           @result = @tester.on_the_spot_edit @dummy, :content, :selected => true
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-ok=\"ok\" data-selected=\"true\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-selected=\"true\">test</span>")
         end
 
         it "makes the correct html for an edit-field and overrule display-text" do
           @result = @tester.on_the_spot_edit @dummy, :content, :display_text => 'jediknight'
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">jediknight</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\">jediknight</span>")
         end
 
         it "makes the correct html for an edit-field and use the display-method as string" do
-          @dummy.should_receive(:changed_content).and_return("test-changed")
-          @tester.should_receive(:url_for).with({:action => 'get_attribute_on_the_spot'}).and_return('/bla-again')
+          expect(@dummy).to receive(:changed_content).and_return("test-changed")
+          expect(@tester).to receive(:url_for).with({:action => 'get_attribute_on_the_spot'}).and_return('/bla-again')
 
           @result = @tester.on_the_spot_edit @dummy, :content, :display_method => 'changed_content'
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-display-method=\"changed_content\" data-loadurl=\"/bla-again\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test-changed</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-display-method=\"changed_content\" data-loadurl=\"/bla-again\">test-changed</span>")
         end
 
         it "makes the correct html for an edit-field and use the display-method (as symbol)" do
-          @dummy.should_receive(:changed_content).and_return("test-changed")
-          @tester.should_receive(:url_for).with({:action => 'get_attribute_on_the_spot'}).and_return('/bla-again')
+          allow(@dummy).to receive(:changed_content).and_return("test-changed")
+          allow(@tester).to receive(:url_for).with({:action => 'get_attribute_on_the_spot'}).and_return('/bla-again')
 
           @result = @tester.on_the_spot_edit @dummy, :content, :display_method => :changed_content
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-display-method=\"changed_content\" data-loadurl=\"/bla-again\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test-changed</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-display-method=\"changed_content\" data-loadurl=\"/bla-again\">test-changed</span>")
         end
 
 
         it "makes the correct html for a text-area" do
           @result = @tester.on_the_spot_edit @dummy, :content, :type => :textarea
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-columns=\"40\" data-edittype=\"textarea\" data-ok=\"ok\" data-rows=\"5\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-edittype=\"textarea\" data-rows=\"5\" data-columns=\"40\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\">test</span>")
         end
 
         it "makes the correct html for a text-area with text selected on click" do
           @result = @tester.on_the_spot_edit @dummy, :content, :type => :textarea, :selected => true
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-columns=\"40\" data-edittype=\"textarea\" data-ok=\"ok\" data-rows=\"5\" data-selected=\"true\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-edittype=\"textarea\" data-rows=\"5\" data-columns=\"40\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-selected=\"true\">test</span>")
         end
 
         it "makes the correct html for a select-box" do
           @result = @tester.on_the_spot_edit @dummy, :content, :type => :select, :data => [['test', 'This a test'], ['prod', 'Pure Production'], ['QA', 'Quality Assurance']]
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-edittype=\"select\" data-ok=\"ok\" data-select=\"{ 'test':'This a test', 'prod':'Pure Production', 'QA':'Quality Assurance', 'selected':'test'}\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">This a test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-edittype=\"select\" data-select=\"{&quot;test&quot;:&quot;This a test&quot;,&quot;prod&quot;:&quot;Pure Production&quot;,&quot;QA&quot;:&quot;Quality Assurance&quot;,&quot;selected&quot;:&quot;test&quot;}\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\">This a test</span>")
         end
 
         it "makes the correct html for a checkbox" do
-          @dummy.stub!(:content).and_return(true)
+          expect(@dummy).to receive(:content).and_return(true)
           @result = @tester.on_the_spot_edit @dummy, :content, :type => :checkbox
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-edittype=\"checkbox\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">true</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-edittype=\"checkbox\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\">true</span>")
         end
 
         it "makes the correct html for an edit-field with a callback" do
           @result = @tester.on_the_spot_edit @dummy, :content, :callback => 'testCallback(value, settings);'
-          @result.should == "<span class=\"on_the_spot_editing\" data-callback=\"testCallback(value, settings);\" data-cancel=\"cancel\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-callback=\"testCallback(value, settings);\">test</span>")
         end
 
         it "makes the correct html for an edit-field with an onblur action" do
           @result = @tester.on_the_spot_edit @dummy, :content, :onblur => 'submit'
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-ok=\"ok\" data-onblur=\"submit\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-onblur=\"submit\">test</span>")
         end
 
         it "makes the correct html for an edit-field with a loadurl" do
           @result = @tester.on_the_spot_edit @dummy, :content, :loadurl => '/load/data'
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-loadurl=\"/load/data\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-loadurl=\"/load/data\">test</span>")
         end
 
         context "a select-box with a loadurl" do
           it "makea the correct html (and not look up the value)" do
             @result = @tester.on_the_spot_edit @dummy, :content, :type => :select, :loadurl => '/load/data'
-            @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-edittype=\"select\" data-loadurl=\"/load/data\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+            expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-edittype=\"select\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-loadurl=\"/load/data\">test</span>")
           end
 
           it "use the display-text preferrably" do
             @result = @tester.on_the_spot_edit @dummy, :content, :type => :select, :loadurl => '/load/data', :display_text => 'ninja'
-            @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-edittype=\"select\" data-loadurl=\"/load/data\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">ninja</span>"
+            expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-edittype=\"select\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\" data-loadurl=\"/load/data\">ninja</span>")
           end
         end
       end
 
       context "with explicit route" do
         before(:each) do
-          @tester.should_receive(:url_for).with({:action => 'update_it_otherwise'}).and_return('/bla')
+          allow(@tester).to receive(:url_for).with({:action => 'update_it_otherwise'}).and_return('/bla')
         end
 
         it "make the correct html for an edit-field" do
           @result = @tester.on_the_spot_edit @dummy, :content, :url => {:action => 'update_it_otherwise' }
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla\" id=\"r_spec/mocks/mock__content__123\">test</span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\">test</span>")
         end
       end
 
       context "with raw parameter" do
         before(:each) do
-          @tester.should_receive(:url_for).with({:action => 'update_attribute_on_the_spot', :raw => true}).and_return('/bla?raw=true')
+          allow(@tester).to receive(:url_for).with({:action => 'update_attribute_on_the_spot', :raw => true}).and_return('/bla?raw=true')
         end
 
         it "supports raw html" do
-          @dummy.stub!(:content).and_return('<b>test</b>')
+          allow(@dummy).to receive(:content).and_return('<b>test</b>')
           @result = @tester.on_the_spot_edit @dummy, :content, :raw => true
-          @result.should == "<span class=\"on_the_spot_editing\" data-cancel=\"cancel\" data-ok=\"ok\" data-tooltip=\"tooltip\" data-url=\"/bla?raw=true\" id=\"r_spec/mocks/mock__content__123\"><b>test</b></span>"
+          expect(@result).to eq("<span id=\"r_spec/mocks/double__content__123\" class=\"on_the_spot_editing\" data-url=\"/bla?raw=true\" data-ok=\"ok\" data-cancel=\"cancel\" data-tooltip=\"tooltip\"><b>test</b></span>")
         end
       end
     end

data/spec/spec_helper.rb

@@ -1,13 +1,13 @@
 # Configure Rails Envinronment
 ENV["RAILS_ENV"] = "test"
+if ENV["COVERAGE"]
+  require 'simplecov'
+  SimpleCov.start 'rails'
+end
 
 require File.expand_path("../dummy/config/environment.rb",  __FILE__)
-require "rails/test_help"
 require "rspec/rails"
 require "rspec/mocks"
-require 'simplecov'
-
-SimpleCov.start 'rails'
 
 ActionMailer::Base.delivery_method = :test
 ActionMailer::Base.perform_deliveries = true
@@ -34,7 +34,5 @@ RSpec.configure do |config|
 
   # == Mock Framework
   config.mock_with :rspec
-
-  config.color_enabled = true
 end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: on_the_spot
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.2
 platform: ruby
 authors:
 - Nathan Van der Auwera
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-18 00:00:00.000000000 Z
+date: 2018-05-25 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rspec
@@ -65,7 +65,6 @@ files:
 - ".rspec"
 - ".travis.yml"
 - Gemfile
-- Gemfile.lock
 - History.md
 - LICENSE
 - README.markdown
@@ -73,6 +72,7 @@ files:
 - VERSION
 - app/assets/css/on_the_spot.css
 - app/assets/javascripts/jquery.jeditable.checkbox.js
+- app/assets/javascripts/jquery.jeditable.js
 - app/assets/javascripts/jquery.jeditable.mini.js
 - app/assets/javascripts/on_the_spot.js
 - app/assets/javascripts/on_the_spot_code.js
@@ -142,7 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: unobtrusive in place editing

data/Gemfile.lock

@@ -1,176 +0,0 @@
-GEM
-  remote: http://rubygems.org/
-  specs:
-    abstract (1.0.0)
-    actionmailer (3.0.9)
-      actionpack (= 3.0.9)
-      mail (~> 2.2.19)
-    actionpack (3.0.9)
-      activemodel (= 3.0.9)
-      activesupport (= 3.0.9)
-      builder (~> 2.1.2)
-      erubis (~> 2.6.6)
-      i18n (~> 0.5.0)
-      rack (~> 1.2.1)
-      rack-mount (~> 0.6.14)
-      rack-test (~> 0.5.7)
-      tzinfo (~> 0.3.23)
-    activemodel (3.0.9)
-      activesupport (= 3.0.9)
-      builder (~> 2.1.2)
-      i18n (~> 0.5.0)
-    activerecord (3.0.9)
-      activemodel (= 3.0.9)
-      activesupport (= 3.0.9)
-      arel (~> 2.0.10)
-      tzinfo (~> 0.3.23)
-    activeresource (3.0.9)
-      activemodel (= 3.0.9)
-      activesupport (= 3.0.9)
-    activesupport (3.0.9)
-    addressable (2.3.5)
-    arel (2.0.10)
-    builder (2.1.2)
-    capybara (2.5.0)
-      mime-types (>= 1.16)
-      nokogiri (>= 1.3.3)
-      rack (>= 1.0.0)
-      rack-test (>= 0.5.4)
-      xpath (~> 2.0)
-    diff-lcs (1.1.2)
-    erubis (2.6.6)
-      abstract (>= 1.0.0)
-    faraday (0.8.8)
-      multipart-post (~> 1.2.0)
-    generator_spec (0.8.3)
-      rails (~> 3.0)
-      rspec-rails
-    git (1.2.6)
-    github_api (0.10.1)
-      addressable
-      faraday (~> 0.8.1)
-      hashie (>= 1.2)
-      multi_json (~> 1.4)
-      nokogiri (~> 1.5.2)
-      oauth2
-    hashie (2.0.5)
-    highline (1.6.20)
-    httpauth (0.2.0)
-    i18n (0.5.0)
-    jeweler (1.8.8)
-      builder
-      bundler (~> 1.0)
-      git (>= 1.2.5)
-      github_api (= 0.10.1)
-      highline (>= 1.6.15)
-      nokogiri (= 1.5.10)
-      rake
-      rdoc
-    json (1.8.3)
-    json_pure (1.5.3)
-    jwt (0.1.8)
-      multi_json (>= 1.5)
-    mail (2.2.19)
-      activesupport (>= 2.3.6)
-      i18n (>= 0.4.0)
-      mime-types (~> 1.16)
-      treetop (~> 1.4.8)
-    mime-types (1.16)
-    multi_json (1.8.2)
-    multi_xml (0.5.5)
-    multipart-post (1.2.0)
-    nokogiri (1.5.10)
-    oauth2 (0.9.2)
-      faraday (~> 0.8)
-      httpauth (~> 0.2)
-      jwt (~> 0.1.4)
-      multi_json (~> 1.0)
-      multi_xml (~> 0.5)
-      rack (~> 1.2)
-    polyglot (0.3.1)
-    power_assert (0.2.4)
-    rack (1.2.3)
-    rack-mount (0.6.14)
-      rack (>= 1.0.0)
-    rack-test (0.5.7)
-      rack (>= 1.0)
-    rails (3.0.9)
-      actionmailer (= 3.0.9)
-      actionpack (= 3.0.9)
-      activerecord (= 3.0.9)
-      activeresource (= 3.0.9)
-      activesupport (= 3.0.9)
-      bundler (~> 1.0)
-      railties (= 3.0.9)
-    railties (3.0.9)
-      actionpack (= 3.0.9)
-      activesupport (= 3.0.9)
-      rake (>= 0.8.7)
-      rdoc (~> 3.4)
-      thor (~> 0.14.4)
-    rake (10.4.2)
-    rdoc (3.8)
-    rr (1.1.2)
-    rspec (2.6.0)
-      rspec-core (~> 2.6.0)
-      rspec-expectations (~> 2.6.0)
-      rspec-mocks (~> 2.6.0)
-    rspec-core (2.6.4)
-    rspec-expectations (2.6.0)
-      diff-lcs (~> 1.1.2)
-    rspec-mocks (2.6.0)
-    rspec-rails (2.6.1)
-      actionpack (~> 3.0)
-      activesupport (~> 3.0)
-      railties (~> 3.0)
-      rspec (~> 2.6.0)
-    simplecov (0.4.2)
-      simplecov-html (~> 0.4.4)
-    simplecov-html (0.4.5)
-    sqlite3 (1.3.3)
-    sqlite3-ruby (1.3.3)
-      sqlite3 (>= 1.3.3)
-    test-unit (3.1.3)
-      power_assert
-    test-unit-activesupport (1.0.4)
-      activesupport
-      test-unit
-    test-unit-capybara (1.0.4)
-      capybara (>= 2.1.0)
-      json
-      test-unit (>= 2.5.3)
-    test-unit-notify (1.0.4)
-      test-unit (>= 2.4.9)
-    test-unit-rails (1.0.4)
-      rails
-      test-unit-activesupport (>= 1.0.2)
-      test-unit-capybara
-      test-unit-notify
-      test-unit-rr
-    test-unit-rr (1.0.3)
-      rr (>= 1.1.1)
-      test-unit (>= 2.5.2)
-    thor (0.14.6)
-    treetop (1.4.9)
-      polyglot (>= 0.3.1)
-    tzinfo (0.3.29)
-    xpath (2.0.0)
-      nokogiri (~> 1.3)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  generator_spec
-  jeweler
-  json_pure
-  rails (>= 3.0.9)
-  rake
-  rspec (>= 2.6.0)
-  rspec-rails
-  simplecov
-  sqlite3-ruby
-  test-unit-rails
-
-BUNDLED WITH
-   1.10.6