omq 0.23.0 → 0.24.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 2a0e72756aae2179b8c790d5b65c54a82b516a17d11f760187a6fefecf6bf2c1
-  data.tar.gz: d6ce860b558977939b28c3d1f23d7bfc0740cf602fb63a519107a59cdca3c8c3
+  metadata.gz: ed87cc3a3243100b7977fd58f102b87918de8568cf8739642afc6377bb3f76e5
+  data.tar.gz: f01b30844ae48ffe26ec3934fef780521937a7611e1d00c87b333136fa5641ac
 SHA512:
-  metadata.gz: fa8a7c98147aa4f0fea5fad3004e8a964105a2005ed645d03b0fd1f0fba67bfc4952a3f4d14926fbaf4293efdcada93235b2ba59956737ef0ced5c1b97d35ea2
-  data.tar.gz: b5878650300c7135e04ec8fffcadef6d5101f77c8f2a7e3e6c1407faebe57714b613398c3fecf71b561cb8bdb6c25a70646d812c395db46f78827e97f796c8e7
+  metadata.gz: 853d3171298de868ad3de28fe284c7970ddf196203bbb217fc91fa62cebb9d39c1d278b53d4259d0dc505b09457624ea68f4a9a8a0e654850c9266139a1fa05e
+  data.tar.gz: ad8a2cec518ceebac32055aeab7fd159d982421e9983670ec28182094f4fe2338f89cd7a1609d02cd8720f01c121159fec7e2489b8c816f9f16adf9d950c34c4

data/CHANGELOG.md

@@ -1,5 +1,52 @@
 # Changelog
 
+## 0.24.0 — 2026-04-18
+
+### Changed
+
+- **Caller owns message parts.** `Writable#send` no longer deep-freezes or
+  binary-coerces the caller's input. The contract is now libzmq-style:
+  don't mutate parts after sending. `#receive` likewise returns mutable
+  arrays of mutable strings. This removes a full-payload allocation per
+  message (`.b.freeze`) on the send path and a per-frame freeze on the
+  receive path.
+
+- **No more implicit `#to_s` / nil coercion.** Passing a non-string part
+  (e.g. Integer, Symbol, nil) will raise `NoMethodError` at the wire layer
+  instead of being silently converted. The `EMPTY_PART` constant is gone.
+
+- **Reactor fast path for `#send` / `#receive`.** When the socket was
+  bound/connected from an Async fiber, hot-path I/O skips `Reactor.run`
+  entirely and calls the engine directly (with an `Async::Task#with_timeout`
+  wrapper only when a timeout is configured). The shared IO thread is used
+  only when the socket was created from a non-Async thread.
+
+### Performance
+
+Combined effect of caller-owns-data + Reactor fast path on inproc:
+
+- PUSH/PULL inproc 1-peer: **+105% to +128%** msg/s across payload sizes
+- PUSH/PULL inproc 3-peer: **+63% to +111%** msg/s
+- PUSH/PULL ipc: +5% to +17%
+- TCP numbers unchanged (OS/syscall-dominated)
+
+### Removed
+
+- `Writable#freeze_message` and `#frozen_binary` private helpers.
+- `Writable::EMPTY_PART` constant.
+
+
+## 0.23.1 — 2026-04-18
+
+### Fixed
+
+- **SCATTER double-tracked each peer.** `Routing::Scatter#connection_added`
+  appended to `@connections` and then called `add_round_robin_send_connection`,
+  which appends again — so every connected peer had two entries in the list.
+  `#connection_removed` deleted only one on disconnect, leaving a stale entry
+  behind. Fixed by dropping the duplicate append.
+
+
 ## 0.23.0 — 2026-04-17
 
 ### Added

data/lib/omq/client_server.rb

@@ -60,7 +60,7 @@ module OMQ
     # @return [self]
     #
     def send_to(routing_id, message)
-      parts = [routing_id.b.freeze, message.b.freeze]
+      parts = [routing_id, message]
       Reactor.run(timeout: @options.write_timeout) { @engine.enqueue_send(parts) }
       self
     end

data/lib/omq/engine/connection_lifecycle.rb

@@ -5,7 +5,7 @@ module OMQ
     # Owns the full arc of *one* connection: handshake → ready → closed.
     #
     # Scope boundary: ConnectionLifecycle tracks a single peer link
-    # (one ZMTP connection or one inproc DirectPipe). SocketLifecycle
+    # (one ZMTP connection or one inproc Pipe). SocketLifecycle
     # owns the socket-wide state above it — first-peer/last-peer
     # signaling, reconnect enable flag, the parent task tree, and the
     # open → closing → closed transitions that gate close-time drain.
@@ -43,7 +43,7 @@ module OMQ
       }.freeze
 
 
-      # @return [Protocol::ZMTP::Connection, Transport::Inproc::DirectPipe, nil]
+      # @return [Protocol::ZMTP::Connection, Transport::Inproc::Pipe, nil]
       attr_reader :conn
 
 
@@ -120,9 +120,9 @@ module OMQ
 
 
       # Registers an already-connected inproc pipe as :ready.
-      # No handshake — inproc DirectPipe bypasses ZMTP entirely.
+      # No handshake — inproc Pipe bypasses ZMTP entirely.
       #
-      # @param pipe [Transport::Inproc::DirectPipe]
+      # @param pipe [Transport::Inproc::Pipe]
       #
       def ready_direct!(pipe)
         ready!(pipe)
@@ -161,7 +161,9 @@ module OMQ
 
 
       def ready!(conn)
-        conn = @engine.connection_wrapper.call(conn) if @engine.connection_wrapper
+        if @engine.connection_wrapper
+          conn = @engine.connection_wrapper.call(conn)
+        end
 
         if @endpoint
           transport_obj = @engine.transport_object_for(@endpoint)
@@ -177,7 +179,7 @@ module OMQ
         @engine.peer_connected.resolve(@conn)
         transition!(:ready)
 
-        # No supervisor if nothing to supervise: inproc DirectPipes
+        # No supervisor if nothing to supervise: inproc Pipes
         # wire the recv/send paths synchronously (no task-based pumps),
         # and isolated unit tests use a FakeEngine without pumps at all.
         # Waiting on an empty barrier returns immediately and would
@@ -213,6 +215,7 @@ module OMQ
 
       def tear_down!(reconnect:, reason: nil)
         return if @state == :closed
+
         transition!(:closed)
         @engine.connections.delete(@conn)
         @engine.routing.connection_removed(@conn) if @conn
@@ -244,11 +247,14 @@ module OMQ
 
       def transition!(new_state)
         allowed = TRANSITIONS[@state]
+
         unless allowed&.include?(new_state)
           raise InvalidTransition, "#{@state} → #{new_state}"
         end
+
         @state = new_state
       end
+
     end
   end
 end

data/lib/omq/engine/heartbeat.rb

@@ -9,7 +9,7 @@ module OMQ
     #
     module Heartbeat
       # @param parent [Async::Task, Async::Barrier] parent to spawn under
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       # @param options [Options]
       #
       def self.start(parent, conn, options)

data/lib/omq/engine/recv_pump.rb

@@ -4,7 +4,7 @@ module OMQ
   class Engine
     # Recv pump for a connection.
     #
-    # For inproc DirectPipe: wires the direct recv path (no fiber spawned).
+    # For inproc Pipe: wires the direct recv path (no fiber spawned).
     # For TCP/IPC: spawns a transient task that reads messages from the
     # connection and enqueues them into +recv_queue+.
     #
@@ -29,7 +29,7 @@ module OMQ
       # Public entry point — callers use the class method.
       #
       # @param parent [Async::Task, Async::Barrier] parent to spawn under
-      # @param conn [Connection, Transport::Inproc::DirectPipe]
+      # @param conn [Protocol::ZMTP::Connection, Transport::Inproc::Pipe]
       # @param recv_queue [Async::LimitedQueue]
       # @param engine [Engine]
       # @param transform [Proc, nil]
@@ -40,7 +40,7 @@ module OMQ
       end
 
 
-      # @param conn [Connection, Transport::Inproc::DirectPipe]
+      # @param conn [Protocol::ZMTP::Connection, Transport::Inproc::Pipe]
       # @param recv_queue [Async::LimitedQueue]
       # @param engine [Engine]
       #
@@ -52,7 +52,7 @@ module OMQ
       end
 
 
-      # Starts the recv pump. For inproc DirectPipe, wires the direct path
+      # Starts the recv pump. For inproc Pipe, wires the direct path
       # (no task spawned). For TCP/IPC, spawns a fiber that reads messages.
       #
       # @param parent_task [Async::Task]
@@ -60,7 +60,7 @@ module OMQ
       # @return [Async::Task, nil]
       #
       def start(parent_task, transform)
-        if @conn.is_a?(Transport::Inproc::DirectPipe) && @conn.peer
+        if @conn.is_a?(Transport::Inproc::Pipe) && @conn.peer
           @conn.peer.wire_direct_recv(@recv_queue, transform)
           return nil
         end
@@ -72,6 +72,7 @@ module OMQ
         end
       end
 
+
       private
 
 
@@ -93,7 +94,7 @@ module OMQ
 
             while count < FAIRNESS_MESSAGES && bytes < FAIRNESS_BYTES
               msg = conn.receive_message
-              msg = transform.call(msg).freeze
+              msg = transform.call(msg)
 
               # Emit the verbose trace BEFORE enqueueing so the monitor
               # fiber is woken before the application fiber -- the

data/lib/omq/engine.rb

@@ -100,6 +100,7 @@ module OMQ
     def parent_task       = @lifecycle.parent_task
     def barrier           = @lifecycle.barrier
     def closed?           = @lifecycle.closed?
+    def on_io_thread?     = @lifecycle.on_io_thread
 
 
     # Enables or disables auto-reconnect for dropped connections.
@@ -280,10 +281,10 @@ module OMQ
     end
 
 
-    # Called by inproc transport with a pre-validated DirectPipe.
+    # Called by inproc transport with a pre-validated Pipe.
     # Skips ZMTP handshake — just registers with routing strategy.
     #
-    # @param pipe [Transport::Inproc::DirectPipe]
+    # @param pipe [Transport::Inproc::Pipe]
     # @return [void]
     #
     def connection_ready(pipe, endpoint: nil)
@@ -328,7 +329,7 @@ module OMQ
 
     # Starts a recv pump for a connection, or wires the inproc fast path.
     #
-    # @param conn [Connection, Transport::Inproc::DirectPipe]
+    # @param conn [Protocol::ZMTP::Connection, Transport::Inproc::Pipe]
     # @param recv_queue [Async::LimitedQueue]
     # @yield [msg] optional per-message transform
     # @return [Async::Task, nil]
@@ -345,7 +346,7 @@ module OMQ
 
     # Called when a connection is lost.
     #
-    # @param connection [Connection]
+    # @param connection [Protocol::ZMTP::Connection]
     # @return [void]
     #
     def connection_lost(connection)
@@ -460,7 +461,7 @@ module OMQ
     # pumps blocked on `dequeue` waiting for messages that will never
     # be written.
     #
-    # @param conn [Connection, Transport::Inproc::DirectPipe]
+    # @param conn [Protocol::ZMTP::Connection, Transport::Inproc::Pipe]
     # @param annotation [String]
     #
     def spawn_conn_pump_task(conn, annotation:, &block)

data/lib/omq/peer.rb

@@ -38,7 +38,7 @@ module OMQ
     # @return [self]
     #
     def send_to(routing_id, message)
-      parts = [routing_id.b.freeze, message.b.freeze]
+      parts = [routing_id, message]
       Reactor.run(timeout: @options.write_timeout) { @engine.enqueue_send(parts) }
       self
     end

data/lib/omq/radio_dish.rb

@@ -42,7 +42,7 @@ module OMQ
     # @return [self]
     #
     def publish(group, body)
-      parts = [group.b.freeze, body.b.freeze]
+      parts = [group, body]
       Reactor.run timeout: @options.write_timeout do
         @engine.enqueue_send(parts)
       end

data/lib/omq/readable.rb

@@ -14,7 +14,11 @@ module OMQ
     # @raise [IO::TimeoutError] if read_timeout exceeded
     #
     def receive
-      Reactor.run timeout: @options.read_timeout do |task|
+      if @engine.on_io_thread?
+        Reactor.run(timeout: @options.read_timeout) { @engine.dequeue_recv }
+      elsif (timeout = @options.read_timeout)
+        Async::Task.current.with_timeout(timeout, IO::TimeoutError) { @engine.dequeue_recv }
+      else
         @engine.dequeue_recv
       end
     end

data/lib/omq/routing/channel.rb

@@ -39,7 +39,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       # @raise [RuntimeError] if a connection already exists
       #
       def connection_added(connection)
@@ -48,7 +48,7 @@ module OMQ
 
         @engine.start_recv_pump(connection, @recv_queue)
 
-        unless connection.is_a?(Transport::Inproc::DirectPipe)
+        unless connection.is_a?(Transport::Inproc::Pipe)
           @send_queue = Routing.build_queue(@engine.options.send_hwm, :block)
           while (msg = @staging_queue.dequeue(timeout: 0))
             @send_queue.enqueue(msg)
@@ -58,7 +58,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         if @connection == connection
@@ -72,7 +72,7 @@ module OMQ
       #
       def enqueue(parts)
         conn = @connection
-        if conn.is_a?(Transport::Inproc::DirectPipe) && conn.direct_recv_queue
+        if conn.is_a?(Transport::Inproc::Pipe) && conn.direct_recv_queue
           conn.send_message(parts)
         elsif @send_queue
           @send_queue.enqueue(parts)

data/lib/omq/routing/client.rb

@@ -42,7 +42,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @connections << connection
@@ -51,7 +51,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/routing/conn_send_pump.rb

@@ -12,7 +12,7 @@ module OMQ
       # is torn down with the rest of the connection's pumps.
       #
       # @param engine [Engine]
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       # @param q [Async::LimitedQueue]
       # @return [Async::Task]
       #

data/lib/omq/routing/dealer.rb

@@ -42,7 +42,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @engine.start_recv_pump(connection, @recv_queue)
@@ -50,7 +50,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/routing/dish.rb

@@ -41,7 +41,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @connections << connection
@@ -52,7 +52,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/routing/fan_out.rb

@@ -61,7 +61,7 @@ module OMQ
       # Override in subclasses to expose subscriptions to the
       # application (e.g. XPUB enqueues to recv_queue).
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       # @param prefix [String]
       #
       def on_subscribe(conn, prefix)
@@ -74,7 +74,7 @@ module OMQ
       # Called when a cancel command is received from a peer.
       # Override in subclasses (e.g. XPUB enqueues to recv_queue).
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       # @param prefix [String]
       #
       def on_cancel(conn, prefix)
@@ -86,7 +86,7 @@ module OMQ
       # Creates a per-connection send queue and starts its send pump.
       # Call from #connection_added.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       #
       def add_fan_out_send_connection(conn)
         q = Routing.build_queue(@engine.options.send_hwm, @engine.options.on_mute)
@@ -99,7 +99,7 @@ module OMQ
       # down by the per-connection lifecycle barrier.
       # Call from #connection_removed.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       #
       def remove_fan_out_send_connection(conn)
         @subscribe_all.delete(conn)
@@ -152,7 +152,7 @@ module OMQ
       # In conflate mode, drains the batch and keeps only the latest
       # message per topic before writing.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       # @param q [Async::LimitedQueue, DropQueue]
       #
       def start_conn_send_pump(conn, q)
@@ -169,7 +169,7 @@ module OMQ
       # Send pump variant for non-conflate fan-out: dequeues, batch-drains,
       # writes each subscribed message, then flushes once.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       # @param q [Async::LimitedQueue, DropQueue]
       # @param use_wire [Boolean] true iff the encoded wire bytes can
       #   be shared across peers (unencrypted ZMTP)
@@ -219,7 +219,7 @@ module OMQ
       # Send pump variant for conflate mode: keeps only the latest
       # subscribed message per batch. Stale duplicates are dropped.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       # @param q [Async::LimitedQueue, DropQueue]
       # @return [Async::Task]
       #

data/lib/omq/routing/gather.rb

@@ -36,14 +36,14 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @engine.start_recv_pump(connection, @recv_queue)
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
       end

data/lib/omq/routing/pair.rb

@@ -43,7 +43,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       # @raise [RuntimeError] if a connection already exists
       #
       def connection_added(connection)
@@ -52,13 +52,13 @@ module OMQ
 
         @engine.start_recv_pump(connection, @recv_queue)
 
-        unless connection.is_a?(Transport::Inproc::DirectPipe)
+        unless connection.is_a?(Transport::Inproc::Pipe)
           start_send_pump(connection)
         end
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connection = nil if @connection == connection
@@ -69,7 +69,7 @@ module OMQ
       #
       def enqueue(parts)
         conn = @connection
-        if conn.is_a?(Transport::Inproc::DirectPipe) && conn.direct_recv_queue
+        if conn.is_a?(Transport::Inproc::Pipe) && conn.direct_recv_queue
           conn.send_message(parts)
         else
           @send_queue.enqueue(parts)

data/lib/omq/routing/peer.rb

@@ -50,7 +50,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         routing_id = SecureRandom.bytes(4)
@@ -65,7 +65,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         routing_id = @routing_id_by_connection.delete(connection)

data/lib/omq/routing/pub.rb

@@ -36,7 +36,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @connections << connection
@@ -46,7 +46,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/routing/pull.rb

@@ -38,14 +38,14 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @engine.start_recv_pump(connection, @recv_queue)
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         # recv pump stops on EOFError via its connection barrier

data/lib/omq/routing/push.rb

@@ -33,7 +33,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         add_round_robin_send_connection(connection)
@@ -41,7 +41,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)
@@ -64,7 +64,7 @@ module OMQ
       # may succeed if the kernel send buffer absorbs the data.
       #
       def start_reaper(conn)
-        return if conn.is_a?(Transport::Inproc::DirectPipe)
+        return if conn.is_a?(Transport::Inproc::Pipe)
         @engine.spawn_conn_pump_task(conn, annotation: "reaper") do
           conn.receive_message # blocks until peer disconnects; then exits
         end

data/lib/omq/routing/radio.rb

@@ -50,7 +50,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @connections << connection
@@ -64,7 +64,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/routing/rep.rb

@@ -45,7 +45,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @engine.start_recv_pump(connection, @recv_queue) do |msg|
@@ -63,7 +63,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @pending_replies.reject! { |r| r[0] == connection }

data/lib/omq/routing/req.rb

@@ -46,7 +46,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @engine.start_recv_pump(connection, @recv_queue) do |msg|
@@ -58,7 +58,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/routing/round_robin.rb

@@ -48,7 +48,7 @@ module OMQ
       # Registers a connection and starts its send pump.
       # Call from #connection_added.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       #
       def add_round_robin_send_connection(conn)
         @connections << conn
@@ -63,7 +63,7 @@ module OMQ
       # guarantee, so this is safe. The pump itself is torn down by
       # the per-connection lifecycle barrier.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       #
       def remove_round_robin_send_connection(conn)
         update_direct_pipe
@@ -73,7 +73,7 @@ module OMQ
       # Updates the direct-pipe shortcut for inproc single-peer bypass.
       #
       def update_direct_pipe
-        if @connections.size == 1 && @connections.first.is_a?(Transport::Inproc::DirectPipe)
+        if @connections.size == 1 && @connections.first.is_a?(Transport::Inproc::Pipe)
           @direct_pipe = @connections.first
         else
           @direct_pipe = nil
@@ -128,7 +128,7 @@ module OMQ
       # run. The yield is effectively free when the scheduler has no
       # other work.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       #
       def start_conn_send_pump(conn)
         @engine.spawn_conn_pump_task(conn, annotation: "send pump") do

data/lib/omq/routing/router.rb

@@ -45,7 +45,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         identity = connection.peer_identity
@@ -61,7 +61,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         identity = @identity_by_connection.delete(connection)

data/lib/omq/routing/scatter.rb

@@ -33,16 +33,15 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
-        @connections << connection
         add_round_robin_send_connection(connection)
         start_reaper(connection)
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)
@@ -63,10 +62,10 @@ module OMQ
       # Detects peer disconnection on write-only sockets by
       # blocking on a receive that only returns on disconnect.
       #
-      # @param conn [Connection]
+      # @param conn [Protocol::ZMTP::Connection]
       #
       def start_reaper(conn)
-        return if conn.is_a?(Transport::Inproc::DirectPipe)
+        return if conn.is_a?(Transport::Inproc::Pipe)
         @engine.spawn_conn_pump_task(conn, annotation: "reaper") do
           conn.receive_message # blocks until peer disconnects; then exits
         end

data/lib/omq/routing/server.rb

@@ -45,7 +45,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         routing_id = SecureRandom.bytes(4)
@@ -60,7 +60,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         routing_id = @routing_id_by_connection.delete(connection)

data/lib/omq/routing/sub.rb

@@ -41,7 +41,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @connections << connection
@@ -54,7 +54,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/routing/xpub.rb

@@ -41,7 +41,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @connections << connection
@@ -51,7 +51,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/routing/xsub.rb

@@ -43,7 +43,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_added(connection)
         @connections << connection
@@ -56,7 +56,7 @@ module OMQ
       end
 
 
-      # @param connection [Connection]
+      # @param connection [Protocol::ZMTP::Connection]
       #
       def connection_removed(connection)
         @connections.delete(connection)

data/lib/omq/transport/inproc/{direct_pipe.rb → pipe.rb}

@@ -14,7 +14,7 @@ module OMQ
       # This reduces inproc from 3 queue hops to 2 (send_queue →
       # recv_queue), eliminating the internal pipe queue in between.
       #
-      class DirectPipe
+      class Pipe
         # @return [String] peer's socket type
         #
         attr_reader :peer_socket_type
@@ -39,7 +39,7 @@ module OMQ
         attr_reader :peer_identity
 
 
-        # @return [DirectPipe, nil] the other end of this pipe pair
+        # @return [Pipe, nil] the other end of this pipe pair
         #
         attr_accessor :peer
 
@@ -85,6 +85,7 @@ module OMQ
         def wire_direct_recv(queue, transform)
           @direct_recv_transform = transform
           @direct_recv_queue     = queue
+
           return unless @pending_direct
 
           @pending_direct.each { |msg| queue.enqueue(msg) }
@@ -99,6 +100,7 @@ module OMQ
         #
         def send_message(parts)
           raise IOError, "closed" if @closed
+
           if @direct_recv_queue
             @direct_recv_queue.enqueue(apply_transform(parts))
           elsif @send_queue
@@ -114,7 +116,7 @@ module OMQ
 
         # Batched form, for parity with Protocol::ZMTP::Connection. The
         # work-stealing pumps call this when they dequeue more than one
-        # message at once; DirectPipe just loops — no mutex to amortize.
+        # message at once; Pipe just loops — no mutex to amortize.
         #
         # @param messages [Array<Array<String>>]
         # @return [void]
@@ -147,14 +149,13 @@ module OMQ
         #
         def receive_message
           loop do
-            item = @receive_queue.dequeue
-
-            raise EOFError, "connection closed" if item.nil?
+            item = @receive_queue.dequeue or raise EOFError, "connection closed"
 
             if item.is_a?(Array) && item.first == :command
               if block_given?
                 yield Protocol::ZMTP::Codec::Frame.new(item[1].to_body, command: true)
               end
+
               next
             end
 
@@ -181,8 +182,7 @@ module OMQ
         # @return [Protocol::ZMTP::Codec::Frame]
         #
         def read_frame
-          item = @receive_queue.dequeue
-          raise EOFError, "connection closed" if item.nil?
+          item = @receive_queue.dequeue or raise EOFError, "connection closed"
 
           if item.is_a?(Array) && item.first == :command
             Protocol::ZMTP::Codec::Frame.new(item[1].to_body, command: true)
@@ -208,7 +208,7 @@ module OMQ
 
         def apply_transform(parts)
           if @direct_recv_transform
-            @direct_recv_transform.call(parts).freeze
+            @direct_recv_transform.call(parts)
           else
             parts
           end

data/lib/omq/transport/inproc.rb

@@ -2,7 +2,7 @@
 
 require "async"
 require "async/queue"
-require_relative "inproc/direct_pipe"
+require_relative "inproc/pipe"
 
 module OMQ
   module Transport
@@ -122,8 +122,8 @@ module OMQ
         end
 
 
-        # Decides whether a DirectPipe pair needs command queues.
-        # DirectPipe's fast path skips queues entirely; command queues
+        # Decides whether a Pipe pair needs command queues.
+        # Pipe's fast path skips queues entirely; command queues
         # are only needed for socket types that exchange ZMTP commands
         # (e.g. ROUTER/DEALER identity, PUB/SUB subscriptions) or when
         # either side enables QoS ≥ 1.
@@ -137,11 +137,11 @@ module OMQ
         end
 
 
-        # Builds a bidirectional {DirectPipe} pair for client + server.
+        # Builds a bidirectional {Pipe} pair for client + server.
         # When +needs_cmds+ is false the pipes have no command queues
         # (fast path — all traffic bypasses Async::Queue entirely).
         #
-        # @return [Array(DirectPipe, DirectPipe)] client, server
+        # @return [Array(Pipe, Pipe)] client, server
         #
         def make_pipe_pair(ce, se, ct, st, needs_cmds)
           if needs_cmds
@@ -149,12 +149,12 @@ module OMQ
             b_to_a = Async::Queue.new
           end
 
-          client = DirectPipe.new(send_queue: needs_cmds ? a_to_b : nil,
-                                  receive_queue: needs_cmds ? b_to_a : nil,
-                                  peer_identity: se.options.identity, peer_type: st.to_s)
-          server = DirectPipe.new(send_queue: needs_cmds ? b_to_a : nil,
-                                  receive_queue: needs_cmds ? a_to_b : nil,
-                                  peer_identity: ce.options.identity, peer_type: ct.to_s)
+          client = Pipe.new(send_queue: needs_cmds ? a_to_b : nil,
+                            receive_queue: needs_cmds ? b_to_a : nil,
+                            peer_identity: se.options.identity, peer_type: st.to_s)
+          server = Pipe.new(send_queue: needs_cmds ? b_to_a : nil,
+                            receive_queue: needs_cmds ? a_to_b : nil,
+                            peer_identity: ce.options.identity, peer_type: ct.to_s)
 
           client.peer = server
           server.peer = client

data/lib/omq/transport/udp.rb

@@ -200,7 +200,7 @@ module OMQ
             next unless parts
             group, body = parts
             next unless @groups.include?(group.b)
-            return [group.b.freeze, body.b.freeze]
+            return [group, body]
           rescue IO::WaitReadable
             @socket.wait_readable
             retry

data/lib/omq/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OMQ
-  VERSION = "0.23.0"
+  VERSION = "0.24.0"
 end

data/lib/omq/writable.rb

@@ -9,19 +9,25 @@ module OMQ
     include QueueWritable
 
 
-    EMPTY_PART = "".b.freeze
-
-
     # Sends a message.
     #
+    # Caller owns the message parts. Don't mutate them after sending — especially
+    # with inproc transport or PUB fan-out, where a single reference can be shared
+    # across peers and read later by the send pump.
+    #
     # @param message [String, Array<String>] message parts
     # @return [self]
     # @raise [IO::TimeoutError] if write_timeout exceeded
     #
     def send(message)
-      parts = freeze_message(message)
+      parts = message.is_a?(Array) ? message : [message]
+      raise ArgumentError, "message has no parts" if parts.empty?
 
-      Reactor.run timeout: @options.write_timeout do |task|
+      if @engine.on_io_thread?
+        Reactor.run(timeout: @options.write_timeout) { @engine.enqueue_send(parts) }
+      elsif (timeout = @options.write_timeout)
+        Async::Task.current.with_timeout(timeout, IO::TimeoutError) { @engine.enqueue_send(parts) }
+      else
         @engine.enqueue_send(parts)
       end
 
@@ -48,42 +54,5 @@ module OMQ
       true
     end
 
-
-    private
-
-
-    # Converts a message into a frozen array of frozen binary strings.
-    #
-    # @param message [String, Array<String>]
-    # @return [Array<String>] frozen array of frozen binary strings
-    #
-    def freeze_message(message)
-      parts = message.is_a?(Array) ? message : [message]
-      raise ArgumentError, "message has no parts" if parts.empty?
-
-      all_ready = parts.all? { |p| p.is_a?(String) && p.frozen? && p.encoding == Encoding::BINARY }
-
-      # Already a frozen array of frozen binary strings → return as-is.
-      return parts if all_ready && parts.frozen?
-
-      # Items are ready; just freeze the outer array.
-      return parts.freeze if all_ready
-
-      # Items need conversion. Mutate in place when we can.
-      if parts.frozen?
-        parts.map { |p| frozen_binary(p) }.freeze
-      else
-        parts.map! { |p| frozen_binary(p) }.freeze
-      end
-    end
-
-
-    def frozen_binary(obj)
-      return EMPTY_PART if obj.nil?
-      s = obj.to_s
-      return s if s.frozen? && s.encoding == Encoding::BINARY
-      s.b.freeze
-    end
-
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omq
 version: !ruby/object:Gem::Version
-  version: 0.23.0
+  version: 0.24.0
 platform: ruby
 authors:
 - Patrik Wenger
@@ -114,7 +114,7 @@ files:
 - lib/omq/single_frame.rb
 - lib/omq/socket.rb
 - lib/omq/transport/inproc.rb
-- lib/omq/transport/inproc/direct_pipe.rb
+- lib/omq/transport/inproc/pipe.rb
 - lib/omq/transport/ipc.rb
 - lib/omq/transport/tcp.rb
 - lib/omq/transport/udp.rb