omq 0.21.0 → 0.22.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f24ac91fe456168b4d369f63506cf1d3d2b48488637ce767363aa17bb542d2b3
-  data.tar.gz: ca1b98ab4083ad90f7f483bc9df937656ae9862c9fd07800fc46315543e5fe75
+  metadata.gz: aa0683eef1c05982186c434cfbb21112518ec220e843207fa772a3cc3cd69ee9
+  data.tar.gz: 95b92509cac850c9b45380675fec60ed3db22cc21674ffde09901742b024f43a
 SHA512:
-  metadata.gz: 16f20fa600ebd66228589da4e03efc809a616d6a74fbe3460a8ced6811349fb86903e43a440708e1e78f102af711d6f9ea3ebf9cbc0e7fb4aef9591db5061e39
-  data.tar.gz: 89ff3da1bb5caa2223d1e323a389cacc4f270fed719902dbd0721c56da8ff5c0a1cbf1e6eebc59c8386f470c433c69dfb20462d46f84c9a2fa848b3e1364dfd0
+  metadata.gz: 51b018f6e6d0fe83181e14fefc9f7cda13661cc3e071e2b83f2ed517e98e550eb22f9c7b7092696261ce4bd458a7355ccfe51cb44235c38df9004f6c72d7c31b
+  data.tar.gz: 7e4581c1f0e18714a30af54833d6cabef1001936d5f4126bde2fa6144dfe3b153b825dff82576a7abca0d61dc9f87b01f0a962f950c56c2d0a5803705addf1ca

data/CHANGELOG.md

@@ -1,5 +1,43 @@
 # Changelog
 
+## 0.22.0 — 2026-04-15
+
+### Fixed
+
+- **PUB/SUB interop with ZMTP 3.0 peers** (libzmq, JeroMQ, pyzmq,
+  NetMQ). OMQ previously sent `SUBSCRIBE`/`CANCEL` as ZMTP 3.1
+  command frames unconditionally; 3.0 peers expect message-form
+  (`\x01`/`\x00` + prefix data frames) and silently dropped them.
+  `Routing::Sub` and `Routing::XSub` now dispatch on
+  `conn.peer_minor`: command-form to ZMTP 3.1+ peers,
+  message-form to ZMTP 3.0 peers. `FanOut`'s subscription listener
+  already accepts both forms via `Protocol::ZMTP::Codec::Subscription.parse`,
+  so PUB/XPUB now also accept legacy message-form subscriptions
+  from 3.0 peers. Verified against JeroMQ in all six role/direction
+  combinations.
+- **ZMTP/2.0 peers are now dropped loudly** during handshake
+  instead of hanging `read_exactly` forever. The underlying
+  `Greeting.read_from` helper in `protocol-zmtp` sniffs the
+  revision byte after 11 bytes and raises; the engine's existing
+  handshake-failure path closes the connection.
+- **`Inproc::DirectPipe#read_frame`** now returns a data `Frame`
+  for non-command queue entries instead of silently dropping
+  them. Previously the fast-path `read_frame` only handled
+  `[:command, cmd]`-tagged items, so a message-form subscription
+  arriving on an inproc pipe was lost. Fallout from the PUB/SUB
+  fix above — without it the inproc tests for that path hung.
+
+### Added
+
+- **ZMTP 3.0 / 3.1 compat tests** (`test/omq/zmtp_30_compat_test.rb`).
+  Hand-crafted raw TCP peer fakes cover: OMQ SUB → 3.0 PUB (message-form),
+  OMQ SUB → 3.1 PUB (command-form), OMQ XSUB → 3.0 PUB, OMQ XSUB → 3.1 PUB,
+  and OMQ PUB accepting message-form SUBSCRIBE from a 3.0 SUB peer.
+- **`Inproc::DirectPipe#peer_major` / `#peer_minor`** — hard-coded to
+  3/1 since both ends of an inproc pipe are OMQ. Lets the routing
+  layer dispatch uniformly on `conn.peer_minor` without special-casing
+  the transport.
+
 ## 0.21.0 — 2026-04-15
 
 ### Changed

data/lib/omq/routing/fan_out.rb

@@ -133,15 +133,14 @@ module OMQ
         @tasks << @engine.spawn_conn_pump_task(conn, annotation: "subscription listener") do
           loop do
             frame = conn.read_frame
-            next unless frame.command?
 
-            cmd = Protocol::ZMTP::Codec::Command.from_body(frame.body)
-
-            case cmd.name
-            when "SUBSCRIBE"
-              on_subscribe(conn, cmd.data)
-            when "CANCEL"
-              on_cancel(conn, cmd.data)
+            case Protocol::ZMTP::Codec::Subscription.parse(frame)
+            in [:subscribe, prefix]
+              on_subscribe(conn, prefix)
+            in [:cancel, prefix]
+              on_cancel(conn, prefix)
+            else
+              next
             end
           end
         end

data/lib/omq/routing/sub.rb

@@ -48,7 +48,7 @@ module OMQ
         @connections << connection
 
         @subscriptions.each do |prefix|
-          connection.send_command(Protocol::ZMTP::Codec::Command.subscribe(prefix))
+          send_subscribe(connection, prefix)
         end
 
         task = @engine.start_recv_pump(connection, @recv_queue)
@@ -76,9 +76,7 @@ module OMQ
       #
       def subscribe(prefix)
         @subscriptions << prefix
-        @connections.each do |conn|
-          conn.send_command(Protocol::ZMTP::Codec::Command.subscribe(prefix))
-        end
+        @connections.each { |conn| send_subscribe(conn, prefix) }
       end
 
 
@@ -88,9 +86,7 @@ module OMQ
       #
       def unsubscribe(prefix)
         @subscriptions.delete(prefix)
-        @connections.each do |conn|
-          conn.send_command(Protocol::ZMTP::Codec::Command.cancel(prefix))
-        end
+        @connections.each { |conn| send_cancel(conn, prefix) }
       end
 
 
@@ -103,6 +99,30 @@ module OMQ
         @tasks.clear
       end
 
+
+      private
+
+
+      # Sends a SUBSCRIBE to +conn+ using the wire form the peer understands:
+      # command-form for ZMTP 3.1+, legacy message-form for ZMTP 3.0.
+      #
+      def send_subscribe(conn, prefix)
+        if conn.peer_minor >= 1
+          conn.send_command(Protocol::ZMTP::Codec::Command.subscribe(prefix))
+        else
+          conn.send_message([Protocol::ZMTP::Codec::Subscription.body(prefix)])
+        end
+      end
+
+
+      def send_cancel(conn, prefix)
+        if conn.peer_minor >= 1
+          conn.send_command(Protocol::ZMTP::Codec::Command.cancel(prefix))
+        else
+          conn.send_message([Protocol::ZMTP::Codec::Subscription.body(prefix, cancel: true)])
+        end
+      end
+
     end
   end
 end

data/lib/omq/routing/xsub.rb

@@ -112,9 +112,19 @@ module OMQ
 
             case flag
             when 0x01
-              conn.send_command(Protocol::ZMTP::Codec::Command.subscribe(prefix))
+              if conn.peer_minor >= 1
+                conn.send_command(Protocol::ZMTP::Codec::Command.subscribe(prefix))
+              else
+                conn.send_message([frame])
+              end
             when 0x00
-              conn.send_command(Protocol::ZMTP::Codec::Command.cancel(prefix))
+              if conn.peer_minor >= 1
+                conn.send_command(Protocol::ZMTP::Codec::Command.cancel(prefix))
+              else
+                conn.send_message([frame])
+              end
+            else
+              next
             end
           end
         end

data/lib/omq/transport/inproc/direct_pipe.rb

@@ -20,6 +20,20 @@ module OMQ
         attr_reader :peer_socket_type
 
 
+        # @return [Integer] always 3 — inproc peers are OMQ
+        #
+        def peer_major
+          3
+        end
+
+
+        # @return [Integer] always 1 — inproc peers are OMQ (ZMTP 3.1)
+        #
+        def peer_minor
+          1
+        end
+
+
         # @return [String] peer's identity
         #
         attr_reader :peer_identity
@@ -158,19 +172,20 @@ module OMQ
         end
 
 
-        # Reads one command frame from the internal command queue.
-        # Used by PUB/XPUB subscription listeners.
+        # Reads one frame. Used by PUB/XPUB subscription listeners,
+        # which must see both the legacy message-form subscription
+        # (ZMTP 3.0) and the command-form (ZMTP 3.1).
         #
         # @return [Protocol::ZMTP::Codec::Frame]
         #
         def read_frame
-          loop do
-            item = @receive_queue.dequeue
-            raise EOFError, "connection closed" if item.nil?
+          item = @receive_queue.dequeue
+          raise EOFError, "connection closed" if item.nil?
 
-            if item.is_a?(Array) && item.first == :command
-              return Protocol::ZMTP::Codec::Frame.new(item[1].to_body, command: true)
-            end
+          if item.is_a?(Array) && item.first == :command
+            Protocol::ZMTP::Codec::Frame.new(item[1].to_body, command: true)
+          else
+            Protocol::ZMTP::Codec::Frame.new(item.first || "".b)
           end
         end
 

data/lib/omq/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OMQ
-  VERSION = "0.21.0"
+  VERSION = "0.22.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omq
 version: !ruby/object:Gem::Version
-  version: 0.21.0
+  version: 0.22.0
 platform: ruby
 authors:
 - Patrik Wenger
@@ -15,14 +15,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.8'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '0.6'
+        version: '0.8'
 - !ruby/object:Gem::Dependency
   name: async
   requirement: !ruby/object:Gem::Requirement