omp-worklog 0.16.1 → 0.17.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7acbe94c0d9ab3889a488877a4d75a94b0adfc9172b67f81620f218b854ba384
-  data.tar.gz: dc6f213011f9e8042e1330c6d6ed408474b775f852437cb617001e463fd22bed
+  metadata.gz: 50fb3b897f083790dbb6414233652dda8f562c4d2cef8cd8f4da71beca65e143
+  data.tar.gz: 3264feb238a62462803431bc333397d655dc2f3e5a69a79126842d1e0d964946
 SHA512:
-  metadata.gz: fc0d66c2d93b6773fa6257537498a9a44870cd539a6959a7713e0e8ebc88839a41a1e905cb4bd9c3267474fa6a02bae2472e73563885dec00dad5f48f08250de
-  data.tar.gz: 99a9f450cae0c23de7e58af186c05dfc2ce85ae73826b86842cf766832642b09faf3908abecb0e0ac76c0cf9a956fddd636211816208fe73694e0e31db90caf7
+  metadata.gz: 5265237e54a305eaf0315f3768a173a43a345e8199f4ebacbb43d4f2572029496f3db21737803493b9af9cd7f6a943c586f2c30ec9734fbd95a350c12cbc2736
+  data.tar.gz: 961a65e2519960980b90d16434656773352cbeb2416d5abf100187461a0bad9ec8fc22a75f4895a52e454582e9b50d26ce8d0f690b6fb56084bfb72a0b91251b

data/README.md

@@ -81,9 +81,9 @@ Type `/worklog ` to discover review, timesheet, stats, plan, and submit. Date al
 
 ### Daily Human and AI Reports and Reviewed Batches
 
-At the end of a workday, run `/worklog review`. It opens today's worklog inside OMP: edit each project's duration, destination, and factual note, then choose **Mark reviewed** or **Exclude entry**. When all retained entries are ready, choose **Submit to Harvest** once. No JSON editing or path copying is required. Use `/worklog review yesterday` for another day.
+At the end of a workday, run `/worklog review`. It opens today's worklog inside OMP: edit each project's duration, destination, and factual note, then choose **Mark reviewed** or **Exclude entry**. A duration above the automatic candidate also requires **Edit adjustment reason**. When all retained entries are ready, choose **Submit to Harvest** and confirm the displayed snapshot. No JSON editing or path copying is required. Use `/worklog review yesterday` for another day.
 
-**Save and close** preserves your private draft for the next run. **Refresh evidence** rebuilds the snapshot after confirmation and retains the prior draft privately. Review does not submit anything until you explicitly choose Submit.
+**Save and close** preserves your private draft, including correction reasons, for the next run. **Refresh evidence** rebuilds the snapshot after confirmation, clears corrections and review state, and retains the prior draft privately. Review does not submit anything until you approve the final confirmation.
 
 ```text
 /worklog stats 2026-10-05 2026-10-18
@@ -138,6 +138,12 @@ Version `0.14.0` is a clean identity cutover. Uninstall the retired `harvest-wor
 
 Version `0.14.3` renames the OMP slash command from `/omp-worklog` to `/worklog`; the `omp-worklog` package identity and CLI executable are unchanged.
 
+## Changes in 0.17.0
+
+- Allow explicitly reviewed duration increases with a required private adjustment reason, without changing the automatic candidate or source evidence.
+- Preserve corrections across save/resume and show candidate, reviewed duration, and rationale in the final approval.
+- Keep native review, saved-batch validation, and Ruby filing consistent while retaining duplicate and uncertain-outcome protections.
+
 ## Changes in 0.16.1
 
 - Keep the time-off tool's numeric schema compatible with Codex requests.

data/lib/omp_worklog/batch_cli.rb

@@ -19,8 +19,10 @@ module OmpWorklog
     ENTRY_KEYS = %w[
       id spentDate localProject project task candidateMilliseconds milliseconds
       humanActiveMilliseconds agentTurnMilliseconds bridgedGapMilliseconds
-      sourceEntryIds notes reviewed reviewReasons
+      sourceEntryIds notes reviewed reviewReasons adjustmentReason
     ].freeze
+    REQUIRED_ENTRY_KEYS = (ENTRY_KEYS - ["adjustmentReason"]).freeze
+    MAX_SAFE_INTEGER = 9_007_199_254_740_991
 
     class InputError < StandardError
       attr_reader :code
@@ -136,7 +138,7 @@ module OmpWorklog
     end
 
     def validate_entry!(entry, from, to, seen_ids)
-      require_hash_with_keys!(entry, ENTRY_KEYS, "invalid_entry_schema")
+      require_entry_keys!(entry)
       spent_date = valid_date!(entry["spentDate"], "invalid_entry_date")
       raise InputError, "entry_date_out_of_range" unless spent_date.between?(from, to)
 
@@ -149,7 +151,13 @@ module OmpWorklog
 
       candidate = positive_integer!(entry["candidateMilliseconds"], "invalid_duration")
       milliseconds = positive_integer!(entry["milliseconds"], "invalid_duration")
-      raise InputError, "duration_exceeds_candidate" if milliseconds > candidate
+      adjustment_reason = entry["adjustmentReason"]
+      if entry.key?("adjustmentReason") && !adjustment_reason.is_a?(String)
+        raise InputError, "invalid_entry_schema"
+      end
+      if milliseconds > candidate && (!adjustment_reason.is_a?(String) || adjustment_reason.strip.empty?)
+        raise InputError, "duration_increase_requires_reason"
+      end
 
       nonnegative_integer!(entry["humanActiveMilliseconds"], "invalid_entry_schema")
       nonnegative_integer!(entry["agentTurnMilliseconds"], "invalid_entry_schema")
@@ -173,6 +181,13 @@ module OmpWorklog
       }
     end
 
+    def require_entry_keys!(entry)
+      unless entry.is_a?(Hash) &&
+             (entry.keys.sort == REQUIRED_ENTRY_KEYS.sort || entry.keys.sort == ENTRY_KEYS.sort)
+        raise InputError, "invalid_entry_schema"
+      end
+    end
+
     def require_approval!(batch)
       raise InputError, "batch_not_approved" unless @dry_run || batch[:approved]
     end
@@ -188,7 +203,7 @@ module OmpWorklog
     end
 
     def positive_integer!(value, code)
-      raise InputError, code unless value.is_a?(Integer) && value.positive?
+      raise InputError, code unless value.is_a?(Integer) && value.positive? && value <= MAX_SAFE_INTEGER
 
       value
     end

data/lib/omp_worklog/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module OmpWorklog
-  VERSION = "0.16.1"
+  VERSION = "0.17.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omp-worklog
 version: !ruby/object:Gem::Version
-  version: 0.16.1
+  version: 0.17.0
 platform: ruby
 authors:
 - Marlen Brunner