omnizip 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 06cbc9a2cd22e74a84d82211efa5e000d857da117bae9a995b76520839211362
-  data.tar.gz: e8ab9ec5638953dda59f4b43aa299cfa55262f77d3c9e9f795bbe8800d443592
+  metadata.gz: 48ed1a8b9fa1d9c51d338c611430fbd78f12de0a9d5d9de3ebff23ac3b9b767c
+  data.tar.gz: 6b173fab258e290030227c869b703631023c621699e810753259b14ef613ef34
 SHA512:
-  metadata.gz: ecd9426b7a3f0a75c68821ec6c2c4c0f0f4f6f5e5ae7a252dc6e1e4fb9f5eb94a01b84f937c797581b44584e8cc4ba244d35e37c2338b1401c46de42299a1627
-  data.tar.gz: 268f70fb015d2e21b8079cae5ea4e09a83e036e967cf83bed03cc37de45b61f1875547b1443b419eec502a3bcc264e323d19bb8c503f72437cfb47bbd9d31853
+  metadata.gz: 07fba2b58cca8f0c0429042e4a2813d5618158cb8231625ad1e6f5c32d1bc532d45a8bb952a3087d6274862647dbab0480aca8c96561f24c5a3debf2a1f7dd63
+  data.tar.gz: 8422215bde30fa926b235b20dddbeba195573a82d1678ea98d541be6e37e6e14c7a6ae444e53b1a4505733a6420a4d9d3a53cec3605c751c5bf6eac49678ef86

data/CHANGELOG.md

@@ -7,6 +7,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- RAR recovery-record repair fails loudly instead of pretending:
+  `recover_with_reed_solomon` returned nil and `recover_with_xor`
+  applied a transform the record does not use. Neither unrar (its
+  recvol5/rs16 cover only the separate .rev volumes) nor any public
+  spec carries the in-archive RAR5 RS parameters, so both paths now
+  raise `NotImplementedError` with par2 guidance, surfaced through
+  `ArchiveRepairer` results. The `ozip repair` counterpart (Rust)
+  ships in omnizip-rs with the same honest contract.
+
 ### Added
 - `rake rust:build` — one command to build and vendor the Rust
   backend's cdylib (clones omnizip-rs or reuses a checkout via

data/lib/omnizip/formats/rar/parity_handler.rb

@@ -266,10 +266,16 @@ module Omnizip
         # @param parity_data [String] Parity information
         # @return [String, nil] Recovered data
         def recover_with_reed_solomon(_corrupted_data, _parity_data)
-          # Placeholder for Reed-Solomon recovery
-          # Real implementation would use reed-solomon gem
-          # For now, return nil to indicate recovery not available
-          nil
+          # The in-archive RAR5 recovery record's RS parameters exist
+          # only in the proprietary rar binary — unrar carries no
+          # implementation (its recvol5/rs16 cover only the separate
+          # .rev volume feature), and no independent spec is public.
+          # Fail loudly with actionable guidance instead of pretending
+          # recovery happened.
+          raise NotImplementedError,
+                "in-archive RAR5 Reed-Solomon recovery is not implemented " \
+                "(rar-proprietary format); protect archives with external " \
+                "parity (par2) instead"
         end
 
         # Recover data using XOR (RAR4)
@@ -277,14 +283,15 @@ module Omnizip
         # @param corrupted_data [String] Corrupted block
         # @param parity_data [String] Parity information
         # @return [String] Recovered data
-        def recover_with_xor(corrupted_data, parity_data)
-          # Simple XOR recovery
-          result = corrupted_data.bytes.map.with_index do |byte, i|
-            parity_byte = parity_data.bytes[i % parity_data.size]
-            byte ^ parity_byte
-          end
-
-          result.pack("C*")
+        def recover_with_xor(_corrupted_data, _parity_data)
+          # RAR4's integrated recovery record is likewise rar-proprietary
+          # (unrar has no repair path for it either); a cyclic XOR with
+          # arbitrary parity bytes is not the record's actual transform
+          # and would silently fabricate corrupt bytes. Refuse honestly.
+          raise NotImplementedError,
+                "in-archive RAR4 recovery-record repair is not implemented " \
+                "(rar-proprietary format); protect archives with external " \
+                "parity (par2) instead"
         end
       end
     end

data/lib/omnizip/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Omnizip
-  VERSION = "0.4.1"
+  VERSION = "0.4.2"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omnizip
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Ribose Inc.
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2026-09-19 00:00:00.000000000 Z
+date: 2026-09-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: base64