omniperm 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a95c6e48a800f14e564fc1739f3de6c7523f6da0df3a74a7551cf1bfb1112ae
-  data.tar.gz: d0cfb2fa102d4364af689f12aa261f03400c340d0f03579463da58625221c252
+  metadata.gz: c54a89f4bab72c45f50cff612e24eaba566ab7803fc09c7c021898e5639f5598
+  data.tar.gz: 6f81efb19ac42ed400d906eb0a44858c9fccbcbdf5fb6c76c4d5c34192cf3dd1
 SHA512:
-  metadata.gz: fc51b8f2f0f9e59d60d74dfa8955f5a26017eff84ded89abd0e39498a731bea21a4c1eb692baec1e89c6fc9e215dc81e33d3a3dfd9adc7b60d84efe8dead6acd
-  data.tar.gz: 4a9b02818fd4a898918c67ff1c423290bcbbf60bbbbdf8fedc5eed741a53760314fc815aa36ce27fd27ecb1cc0555040b031b14f527a13e907edbbcff9e5244f
+  metadata.gz: 1b7f6bfe5e79e679d07f26f548b31b3f813120f59c90a758f60fa2167355b055467e94580822ef6422c26c1468f6ef74f1f039dd1253abd6b4cbc9c57329f754
+  data.tar.gz: 6c7a383564f2a33fe135e3f71b22b455623d14c5d63879436cbdbae64f1deec63f6364972cc99bad3aecf3a46a2c580a113cf9ef2b522730dc22c86f03d72fe2

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    omniperm (0.0.1)
+    omniperm (0.0.4)
 
 GEM
   remote: https://rubygems.org/

data/lib/omniperm/decorators.rb

@@ -14,8 +14,8 @@ module Omniperm
         target_methods.reject{|value| [:inject_before_to_methods, :__before_method, :__after_method].include?(value) }.each { |m|
           # Rename original method
           target = nil
-          target = self if instance_methods(false).include?(m.to_sym)
-          target = self.singleton_class if singleton_methods(false).include?(m.to_sym)
+          target = self if instance_methods(false).include?(m.to_sym) # decorate instance methods
+          # target = self.singleton_class if singleton_methods(false).include?(m.to_sym) # decorate class methods
           if target
             target.send(:alias_method, "__#{m}_original", m)
             target.define_method m do |*args, **kwargs|

data/lib/omniperm/version.rb

@@ -1,3 +1,3 @@
 module Omniperm
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/omniperm.gemspec

@@ -10,7 +10,7 @@ Gem::Specification.new do |s|
   s.email         = %w(samuel@hydrodigit.com)
   s.date = %q{2020-07-21}
   s.description = %q{With Omniperm you can centralize your authorization strategies in a YAML file against a configurable context }
-  s.summary = 'Flexible Authorization for Ruby or Rails'
+  s.summary = 'Flexible Authorization for Ruby and Rails'
   s.homepage = 'https://github.com/3pns/omniperm'
   s.license = 'MIT'
   s.files = `git ls-files`.split($/)

data/test/decorators_test.rb

@@ -20,6 +20,11 @@ describe Omniperm::Core do
     assert_equal 42, @service_class_decorated_allowed.buy
   end
 
+  it 'should not perform authorization for class methods' do
+    # @user is pear
+    assert_equal 42, Services::ExternalServiceClassDecorated.my_class_method
+  end
+
   it 'should perform authorization' do
     assert_equal false, @service_class_decorated_allowed.bucket
   end

data/test/omniperm_test.rb

@@ -5,6 +5,7 @@ require_relative 'helper'
 describe Omniperm::Core do
   before do
     @user = User.new(:pear)
+    @user_nanosoft = User.new(:nanosoft)
     @service = Services::ExternalService.new(@user)
     @internal_service = Services::InternalService.new(@user)
     @secret_service = Services::InternalService::SecretService.new(@user)
@@ -16,6 +17,13 @@ describe Omniperm::Core do
 
   it 'should properly detect hierarchy and method_name from a class method' do
     assert_equal 42, Services::ClassService.compute(@user)
+    assert_equal false, Services::ClassService.compute(@user_nanosoft)
+  end
+
+  it 'should properly detect instance variables from a class method' do
+    skip ("impossible case")
+    assert_equal 42, Services::ClassService.compute_instance_variable
+    assert_equal false, Services::ClassService.compute_instance_variable
   end
 
   it 'should deny if element has default to true' do

data/test/services/class_service.rb

@@ -4,5 +4,10 @@ module Services
       return false unless service_authorized?(user)
       return 42
     end
+
+    def self.compute_instance_variable
+      return false unless service_authorized?
+      return 42
+    end
   end
 end

data/test/services/external_service_class_decorated.rb

@@ -20,5 +20,9 @@ module Services
     def n42
       return 42
     end
+
+    def self.my_class_method
+      return 42
+    end
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniperm
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Samuel Bohn
@@ -110,5 +110,5 @@ requirements: []
 rubygems_version: 3.0.8
 signing_key:
 specification_version: 4
-summary: Flexible Authorization for Ruby or Rails
+summary: Flexible Authorization for Ruby and Rails
 test_files: []