omniorder 0.0.4 → 0.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 08acaaeabef190021f9adb0423a59faec3783c73
-  data.tar.gz: 8e77e461b790a6bb3ecbe8e133551eb5e3075c07
+  metadata.gz: 837ddd9e90efb1c7157a6a34f3b80bb5236663c0
+  data.tar.gz: 5148357797c7481c41fd34fabd50d7a1e058d279
 SHA512:
-  metadata.gz: a2ee79b57210e4fedc5966a7ffd2b7d5cb3cde9db21bd37c456dadcdbca22c83ef93d7ed7650b9fb1cc9d4810f1f5831e4660c0110e2e805544ce3fa03c7367d
-  data.tar.gz: b8d070076a5600e7f03a9ea79737644c9e7808e7e0c3d79c53e617502b86aad411e232a1087e015f4997549bed21ef76c34957ba0574c8dd30da18c143a59dcc
+  metadata.gz: 3ec7245e462717e5e089527d3903f2b26eae78c2325554c633ec5b0d6d4a4197bfe642588cfcd9187a74f2a3da4cfece44541bc613478b3c0d87c0b5d4d66e23
+  data.tar.gz: bf179cb35db7ca0683bb8068b3a1d84ce80d03784041d65934680b06a0f5db11a168140300d54f8b20a265b7059a9d2b164321937c1c81c5a1a31cda1e7457bc

data/lib/omniorder/import_strategy/groupon.rb

@@ -42,8 +42,8 @@ module Omniorder
               raise "Cannot send tracking info for Groupon order ##{order.order_number} since it has no external_carrier_reference"
             end
 
-            if order.order_products.any? { |op| op.external_reference.to_i == 0 }
-              raise "Cannot send tracking info for Groupon order ##{order.order_number} since a line item has no external_reference"
+            if order.external_data.nil? || order.external_data[:line_item_ids].nil? || order.external_data[:line_item_ids].empty?
+              raise "Cannot send tracking info for Groupon order ##{order.order_number} since there is no line item external data"
             end
 
             true
@@ -75,10 +75,10 @@ module Omniorder
 
       def tracking_notification_url(orders)
         tracking_info = orders.map do |order|
-          order.order_products.map do |line_item|
+          order.external_data[:line_item_ids].map do |line_item_id|
             {
               "carrier" => order.external_carrier_reference,
-              "ci_lineitem_id" => line_item.external_reference.to_i,
+              "ci_lineitem_id" => line_item_id,
               "tracking" => order.shipping_reference
             }
           end
@@ -93,7 +93,8 @@ module Omniorder
         order = import.generate_order(
           :order_number => order_info['orderid'],
           :total_price => order_info['amount']['total'].to_f,
-          :date => DateTime.strptime(order_info['date'], '%m/%d/%Y %I:%M%p UTC')
+          :date => DateTime.strptime(order_info['date'], '%m/%d/%Y %I:%M%p UTC'),
+          :external_data => { :line_item_ids => order_info['line_items'].map { |li| li['ci_lineitemid'] } }
         )
 
         order.customer = create_customer(order, order_info['customer'])

data/lib/omniorder/order.rb

@@ -3,7 +3,7 @@ module Omniorder
     include Orderable
 
     attributes :customer, :order_products, :order_number, :total_price, :date, :shipping_reference,
-      :external_carrier_reference
+      :external_carrier_reference, :external_data
 
     def initialize(attributes = {})
       super

data/lib/omniorder/version.rb

@@ -1,3 +1,3 @@
 module Omniorder
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end

data/spec/import_strategy/groupon_spec.rb

@@ -108,12 +108,12 @@ describe Omniorder::ImportStrategy::Groupon do
         Omniorder::Order.new(
           :shipping_reference => 'SR123451',
           :external_carrier_reference => '4SL',
-          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553918')]
+          :external_data => { :line_item_ids => [54553918] }
         ),
         Omniorder::Order.new(
           :shipping_reference => 'SR123452',
           :external_carrier_reference => 'DHL',
-          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553920')]
+          :external_data => { :line_item_ids => [54553920] }
         )
       ]
 
@@ -137,12 +137,12 @@ describe Omniorder::ImportStrategy::Groupon do
         Omniorder::Order.new(
           :order_number => 'ORD1',
           :shipping_reference => 'SR123451',
-          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553918')]
+          :external_data => { :line_item_ids => [54553918] }
         ),
         Omniorder::Order.new(
           :shipping_reference => 'SR123452',
           :external_carrier_reference => 'DHL',
-          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553920')]
+          :external_data => { :line_item_ids => [54553920] }
         )
       ]
 
@@ -150,23 +150,22 @@ describe Omniorder::ImportStrategy::Groupon do
         to raise_exception "Cannot send tracking info for Groupon order #ORD1 since it has no external_carrier_reference"
     end
 
-    it 'raises an exception when and order line item has no external_reference' do
+    it 'raises an exception when an order does not have appropriate external data' do
       orders = [
         Omniorder::Order.new(
           :order_number => 'ORD1',
           :shipping_reference => 'SR123451',
-          :external_carrier_reference => '4SL',
-          :order_products => [Omniorder::OrderProduct.new]
+          :external_carrier_reference => '4SL'
         ),
         Omniorder::Order.new(
           :shipping_reference => 'SR123452',
           :external_carrier_reference => 'DHL',
-          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553920')]
+          :external_data => { :line_item_ids => [54553920] }
         )
       ]
 
       expect { strategy.update_order_tracking!(orders) }.
-        to raise_exception "Cannot send tracking info for Groupon order #ORD1 since a line item has no external_reference"
+        to raise_exception "Cannot send tracking info for Groupon order #ORD1 since there is no line item external data"
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniorder
 version: !ruby/object:Gem::Version
-  version: 0.0.4
+  version: 0.0.5
 platform: ruby
 authors:
 - Howard Wilson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-15 00:00:00.000000000 Z
+date: 2015-01-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: crack