omniorder 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d7e7efc2ebd649ff319459de8a0760bcd6331001
-  data.tar.gz: 711d3f5d76e2650a6a499926b0be94bd31f346ee
+  metadata.gz: 08acaaeabef190021f9adb0423a59faec3783c73
+  data.tar.gz: 8e77e461b790a6bb3ecbe8e133551eb5e3075c07
 SHA512:
-  metadata.gz: 29329c7d41987a63e67eda25e248ec7655216f0d4dfbf65660b91b1af5d5f09084395247547f9f866272a7395e8d1483650fb2e0cb44f4611624071b5f026fbd
-  data.tar.gz: 501165b13166f32f1b514a839fe4cc43e17693f2b94096c92f79add4b78e09edee7133a8f227043168b711929aa9f9a7160c32d9d6d0518b32d5d8f40816c6f8
+  metadata.gz: a2ee79b57210e4fedc5966a7ffd2b7d5cb3cde9db21bd37c456dadcdbca22c83ef93d7ed7650b9fb1cc9d4810f1f5831e4660c0110e2e805544ce3fa03c7367d
+  data.tar.gz: b8d070076a5600e7f03a9ea79737644c9e7808e7e0c3d79c53e617502b86aad411e232a1087e015f4997549bed21ef76c34957ba0574c8dd30da18c143a59dcc

data/lib/omniorder/import_strategy/groupon.rb

@@ -3,6 +3,8 @@ module Omniorder
     # Groupon Import Strategy
     # See: https://scm.commerceinterface.com/api-doc/v2/
     class Groupon < Base
+      require 'json'
+
       API_URL = "https://scm.commerceinterface.com/api/v2/"
 
       attr_accessor :supplier_id, :access_token
@@ -33,6 +35,35 @@ module Omniorder
         end
       end
 
+      def update_order_tracking!(orders)
+        orders = [*orders].select do |order|
+          if order.respond_to?(:shipping_reference) && !order.shipping_reference.nil?
+            if order.external_carrier_reference.nil? || order.external_carrier_reference == ''
+              raise "Cannot send tracking info for Groupon order ##{order.order_number} since it has no external_carrier_reference"
+            end
+
+            if order.order_products.any? { |op| op.external_reference.to_i == 0 }
+              raise "Cannot send tracking info for Groupon order ##{order.order_number} since a line item has no external_reference"
+            end
+
+            true
+          end
+        end
+
+        unless orders.empty?
+          result = Crack::JSON.parse do_request(tracking_notification_url(orders), :post)
+        end
+
+        if result && result['success'].nil?
+          # Include order number too if there is only one order
+          if orders.count == 1
+            raise "Failed to update Groupon tracking data for order ##{orders.first.order_number} (#{result['reason']})"
+          else
+            raise "Failed to update Groupon tracking data (#{result['reason']})"
+          end
+        end
+      end
+
       def get_orders_url
         URI.join(API_URL, "get_orders?supplier_id=#{supplier_id}&token=#{access_token}")
       end
@@ -42,6 +73,20 @@ module Omniorder
         URI.join(API_URL, "mark_exported?supplier_id=#{supplier_id}&token=#{access_token}&ci_lineitem_ids=[#{lids.join(',')}]")
       end
 
+      def tracking_notification_url(orders)
+        tracking_info = orders.map do |order|
+          order.order_products.map do |line_item|
+            {
+              "carrier" => order.external_carrier_reference,
+              "ci_lineitem_id" => line_item.external_reference.to_i,
+              "tracking" => order.shipping_reference
+            }
+          end
+        end.flatten
+
+        File.join(API_URL, "tracking_notification?supplier_id=#{supplier_id}&token=#{access_token}&tracking_info=#{tracking_info.to_json}")
+      end
+
       private
 
       def create_order(order_info)
@@ -54,7 +99,11 @@ module Omniorder
         order.customer = create_customer(order, order_info['customer'])
 
         order_info['line_items'].each do |line_item_info|
-          order.add_product_by_code(line_item_info['sku'].to_s, line_item_info['quantity'].to_i)
+          order.add_product_by_code(
+            line_item_info['sku'].to_s,
+            line_item_info['quantity'].to_i,
+            line_item_info['ci_lineitemid'].to_i
+          )
         end
 
         after_build_order order, order_info
@@ -82,7 +131,8 @@ module Omniorder
       private
 
       def do_request(url, type = :get)
-        uri = URI(url)
+        host_and_path, query = url.to_s.split('?')
+        uri = URI(type == :get ? url : host_and_path)
         http = Net::HTTP.new(uri.host, 443)
         http.use_ssl = true
         http.verify_mode = OpenSSL::SSL::VERIFY_PEER
@@ -91,8 +141,8 @@ module Omniorder
         if type == :get
           http.request(Net::HTTP::Get.new(uri.request_uri)).body
         else
-          request = Net::HTTP::Post.new(uri.path)
-          request.body = uri.query
+          request = Net::HTTP::Post.new(host_and_path)
+          request.body = query
           http.request(request).body
         end
       end

data/lib/omniorder/order.rb

@@ -2,7 +2,8 @@ module Omniorder
   class Order < Entity
     include Orderable
 
-    attributes :customer, :order_products, :order_number, :total_price, :date
+    attributes :customer, :order_products, :order_number, :total_price, :date, :shipping_reference,
+      :external_carrier_reference
 
     def initialize(attributes = {})
       super

data/lib/omniorder/order_product.rb

@@ -2,6 +2,6 @@ module Omniorder
   class OrderProduct < Entity
     include OrderProductable
 
-    attributes :product, :quantity
+    attributes :product, :quantity, :external_reference
   end
 end

data/lib/omniorder/orderable.rb

@@ -7,19 +7,23 @@ module Omniorder
       Omniorder.customer_type.new(attributes)
     end
 
-    def add_product(product, quantity = 1)
+    def add_product(product, quantity = 1, external_reference = nil)
       order_product = order_products.to_a.find { |op| op.product == product }
 
       if order_product.nil?
-        order_products << Omniorder.order_product_type.new(:product => product, :quantity => quantity)
+        order_products << Omniorder.order_product_type.new(
+          :product => product,
+          :quantity => quantity,
+          :external_reference => external_reference
+        )
       else
         order_product.quantity += quantity
       end
     end
 
-    def add_product_by_code(code, quantity = 1)
+    def add_product_by_code(code, quantity = 1, external_reference = nil)
       Omniorder.product_type.find_by_code(code).tap do |product|
-        add_product product, quantity unless product.nil?
+        add_product product, quantity, external_reference unless product.nil?
       end
     end
 

data/lib/omniorder/version.rb

@@ -1,3 +1,3 @@
 module Omniorder
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/import_strategy/groupon_spec.rb

@@ -44,6 +44,7 @@ describe Omniorder::ImportStrategy::Groupon do
     order_product = order.order_products.first
     expect(order_product.quantity).to eq(3)
     expect(order_product.product.code).to eq('03658246')
+    expect(order_product.external_reference).to eq(54553918)
 
     customer = order.customer
     expect(customer.name).to eq("SOME BODY HERE")
@@ -87,4 +88,85 @@ describe Omniorder::ImportStrategy::Groupon do
       end
     end
   end
+
+  describe '#update_order_tracking!' do
+    let(:tracking_notification_result) { '{ "success": true }' }
+    let!(:tracking_notification_stub) do
+      stub_request(
+        :post,
+        "https://scm.commerceinterface.com/api/v2/tracking_notification"
+      ).with(
+        body: "supplier_id=1&token=xYRPKcoakMoiRzWgKLV5TqPSdNAaZQT&tracking_info=[{\"carrier\":\"4SL\",\"ci_lineitem_id\":54553918,\"tracking\":\"SR123451\"},{\"carrier\":\"DHL\",\"ci_lineitem_id\":54553920,\"tracking\":\"SR123452\"}]"
+      ).to_return(
+        body: tracking_notification_result,
+        status: 200
+      )
+    end
+
+    it 'updates Groupon tracking information from orders' do
+      orders = [
+        Omniorder::Order.new(
+          :shipping_reference => 'SR123451',
+          :external_carrier_reference => '4SL',
+          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553918')]
+        ),
+        Omniorder::Order.new(
+          :shipping_reference => 'SR123452',
+          :external_carrier_reference => 'DHL',
+          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553920')]
+        )
+      ]
+
+      strategy.update_order_tracking!(orders)
+      expect(tracking_notification_stub).to have_been_requested.once
+    end
+
+    it 'does nothing when an order has no shipping_reference' do
+      order = Omniorder::Order.new(
+        :order_number => 'ORD1',
+        :external_carrier_reference => '4SL',
+        :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553918')]
+      )
+
+      # Exception would be raised on request as single-order stub does not exist
+      strategy.update_order_tracking!(order)
+    end
+
+    it 'raises an exception when an order has no external_carrier_reference' do
+      orders = [
+        Omniorder::Order.new(
+          :order_number => 'ORD1',
+          :shipping_reference => 'SR123451',
+          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553918')]
+        ),
+        Omniorder::Order.new(
+          :shipping_reference => 'SR123452',
+          :external_carrier_reference => 'DHL',
+          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553920')]
+        )
+      ]
+
+      expect { strategy.update_order_tracking!(orders) }.
+        to raise_exception "Cannot send tracking info for Groupon order #ORD1 since it has no external_carrier_reference"
+    end
+
+    it 'raises an exception when and order line item has no external_reference' do
+      orders = [
+        Omniorder::Order.new(
+          :order_number => 'ORD1',
+          :shipping_reference => 'SR123451',
+          :external_carrier_reference => '4SL',
+          :order_products => [Omniorder::OrderProduct.new]
+        ),
+        Omniorder::Order.new(
+          :shipping_reference => 'SR123452',
+          :external_carrier_reference => 'DHL',
+          :order_products => [Omniorder::OrderProduct.new(:external_reference => '54553920')]
+        )
+      ]
+
+      expect { strategy.update_order_tracking!(orders) }.
+        to raise_exception "Cannot send tracking info for Groupon order #ORD1 since a line item has no external_reference"
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniorder
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Howard Wilson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-27 00:00:00.000000000 Z
+date: 2014-12-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: crack