omniorder 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c03ee4b2df4c0589a2a01e7787556544cf5bc382
-  data.tar.gz: e229b29ba52d8c82adc3b083933c6112f8c20011
+  metadata.gz: 797f0af13bcfa4627aa6a123ba34bbde2b471d73
+  data.tar.gz: 93add816bee91c523b972efc180a6f6d04ad5fe6
 SHA512:
-  metadata.gz: ce3a0db160edea671d7c571be7251616f7832cf85d842cd0f54f6ec2f2e389540744ca6c6b023042ad87c53fd56293fad8c5ae14b72d2a3976d4b4da913b4d9d
-  data.tar.gz: 2b70815df33f45e01f465aefec85797e292ef9e33f9caefafba0680f3407194d9acbdc8c4ad4c8ec168daa3eae09986be793ce8be8d8f51baad77e60040bf4f3
+  metadata.gz: 26a793eaff12bdefb446d2936eca79f0440e815535538b8e79be17a4ef85fe5ee373eab92ebe5f733e1a44ed3f836935023f94c34be0574561ad390df19946ab
+  data.tar.gz: 5cc5b99c959e7c84656c6dbea7914a45c1876da9dea4771a455c319c2a41602c1329ee33bc306433928d322bea3f07df643cc50f5b5fc969682c96adb13b79b2

data/README.md

@@ -1,6 +1,7 @@
 # Omniorder
 
 [![Build Status](http://img.shields.io/travis/watsonbox/omniorder.svg?style=flat)](https://travis-ci.org/watsonbox/omniorder)
+[![Coverage Status](https://img.shields.io/coveralls/watsonbox/omniorder.svg?style=flat)](https://coveralls.io/r/watsonbox/omniorder)
 
 Import online orders from various channels for fulfillment.
 

data/lib/omniorder/import_strategy/base.rb

@@ -16,6 +16,10 @@ module Omniorder
         def clear_options
           @options = nil
         end
+
+        def from_name(name)
+          Utils.constantize "Omniorder::ImportStrategy::#{Utils.camelize name}"
+        end
       end
 
       def initialize(import, options = {})

data/lib/omniorder/import_strategy/groupon.rb

@@ -27,7 +27,7 @@ module Omniorder
             result = Crack::JSON.parse do_request(mark_exported_url(order_info), :post)
 
             unless result['success']
-              raise "Failed to mark Groupon order ##{order_info['orderid']} as exported"
+              raise "Failed to mark Groupon order ##{order_info['orderid']} as exported (#{result['reason']})"
             end
           end
         end
@@ -86,7 +86,15 @@ module Omniorder
         http = Net::HTTP.new(uri.host, 443)
         http.use_ssl = true
         http.verify_mode = OpenSSL::SSL::VERIFY_PEER
-        http.request((type == :post ? Net::HTTP::Post : Net::HTTP::Get).new(uri.request_uri)).body
+
+        # Send post request params in body
+        if type == :get
+          http.request(Net::HTTP::Get.new(uri.request_uri)).body
+        else
+          request = Net::HTTP::Post.new(uri.path)
+          request.body = uri.query
+          http.request(request).body
+        end
       end
     end
   end

data/lib/omniorder/utils.rb

@@ -0,0 +1,34 @@
+module Omniorder
+  module Utils
+    # Extracted from activesupport/lib/active_support/inflector/methods.rb
+    def self.constantize(camel_cased_word)
+      names = camel_cased_word.split('::')
+      names.shift if names.empty? || names.first.empty?
+
+      names.inject(Object) do |constant, name|
+        if constant == Object
+          constant.const_get(name)
+        else
+          candidate = constant.const_get(name)
+          next candidate if constant.const_defined?(name, false)
+          next candidate unless Object.const_defined?(name)
+
+          # Go down the ancestors to check it it's owned
+          # directly before we reach Object or the end of ancestors.
+          constant = constant.ancestors.inject do |const, ancestor|
+            break const    if ancestor == Object
+            break ancestor if ancestor.const_defined?(name, false)
+            const
+          end
+
+          # owner is in Object, so raise
+          constant.const_get(name, false)
+        end
+      end
+    end
+
+    def self.camelize(str)
+      str.to_s.split('_').map { |w| w.capitalize }.join
+    end
+  end
+end

data/lib/omniorder/version.rb

@@ -1,3 +1,3 @@
 module Omniorder
-  VERSION = "0.0.1"
+  VERSION = "0.0.2"
 end

data/lib/omniorder.rb

@@ -3,6 +3,7 @@ require "net/https"
 require "crack"
 
 require "omniorder/version"
+require "omniorder/utils"
 require "omniorder/entity"
 require "omniorder/customerable"
 require "omniorder/customer"

data/omniorder.gemspec

@@ -24,4 +24,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake"
   spec.add_development_dependency "rspec", "~> 3.1.0"
   spec.add_development_dependency "webmock", "~> 1.20.4"
+  spec.add_development_dependency "coveralls"
 end

data/spec/{assets/imports/groupon → import_strategy}/base_spec.rb

@@ -14,4 +14,10 @@ describe Omniorder::ImportStrategy::Base do
       expect(strategy_class.new(nil, local_option: true).options).to eq(global_option: true, local_option: true)
     end
   end
+
+  describe '.from_name' do
+    it 'selects a specific strategy from its name' do
+      expect(Omniorder::ImportStrategy::Base.from_name(:groupon)).to eq(Omniorder::ImportStrategy::Groupon)
+    end
+  end
 end

data/spec/import_strategy/groupon_spec.rb

@@ -63,7 +63,9 @@ describe Omniorder::ImportStrategy::Groupon do
     let!(:mark_exported_stub) do
       stub_request(
         :post,
-        "https://scm.commerceinterface.com/api/v2/mark_exported?supplier_id=1&token=xYRPKcoakMoiRzWgKLV5TqPSdNAaZQT&ci_lineitem_ids=[54553920,54553921]"
+        "https://scm.commerceinterface.com/api/v2/mark_exported"
+      ).with(
+        body: "supplier_id=1&token=xYRPKcoakMoiRzWgKLV5TqPSdNAaZQT&ci_lineitem_ids=[54553920,54553921]"
       ).to_return(
         body: mark_exported_result,
         status: 200
@@ -76,12 +78,12 @@ describe Omniorder::ImportStrategy::Groupon do
     end
 
     context "mark exported API call fails" do
-      let(:mark_exported_result) { '{ "success": false }' }
+      let(:mark_exported_result) { '{ "success": false, "reason": "Something went wrong" }' }
 
       it 'raises an exception' do
         expect {
           strategy.import_orders { |o| true if o.order_number == "FFB7A68990" }
-        }.to raise_exception "Failed to mark Groupon order #FFB7A68990 as exported"
+        }.to raise_exception "Failed to mark Groupon order #FFB7A68990 as exported (Something went wrong)"
       end
     end
   end

data/spec/spec_helper.rb

@@ -1,3 +1,6 @@
+require 'coveralls'
+Coveralls.wear!
+
 require 'webmock/rspec'
 require 'omniorder'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniorder
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Howard Wilson
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-11-19 00:00:00.000000000 Z
+date: 2014-11-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: crack
@@ -80,6 +80,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.20.4
+- !ruby/object:Gem::Dependency
+  name: coveralls
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 description: Import online orders from various channels for fulfillment.
 email:
 - howard@watsonbox.net
@@ -107,11 +121,12 @@ files:
 - lib/omniorder/orderable.rb
 - lib/omniorder/product.rb
 - lib/omniorder/purchasable.rb
+- lib/omniorder/utils.rb
 - lib/omniorder/version.rb
 - omniorder.gemspec
-- spec/assets/imports/groupon/base_spec.rb
 - spec/assets/imports/groupon/get_orders.json
 - spec/customerable_spec.rb
+- spec/import_strategy/base_spec.rb
 - spec/import_strategy/groupon_spec.rb
 - spec/orderable_spec.rb
 - spec/spec_helper.rb
@@ -140,9 +155,9 @@ signing_key:
 specification_version: 4
 summary: Import online orders from various channels for fulfillment.
 test_files:
-- spec/assets/imports/groupon/base_spec.rb
 - spec/assets/imports/groupon/get_orders.json
 - spec/customerable_spec.rb
+- spec/import_strategy/base_spec.rb
 - spec/import_strategy/groupon_spec.rb
 - spec/orderable_spec.rb
 - spec/spec_helper.rb