omnibus 5.5.0 → 5.6.0

data/spec/unit/packagers/pkg_spec.rb

@@ -40,31 +40,31 @@ module Omnibus
       end
     end
 
-    describe '#id' do
+    describe "#id" do
       it "is :pkg" do
         expect(subject.id).to eq(:pkg)
       end
     end
 
-    describe '#package_name' do
+    describe "#package_name" do
       it "includes the name, version, and build iteration" do
         expect(subject.package_name).to eq("project-full-name-1.2.3-2.pkg")
       end
     end
 
-    describe '#resources_dir' do
+    describe "#resources_dir" do
       it "is nested inside the staging_dir" do
         expect(subject.resources_dir).to eq("#{staging_dir}/Resources")
       end
     end
 
-    describe '#scripts_dir' do
+    describe "#scripts_dir" do
       it "is nested inside the staging_dir" do
         expect(subject.scripts_dir).to eq("#{staging_dir}/Scripts")
       end
     end
 
-    describe '#write_scripts' do
+    describe "#write_scripts" do
       context "when scripts are given" do
         let(:scripts) { %w{ preinstall postinstall } }
         before do
@@ -109,7 +109,7 @@ module Omnibus
       end
     end
 
-    describe '#build_component_pkg' do
+    describe "#build_component_pkg" do
       it "executes the pkgbuild command" do
         expect(subject).to receive(:shellout!).with <<-EOH.gsub(/^ {10}/, "")
           pkgbuild \\
@@ -125,7 +125,7 @@ module Omnibus
       end
     end
 
-    describe '#write_distribution_file' do
+    describe "#write_distribution_file" do
       it "generates the file" do
         subject.write_distribution_file
         expect("#{staging_dir}/Distribution").to be_a_file
@@ -141,7 +141,7 @@ module Omnibus
       end
     end
 
-    describe '#build_product_pkg' do
+    describe "#build_product_pkg" do
       context "when pkg signing is disabled" do
         it "generates the distribution and runs productbuild" do
           expect(subject).to receive(:shellout!).with <<-EOH.gsub(/^ {12}/, "")
@@ -175,7 +175,7 @@ module Omnibus
       context "when the identifier isn't specified by the project" do
         before do
           subject.identifier(nil)
-          project.name('$Project#')
+          project.name("$Project#")
         end
 
         it "uses com.example.PROJECT_NAME as the identifier" do
@@ -184,13 +184,13 @@ module Omnibus
       end
     end
 
-    describe '#component_pkg' do
+    describe "#component_pkg" do
       it "returns the project name with -core.pkg" do
         expect(subject.component_pkg).to eq("project-full-name-core.pkg")
       end
     end
 
-    describe '#safe_base_package_name' do
+    describe "#safe_base_package_name" do
       context 'when the project name is "safe"' do
         it "returns the value without logging a message" do
           expect(subject.safe_base_package_name).to eq("project-full-name")
@@ -211,8 +211,8 @@ module Omnibus
       end
     end
 
-    describe '#safe_identifier' do
-      context 'when Project#identifier is given' do
+    describe "#safe_identifier" do
+      context "when Project#identifier is given" do
         before { subject.identifier("com.apple.project") }
 
         it "is used" do
@@ -241,13 +241,13 @@ module Omnibus
       end
     end
 
-    describe '#safe_build_iteration' do
+    describe "#safe_build_iteration" do
       it "returns the build iternation" do
         expect(subject.safe_build_iteration).to eq(project.build_iteration)
       end
     end
 
-    describe '#safe_version' do
+    describe "#safe_version" do
       context 'when the project build_version is "safe"' do
         it "returns the value without logging a message" do
           expect(subject.safe_version).to eq("1.2.3")

data/spec/unit/packagers/pkgsrc_spec.rb

@@ -0,0 +1,77 @@
+require "spec_helper"
+
+module Omnibus
+  describe Packager::PKGSRC do
+    let(:project) do
+      Project.new.tap do |project|
+        project.name("project")
+        project.homepage("https://example.com")
+        project.install_dir("/opt/project")
+        project.build_version("1.2.3")
+        project.build_iteration("1")
+        project.maintainer("Chef Software")
+      end
+    end
+
+    subject { described_class.new(project) }
+
+    let(:project_root) { File.join(tmp_path, "project/root") }
+    let(:package_dir)  { File.join(tmp_path, "package/dir") }
+    let(:staging_dir)  { File.join(tmp_path, "staging/dir") }
+    let(:architecture) { "86_64" }
+
+    before do
+      # This is here to allow this unit test to run on windows.
+      allow(File).to receive(:expand_path).and_wrap_original do |m, *args|
+        m.call(*args).sub(/^[A-Za-z]:/, "")
+      end
+      Config.project_root(project_root)
+      Config.package_dir(package_dir)
+
+      allow(subject).to receive(:staging_dir).and_return(staging_dir)
+      create_directory(staging_dir)
+
+      stub_ohai(platform: "smartos", version: "5.11") do |data|
+        data["kernel"]["update"] = architecture
+      end
+    end
+
+    describe "#id" do
+      it "is :pkgsrc" do
+        expect(subject.id).to eq(:pkgsrc)
+      end
+    end
+
+    describe "#package_name" do
+      it "includes the name and version" do
+        expect(subject.package_name).to eq("project-1.2.3.tgz")
+      end
+    end
+
+    describe "#write_buildver" do
+      it "writes the build version data" do
+        subject.write_buildver
+        contents = File.read("#{staging_dir}/build-ver")
+        expect(contents).to eq("1.2.3-1")
+      end
+    end
+
+    describe "#write_buildinfo" do
+      it "writes the build metaddata" do
+        subject.write_buildinfo
+        contents = File.read("#{staging_dir}/build-info")
+        expect(contents).to match(/OS_VERSION=5.11/)
+        expect(contents).to match(/MACHINE_ARCH=x86_64/)
+      end
+    end
+
+    describe "#write_packlist" do
+      it "it writes the list of files" do
+        expect(subject).to receive(:shellout!)
+          .with "cd #{project.install_dir} && find . -type l -or -type f | sort >> #{staging_dir}/packlist"
+        subject.write_packlist
+        expect(File.read("#{staging_dir}/packlist")).to match(/@pkgdir \/opt\/project/)
+      end
+    end
+  end
+end

data/spec/unit/packagers/rpm_spec.rb

@@ -40,7 +40,7 @@ module Omnibus
       end
     end
 
-    describe '#signing_passphrase' do
+    describe "#signing_passphrase" do
       it "is a DSL method" do
         expect(subject).to have_exposed_method(:signing_passphrase)
       end
@@ -50,7 +50,7 @@ module Omnibus
       end
     end
 
-    describe '#vendor' do
+    describe "#vendor" do
       it "is a DSL method" do
         expect(subject).to have_exposed_method(:vendor)
       end
@@ -64,7 +64,7 @@ module Omnibus
       end
     end
 
-    describe '#license' do
+    describe "#license" do
       it "is a DSL method" do
         expect(subject).to have_exposed_method(:license)
       end
@@ -86,7 +86,7 @@ module Omnibus
       end
     end
 
-    describe '#priority' do
+    describe "#priority" do
       it "is a DSL method" do
         expect(subject).to have_exposed_method(:priority)
       end
@@ -100,7 +100,7 @@ module Omnibus
       end
     end
 
-    describe '#category' do
+    describe "#category" do
       it "is a DSL method" do
         expect(subject).to have_exposed_method(:category)
       end
@@ -114,7 +114,7 @@ module Omnibus
       end
     end
 
-    describe '#dist_tag' do
+    describe "#dist_tag" do
       it "is a DSL method" do
         expect(subject).to have_exposed_method(:dist_tag)
       end
@@ -124,13 +124,41 @@ module Omnibus
       end
     end
 
-    describe '#id' do
+    describe "#compression_type" do
+      it "is a DSL method" do
+        expect(subject).to have_exposed_method(:compression_type)
+      end
+
+      it "has a default value" do
+        expect(subject.compression_type).to eq(:gzip)
+      end
+
+      it "must be a symbol" do
+        expect { subject.compression_type(Object.new) }.to raise_error(InvalidValue)
+      end
+    end
+
+    describe "#compression_level" do
+      it "is a DSL method" do
+        expect(subject).to have_exposed_method(:compression_level)
+      end
+
+      it "has a default value" do
+        expect(subject.compression_level).to eq(9)
+      end
+
+      it "must be an integer" do
+        expect { subject.compression_level(Object.new) }.to raise_error(InvalidValue)
+      end
+    end
+
+    describe "#id" do
       it "is :rpm" do
         expect(subject.id).to eq(:rpm)
       end
     end
 
-    describe '#package_name' do
+    describe "#package_name" do
       context "when dist_tag is enabled" do
         before do
           allow(subject).to receive(:safe_architecture).and_return("x86_64")
@@ -152,13 +180,13 @@ module Omnibus
       end
     end
 
-    describe '#build_dir' do
+    describe "#build_dir" do
       it "is nested inside the staging_dir" do
         expect(subject.build_dir).to eq("#{staging_dir}/BUILD")
       end
     end
 
-    describe '#write_rpm_spec' do
+    describe "#write_rpm_spec" do
       before do
         allow(subject).to receive(:safe_architecture).and_return("x86_64")
       end
@@ -187,6 +215,55 @@ module Omnibus
         expect(contents).to include("URL: https://example.com")
         expect(contents).to include("Packager: Chef Software")
         expect(contents).to include("Obsoletes: old-project")
+        expect(contents).to include("_binary_payload w9.gzdio")
+      end
+
+      context "when RPM compression type xz is configured" do
+        before do
+          subject.compression_type(:xz)
+        end
+
+        it "has the correct binary_payload line" do
+          subject.write_rpm_spec
+          contents = File.read(spec_file)
+          expect(contents).to include("_binary_payload w9.xzdio")
+        end
+
+        context "when RPM compression level is also configured" do
+          before do
+            subject.compression_level(6)
+          end
+
+          it "has the correct binary_payload line" do
+            subject.write_rpm_spec
+            contents = File.read(spec_file)
+            expect(contents).to include("_binary_payload w6.xzdio")
+          end
+        end
+      end
+
+      context "when RPM compression type bzip2 is configured" do
+        before do
+          subject.compression_type(:bzip2)
+        end
+
+        it "has the correct binary_payload line" do
+          subject.write_rpm_spec
+          contents = File.read(spec_file)
+          expect(contents).to include("_binary_payload w9.bzdio")
+        end
+
+        context "when RPM compression level is also configured" do
+          before do
+            subject.compression_level(6)
+          end
+
+          it "has the correct binary_payload line" do
+            subject.write_rpm_spec
+            contents = File.read(spec_file)
+            expect(contents).to include("_binary_payload w6.bzdio")
+          end
+        end
       end
 
       context "when scripts are given" do
@@ -301,7 +378,7 @@ module Omnibus
       end
     end
 
-    describe '#create_rpm_file' do
+    describe "#create_rpm_file" do
       before do
         allow(subject).to receive(:shellout!)
         allow(Dir).to receive(:chdir) { |_, &b| b.call }
@@ -332,7 +409,7 @@ module Omnibus
       end
     end
 
-    describe '#spec_file' do
+    describe "#spec_file" do
       before do
         allow(subject).to receive(:package_name).and_return("package_name")
       end
@@ -342,7 +419,7 @@ module Omnibus
       end
     end
 
-    describe '#rpm_safe' do
+    describe "#rpm_safe" do
       it "adds quotes when required" do
         expect(subject.rpm_safe("file path")).to eq('"file path"')
       end
@@ -364,7 +441,7 @@ module Omnibus
       end
     end
 
-    describe '#safe_base_package_name' do
+    describe "#safe_base_package_name" do
       context 'when the project name is "safe"' do
         it "returns the value without logging a message" do
           expect(subject.safe_base_package_name).to eq("project")
@@ -385,13 +462,13 @@ module Omnibus
       end
     end
 
-    describe '#safe_build_iteration' do
+    describe "#safe_build_iteration" do
       it "returns the build iternation" do
         expect(subject.safe_build_iteration).to eq(project.build_iteration)
       end
     end
 
-    describe '#safe_version' do
+    describe "#safe_version" do
       context 'when the project build_version is "safe"' do
         it "returns the value without logging a message" do
           expect(subject.safe_version).to eq("1.2.3")
@@ -454,7 +531,7 @@ module Omnibus
       end
     end
 
-    describe '#safe_architecture' do
+    describe "#safe_architecture" do
       before do
         stub_ohai(platform: "redhat", version: "6.5") do |data|
           data["kernel"]["machine"] = "i386"

data/spec/unit/packagers/solaris_spec.rb

@@ -36,37 +36,37 @@ module Omnibus
       end
     end
 
-    describe '#id' do
+    describe "#id" do
       it "is :solaris" do
         expect(subject.id).to eq(:solaris)
       end
     end
 
-    describe '#package_name' do
+    describe "#package_name" do
       it "includes the name, version, iteration and architecture" do
         expect(subject.package_name).to eq("project-1.2.3-1.i386.solaris")
       end
     end
 
-    describe '#pkgmk_version' do
+    describe "#pkgmk_version" do
       it "includes the version and iteration" do
         expect(subject.pkgmk_version).to eq("1.2.3-1")
       end
     end
 
-    describe '#install_dirname' do
+    describe "#install_dirname" do
       it "returns the parent directory" do
         expect(subject.install_dirname).to eq("/opt")
       end
     end
 
-    describe '#install_basename' do
+    describe "#install_basename" do
       it "name of the install directory" do
         expect(subject.install_basename).to eq("project")
       end
     end
 
-    describe '#write_scripts' do
+    describe "#write_scripts" do
       context "when scripts are given" do
         let(:scripts) { %w{ postinstall postremove } }
         before do
@@ -111,7 +111,7 @@ module Omnibus
       end
     end
 
-    describe '#write_prototype_file' do
+    describe "#write_prototype_file" do
       let(:prototype_file) { File.join(staging_dir, "Prototype") }
 
       before do
@@ -155,7 +155,7 @@ module Omnibus
       end
     end
 
-    describe '#create_solaris_file' do
+    describe "#create_solaris_file" do
       it "uses the correct commands" do
         expect(subject).to receive(:shellout!)
           .with("pkgmk -o -r /opt -d #{staging_dir} -f #{File.join(staging_dir, 'Prototype')}")
@@ -168,7 +168,7 @@ module Omnibus
       end
     end
 
-    describe '#write_pkginfo_file' do
+    describe "#write_pkginfo_file" do
       let(:pkginfo_file) { File.join(staging_dir, "pkginfo") }
       let(:hostname) { Socket.gethostname }
       let(:now) { Time.now }
@@ -199,7 +199,7 @@ module Omnibus
       end
     end
 
-    describe '#create_solaris_file' do
+    describe "#create_solaris_file" do
       before do
         allow(subject).to receive(:shellout!)
         allow(Dir).to receive(:chdir) { |_, &b| b.call }
@@ -217,7 +217,7 @@ module Omnibus
       end
     end
 
-    describe '#safe_architecture' do
+    describe "#safe_architecture" do
       context "the architecture is Intel-based" do
         let(:architecture) { "i86pc" }