omnibus 5.3.0 → 5.4.0

data/spec/unit/packager_spec.rb

@@ -0,0 +1,64 @@
+require 'spec_helper'
+
+module Omnibus
+  describe Packager do
+    describe '.for_current_system' do
+      context 'on Mac OS X' do
+        before { stub_ohai(platform: 'mac_os_x', version: '10.9.2') }
+        it 'prefers PKG' do
+            expect(described_class.for_current_system).to eq(Packager::PKG)
+          end
+      end
+
+      context 'on Windows' do
+        before { stub_ohai(platform: 'windows', version: '2012') }
+          it 'prefers MSI' do
+            expect(described_class.for_current_system).to eq(Packager::MSI)
+          end
+      end
+
+      context 'on Solaris 11' do
+        before { stub_ohai(platform: 'solaris2', version: '5.11') }
+          it 'prefers IPS' do
+            expect(described_class.for_current_system).to eq(Packager::IPS)
+          end
+      end
+
+      context 'on Solaris 10' do
+        before { stub_ohai(platform: 'solaris2', version: '5.10') }
+          it 'prefers Solaris' do
+            expect(described_class.for_current_system).to eq(Packager::Solaris)
+          end
+      end
+
+
+      context 'on aix' do
+        before { stub_ohai(platform: 'aix', version: '7.1') }
+          it 'prefers BFF' do
+            expect(described_class.for_current_system).to eq(Packager::BFF)
+          end
+      end
+
+      context 'on fedora' do
+        before { stub_ohai(platform: 'fedora', version: '20') }
+          it 'prefers RPM' do
+            expect(described_class.for_current_system).to eq(Packager::RPM)
+          end
+      end
+
+      context 'on debian' do
+        before { stub_ohai(platform: 'debian', version: '7.2') }
+          it 'prefers RPM' do
+            expect(described_class.for_current_system).to eq(Packager::DEB)
+          end
+      end
+
+      context 'on suse' do
+        before { stub_ohai(platform: 'suse', version: '12.0') }
+          it 'prefers RPM' do
+            expect(described_class.for_current_system).to eq(Packager::RPM)
+          end
+      end
+    end
+  end
+end

data/spec/unit/packagers/ips_spec.rb

@@ -0,0 +1,222 @@
+require 'spec_helper'
+require 'pry'
+
+module Omnibus
+  describe Packager::IPS do
+    let(:project) do
+      Project.new.tap do |project|
+        project.name('project')
+        project.homepage('https://example.com')
+        project.install_dir('/opt/project')
+        project.build_version('1.2.3')
+        project.build_iteration('2')
+        project.maintainer('Chef Software')
+      end
+    end
+
+    subject { described_class.new(project) }
+
+    let(:project_root) { File.join(tmp_path, 'project/root') }
+    let(:package_dir)  { File.join(tmp_path, 'package/dir') }
+    let(:staging_dir)  { File.join(tmp_path, 'staging/dir') }
+    let(:source_dir)   { File.join(staging_dir, 'proto_install')}
+    let(:repo_dir)     { File.join(staging_dir, 'publish/repo')}
+    let(:architecture) { 'i86pc' }
+    let(:shellout) { double("Mixlib::ShellOut", :run_command => true, :error! => nil) }
+
+    before do
+      Config.project_root(project_root)
+      Config.package_dir(package_dir)
+
+      allow(Mixlib::ShellOut).to receive(:new).and_return(shellout)
+      allow(subject).to receive(:staging_dir).and_return(staging_dir)
+      create_directory(staging_dir)
+      create_directory(source_dir)
+      create_directory(repo_dir)
+
+      stub_ohai(platform: 'solaris2', version: '5.11') do |data|
+        data['kernel']['machine'] = architecture
+      end
+    end
+
+    describe '#publisher_prefix' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:publisher_prefix)
+      end
+
+      it 'has a default value' do
+        expect(subject.publisher_prefix).to eq('Omnibus')
+      end
+    end
+
+    it '#id is :IPS' do
+      expect(subject.id).to eq(:ips)
+    end
+
+    describe '#package_name' do
+      it 'should create correct package name' do
+        expect(subject.package_name).to eq('project.p5p')
+      end
+    end
+
+    describe '#fmri_package_name' do
+      it 'should create correct fmri package name' do
+        expect(subject.fmri_package_name).to eq ('project@1.2.3,5.11-2')
+      end
+    end
+
+    describe '#pkg_metadata_file' do
+      it 'is created inside the staging_dir' do
+        expect(subject.pkg_metadata_file).to eq("#{subject.staging_dir}/gen.manifestfile")
+      end
+    end
+
+    describe '#pkg_manifest_file' do
+      it 'is created inside the staging_dir' do
+        expect(subject.pkg_manifest_file).to eq("#{subject.staging_dir}/#{subject.safe_base_package_name}.p5m")
+      end
+    end
+
+    describe '#repo_dir' do
+      it 'is created inside the staging_dir' do
+        expect(subject.repo_dir).to eq("#{subject.staging_dir}/publish/repo")
+      end
+    end
+
+    describe '#source_dir' do
+      it 'is created inside the staging_dir' do
+        expect(subject.source_dir).to eq("#{subject.staging_dir}/proto_install")
+      end
+    end
+
+    describe '#safe_base_package_name' do
+      context 'when the project name is "safe"' do
+        it 'returns the value without logging a message' do
+          expect(subject.safe_base_package_name).to eq('project')
+          expect(subject).to_not receive(:log)
+        end
+      end
+
+      context 'when the project name has invalid characters' do
+        before { project.name("Pro$ject123.for-realz_2") }
+
+        it 'returns the value while logging a message' do
+          output = capture_logging do
+            expect(subject.safe_base_package_name).to eq('pro-ject123.for-realz-2')
+          end
+
+          expect(output).to include("The `name' component of IPS package names can only include")
+        end
+      end
+    end
+
+    describe '#safe_architecture' do
+      context 'the architecture is Intel-based' do
+        let(:architecture) { 'i86pc' }
+
+        it 'returns `i386`' do
+          expect(subject.safe_architecture).to eq('i386')
+        end
+      end
+
+      context 'the architecture is SPARC-based' do
+        let(:architecture) { 'sun4v' }
+
+        it 'returns `sparc`' do
+          expect(subject.safe_architecture).to eq('sparc')
+        end
+      end
+
+      context 'anything else' do
+        let(:architecture) { 'FOO' }
+
+        it 'returns the value from Ohai' do
+          expect(subject.safe_architecture).to eq('FOO')
+        end
+      end
+    end
+
+    describe "#write_transform_file" do
+      let(:transform_file) { File.join(staging_dir, "doc-transform") }
+
+      it "creates the transform file" do
+        subject.write_transform_file
+        transform_file_contents = File.read(transform_file)
+        expect(transform_file_contents).to include("<transform dir path=opt$ -> edit group bin sys>")
+        expect(transform_file_contents).to include("<transform file depend -> edit pkg.debug.depend.file ruby env>")
+      end
+    end
+
+    describe "#write_pkg_metadata" do
+      it "should create metadata correctly" do
+        subject.write_pkg_metadata
+        manifest_file = File.join(staging_dir, "gen.manifestfile")
+        manifest_file_contents = File.read(manifest_file)
+        expect(File.exist?(manifest_file)).to be(true)
+        expect(manifest_file_contents).to include("set name=pkg.fmri value=developer/versioning/project@1.2.3,5.11-2")
+        expect(manifest_file_contents).to include("set name=variant.arch value=i386")
+      end
+    end
+
+    describe "#generate_pkg_contents" do
+      it "uses the correct commands" do
+        expect(subject).to receive(:shellout!)
+          .with("pkgsend generate #{staging_dir}/proto_install | pkgfmt > #{staging_dir}/project.p5m.1")
+        expect(subject).to receive(:shellout!)
+          .with("pkgmogrify -DARCH=`uname -p` #{staging_dir}/project.p5m.1 #{staging_dir}/gen.manifestfile #{staging_dir}/doc-transform | pkgfmt > #{staging_dir}/project.p5m.2")
+        subject.generate_pkg_contents
+      end
+    end
+
+    describe "#generate_pkg_deps" do
+      it "uses the correct commands" do
+        expect(subject).to receive(:shellout!)
+          .with("pkgdepend generate -md #{staging_dir}/proto_install #{staging_dir}/project.p5m.2 | pkgfmt > #{staging_dir}/project.p5m.3")
+        expect(subject).to receive(:shellout!)
+          .with("pkgmogrify -DARCH=`uname -p` #{staging_dir}/project.p5m.3 #{staging_dir}/doc-transform | pkgfmt > #{staging_dir}/project.p5m.4")
+        expect(subject).to receive(:shellout!)
+          .with("pkgdepend resolve -m #{staging_dir}/project.p5m.4")
+        subject.generate_pkg_deps
+      end
+    end
+
+    describe "#validate_pkg_manifest" do
+      it "uses the correct commands" do
+        expect(subject).to receive(:shellout!)
+          .with("pkglint -c /tmp/lint-cache -r http://pkg.oracle.com/solaris/release #{staging_dir}/project.p5m.4.res")
+        subject.validate_pkg_manifest
+      end
+    end
+
+    describe "#create_ips_repo" do
+      it "uses the correct commands" do
+        expect(subject).to receive(:shellout!)
+          .with("pkgrepo create #{staging_dir}/publish/repo")
+        subject.create_ips_repo
+      end
+    end
+
+    describe "#publish_ips_pkg" do
+      it "uses the correct commands" do
+        expect(subject).to receive(:shellout!)
+          .with("pkgrepo -s #{staging_dir}/publish/repo set publisher/prefix=Omnibus")
+        expect(subject).to receive(:shellout!)
+          .with("pkgsend publish -s #{staging_dir}/publish/repo -d #{staging_dir}/proto_install #{staging_dir}/project.p5m.4.res")
+
+        expect(shellout).to receive(:stdout)
+        subject.publish_ips_pkg
+      end
+    end
+
+    describe "#export_pkg_archive_file" do
+      it "uses the correct commands" do
+        expect(subject).to receive(:shellout!)
+          .with("pkgrecv -s #{staging_dir}/publish/repo -a -d #{package_dir}/project.p5p project")
+
+        expect(shellout).to receive(:stdout)
+        subject.export_pkg_archive_file
+      end
+    end
+
+  end
+end

data/spec/unit/publisher_spec.rb

@@ -67,11 +67,73 @@ module Omnibus
             version: '11.0.6',
             iteration: 1,
             basename: 'chef.deb',
+            license: 'Apache-2.0',
             platform: 'ubuntu',
             platform_version: '12.04',
             arch: 'x86_64',
             sha1: 'SHA1',
             md5: 'ABCDEF123456',
+            version_manifest: {
+              manifest_format: 1,
+              build_version: '11.0.6',
+              build_git_revision: '2e763ac957b308ba95cef256c2491a5a55a163cc',
+              software: {
+                zlib: {
+                  locked_source: {
+                    md5: '44d667c142d7cda120332623eab69f40',
+                    url: 'http://iweb.dl.sourceforge.net/project/libpng/zlib/1.2.8/zlib-1.2.8.tar.gz',
+                  },
+                  locked_version: '1.2.8',
+                  source_type: 'url',
+                  described_version: '1.2.8',
+                  license: 'Zlib',
+                },
+                openssl: {
+                  locked_source: {
+                    md5: '562986f6937aabc7c11a6d376d8a0d26',
+                    extract: 'lax_tar',
+                    url: 'http://iweb.dl.sourceforge.net/project/libpng/zlib/1.2.8/zlib-1.2.8.tar.gz',
+                  },
+                  locked_version: '1.0.1s',
+                  source_type: 'url',
+                  described_version: '1.0.1s',
+                  license: 'OpenSSL',
+                },
+                ruby: {
+                  locked_source: {
+                    md5: '091b62f0a9796a3c55de2a228a0e6ef3',
+                    url: 'https://cache.ruby-lang.org/pub/ruby/2.1/ruby-2.1.8.tar.gz',
+                  },
+                  locked_version: '2.1.8',
+                  source_type: 'url',
+                  described_version: '2.1.8',
+                  license: 'BSD-2-Clause',
+                },
+                ohai: {
+                  locked_source: {
+                    git: 'https://github.com/opscode/ohai.git'
+                  },
+                  locked_version: 'fec0959aa5da5ce7ba0e07740dbc08546a8f53f0',
+                  source_type: 'git',
+                  described_version: 'master',
+                  license: 'Apache-2.0',
+                },
+                chef: {
+                  locked_source: {
+                    path: '/home/jenkins/workspace/chef-build/architecture/x86_64/platform/ubuntu-10.04/project/chef/role/builder/omnibus/files/../..',
+                    options: {
+                      exclude: [
+                        'omnibus/vendor',
+                      ],
+                    },
+                  },
+                  locked_version: 'local_source',
+                  source_type: 'path',
+                  described_version: 'local_source',
+                  license: 'Apache-2.0',
+                },
+              }
+            }
           )
         end
 

data/spec/unit/publishers/artifactory_publisher_spec.rb

@@ -21,6 +21,7 @@ module Omnibus
         homepage: 'https://www.getchef.com',
         version: '11.0.6',
         iteration: 1,
+        license:  'Apache-2.0',
         basename: 'chef.deb',
         platform: 'ubuntu',
         platform_version: '14.04',
@@ -29,6 +30,67 @@ module Omnibus
         sha256: 'SHA256',
         sha512: 'SHA512',
         md5: 'ABCDEF123456',
+        version_manifest: {
+          manifest_format: 1,
+          build_version: '11.0.6',
+          build_git_revision: '2e763ac957b308ba95cef256c2491a5a55a163cc',
+          software: {
+            zlib: {
+              locked_source: {
+                md5: '44d667c142d7cda120332623eab69f40',
+                url: 'http://iweb.dl.sourceforge.net/project/libpng/zlib/1.2.8/zlib-1.2.8.tar.gz',
+              },
+              locked_version: '1.2.8',
+              source_type: 'url',
+              described_version: '1.2.8',
+              license: 'Zlib',
+            },
+            openssl: {
+              locked_source: {
+                md5: '562986f6937aabc7c11a6d376d8a0d26',
+                extract: 'lax_tar',
+                url: 'http://iweb.dl.sourceforge.net/project/libpng/zlib/1.2.8/zlib-1.2.8.tar.gz',
+              },
+              locked_version: '1.0.1s',
+              source_type: 'url',
+              described_version: '1.0.1s',
+              license: 'OpenSSL',
+            },
+            ruby: {
+              locked_source: {
+                md5: '091b62f0a9796a3c55de2a228a0e6ef3',
+                url: 'https://cache.ruby-lang.org/pub/ruby/2.1/ruby-2.1.8.tar.gz',
+              },
+              locked_version: '2.1.8',
+              source_type: 'url',
+              described_version: '2.1.8',
+              license: 'BSD-2-Clause',
+            },
+            ohai: {
+              locked_source: {
+                git: 'https://github.com/opscode/ohai.git'
+              },
+              locked_version: 'fec0959aa5da5ce7ba0e07740dbc08546a8f53f0',
+              source_type: 'git',
+              described_version: 'master',
+              license: 'Apache-2.0',
+            },
+            chef: {
+              locked_source: {
+                path: '/home/jenkins/workspace/chef-build/architecture/x86_64/platform/ubuntu-10.04/project/chef/role/builder/omnibus/files/../..',
+                options: {
+                  exclude: [
+                    'omnibus/vendor',
+                  ],
+                },
+              },
+              locked_version: 'local_source',
+              source_type: 'path',
+              described_version: 'local_source',
+              license: 'Apache-2.0',
+            },
+          }
+        }
       )
     end
 
@@ -37,7 +99,7 @@ module Omnibus
     let(:artifact) { double('Artifactory::Resource::Artifact', upload: nil) }
     let(:build)    { double('Artifactory::Resource::Build') }
 
-    let(:transformed_metadata_values) do
+    let(:package_properties) do
       {
         "omnibus.architecture" => "x86_64",
         "omnibus.iteration" => 1,
@@ -49,8 +111,13 @@ module Omnibus
         "omnibus.sha256" => "SHA256",
         "omnibus.sha512" => "SHA512",
         "omnibus.version" => "11.0.6",
+        "omnibus.license" => "Apache-2.0",
       }
     end
+    let(:metadata_json_properites) do
+      # we don't attache checksum properties to the *.metadata.json
+      package_properties.delete_if { |k,v| k =~ /md5|sha/ }
+    end
     let(:build_values) do
       {
         "build.name" => "chef",
@@ -86,7 +153,17 @@ module Omnibus
         expect(artifact).to receive(:upload).with(
           repository,
           'com/getchef/chef/11.0.6/ubuntu/14.04/chef.deb',
-          hash_including(transformed_metadata_values),
+          hash_including(package_properties),
+        ).once
+
+        subject.publish
+      end
+
+      it "uploads the package's associated *.metadata.json" do
+        expect(artifact).to receive(:upload).with(
+          repository,
+          'com/getchef/chef/11.0.6/ubuntu/14.04/chef.deb.metadata.json',
+          hash_including(metadata_json_properites),
         ).once
 
         subject.publish
@@ -161,7 +238,7 @@ module Omnibus
           expect(artifact).to receive(:upload).with(
             repository,
             'com/getchef/chef/11.0.6/ubuntu/14.04/chef.deb',
-            hash_including(transformed_metadata_values.merge(delivery_props)),
+            hash_including(package_properties.merge(delivery_props)),
           ).once
 
           subject.publish
@@ -171,7 +248,7 @@ module Omnibus
 
     describe '#metadata_properties_for' do
       it 'returns the transformed package metadata values' do
-        expect(subject.send(:metadata_properties_for, package)).to include(transformed_metadata_values.merge(build_values))
+        expect(subject.send(:metadata_properties_for, package)).to include(package_properties.merge(build_values))
       end
 
       context ':build_record is false' do
@@ -183,7 +260,7 @@ module Omnibus
         end
 
         it 'does not include `build.*` values' do
-          expect(subject.send(:metadata_properties_for, package)).to include(transformed_metadata_values)
+          expect(subject.send(:metadata_properties_for, package)).to include(package_properties)
           expect(subject.send(:metadata_properties_for, package)).to_not include(build_values)
         end
       end