omnibus 4.1.0 → 5.0.0

data/spec/functional/fetchers/net_fetcher_spec.rb

@@ -137,6 +137,16 @@ module Omnibus
         end
       end
 
+      context 'source with no checksum' do
+        let(:source) do
+          { url: source_url }
+        end
+
+        it 'raises an exception' do
+          expect { fetch! }.to raise_error(ChecksumMissing)
+        end
+      end
+
       context 'source with sha1' do
         let(:source) do
           { url: source_url, sha1: source_sha1 }

data/spec/unit/metadata_spec.rb

@@ -22,18 +22,51 @@ module Omnibus
     subject { described_class.new(package, data) }
 
     describe '.arch' do
-      it 'returns the architecture' do
+      let(:architecture) { 'x86_64' }
+
+      before do
         stub_ohai(platform: 'ubuntu', version: '12.04') do |data|
-          data['kernel']['machine'] = 'x86_64'
+          data['kernel']['machine'] = architecture
         end
+      end
+
+      it 'returns the architecture' do
         expect(described_class.arch).to eq('x86_64')
       end
 
+      context 'on solaris' do
+        before do
+          stub_ohai(platform: 'solaris2', version: '5.11') do |data|
+            data['platform'] = 'solaris2'
+            data['kernel']['machine'] = architecture
+          end
+        end
+
+        context 'architecture is Intel-based' do
+          let(:architecture) { 'i86pc' }
+
+          it 'returns i386' do
+            expect(described_class.arch).to eq('i386')
+          end
+        end
+
+        context 'architecture is SPARC-based' do
+          let(:architecture) { 'sun4v' }
+
+          it 'returns sparc' do
+            expect(described_class.arch).to eq('sparc')
+          end
+        end
+      end
+
       context 'on windows' do
-        it 'returns a 32-bit value based on Config.windows_arch being set to x86' do
+        before do
           stub_ohai(platform: 'windows', version: '2012R2') do |data|
-            data['kernel']['machine'] = 'x86_64'
+            data['kernel']['machine'] = architecture
           end
+        end
+
+        it 'returns a 32-bit value based on Config.windows_arch being set to x86' do
           expect(Config).to receive(:windows_arch).and_return(:x86)
           expect(described_class.arch).to eq('i386')
         end
@@ -80,7 +113,9 @@ module Omnibus
       it_behaves_like 'a version manipulator', 'fedora', '11.5', '11'
       it_behaves_like 'a version manipulator', 'freebsd', '10.0', '10'
       it_behaves_like 'a version manipulator', 'gentoo', '2004.3', '2004.3'
+      it_behaves_like 'a version manipulator', 'ios_xr', '6.0.0.14I', '6'
       it_behaves_like 'a version manipulator', 'mac_os_x', '10.9.1', '10.9'
+      it_behaves_like 'a version manipulator', 'nexus', '5.0', '5'
       it_behaves_like 'a version manipulator', 'omnios', 'r151010', 'r151010'
       it_behaves_like 'a version manipulator', 'openbsd', '5.4.4', '5.4'
       it_behaves_like 'a version manipulator', 'opensuse', '5.9', '5.9'

data/spec/unit/packagers/bff_spec.rb

@@ -163,6 +163,15 @@ module Omnibus
         allow(Dir).to receive(:chdir) { |_, &b| b.call }
       end
 
+      it 'chowns the directory' do
+        # A note - the /opt/ here is essentially project.install_dir one level up.
+        # There is nothing magical about 'opt' as a directory.
+        expect(subject).to receive(:shellout!)
+          .with(/chown -R 0:0 #{staging_dir}\/opt$/)
+        subject.create_bff_file
+      end
+
+
       it 'logs a message' do
         output = capture_logging { subject.create_bff_file }
         expect(output).to include('Creating .bff file')

data/spec/unit/packagers/deb_spec.rb

@@ -209,9 +209,9 @@ module Omnibus
         subject.write_md5_sums
         contents = File.read("#{staging_dir}/DEBIAN/md5sums")
 
-         expect(contents).to include("9334770d184092f998009806af702c8c .filea")
-         expect(contents).to include("826e8142e6baabe8af779f5f490cf5f5 file1")
-         expect(contents).to include("1c1c96fd2cf8330db0bfa936ce82f3b9 file2")
+        expect(contents).to include("9334770d184092f998009806af702c8c .filea")
+        expect(contents).to include("826e8142e6baabe8af779f5f490cf5f5 file1")
+        expect(contents).to include("1c1c96fd2cf8330db0bfa936ce82f3b9 file2")
       end
     end
 
@@ -243,8 +243,8 @@ module Omnibus
       before do
         project.install_dir(staging_dir)
 
-        create_file("#{staging_dir}/file1") { "1"*10_000 }
-        create_file("#{staging_dir}/file2") { "2"*20_000 }
+        create_file("#{staging_dir}/file1") { "1" * 10_000 }
+        create_file("#{staging_dir}/file2") { "2" * 20_000 }
       end
 
       it 'stats all the files in the install_dir' do
@@ -390,6 +390,18 @@ module Omnibus
           end
         end
       end
+
+      context '64bit ARM platform' do
+        before do
+          stub_ohai(platform: 'ubuntu', version: '14.04') do |data|
+            data['kernel']['machine'] = 'aarch64'
+          end
+        end
+
+        it 'returns arm64' do
+          expect(subject.safe_architecture).to eq('arm64')
+        end
+      end
     end
   end
 end

data/spec/unit/packagers/msi_spec.rb

@@ -6,7 +6,7 @@ module Omnibus
       Project.new.tap do |project|
         project.name('project')
         project.homepage('https://example.com')
-        project.install_dir('C:/project')
+        project.install_dir(install_dir)
         project.build_version('1.2.3')
         project.build_iteration('2')
         project.maintainer('Chef Software <maintainers@chef.io>')
@@ -18,6 +18,7 @@ module Omnibus
     let(:project_root) { File.join(tmp_path, 'project/root') }
     let(:package_dir)  { File.join(tmp_path, 'package/dir') }
     let(:staging_dir)  { File.join(tmp_path, 'staging/dir') }
+    let(:install_dir)  { 'C:/project' }
 
     before do
       Config.project_root(project_root)
@@ -179,6 +180,26 @@ module Omnibus
         expect(contents).to include('<?include "parameters.wxi" ?>')
         expect(contents).to include('<Property Id="WIXUI_INSTALLDIR" Value="WINDOWSVOLUME" />')
       end
+
+      context 'when fastmsi is not specified' do
+        it 'does not include a reference to the fast msi custom action' do
+          subject.write_source_file
+          contents = File.read("#{staging_dir}/source.wxs")
+          expect(contents).not_to include("<Binary Id=\"CustomActionFastMsiDLL\"")
+        end
+      end
+
+      context 'when fastmsi is specified' do
+        before do
+          subject.fast_msi(true)
+        end
+
+        it 'includes a reference to the fast msi custom action' do
+          subject.write_source_file
+          contents = File.read("#{staging_dir}/source.wxs")
+          expect(contents).to include("<Binary Id=\"CustomActionFastMsiDLL\"")
+        end
+      end
     end
 
     describe '#write_bundle_file' do
@@ -298,7 +319,7 @@ module Omnibus
       end
     end
 
-    describe "#bundle_msi" do
+    describe '#bundle_msi' do
       it 'is a DSL method' do
         expect(subject).to have_exposed_method(:bundle_msi)
       end
@@ -315,6 +336,157 @@ module Omnibus
       end
     end
 
+    describe '#fast_msi' do
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:fast_msi)
+      end
+
+      it 'requires the value to be a TrueClass or a FalseClass' do
+        expect {
+          subject.fast_msi(Object.new)
+        }.to raise_error(InvalidValue)
+      end
+
+      it 'returns the given value' do
+        subject.fast_msi(true)
+        expect(subject.fast_msi).to be_truthy
+      end
+    end
+
+    describe '#zip_command' do
+      it 'returns a String' do
+        expect(subject.zip_command).to be_a(String)
+      end
+
+      it 'sets zip file location to the staging directory' do
+        expect(subject.zip_command).to include("#{subject.windows_safe_path(staging_dir)}\\#{project.name}.zip")
+      end
+    end
+
+    describe '#candle_command' do
+      it 'returns a String' do
+        expect(subject.candle_command).to be_a(String)
+      end
+
+      context 'default behavior' do
+        it 'defines the ProjectSourceDir property' do
+          expect(subject.candle_command).to include("-dProjectSourceDir=")
+        end
+
+        it 'outputs a source.wxs file to the staging directory' do
+          expect(subject.candle_command).to include("#{subject.windows_safe_path(staging_dir, 'source.wxs')}")
+        end
+      end
+
+      context 'when is_bundle is true' do
+        it 'uses the WIX Bootstrapper/Burn extension' do
+          expect(subject.candle_command(is_bundle: true)).to include("-ext WixBalExtension")
+        end
+
+        it 'defines the OmnibusCacheDir property' do
+          expect(subject.candle_command(is_bundle: true)).to include("-dOmnibusCacheDir=")
+        end
+
+        it 'outputs a bundle.wxs file to the staging directory' do
+          expect(subject.candle_command(is_bundle: true)).to include("#{subject.windows_safe_path(staging_dir, 'bundle.wxs')}")
+        end
+      end
+    end
+
+    describe '#heat_command' do
+      it 'returns a String' do
+        expect(subject.heat_command).to be_a(String)
+      end
+
+      context 'when fast_msi is not set' do
+        it 'operates in directory mode' do
+          expect(subject.heat_command).to include("dir \"#{subject.windows_safe_path(project.install_dir)}\"")
+        end
+
+        it 'sets destination to the project location' do
+          expect(subject.heat_command).to include("-dr PROJECTLOCATION")
+        end
+      end
+
+      context 'when fast_msi is set' do
+        before do
+          subject.fast_msi(true)
+        end
+
+        it 'operates in file mode' do
+          expect(subject.heat_command).to include("file \"#{project.name}.zip\"")
+        end
+
+        it 'sets destination to the install location' do
+          expect(subject.heat_command).to include("-dr INSTALLLOCATION")
+        end
+      end
+    end
+
+    describe '#light_command' do
+      it 'returns a String' do
+        expect(subject.light_command("foo")).to be_a(String)
+      end
+
+      context 'default behavior' do
+        let (:command)  { subject.light_command("foo") }
+
+        it 'uses the WIX UI extension' do
+          expect(command).to include("-ext WixUIExtension")
+        end
+
+        it 'includes the project-files and source wixobj files' do
+          expect(command).to include("project-files.wixobj source.wixobj")
+        end
+      end
+
+      context 'when is_bundle is true' do
+        let (:command)  { subject.light_command("foo", is_bundle: true) }
+
+        it 'uses the WIX Bootstrapper/Burn extension' do
+          expect(command).to include("-ext WixBalExtension")
+        end
+
+        it 'includes the bundle wixobj file' do
+          expect(command).to include("bundle.wixobj")
+        end
+      end
+    end
+
+    describe '#gem_path' do
+      let(:install_dir) { File.join(tmp_path, 'install_dir') }
+
+      before do
+        create_directory(install_dir)
+      end
+
+      after do
+        remove_directory(install_dir)
+      end
+
+      it 'is a DSL method' do
+        expect(subject).to have_exposed_method(:gem_path)
+      end
+
+      it 'requires the value to be a String' do
+        expect {
+          subject.gem_path(Object.new)
+        }.to raise_error(InvalidValue)
+      end
+
+      it 'globs for gems under the install directory' do
+        expected_gem_path = 'something/gems/athing-1.0.0'
+        create_directory(File.join(install_dir, expected_gem_path))
+        expect(subject.gem_path('athing-*')).to eq(expected_gem_path)
+      end
+
+      it 'returns the gem directory when no argument is given' do
+        expected_gem_path = 'foo/bar123/gems'
+        create_directory(File.join(install_dir, expected_gem_path))
+        expect(subject.gem_path).to eq(expected_gem_path)
+      end
+    end
+
     context 'when signing parameters are provided' do
       let(:msi) { 'somemsi.msi' }
 
@@ -343,7 +515,7 @@ module Omnibus
           subject.sign_package(msi)
         end
 
-        describe "#timestamp_servers" do
+        describe '#timestamp_servers' do
           it "defaults to using ['http://timestamp.digicert.com','http://timestamp.verisign.com/scripts/timestamp.dll']" do
             subject.signing_identity('foo')
             expect(subject).to receive(:try_timestamp).with(msi, 'http://timestamp.digicert.com').and_return(false)

data/spec/unit/packagers/rpm_spec.rb

@@ -19,6 +19,7 @@ module Omnibus
     let(:project_root) { File.join(tmp_path, 'project/root') }
     let(:package_dir)  { File.join(tmp_path, 'package/dir') }
     let(:staging_dir)  { File.join(tmp_path, 'staging/dir') }
+    let(:architecture) { 'x86_64' }
 
     before do
       Config.project_root(project_root)
@@ -32,7 +33,9 @@ module Omnibus
       create_directory("#{staging_dir}/SOURCES")
       create_directory("#{staging_dir}/SPECS")
 
-      stub_ohai(platform: 'redhat', version: '6.5')
+      stub_ohai(platform: 'redhat', version: '6.5') do |data|
+        data['kernel']['machine'] = architecture
+      end
     end
 
     describe '#signing_passphrase' do
@@ -144,7 +147,6 @@ module Omnibus
         expect(contents).to include("Version: 1.2.3")
         expect(contents).to include("Release: 2.el6")
         expect(contents).to include("Summary:  The full stack of project")
-        expect(contents).to include("BuildArch: x86_64")
         expect(contents).to include("AutoReqProv: no")
         expect(contents).to include("BuildRoot: %buildroot")
         expect(contents).to include("Prefix: /")
@@ -237,6 +239,21 @@ module Omnibus
           expect(contents).to include("%dir %attr(0555,root,root) /usr/lib")
         end
       end
+
+      context 'when the platform_family is wrlinux' do
+        let(:spec_file) { "#{staging_dir}/SPECS/project-1.2.3-2.nexus5.x86_64.rpm.spec" }
+
+        before do
+          stub_ohai(platform: 'nexus', version: '5')
+        end
+
+        it 'writes out a spec file with no BuildArch' do
+          subject.write_rpm_spec
+          contents = File.read(spec_file)
+
+          expect(contents).not_to include("BuildArch")
+        end
+      end
     end
 
     describe '#create_rpm_file' do
@@ -252,7 +269,7 @@ module Omnibus
 
       it 'uses the correct command' do
         expect(subject).to receive(:shellout!)
-          .with(/rpmbuild -bb --buildroot/)
+          .with(/rpmbuild --target #{architecture} -bb --buildroot/)
         subject.create_rpm_file
       end
 
@@ -366,6 +383,36 @@ module Omnibus
           expect(output).to include("The `version' component of RPM package names can only include")
         end
       end
+
+      context 'when the build is for nexus' do
+        before do
+          project.build_version('1.2-3')
+          stub_ohai(platform: 'nexus', version: '5')
+        end
+
+        it 'returns the value while logging a message' do
+          output = capture_logging do
+            expect(subject.safe_version).to eq('1.2_3')
+          end
+
+          expect(output).to include("rpmbuild on Wind River Linux does not support this")
+        end
+      end
+
+      context 'when the build is for ios_xr' do
+        before do
+          project.build_version('1.2-3')
+          stub_ohai(platform: 'ios_xr', version: '6.0.0.14I')
+        end
+
+        it 'returns the value while logging a message' do
+          output = capture_logging do
+            expect(subject.safe_version).to eq('1.2_3')
+          end
+
+          expect(output).to include("rpmbuild on Wind River Linux does not support this")
+        end
+      end
     end
 
     describe '#safe_architecture' do