omnibus 3.1.1 → 3.2.0.rc.1

data/lib/omnibus/software_s3_urls.rb

@@ -1,50 +0,0 @@
-#
-# Copyright 2013-2014 Chef Software, Inc.
-#
-# Licensed under the Apache License, Version 2.0 (the "License");
-# you may not use this file except in compliance with the License.
-# You may obtain a copy of the License at
-#
-#     http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing, software
-# distributed under the License is distributed on an "AS IS" BASIS,
-# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-# See the License for the specific language governing permissions and
-# limitations under the License.
-#
-
-module Omnibus
-  module SoftwareS3URLs
-    class InsufficientSpecification < ArgumentError
-      def initialize(key, package)
-        @key, @package = key, package
-      end
-
-      def to_s
-        "Software must specify a #{@key} to cache it in S3 (#{@package})!"
-      end
-    end
-
-    def config
-      Omnibus.config
-    end
-
-    def url_for(software)
-      "http://#{config.s3_bucket}.s3.amazonaws.com/#{key_for_package(software)}"
-    end
-
-    private
-
-    def key_for_package(package)
-      return @key_for_package if @key_for_package
-
-      package.name     || raise(InsufficientSpecification.new(:name, package))
-      package.version  || raise(InsufficientSpecification.new(:version, package))
-      package.checksum || raise(InsufficientSpecification.new(:checksum, package))
-
-      @key_for_package = "#{package.name}-#{package.version}-#{package.checksum}"
-      @key_for_package
-    end
-  end
-end

data/spec/unit/artifact_spec.rb

@@ -1,91 +0,0 @@
-require 'spec_helper'
-
-describe Omnibus::Artifact do
-
-  let(:path) { 'build_os=centos-5,machine_architecture=x86,role=oss-builder/pkg/demoproject-11.4.0-1.el5.x86_64.rpm' }
-
-  let(:content) { StringIO.new("this is the package content\n") }
-
-  let(:md5) { 'd41d8cd98f00b204e9800998ecf8427e' }
-
-  let(:sha256) { 'e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855' }
-
-  let(:platforms) { [%w(el 5 x86_64), ['sles', '11.2', 'x86_64']] }
-
-  let(:artifact) { Omnibus::Artifact.new(path, platforms,  version: '11.4.0-1') }
-
-  it 'has the path to the package' do
-    expect(artifact.path).to eq(path)
-  end
-
-  it 'has a list of platforms the package supports' do
-    expect(artifact.platforms).to eq(platforms)
-  end
-
-  it 'generates a MD5 of an artifact' do
-    expect(File).to receive(:open).with(path).and_return(content)
-    expect(artifact.md5).to eq(md5)
-  end
-
-  it 'generates a SHA256 of an artifact' do
-    expect(File).to receive(:open).with(path).and_return(content)
-    expect(artifact.sha256).to eq(sha256)
-  end
-
-  it "generates 'flat' metadata" do
-    expect(File).to receive(:open).twice.with(path).and_return(content)
-    flat_metadata = artifact.flat_metadata
-    expect(flat_metadata['platform']).to eq('el')
-    expect(flat_metadata['platform_version']).to eq('5')
-    expect(flat_metadata['arch']).to eq('x86_64')
-    expect(flat_metadata['version']).to eq('11.4.0-1')
-    expect(flat_metadata['basename']).to eq('demoproject-11.4.0-1.el5.x86_64.rpm')
-    expect(flat_metadata['md5']).to eq(md5)
-    expect(flat_metadata['sha256']).to eq(sha256)
-  end
-
-  it 'adds the package to a release manifest' do
-    expected = {
-      'el' => {
-        '5' => { 'x86_64' => { '11.4.0-1' => '/el/5/x86_64/demoproject-11.4.0-1.el5.x86_64.rpm' } },
-      },
-      'sles' => {
-        '11.2' => { 'x86_64' => { '11.4.0-1' => '/el/5/x86_64/demoproject-11.4.0-1.el5.x86_64.rpm' } },
-      },
-    }
-
-    manifest = artifact.add_to_release_manifest!({})
-    expect(manifest).to eq(expected)
-  end
-
-  it 'adds the package to a v2 release manifest' do
-    expect(File).to receive(:open).with(path).twice.and_return(content)
-    expected = {
-      'el' => {
-        '5' => {
-          'x86_64' => {
-            '11.4.0-1' => {
-              'relpath' => '/el/5/x86_64/demoproject-11.4.0-1.el5.x86_64.rpm',
-              'md5' => md5,
-              'sha256' => sha256,
-            },
-          },
-        },
-      },
-      'sles' => {
-        '11.2' => {
-          'x86_64' => {
-            '11.4.0-1' => {
-              'relpath' => '/el/5/x86_64/demoproject-11.4.0-1.el5.x86_64.rpm',
-              'md5' => md5,
-              'sha256' => sha256,
-            },
-          },
-        },
-      },
-    }
-    v2_manifest = artifact.add_to_v2_release_manifest!({})
-    expect(v2_manifest).to eq(expected)
-  end
-
-end

data/spec/unit/overrides_spec.rb

@@ -1,102 +0,0 @@
-require 'spec_helper'
-
-describe Omnibus::Overrides do
-  describe '#parse_file' do
-
-    let(:overrides) { Omnibus::Overrides.parse_file(file) }
-    subject { overrides }
-
-    context 'with a valid overrides file' do
-      let(:file) { overrides_path('good') }
-
-      its(:size) { should eq(5) }
-      its(['foo']) { should eq('1.2.3') }
-      its(['bar']) { should eq('0.0.1') }
-      its(['baz']) { should eq('deadbeefdeadbeefdeadbeefdeadbeef') }
-      its(['spunky']) { should eq('master') }
-      its(['monkey']) { should eq('release') }
-    end
-
-    context 'with an overrides file that contains a bad line' do
-      let(:file) { overrides_path('bad_line') }
-
-      it 'fails' do
-        expect { overrides }.to raise_error(ArgumentError, "Invalid overrides line: 'THIS IS A BAD LINE'")
-      end
-    end
-
-    context 'with an overrides file that contains duplicates' do
-      let(:file) { overrides_path('with_dupes') }
-      let(:duplicated_package) { 'erchef' }
-      it 'fails' do
-        expect { overrides }.to raise_error(ArgumentError, "Multiple overrides present for '#{duplicated_package}' in overrides file #{file}!")
-      end
-    end
-
-    context "when passed 'nil'" do
-      let(:file) { nil }
-      it { should be_nil }
-    end
-  end # parse_file
-
-  describe '#resolve_override_file' do
-    subject { Omnibus::Overrides.resolve_override_file }
-
-    context 'with no environment variable set' do
-      before :each do
-        stub_const('Omnibus::Overrides::DEFAULT_OVERRIDE_FILE_NAME', new_default_file)
-      end
-
-      context 'and a non-existent overrides file' do
-        let(:new_default_file) { '/this/file/totally/does/not/exist.txt' }
-        it { should be_nil }
-      end
-
-      context 'with an existing overrides file' do
-        let(:path) { overrides_path('good') }
-        let(:new_default_file) { path }
-        it { should eq(path) }
-      end
-    end # no environment variable
-
-    context 'with OMNIBUS_OVERRIDE_FILE environment variable set' do
-      before { stub_env('OMNIBUS_OVERRIDE_FILE', env_override_file) }
-
-      context 'to an existing file' do
-        let(:path) { overrides_path('good') }
-        let(:env_override_file) { path  }
-        it { should eq(path) }
-      end
-
-      context 'to a non-existent file' do
-        let(:env_override_file) { '/this/file/totally/does/not/exist.txt' }
-        it { should be_nil }
-      end
-
-      context 'to a non-existent file, but with an existing DEFAULT_OVERRIDE_FILE_NAME file' do
-        let(:env_override_file) { '/this/file/totally/does/not/exist.txt' }
-        let(:new_default_file) { overrides_path('good') }
-
-        it "should still return 'nil', because environment variable has priority" do
-          stub_const('Omnibus::Overrides::DEFAULT_OVERRIDE_FILE_NAME', new_default_file)
-
-          expect(File.exist?(Omnibus::Overrides::DEFAULT_OVERRIDE_FILE_NAME)).to be_true
-          expect(subject).to be_nil
-        end
-      end
-    end
-  end
-
-  describe '#overrides' do
-    context 'when an overrides file cannot be found' do
-      before :each do
-        Omnibus::Overrides.stub(:resolve_override_file).and_return(nil)
-      end
-
-      it 'returns an empty hash' do
-        expect(Omnibus::Overrides.overrides).to eq({})
-      end
-    end
-  end
-
-end

data/spec/unit/package_release_spec.rb

@@ -1,180 +0,0 @@
-require 'spec_helper'
-
-describe Omnibus::PackageRelease do
-  let(:s3_key) { 's3key' }
-  let(:s3_secret) { 'hey-bezos-store-my-stuff' }
-  let(:s3_bucket) { 'myorg-omnibus-packages' }
-  let(:pkg_path) { 'pkg/chef_11.4.0-183-g2c0040c-0.el6.x86_64.rpm' }
-  let(:pkg_metadata_path) { "#{pkg_path}.metadata.json" }
-
-  let(:config) do
-    {
-      release_s3_access_key: s3_key,
-      release_s3_secret_key: s3_secret,
-      release_s3_bucket: s3_bucket,
-    }
-  end
-  subject(:package_release) do
-    Omnibus::PackageRelease.new(pkg_path)
-  end
-
-  it 'has a package path' do
-    expect(package_release.package_path).to eq(pkg_path)
-  end
-
-  it "defaults to `:private' access policy" do
-    expect(package_release.access_policy).to eq(:private)
-  end
-
-  describe 'validating configuration' do
-
-    before do
-      Omnibus.stub(:config).and_return(config)
-    end
-
-    it 'validates that the s3 key is set' do
-      config.delete(:release_s3_access_key)
-      expect { package_release.validate_config! }.to raise_error(Omnibus::InvalidS3ReleaseConfiguration)
-    end
-
-    it 'validates that the s3 secret key is set' do
-      config.delete(:release_s3_secret_key)
-      expect { package_release.validate_config! }.to raise_error(Omnibus::InvalidS3ReleaseConfiguration)
-    end
-
-    it 'validates that the s3 bucket is set' do
-      config.delete(:release_s3_bucket)
-      expect { package_release.validate_config! }.to raise_error(Omnibus::InvalidS3ReleaseConfiguration)
-    end
-
-    it 'does not error on a valid configuration' do
-      expect { package_release.validate_config! }.to_not raise_error
-    end
-  end
-
-  describe 'validating package for upload' do
-    it 'ensures that the package file exists' do
-      expect { package_release.validate_package! }.to raise_error(Omnibus::NoPackageFile)
-    end
-
-    it 'ensures that there is a metadata file for the package' do
-      expect(File).to receive(:exist?).with(pkg_path).and_return(true)
-      expect(File).to receive(:exist?).with(pkg_metadata_path).and_return(false)
-      expect { package_release.validate_package! }.to raise_error(Omnibus::NoPackageMetadataFile)
-    end
-  end
-
-  context 'with a valid config and package' do
-
-    let(:basename) { 'chef_11.4.0-183-g2c0040c-0.el6.x86_64.rpm' }
-    let(:md5) { '016f2e0854c69901b3f0ad8f99ffdb75' }
-    let(:platform_path) { 'el/6/x86_64' }
-    let(:pkg_content) { 'expected package content' }
-
-    let(:metadata_json) do
-      <<-E
-{
-  "platform": "el",
-  "platform_version": "6",
-  "arch": "x86_64",
-  "version": "11.4.0-183-g2c0040c",
-  "basename": "#{basename}",
-  "md5": "#{md5}",
-  "sha256": "21191ab698d1663a5e738e470fad16a2c6efee05ed597002f2e846ec80ade38c"
-}
-      E
-    end
-
-    before do
-      package_release.stub(:config).and_return(config)
-      File.stub(:exist?).with(pkg_metadata_path).and_return(true)
-      File.stub(:exist?).with(pkg_path).and_return(true)
-      IO.stub(:read).with(pkg_metadata_path).and_return(metadata_json)
-      IO.stub(:read).with(pkg_path).and_return(pkg_content)
-    end
-
-    it 'configures s3 with the given credentials' do
-      expected_s3_config = {
-        access_key: s3_key,
-        secret_access_key: s3_secret,
-        bucket: s3_bucket,
-        adaper: :net_http,
-      }
-      expect(UberS3).to receive(:new).with(expected_s3_config)
-      package_release.s3_client
-    end
-
-    it 'generates the relative path for the package s3 key' do
-      expect(package_release.platform_path).to eq(platform_path)
-    end
-
-    it 'uploads the package and metadata' do
-      expect(package_release.s3_client).to receive(:store).with(
-        "#{platform_path}/#{basename}.metadata.json",
-        metadata_json,
-        access: :private,
-      )
-      expect(package_release.s3_client).to receive(:store).with(
-        "#{platform_path}/#{basename}",
-        pkg_content,
-        access: :private,
-        content_md5: md5,
-      )
-      package_release.release
-    end
-
-    context 'and a callback is given for after upload' do
-      let(:upload_records) { [] }
-
-      subject(:package_release) do
-        Omnibus::PackageRelease.new(pkg_path) do |uploaded|
-          upload_records << uploaded
-        end
-      end
-
-      it 'fires the after_upload callback for each item uploaded' do
-        expect(package_release.s3_client).to receive(:store).with(
-          "#{platform_path}/#{basename}.metadata.json",
-          metadata_json,
-          access: :private,
-        )
-        expect(package_release.s3_client).to receive(:store).with(
-          "#{platform_path}/#{basename}",
-          pkg_content,
-          access: :private,
-          content_md5: md5,
-        )
-        package_release.release
-
-        expect(upload_records).to eq [
-          "#{platform_path}/#{basename}.metadata.json",
-          "#{platform_path}/#{basename}",
-        ]
-      end
-    end
-
-    context 'and the package is public' do
-
-      subject(:package_release) do
-        Omnibus::PackageRelease.new(pkg_path, access: :public_read)
-      end
-
-      it 'uploads the package and metadata' do
-        expect(package_release.s3_client).to receive(:store).with(
-          "#{platform_path}/#{basename}.metadata.json",
-          metadata_json,
-          access: :public_read,
-        )
-        expect(package_release.s3_client).to receive(:store).with(
-          "#{platform_path}/#{basename}",
-          pkg_content,
-          access: :public_read,
-          content_md5: md5,
-        )
-        package_release.release
-      end
-    end
-
-  end
-
-end

data/spec/unit/sugar_spec.rb

@@ -1,17 +0,0 @@
-require 'spec_helper'
-
-describe Omnibus::Software do
-  it 'includes the Chef Sugar DSL methods' do
-    expect(described_class).to be_method_defined(:windows?)
-    expect(described_class).to be_method_defined(:vagrant?)
-    expect(described_class).to be_method_defined(:_64_bit?)
-  end
-end
-
-describe Omnibus::Project do
-  it 'includes the Chef Sugar DSL methods' do
-    expect(described_class).to be_method_defined(:windows?)
-    expect(described_class).to be_method_defined(:vagrant?)
-    expect(described_class).to be_method_defined(:_64_bit?)
-  end
-end