omnibus 1.3.0 → 2.0.0.rc1

data/lib/omnibus/fetchers/net_fetcher.rb

@@ -1,5 +1,5 @@
 #
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Copyright:: Copyright (c) 2012-2014 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -16,7 +16,6 @@
 #
 
 module Omnibus
-
   class UnsupportedURIScheme < ArgumentError
   end
 
@@ -25,7 +24,6 @@ module Omnibus
 
   # Fetcher Implementation for HTTP and FTP hosted tarballs
   class NetFetcher < Fetcher
-
     name :net
 
     attr_reader :name
@@ -46,10 +44,10 @@ module Omnibus
     end
 
     def description
-      s=<<-E
+      <<-E
 source URI:     #{source_uri}
 checksum:       #{@checksum}
-local location: #@project_file
+local location: #{@project_file}
 E
     end
 
@@ -61,7 +59,6 @@ E
       !File.exists?(project_file) || Digest::MD5.file(project_file) != @checksum
     end
 
-
     def clean
       if File.exists?(project_dir)
         log "cleaning existing build from #{project_dir}"
@@ -75,31 +72,29 @@ E
         download
         verify_checksum!
       else
-        log "Cached copy of source tarball up to date"
+        log 'Cached copy of source tarball up to date'
       end
     end
 
     def get_with_redirect(url, headers, limit = 10)
-      raise ArgumentError, 'HTTP redirect too deep' if limit == 0
+      fail ArgumentError, 'HTTP redirect too deep' if limit == 0
       log "getting from #{url} with #{limit} redirects left"
 
-      if !url.kind_of?(URI)
-        url = URI.parse(url)
-      end
+      url = URI.parse(url) unless url.kind_of?(URI)
 
       req = Net::HTTP::Get.new(url.request_uri, headers)
 
       http_client = if http_proxy && !excluded_from_proxy?(url.host)
-        Net::HTTP::Proxy(http_proxy.host, http_proxy.port, http_proxy.user, http_proxy.password).new(url.host, url.port)
-      else
-        Net::HTTP.new(url.host, url.port)
-      end
-      http_client.use_ssl = (url.scheme == "https")
+                      Net::HTTP::Proxy(http_proxy.host, http_proxy.port, http_proxy.user, http_proxy.password).new(url.host, url.port)
+                    else
+                      Net::HTTP.new(url.host, url.port)
+                    end
+      http_client.use_ssl = (url.scheme == 'https')
 
       response = http_client.start { |http| http.request(req) }
       case response
       when Net::HTTPSuccess
-        open(project_file, "wb") do |f|
+        open(project_file, 'wb') do |f|
           f.write(response.body)
         end
       when Net::HTTPRedirection
@@ -117,7 +112,7 @@ E
     # constructs a http_proxy uri from HTTP_PROXY* env vars
     def http_proxy
       @http_proxy ||= begin
-        proxy = get_env('HTTP_PROXY') or return
+        proxy = get_env('HTTP_PROXY') || return
         proxy = "http://#{proxy}" unless proxy =~ /^https?:/
         uri = URI.parse(proxy)
         uri.user ||= get_env('HTTP_PROXY_USER')
@@ -130,14 +125,14 @@ E
     # the 'no_proxy' variable contains a list of host suffixes separated by comma
     # example: example.com,www.examle.org,localhost
     def excluded_from_proxy?(host)
-      no_proxy = get_env('no_proxy') || ""
+      no_proxy = get_env('no_proxy') || ''
       no_proxy.split(/\s*,\s*/).any? { |pattern| host.end_with? pattern }
     end
 
     def download
       tries = 5
       begin
-        log "\033[1;31m#{source[:warning]}\033[0m" if source.has_key?(:warning)
+        log "\033[1;31m#{source[:warning]}\033[0m" if source.key?(:warning)
         log "fetching #{project_file} from #{source_uri}"
 
         case source_uri.scheme
@@ -145,11 +140,11 @@ E
           headers = {
             'accept-encoding' => '',
           }
-          if source.has_key?(:cookie)
+          if source.key?(:cookie)
             headers['Cookie'] = source[:cookie]
           end
           get_with_redirect(source_uri, headers)
-        when "ftp"
+        when 'ftp'
           Net::FTP.open(source_uri.host) do |ftp|
             ftp.passive = true
             ftp.login
@@ -157,11 +152,12 @@ E
             ftp.close
           end
         else
-          raise UnsupportedURIScheme, "Don't know how to download from #{source_uri}"
+          fail UnsupportedURIScheme, "Don't know how to download from #{source_uri}"
         end
-      rescue Exception => e
-        if ( tries -= 1 ) != 0
-          log "retrying failed download..."
+      rescue Exception
+        tries = tries - 1
+        if tries != 0
+          log 'retrying failed download...'
           retry
         else
           raise
@@ -175,10 +171,10 @@ E
     def verify_checksum!
       actual_md5 = Digest::MD5.file(project_file)
       unless actual_md5 == @checksum
-        log "Invalid MD5 for #@name"
+        log "Invalid MD5 for #{@name}"
         log "Expected: #{@checksum}"
         log "Actual:   #{actual_md5}"
-        raise InvalidSourceFile, "Checksum of downloaded file #{project_file} doesn't match expected"
+        fail InvalidSourceFile, "Checksum of downloaded file #{project_file} doesn't match expected"
       end
     end
 
@@ -189,11 +185,11 @@ E
       when Proc
         cmd.call
       when String
-        shell = Mixlib::ShellOut.new(cmd, :live_stream => STDOUT)
+        shell = Mixlib::ShellOut.new(cmd, live_stream: STDOUT)
         shell.run_command
         shell.error!
       else
-        raise "Don't know how to extract command for #{cmd.class} class"
+        fail "Don't know how to extract command for #{cmd.class} class"
       end
     rescue Exception => e
       ErrorReporter.new(e, self).explain("Failed to unpack archive at #{project_file} (#{e.class}: #{e.message.strip})")
@@ -201,21 +197,21 @@ E
     end
 
     def extract_cmd
-      if project_file.end_with?(".gz") || project_file.end_with?(".tgz")
+      if project_file.end_with?('.gz') || project_file.end_with?('.tgz')
         "gzip -dc  #{project_file} | ( cd #{source_dir} && tar -xf - )"
-      elsif project_file.end_with?(".bz2")
+      elsif project_file.end_with?('.bz2')
         "bzip2 -dc  #{project_file} | ( cd #{source_dir} && tar -xf - )"
-      elsif project_file.end_with?(".7z")
+      elsif project_file.end_with?('.7z')
         "7z.exe x #{project_file} -o#{source_dir} -r -y"
-      elsif project_file.end_with?(".zip")
+      elsif project_file.end_with?('.zip')
         "unzip #{project_file} -d #{source_dir}"
-      elsif project_file.end_with?(".xz") || project_file.end_with?(".txz")
+      elsif project_file.end_with?('.xz') || project_file.end_with?('.txz')
         "xz -dc #{project_file} | ( cd #{source_dir} && tar -xf - )"
       else
-        #if we don't recognize the extension, simply copy over the file
-        Proc.new do
+        # if we don't recognize the extension, simply copy over the file
+        proc do
           log "#{project_file} not an archive. Copying to #{project_dir}"
-          # hack hack hack, no project dir yet
+          # WARNING: hack hack hack, no project dir yet
           FileUtils.mkdir_p(project_dir)
           FileUtils.cp(project_file, project_dir)
         end

data/lib/omnibus/fetchers/path_fetcher.rb

@@ -1,13 +1,13 @@
 #
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Copyright:: Copyright (c) 2012-2014 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
-# 
+#
 #     http://www.apache.org/licenses/LICENSE-2.0
-# 
+#
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -16,10 +16,8 @@
 #
 
 module Omnibus
-
   # Fetcher implementation for projects on the filesystem
   class PathFetcher < Fetcher
-
     name :path
 
     def initialize(software)
@@ -30,18 +28,18 @@ module Omnibus
     end
 
     def description
-      s=<<-E
+      <<-E
 source path:    #{@source[:path]}
 local location: #{@project_dir}
 E
     end
-    
+
     def rsync
-      if OHAI.platform == "windows"
+      if OHAI.platform == 'windows'
         # Robocopy's return code is 1 if it succesfully copies over the
         # files and 0 if the files are already existing at the destination
         sync_cmd = "robocopy #{@source[:path]}\\ #{@project_dir}\\ /MIR /S"
-        shell = Mixlib::ShellOut.new(sync_cmd, :returns => [0, 1])
+        shell = Mixlib::ShellOut.new(sync_cmd, returns: [0, 1])
       else
         sync_cmd = "rsync --delete -a #{@source[:path]}/ #{@project_dir}/"
         shell = Mixlib::ShellOut.new(sync_cmd)

data/lib/omnibus/fetchers/s3_cache_fetcher.rb

@@ -1,13 +1,13 @@
 #
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Copyright:: Copyright (c) 2012-2014 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
-# 
+#
 #     http://www.apache.org/licenses/LICENSE-2.0
-# 
+#
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -39,4 +39,3 @@ module Omnibus
     end
   end
 end
-

data/lib/omnibus/fetchers.rb

@@ -1,13 +1,13 @@
 #
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Copyright:: Copyright (c) 2012-2014 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
 # you may not use this file except in compliance with the License.
 # You may obtain a copy of the License at
-# 
+#
 #     http://www.apache.org/licenses/LICENSE-2.0
-# 
+#
 # Unless required by applicable law or agreed to in writing, software
 # distributed under the License is distributed on an "AS IS" BASIS,
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.

data/lib/omnibus/health_check.rb

@@ -1,5 +1,5 @@
 #
-# Copyright:: Copyright (c) 2012 Opscode, Inc.
+# Copyright:: Copyright (c) 2012-2014 Chef Software, Inc.
 # License:: Apache License, Version 2.0
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -17,38 +17,37 @@
 
 module Omnibus
   class HealthCheck
-
     WHITELIST_LIBS = [
-                      /ld-linux/,
-                      /libc\.so/,
-                      /libcrypt\.so/,
-                      /libdl/,
-                      /libfreebl\d\.so/,
-                      /libgcc_s\.so/,
-                      /libm\.so/,
-                      /libnsl\.so/,
-                      /libpthread/,
-                      /libresolv\.so/,
-                      /librt\.so/,
-                      /libstdc\+\+\.so/,
-                      /libutil\.so/,
-                      /linux-vdso.+/,
-                      /linux-gate\.so/
-                     ]
+      /ld-linux/,
+      /libc\.so/,
+      /libcrypt\.so/,
+      /libdl/,
+      /libfreebl\d\.so/,
+      /libgcc_s\.so/,
+      /libm\.so/,
+      /libnsl\.so/,
+      /libpthread/,
+      /libresolv\.so/,
+      /librt\.so/,
+      /libstdc\+\+\.so/,
+      /libutil\.so/,
+      /linux-vdso.+/,
+      /linux-gate\.so/,
+    ]
 
     ARCH_WHITELIST_LIBS = [
-                           /libc\.so/,
-                           /libcrypt\.so/,
-                           /libdb-5\.3\.so/,
-                           /libdl\.so/,
-                           /libffi\.so/,
-                           /libgdbm\.so/,
-                           /libm\.so/,
-                           /libnsl\.so/,
-                           /libpthread\.so/,
-                           /librt\.so/,
-                           /libutil\.so/
-                          ]
+      /libc\.so/,
+      /libcrypt\.so/,
+      /libdb-5\.3\.so/,
+      /libdl\.so/,
+      /libffi\.so/,
+      /libgdbm\.so/,
+      /libm\.so/,
+      /libnsl\.so/,
+      /libpthread\.so/,
+      /librt\.so/,
+      /libutil\.so/,
+    ]
 
     AIX_WHITELIST_LIBS = [
       /libpthread\.a/,
@@ -61,78 +60,78 @@ module Omnibus
     ]
 
     SOLARIS_WHITELIST_LIBS = [
-                              /libaio\.so/,
-                              /libavl\.so/,
-                              /libcrypt_[di]\.so/,
-                              /libcrypto.so/,
-                              /libcurses\.so/,
-                              /libdoor\.so/,
-                              /libgen\.so/,
-                              /libmd5\.so/,
-                              /libmd\.so/,
-                              /libmp\.so/,
-                              /libscf\.so/,
-                              /libsec\.so/,
-                              /libsocket\.so/,
-                              /libssl.so/,
-                              /libthread.so/,
-                              /libuutil\.so/,
-                              /libz.so/,
-                              # solaris 11 libraries:
-                              /libc\.so\.1/,
-                              /libm\.so\.2/,
-                              /libdl\.so\.1/,
-                              /libnsl\.so\.1/,
-                              /libpthread\.so\.1/,
-                              /librt\.so\.1/,
-                              /libcrypt\.so\.1/,
-                              /libgdbm\.so\.3/,
-                              # solaris 9 libraries:
-                              /libm\.so\.1/,
-                              /libc_psr\.so\.1/,
-                              /s9_preload\.so\.1/
-                             ]
+      /libaio\.so/,
+      /libavl\.so/,
+      /libcrypt_[di]\.so/,
+      /libcrypto.so/,
+      /libcurses\.so/,
+      /libdoor\.so/,
+      /libgen\.so/,
+      /libmd5\.so/,
+      /libmd\.so/,
+      /libmp\.so/,
+      /libscf\.so/,
+      /libsec\.so/,
+      /libsocket\.so/,
+      /libssl.so/,
+      /libthread.so/,
+      /libuutil\.so/,
+      /libz.so/,
+      # solaris 11 libraries:
+      /libc\.so\.1/,
+      /libm\.so\.2/,
+      /libdl\.so\.1/,
+      /libnsl\.so\.1/,
+      /libpthread\.so\.1/,
+      /librt\.so\.1/,
+      /libcrypt\.so\.1/,
+      /libgdbm\.so\.3/,
+      # solaris 9 libraries:
+      /libm\.so\.1/,
+      /libc_psr\.so\.1/,
+      /s9_preload\.so\.1/,
+    ]
 
     SMARTOS_WHITELIST_LIBS = [
-                              /libm.so/,
-                              /libpthread.so/,
-                              /librt.so/,
-                              /libsocket.so/,
-                              /libdl.so/,
-                              /libnsl.so/,
-                              /libgen.so/,
-                              /libmp.so/,
-                              /libmd.so/,
-                              /libc.so/,
-                              /libgcc_s.so/,
-                              /libstdc\+\+\.so/,
-                              /libcrypt.so/
-                             ]
+      /libm.so/,
+      /libpthread.so/,
+      /librt.so/,
+      /libsocket.so/,
+      /libdl.so/,
+      /libnsl.so/,
+      /libgen.so/,
+      /libmp.so/,
+      /libmd.so/,
+      /libc.so/,
+      /libgcc_s.so/,
+      /libstdc\+\+\.so/,
+      /libcrypt.so/,
+    ]
 
     MAC_WHITELIST_LIBS = [
-                          /libobjc\.A\.dylib/,
-                          /libSystem\.B\.dylib/,
-                          /CoreFoundation/,
-                          /Tcl$/,
-                          /Cocoa$/,
-                          /Carbon$/,
-                          /IOKit$/,
-                          /Tk$/,
-                          /libutil\.dylib/,
-                          /libffi\.dylib/,
-                          /libncurses\.5\.4\.dylib/,
-                          /libiconv/,
-                          /libstdc\+\+\.6\.dylib/
-                         ]
+      /libobjc\.A\.dylib/,
+      /libSystem\.B\.dylib/,
+      /CoreFoundation/,
+      /Tcl$/,
+      /Cocoa$/,
+      /Carbon$/,
+      /IOKit$/,
+      /Tk$/,
+      /libutil\.dylib/,
+      /libffi\.dylib/,
+      /libncurses\.5\.4\.dylib/,
+      /libiconv/,
+      /libstdc\+\+\.6\.dylib/,
+    ]
 
     FREEBSD_WHITELIST_LIBS = [
-                               /libc\.so/,
-                               /libcrypt\.so/,
-                               /libm\.so/,
-                               /librt\.so/,
-                               /libthr\.so/,
-                               /libutil\.so/
-                              ]
+      /libc\.so/,
+      /libcrypt\.so/,
+      /libm\.so/,
+      /librt\.so/,
+      /libthr\.so/,
+      /libutil\.so/,
+    ]
 
     def self.log(msg)
       puts "[health_check] #{msg}"
@@ -140,9 +139,9 @@ module Omnibus
 
     def self.run(install_dir, whitelist_files = [])
       case OHAI.platform
-      when "mac_os_x"
+      when 'mac_os_x'
         bad_libs = health_check_otool(install_dir, whitelist_files)
-      when "aix"
+      when 'aix'
         bad_libs = health_check_aix(install_dir, whitelist_files)
       else
         bad_libs = health_check_ldd(install_dir, whitelist_files)
@@ -165,38 +164,38 @@ module Omnibus
             end
           end
         end
-        log "*** Health Check Failed, Summary follows:"
-        bad_omnibus_libs, bad_omnibus_bins = bad_libs.keys.partition { |k| k.include? "embedded/lib" }
-        log "*** The following Omnibus-built libraries have unsafe or unmet dependencies:"
+        log '*** Health Check Failed, Summary follows:'
+        bad_omnibus_libs, bad_omnibus_bins = bad_libs.keys.partition { |k| k.include? 'embedded/lib' }
+        log '*** The following Omnibus-built libraries have unsafe or unmet dependencies:'
         bad_omnibus_libs.each { |lib| log "    --> #{lib}" }
-        log "*** The following Omnibus-built binaries have unsafe or unmet dependencies:"
+        log '*** The following Omnibus-built binaries have unsafe or unmet dependencies:'
         bad_omnibus_bins.each { |bin| log "    --> #{bin}" }
         if unresolved.length > 0
-          log "*** The following requirements could not be resolved:"
-          unresolved.each { |lib| log "    --> #{lib}"}
+          log '*** The following requirements could not be resolved:'
+          unresolved.each { |lib| log "    --> #{lib}" }
         end
         if unreliable.length > 0
-          log "*** The following libraries cannot be guaranteed to be on target systems:"
-          unreliable.each { |lib| log "    --> #{lib}"}
+          log '*** The following libraries cannot be guaranteed to be on target systems:'
+          unreliable.each { |lib| log "    --> #{lib}" }
         end
-        log "*** The precise failures were:"
+        log '*** The precise failures were:'
         detail.each do |line|
           item, dependency, location, count = line.split('|')
-          reason = location =~ /not found/ ? "Unresolved dependency" : "Unsafe dependency"
+          reason = location =~ /not found/ ? 'Unresolved dependency' : 'Unsafe dependency'
           log "    --> #{item}"
           log "    DEPENDS ON: #{dependency}"
           log "      COUNT: #{count}"
           log "      PROVIDED BY: #{location}"
           log "      FAILED BECAUSE: #{reason}"
         end
-        raise "Health Check Failed"
+        fail 'Health Check Failed'
       end
     end
 
     def self.health_check_otool(install_dir, whitelist_files)
       otool_cmd = "find #{install_dir}/ -type f | egrep '\.(dylib|bundle)$' | xargs otool -L > otool.out 2>/dev/null"
       log "Executing `#{otool_cmd}`"
-      shell = Mixlib::ShellOut.new(otool_cmd, :timeout => 3600)
+      shell = Mixlib::ShellOut.new(otool_cmd, timeout: 3600)
       shell.run_command
 
       otool_output = File.read('otool.out')
@@ -207,9 +206,9 @@ module Omnibus
       otool_output.each_line do |line|
         case line
         when /^(.+):$/
-          current_library = $1
+          current_library = Regexp.last_match[1]
         when /^\s+(.+) \(.+\)$/
-          linked = $1
+          linked = Regexp.last_match[1]
           name = File.basename(linked)
           bad_libs = check_for_bad_library(install_dir, bad_libs, whitelist_files, current_library, name, linked)
         end
@@ -246,20 +245,20 @@ module Omnibus
         safe ||= true if reg.match(current_library)
       end
 
-      log "  --> Dependency: #{name}" if ARGV[0] == "verbose"
-      log "  --> Provided by: #{linked}" if ARGV[0] == "verbose"
+      log "  --> Dependency: #{name}" if ARGV[0] == 'verbose'
+      log "  --> Provided by: #{linked}" if ARGV[0] == 'verbose'
 
       if !safe && linked !~ Regexp.new(install_dir)
-        log "    -> FAILED: #{current_library} has unsafe dependencies" if ARGV[0] == "verbose"
+        log "    -> FAILED: #{current_library} has unsafe dependencies" if ARGV[0] == 'verbose'
         bad_libs[current_library] ||= {}
         bad_libs[current_library][name] ||= {}
-        if bad_libs[current_library][name].has_key?(linked)
+        if bad_libs[current_library][name].key?(linked)
           bad_libs[current_library][name][linked] += 1
         else
           bad_libs[current_library][name][linked] = 1
         end
       else
-        log "    -> PASSED: #{name} is either whitelisted or safely provided." if ARGV[0] == "verbose"
+        log "    -> PASSED: #{name} is either whitelisted or safely provided." if ARGV[0] == 'verbose'
       end
 
       bad_libs
@@ -275,7 +274,7 @@ module Omnibus
       ldd_cmd = "find #{install_dir}/ -type f | xargs file | grep \"RISC System\" | awk -F: '{print $1}' | xargs -n 1 ldd > ldd.out 2>/dev/null"
 
       log "Executing `#{ldd_cmd}`"
-      shell = Mixlib::ShellOut.new(ldd_cmd, :timeout => 3600)
+      shell = Mixlib::ShellOut.new(ldd_cmd, timeout: 3600)
       shell.run_command
 
       ldd_output = File.read('ldd.out')
@@ -286,11 +285,11 @@ module Omnibus
       ldd_output.each_line do |line|
         case line
         when /^(.+) needs:$/
-          current_library = $1
-	  log "*** Analysing dependencies for #{current_library}" if ARGV[0] == "verbose"
+          current_library = Regexp.last_match[1]
+          log "*** Analysing dependencies for #{current_library}" if ARGV[0] == 'verbose'
         when /^\s+(.+)$/
-          name = $1
-          linked = $1
+          name = Regexp.last_match[1]
+          linked = Regexp.last_match[1]
           bad_libs = check_for_bad_library(install_dir, bad_libs, whitelist_files, current_library, name, linked)
         when /File is not an executable XCOFF file/ # ignore non-executable files
         else
@@ -312,7 +311,7 @@ module Omnibus
       ldd_cmd = "find #{install_dir}/ -type f | xargs ldd > ldd.out 2>/dev/null"
 
       log "Executing `#{ldd_cmd}`"
-      shell = Mixlib::ShellOut.new(ldd_cmd, :timeout => 3600)
+      shell = Mixlib::ShellOut.new(ldd_cmd, timeout: 3600)
       shell.run_command
 
       ldd_output = File.read('ldd.out')
@@ -323,11 +322,11 @@ module Omnibus
       ldd_output.each_line do |line|
         case line
         when /^(.+):$/
-          current_library = $1
-	  log "*** Analysing dependencies for #{current_library}" if ARGV[0] == "verbose"
+          current_library = Regexp.last_match[1]
+          log "*** Analysing dependencies for #{current_library}" if ARGV[0] == 'verbose'
         when /^\s+(.+) \=\>\s+(.+)( \(.+\))?$/
-          name = $1
-          linked = $2
+          name = Regexp.last_match[1]
+          linked = Regexp.last_match[2]
           bad_libs = check_for_bad_library(install_dir, bad_libs, whitelist_files, current_library, name, linked)
         when /^\s+(.+) \(.+\)$/
           next