omniauth-suomifi 0.4.1 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6f13147094a51b1011e54a3b72e31352b17ce876fad5598156b5b1f6ada977b2
-  data.tar.gz: 3ab984607001ce46573290197e49390f7e9b27bc098a7c1f48a4f24717609065
+  metadata.gz: 3343cb094200e73b259c021ebcd80e7d4c21ecc1cccc5706b9aa55dc7d214dc6
+  data.tar.gz: 032c0abbb7fc157a988890d639dfe8ba1c476cb9446f3a20e6eba6e83f77e5e1
 SHA512:
-  metadata.gz: 58af0b760126edc00ee2f114f90fd8c632271f1a60bc80938c70e61dbfb536c7e7032da6cd3cb91515bb239d68872c44ec3784c1498930f121e2bd139e63ff5d
-  data.tar.gz: a6367ec02b859f4e18e84bc9e739d3b44314a299b00730092c52c65a657b44b57b7ac80149cd2fd067023a200f1e25dc537647bd33e155b2bc4d5573fac7e39d
+  metadata.gz: f671513e0c41c72ce3e09d6b643685b6298347a9637f7ca9bf0bf09432d9a53e5dc429ab1877b322b5fad956fc56ed97969e9a211c032f0e338c3970a7bde31b
+  data.tar.gz: a1cc1add8a88f4ccf43761a621f43cc9e83b20683e64403eef171159a106e99151b55d4b97b5cf76fe0f617b4c007cab64e15661c820d60de0ecd71404619aef

data/lib/omniauth/strategies/suomifi.rb

@@ -28,16 +28,16 @@ module OmniAuth
       # - en_US
       #
       # In case a valid language cannot be parsed from the parameter, the locale
-      # parameter will default to `:idp_sso_target_url_default_locale`.
+      # parameter will default to `:idp_sso_service_url_default_locale`.
       #
       # Note that the locale parameter is always added as the last parameter in
       # in the redirect URL as expected by Suomi.fi.
-      option :idp_sso_target_url_locale_params, %w[locale language lang]
+      option :idp_sso_service_url_locale_params, %w[locale language lang]
 
       # This is the default locale to be passed to IdP sign in redirect URL as
       # defined above. In case a valid locale is not found from the request
       # parameters, this will be used instead.
-      option :idp_sso_target_url_default_locale, 'fi'
+      option :idp_sso_service_url_default_locale, 'fi'
 
       # The request attributes for Suomi.fi
       option :possible_request_attributes, [
@@ -557,7 +557,7 @@ module OmniAuth
       # Suomi.fi requires that the service provider needs to end the local user
       # session BEFORE sending the logout request to the identity provider.
       def other_phase_for_spslo
-        return super unless options.idp_slo_target_url
+        return super unless options.idp_slo_service_url
 
         with_settings do |settings|
           # Some session variables are needed when generating the logout request
@@ -610,7 +610,7 @@ module OmniAuth
         when :test
           'https://testi.apro.tunnistus.fi/static/metadata/idp-metadata.xml'
         else # :production
-          'https://tunnistus.suomi.fi/static/metadata/idp-metadata-tunnistautuminen.xml'
+          'https://tunnistus.suomi.fi/static/metadata/idp-metadata.xml'
         end
       end
 
@@ -629,6 +629,16 @@ module OmniAuth
           slo_binding: ['urn:oasis:names:tc:SAML:2.0:bindings:HTTP-Redirect']
         )
 
+        if settings[:idp_slo_response_service_url].nil? && settings[:idp_slo_target_url].nil?
+          # Mitigation after ruby-saml update to 1.12.x. This gem has been
+          # originally developed relying on the `:idp_slo_target_url` settings
+          # which was removed from the newer versions. The SLO requests won't
+          # work unless `:idp_slo_response_service_url` is defined in the
+          # metadata through the `ResponseLocation` attribute in the
+          # `<SingleLogoutService />` node.
+          settings[:idp_slo_target_url] ||= settings[:idp_slo_service_url]
+        end
+
         # Local certificate and private key to decrypt the responses
         settings[:certificate] = certificate
         settings[:private_key] = private_key
@@ -662,8 +672,8 @@ module OmniAuth
       end
 
       def locale_for_authn_request
-        if options.idp_sso_target_url_locale_params.is_a?(Array)
-          options.idp_sso_target_url_locale_params.each do |param|
+        if options.idp_sso_service_url_locale_params.is_a?(Array)
+          options.idp_sso_service_url_locale_params.each do |param|
             next unless request.params.key?(param.to_s)
 
             locale = parse_language_value(request.params[param.to_s])
@@ -671,7 +681,7 @@ module OmniAuth
           end
         end
 
-        options.idp_sso_target_url_default_locale
+        options.idp_sso_service_url_default_locale
       end
 
       def parse_language_value(string)

data/lib/omniauth-suomifi/version.rb

@@ -2,6 +2,6 @@
 
 module OmniAuth
   module Suomifi
-    VERSION = '0.4.1'
+    VERSION = '0.5.1'
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-suomifi
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.5.1
 platform: ruby
 authors:
 - Antti Hukkanen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2021-02-03 00:00:00.000000000 Z
+date: 2022-10-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth-saml
@@ -24,6 +24,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 1.10.3
+- !ruby/object:Gem::Dependency
+  name: ruby-saml
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.12.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.12.1
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement