omniauth-signnow 0.5.0 → 0.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7a37c1eef09087180fed82d643241ae5cc961a28
-  data.tar.gz: 0ecf07e019ec47656c71a36c015d755b88fa1808
+  metadata.gz: cfd9d3db9153ba00398c8a80601f13c659da3bd5
+  data.tar.gz: fd3b9c1cc04098707a6652c7e53eb7a2a0c15cb7
 SHA512:
-  metadata.gz: 707645d365fb1760bd0ee0ca1cbbf66373b8e8ee78abd6a7a1e075b6347fa8cf07c0a4094ad31cff4696374b69797a4a05c31056d767cff311ada1e99b28f1ff
-  data.tar.gz: db1d0716d7367dae52ddecff3631ac9c3bc889ddaccc3f1bd3aedda9bfa3edcb5320daf296e3e0bddcf00a379bb76de726d74f6e4a93ac533f8810dc02eb9b51
+  metadata.gz: a9c78f06a020078278def775f235b5d5fdf9605891765be0c013634135116a86e64ee5fec32f9091ef2f6a54a47cc7fe6b39b542f0373cb401f41b2dc3fb2d73
+  data.tar.gz: 8ebd4dd14d5b9ea3aa0fac9818954ad7d280aa8f1b5f8889c4480a4d6b2d20943c614e955260fc39df4748860be4f97f33cf9d983c4378f3b3032e7519228d3d

data/README.md

@@ -21,7 +21,7 @@ Here's an example for adding the middleware to a Rails app in `config/initialize
 
 ```ruby
 Rails.application.config.middleware.use OmniAuth::Builder do
-  provider :signnow, ENV['SIGNNOW_APP_KEY'], ENV['SIGNNOW_APP_SECRET']
+  provider :signnow, ENV['SIGNNOW_APP_ID'], ENV['SIGNNOW_APP_SECRET']
 end
 ```
 

data/lib/omniauth/strategies/signnow.rb

@@ -53,11 +53,12 @@ module OmniAuth
       end
 
       def auth_options
-        {
-          :headers => {
-            'Authorization' => "Basic #{Base64.encode64(client.id+':'+client.secret).gsub(/[\n=]/,'')}"
-          }
-        }
+        { headers: { Authorization: "Basic #{encoded_credentials}" } }
+      end
+
+      def encoded_credentials
+        return unless client and client.id and client.secret
+        Base64.strict_encode64( client.id + ':' + client.secret)
       end
     end
   end

data/lib/omniauth-signnow/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module Signnow
-    VERSION = '0.5.0'
+    VERSION = '0.5.1'
   end
 end

data/spec/omniauth/strategies/signnow_spec.rb

@@ -101,7 +101,7 @@ describe OmniAuth::Strategies::Signnow do
 
   describe '#auth_options' do
     let(:base64_client_key) {
-      Base64.encode64(subject.client.id + ':' + subject.client.secret).gsub(/[\n=]/,'')
+      Base64.strict_encode64(subject.client.id + ':' + subject.client.secret)
     }
     it  'is protected' do
       expect(subject.auth_options).to raise_error(NoMethodError)
@@ -109,9 +109,9 @@ describe OmniAuth::Strategies::Signnow do
     it 'returns a hash with the Autorization header' do
       expect(subject.send(:auth_options).class).to eql(Hash)
       expect(subject.send(:auth_options)).to include(:headers)
-      expect(subject.send(:auth_options)[:headers]).to include('Authorization')
-      expect(subject.send(:auth_options)[:headers]['Authorization']).to match(/Basic/)
-      expect(subject.send(:auth_options)[:headers]['Authorization']).to match(/#{base64_client_key}/)
+      expect(subject.send(:auth_options)[:headers]).to include :Authorization
+      expect(subject.send(:auth_options)[:headers][:Authorization]).to match(/Basic/)
+      expect(subject.send(:auth_options)[:headers][:Authorization]).to match(/#{base64_client_key}/)
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-signnow
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.5.1
 platform: ruby
 authors:
 - Andres Bravo
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-13 00:00:00.000000000 Z
+date: 2014-01-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth