omniauth-shopify 0.0.1 → 0.0.2

data/Rakefile

@@ -1 +1,6 @@
 require "bundler/gem_tasks"
+require 'rake/testtask'
+
+Rake::TestTask.new do |t|
+  t.test_files = FileList['spec/**/*_spec.rb']
+end

data/lib/omniauth-shopify/version.rb

@@ -1,5 +1,5 @@
-module Omniauth
+module OmniAuth
   module Shopify
-    VERSION = "0.0.1"
+    VERSION = "0.0.2"
   end
 end

data/omniauth-shopify.gemspec

@@ -4,7 +4,7 @@ require "omniauth-shopify/version"
 
 Gem::Specification.new do |s|
   s.name        = "omniauth-shopify"
-  s.version     = Omniauth::Shopify::VERSION
+  s.version     = OmniAuth::Shopify::VERSION
   s.authors     = ["Yevgeniy A. Viktorov"]
   s.email       = ["craftsman@yevgenko.me"]
   s.homepage    = ""
@@ -19,4 +19,8 @@ Gem::Specification.new do |s|
   s.require_paths = ["lib"]
 
   s.add_runtime_dependency 'omniauth', '~> 1.0'
+
+  s.add_development_dependency 'minitest' if RUBY_VERSION < '1.9.2'
+  s.add_development_dependency 'rack-test'
+  s.add_development_dependency 'rake'
 end

data/spec/omniauth/strategies/shopify_spec.rb

@@ -0,0 +1,86 @@
+ENV['RACK_ENV'] = 'test'
+require 'minitest/autorun'
+require 'rack/test'
+
+require 'omniauth-shopify'
+require 'digest/md5'
+
+include Rack::Test::Methods
+
+describe OmniAuth::Strategies::Shopify do
+  def app
+    Rack::Builder.new {
+      use Rack::Session::Cookie
+      use OmniAuth::Strategies::Shopify, 'apikey', 'hush'
+      run lambda {|env| [404, {'Content-Type' => 'text/plain'}, [nil || env.key?('omniauth.auth').to_s]] }
+    }.to_app
+  end
+
+  def query_parameters
+    {
+      "shop" => "some-shop.myshopify.com",
+      "t" => "a94a110d86d2452eb3e2af4cfb8a3828"
+    }
+  end
+
+  def query_string
+    query_parameters.collect { |k, v| "#{k}=#{v}" }.join '&'
+  end
+
+  def timestamp
+    Time.now.utc.to_i
+  end
+
+  def bad_timestamp
+    (Time.now - 25 * 3600).utc.to_i
+  end
+
+  def signature timestamp
+    calculated_signature = query_parameters.collect { |k, v| "#{k}=#{v}" }
+    calculated_signature.push "timestamp=#{timestamp}"
+    Digest::MD5.hexdigest('hush' + calculated_signature.sort.join)
+  end
+
+  describe '#request_phase' do
+    it 'must prompt for a shop url' do
+      get '/auth/shopify'
+      last_response.body.must_match %r{<input[^>]*shop}
+    end
+
+    it 'must redirect to authentication url' do
+      post '/auth/shopify', :shop => 'some-shop'
+      assert last_response.redirect?
+      last_response.headers['Location'].must_equal 'http://some-shop.myshopify.com/admin/api/auth?api_key=apikey'
+    end
+  end
+
+  describe '#callback phase' do
+    before(:each) do
+      get "/auth/shopify/callback?#{query_string}&timestamp=#{timestamp}&signature=#{signature(timestamp)}"
+    end
+
+    it 'must have auth hash' do
+      last_request.env['omniauth.auth'].must_be_kind_of Hash
+    end
+
+    it 'must have proper uid' do
+      last_request.env['omniauth.auth']['uid'].must_equal query_parameters['shop']
+    end
+
+    it 'must have token' do
+      last_request.env['omniauth.auth']['credentials']['token'].must_equal query_parameters['t']
+    end
+  end
+
+  describe 'invalid response' do
+    it 'must fail when bad signature' do
+      get "/auth/shopify/callback?#{query_string}&timestamp=#{timestamp}&signature=some_bad_signature"
+      last_response.headers['Location'].must_match %r{invalid_response}
+    end
+
+    it 'must fail when timestamps above 24 hours' do
+      get "/auth/shopify/callback?#{query_string}&timestamp=#{bad_timestamp}&signature=#{signature(bad_timestamp)}"
+      last_response.headers['Location'].must_match %r{invalid_response}
+    end
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-shopify
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
   prerelease: 
 platform: ruby
 authors:
@@ -9,11 +9,11 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-02-04 00:00:00.000000000Z
+date: 2012-02-13 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
-  requirement: &17205853220 !ruby/object:Gem::Requirement
+  requirement: &17205819720 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -21,7 +21,29 @@ dependencies:
         version: '1.0'
   type: :runtime
   prerelease: false
-  version_requirements: *17205853220
+  version_requirements: *17205819720
+- !ruby/object:Gem::Dependency
+  name: rack-test
+  requirement: &17205819280 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *17205819280
+- !ruby/object:Gem::Dependency
+  name: rake
+  requirement: &17205818820 !ruby/object:Gem::Requirement
+    none: false
+    requirements:
+    - - ! '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: *17205818820
 description: Strategy for authenticating to Shopify API with OmniAuth.
 email:
 - craftsman@yevgenko.me
@@ -38,6 +60,7 @@ files:
 - lib/omniauth-shopify/version.rb
 - lib/omniauth/strategies/shopify.rb
 - omniauth-shopify.gemspec
+- spec/omniauth/strategies/shopify_spec.rb
 homepage: ''
 licenses: []
 post_install_message: