omniauth-multipassword 2.0.1 → 2.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 22cda2cc2846bbe4d81087736f52e35f63c590595e6fc384006b0af8da14802f
-  data.tar.gz: 0600cb2dbafa41d13aeee34bda46ecb0263546489903aa68444d05126ade735c
+  metadata.gz: db4e255ccd2a90d205d8ad9b0a6aea7456e4af42d9d30ad88bcd32b59b5619b9
+  data.tar.gz: acce514c49e0fe34f39ce6161a9bb4277720d5af0dfb10056726c3c7761b235a
 SHA512:
-  metadata.gz: f3148c680d27dd56bae5325280e49670cd905d42d6e79cb668b01f0eb8951605bd27816233f3f55cef452c1a67215a94c6b25280dc6083eae3796c1eb12c2ce3
-  data.tar.gz: 6b48ab914cd47ff3b8b9641d52f1618050b5cafec8e1f171528eae6f7c8cbe909dd4095fbadc2b92caca6a9f25c002a06e9ab4ee837e8b504d1c031502772f26
+  metadata.gz: 8830e6455ecc2205409219603966056d9a99ee4b9cf556216c77113e0f323c6df78993d4631b96066d179bf16d3deedd225c04eb4c20b218cd2c7df574e1e7e6
+  data.tar.gz: 858305c757402a42b61d0cf90b493b1a82f0d928e5ec3991c78ca56aa27edbf5caab08b169eb6e463960ada74030d3a5e30bf182f3c4c706ac9edc4143b270b7

data/.github/workflows/release.yml

@@ -0,0 +1,36 @@
+name: release
+
+on:
+  push:
+    tags:
+      - v*
+
+jobs:
+  rubygems:
+    if: github.repository == 'jgraichen/omniauth-multipassword'
+    runs-on: ubuntu-24.04
+
+    permissions:
+      contents: write
+      id-token: write
+
+    env:
+      BUNDLE_JOBS: 4
+      BUNDLE_RETRY: 10
+      BUNDLE_WITHOUT: development test
+
+    steps:
+      - uses: actions/checkout@v4
+
+      - uses: ruby/setup-ruby@v1
+        with:
+          ruby-version: ruby
+          bundler-cache: true
+
+      - uses: rubygems/release-gem@v1
+
+      - uses: taiki-e/create-gh-release-action@v1
+        with:
+          changelog: CHANGELOG.md
+          draft: true
+          token: ${{ secrets.GITHUB_TOKEN }}

data/.github/workflows/test.yml

@@ -8,7 +8,7 @@ on:
 jobs:
   rspec:
     name: "Ruby ${{ matrix.ruby }} / ${{ matrix.gemfile }}"
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     strategy:
       fail-fast: false
@@ -47,13 +47,13 @@ jobs:
 
   rubocop:
     name: rubocop
-    runs-on: ubuntu-22.04
+    runs-on: ubuntu-24.04
 
     steps:
       - uses: actions/checkout@master
       - uses: ruby/setup-ruby@v1
         with:
-          ruby-version: "3.3"
+          ruby-version: "3.3.5"
           bundler-cache: true
         env:
           BUNDLE_JOBS: 4

data/.markdownlint.yml

@@ -0,0 +1,26 @@
+# markdownlint config
+
+# The CHANGELOG contains duplicated headers by design
+MD024: false
+
+# MD013/line-length: disable line length for all. We prefer lines as
+# long as paragraph with in-editor line breaks.
+MD013: false
+
+# MD033/no-inline-html: allow often need tags
+MD033:
+  allowed_elements:
+    - code
+    - dd
+    - dl
+    - dt
+    - figcaption
+    - figure
+
+# MD046/code-block-style: code block style conflicting with
+# admonitions...
+MD046: false
+
+# MD048/code-fence-style: code fence style
+MD048:
+  style: backtick

data/CHANGELOG.md

@@ -5,6 +5,12 @@ This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a Ch
 
 ## [Unreleased]
 
+## [2.1.0] - 2024-11-06
+
+### Changed
+
+- Pass GET requests to the app if not on the request path by @larskanis
+
 ## [2.0.1] - 2024-07-20
 
 ### Changed
@@ -22,6 +28,7 @@ This project adheres to [Semantic Versioning](http://semver.org/) and [Keep a Ch
 - Updated strategy to OmniAuth >= 2.0
 - Drop support for Ruby < 2.7
 
-[Unreleased]: https://github.com/jgraichen/omniauth-multipassword/compare/v2.0.1...HEAD
+[Unreleased]: https://github.com/jgraichen/omniauth-multipassword/compare/v2.1.1...HEAD
+[2.1.0]: https://github.com/jgraichen/omniauth-multipassword/compare/v2.0.1...v2.1.0
 [2.0.1]: https://github.com/jgraichen/omniauth-multipassword/compare/v2.0.0...v2.0.1
 [2.0.0]: https://github.com/jgraichen/omniauth-multipassword/releases/tag/v2.0.0

data/Gemfile

@@ -10,11 +10,11 @@ gem 'appraisal'
 gem 'rake'
 gem 'rake-release'
 
+gem 'rspec', '~> 3.0'
+
 group :test do
   gem 'rack-test'
 
-  gem 'rspec', '~> 3.0'
-
   gem 'simplecov'
   gem 'simplecov-cobertura'
 end

data/README.md

@@ -1,32 +1,39 @@
 # Omniauth::Multipassword
 
-[![Build Status](https://travis-ci.org/jgraichen/omniauth-multipassword.svg?branch=master)](https://travis-ci.org/jgraichen/omniauth-multipassword)
+[![Gem Version](https://img.shields.io/gem/v/omniauth-multipassword?logo=ruby)](https://rubygems.org/gems/omniauth-multipassword)
+[![Workflow Status](https://img.shields.io/github/actions/workflow/status/jgraichen/omniauth-multipassword/test.yml?logo=github)](https://github.com/jgraichen/omniauth-multipassword/actions)
+[![Test Coverage](https://img.shields.io/codecov/c/github/jgraichen/omniauth-multipassword?logo=codecov&logoColor=white)](https://app.codecov.io/gh/jgraichen/omniauth-multipassword)
 [![Code Climate](https://codeclimate.com/github/jgraichen/omniauth-multipassword/badges/gpa.svg)](https://codeclimate.com/github/jgraichen/omniauth-multipassword)
-[![Test Coverage](https://codeclimate.com/github/jgraichen/omniauth-multipassword/badges/coverage.svg)](https://codeclimate.com/github/jgraichen/omniauth-multipassword/coverage)
 
 **omniauth-multipassword** is a [OmniAuth](https://github.com/intridea/omniauth)
 strategy that allows to authenticate again different password strategies at once.
 
-
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'omniauth-multipassword'
+```ruby
+gem 'omniauth-multipassword'
+```
 
 Add multipassword compatible omniauth strategies you want to use:
 
-	gem 'omniauth-internal'
-	gem 'omniauth-kerberos'
+```ruby
+gem 'omniauth-internal'
+gem 'omniauth-kerberos'
+```
 
 And then execute:
 
-    $ bundle
+```console
+bundle
+```
 
 Or install it yourself as:
 
-    $ gem install omniauth-multipassword
-
+```console
+gem install omniauth-multipassword
+```
 
 ## Usage
 
@@ -37,26 +44,32 @@ Rails.application.config.middleware.use OmniAuth::Strategies::MultiPassword, fie
 end
 ```
 
-
 ## Options
 
-** title **
+<dl>
+  <dt><code>title</code></dt>
+  <dd>
+
 The title text shown on default login form.
 (default: `"Restricted Access"`)
 
-** fields **
+  </dd>
+  <dt><code>fields</code></dt>
+  <dd>
+
 The request parameter names to fetch username and password.
 (default: `[ "username", "password" ]`)
 
+  </dd>
+</dl>
 
 ### Compatible Strategies
 
-* [omniauth-internal](https://github.com/jgraichen/omniauth-internal)
-* [omniauth-kerberos](https://github.com/jgraichen/omniauth-kerberos)
-
+- [omniauth-internal](https://github.com/jgraichen/omniauth-internal)
+- [omniauth-kerberos](https://github.com/jgraichen/omniauth-kerberos)
 
 ## License
 
 [MIT License](http://www.opensource.org/licenses/mit-license.php)
 
-Copyright (c) 2012, Jan Graichen
+Copyright © 2012, Jan Graichen

data/lib/omniauth/multipassword/base.rb

@@ -49,7 +49,11 @@ module OmniAuth
         # OmniAuth, by default, disables "GET" requests for security reasons.
         # This effectively disables showing a password form on a GET request to
         # the `request_phase`. Instead, we hook the GET requests here.
-        request_phase if on_request_path?
+        if on_request_path?
+          request_phase
+        else
+          call_app!
+        end
       end
     end
   end

data/lib/omniauth/multipassword/version.rb

@@ -4,8 +4,8 @@ module Omniauth
   module Multipassword
     module VERSION
       MAJOR = 2
-      MINOR = 0
-      PATCH = 1
+      MINOR = 1
+      PATCH = 0
       STAGE = nil
 
       def self.to_s

data/spec/omniauth/multipassword/base_spec.rb

@@ -46,6 +46,9 @@ describe OmniAuth::MultiPassword::Base do # rubocop:disable RSpec/SpecFilePathFo
       Rack::Builder.new do
         use OmniAuth::Test::PhonySession
         use OmniAuth::Strategies::OneTest
+        map '/app-ok' do
+          run ->(env) { [200, {'Content-Type' => 'text/plain'}, ['OK']] }
+        end
         run ->(env) { [404, {'Content-Type' => 'text/plain'}, [env.key?('omniauth.auth').to_s]] }
       end.to_app
     end
@@ -66,5 +69,10 @@ describe OmniAuth::MultiPassword::Base do # rubocop:disable RSpec/SpecFilePathFo
       post '/auth/onetest/callback', username: 'john', password: 'secret'
       expect(last_response.body).to eq 'true'
     end
+
+    it 'shows app page' do
+      get '/app-ok'
+      expect(last_response.body).to eq 'OK'
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-multipassword
 version: !ruby/object:Gem::Version
-  version: 2.0.1
+  version: 2.1.0
 platform: ruby
 authors:
 - Jan Graichen
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-07-20 00:00:00.000000000 Z
+date: 2024-11-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
@@ -34,8 +34,10 @@ files:
 - ".editorconfig"
 - ".github/workflows/maintenance-cache-wipe.yml"
 - ".github/workflows/maintenance-workflow-cleanup.yml"
+- ".github/workflows/release.yml"
 - ".github/workflows/test.yml"
 - ".gitignore"
+- ".markdownlint.yml"
 - ".rspec"
 - ".rubocop.yml"
 - Appraisals
@@ -76,7 +78,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.11
+rubygems_version: 3.5.22
 signing_key:
 specification_version: 4
 summary: A OmniAuth strategy to authenticate using different passwort strategies.