omniauth-msunet 1.0.1 → 1.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 1a075ba76fbdcc191755882fbe1a50e559e9a7f4
-  data.tar.gz: abea209dee639b65c2aac32ad47ff22e276bff7b
+  metadata.gz: 6fd0c7bae1d9ae0c5dfb334385bf172701a29f5b
+  data.tar.gz: b850e88fe74294a8d62e409a74fa0faf5722eea8
 SHA512:
-  metadata.gz: 7b432cb66a4933678f3d5c5ce9acd7228bf4b489e23c0a045f9868c9d9941367fe811d999ff4851dfbe79d3f65416d0197d0a55e39233b6f01c5cbfd241b2613
-  data.tar.gz: 1cad188030d80330dd102fdf7723bc14954ee037a45fb95688d134a3d840d978227fd1d83db41b112459ccc12d26bf4ca0082891174075a3e4b3c0cdac05a37f
+  metadata.gz: 4856f0e5c8eb59e4c097431781a435dac7dff14c73715e699670d342a5c6c92e2de0aff5c86a9aaf80132d14f13cf16dc7632af8bfab0da42178609567d150c6
+  data.tar.gz: c1a048f6e1ddfdf68b6a28292d60d217a87ffe61fe1a16c5ba0bbeb1dee3b2d65869409b27066add5637aca81dd5532f9def42d8f4d09c1fe9b866937966d038

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 1.0.2
+
+* Clean-up some code and formatting
+* Add some specs
+
 ## 1.0.1
 
 * Rename netid field to msunetid
@@ -12,4 +17,3 @@
 ## 0.5.0
 
 * Initial release
-

data/Gemfile

@@ -2,11 +2,3 @@ source 'http://rubygems.org'
 
 # Specify your gem's dependencies in omniauth-msunet.gemspec
 gemspec
-
-group :development, :test do
-  gem 'guard'
-  gem 'guard-rspec'
-  gem 'guard-bundler'
-  gem 'rb-fsevent'
-  gem 'growl'
-end

data/README.md

@@ -49,4 +49,4 @@ Once the login is completed you should receive the following hash that you can a
 
 ## License
 
-Please see the LICENSE.md file.
+Please see the LICENSE.md file.

data/lib/omniauth-msunet/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module MSUnet
-    VERSION = "1.0.1"
+    VERSION = "1.0.2"
   end
 end

data/lib/omniauth/strategies/msunet.rb

@@ -6,7 +6,6 @@ module OmniAuth
     class MSUnet < OmniAuth::Strategies::OAuth2
       option :client_options, {
         site: "https://oauth.ais.msu.edu",
-        authorize_path: "/oauth/authorize",
         authorize_url: "/oauth/authorize",
         token_url: "/oauth/token"
       }
@@ -26,7 +25,7 @@ module OmniAuth
       end
 
       extra do
-        { :raw_info => raw_info }
+        { raw_info: raw_info }
       end
 
       def raw_info
@@ -37,4 +36,4 @@ module OmniAuth
   end
 end
 
-OmniAuth.config.add_camelization 'msunet', 'MSUnet'
+OmniAuth.config.add_camelization 'msunet', 'MSUnet'

data/omniauth-msunet.gemspec

@@ -2,8 +2,8 @@
 require File.expand_path('../lib/omniauth-msunet/version', __FILE__)
 
 Gem::Specification.new do |gem|
-  gem.authors       = ["Troy Murray"]
-  gem.email         = ["tm@msu.edu"]
+  gem.authors       = ['Troy Murray', 'Andrew Tomaka']
+  gem.email         = ['tm@msu.edu', 'atomaka@msu.edu']
   gem.summary       = %q{Michigan State University MSUnet OmniAuth strategy.}
   gem.description   = %q{Official OmniAuth strategy for authenticating against the Michigan State University MSUnet OAuth2 provider.}
   gem.homepage      = "https://gitlab.msu.edu/msu-middleware-group/omniauth-msunet"
@@ -19,8 +19,5 @@ Gem::Specification.new do |gem|
   gem.add_dependency 'omniauth', '~> 1.1'
   gem.add_dependency 'omniauth-oauth2', '~> 1.1'
   gem.add_dependency 'multi_json', '~> 1.7'
-  gem.add_development_dependency 'rspec', '~> 2.7'
-  gem.add_development_dependency 'rack-test'
-  gem.add_development_dependency 'simplecov'
-  gem.add_development_dependency 'webmock'
+  gem.add_development_dependency 'rspec', '~> 3.4'
 end

data/spec/omniauth/strategies/msunet_spec.rb

@@ -0,0 +1,82 @@
+require 'spec_helper'
+require 'omniauth-msunet'
+
+describe OmniAuth::Strategies::MSUnet do
+  let(:request) { double('Request', params: {}, cookies: {}, env: {}) }
+  let(:app) { lambda { [200, {}, ["Hello."]] } }
+
+  subject do
+    OmniAuth::Strategies::MSUnet.new(app, 'appid', 'secret', @options || {}).tap do |strategy|
+      allow(strategy).to receive(:request) { request }
+    end
+  end
+
+  before do
+    OmniAuth.config.test_mode = true
+  end
+
+  after do
+    OmniAuth.config.test_mode = false
+  end
+
+  describe '#client_options' do
+    it 'has correct site' do
+      expect(subject.client.site).to eq('https://oauth.ais.msu.edu')
+    end
+
+    it 'has correct authorize_url' do
+      expect(subject.client.options[:authorize_url]).to eq('/oauth/authorize')
+    end
+
+    it 'has correct token_url' do
+      expect(subject.client.options[:token_url]).to eq('/oauth/token')
+    end
+
+    context 'overrides' do
+      it 'should allow overriding the site' do
+        @options = { client_options: { site: 'https://domain.com' }}
+        expect(subject.client.site).to eq('https://domain.com')
+      end
+
+      it 'should allow overriding the authorize_url' do
+        @options = { client_options: { authorize_url: 'https://domain.com' }}
+        expect(subject.client.authorize_url).to eq('https://domain.com')
+      end
+
+      it 'should allow overriding the token_url' do
+        @options = { client_options: { token_url: 'https://domain.com' }}
+        expect(subject.client.token_url).to eq('https://domain.com')
+      end
+    end
+  end
+
+  describe '#extra' do
+    let(:client) do
+      OAuth2::Client.new('abc', 'def') do |builder|
+        builder.request :url_encoded
+        builder.adapter :test do |stub|
+          stub.get('/oauth/me?access_token=') {|env| [200, {'content-type' => 'application/json'}, '{"email": "user@domain.com"}']}
+        end
+      end
+    end
+    let(:access_token) { OAuth2::AccessToken.from_hash(client, {}) }
+    before { allow(subject).to receive(:access_token).and_return(access_token) }
+
+    describe '#raw_info' do
+      it 'should include raw_info' do
+        expect(subject.raw_info).to eq('email' => 'user@domain.com')
+      end
+    end
+  end
+
+  describe '#callback_path' do
+    it 'has the correct default callback path' do
+      expect(subject.callback_path).to eq('/auth/msunet/callback')
+    end
+
+    it 'should set the callback_path parameter if present' do
+      @options = {callback_path: '/login'}
+      expect(subject.callback_path).to eq('/login')
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,2 @@
+require File.join('bundler', 'setup')
+require 'rspec'

metadata

@@ -1,122 +1,82 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-msunet
 version: !ruby/object:Gem::Version
-  version: 1.0.1
+  version: 1.0.2
 platform: ruby
 authors:
 - Troy Murray
+- Andrew Tomaka
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-16 00:00:00.000000000 Z
+date: 2016-04-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth2
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.1'
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.7'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
+        version: '3.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '2.7'
-- !ruby/object:Gem::Dependency
-  name: rack-test
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: simplecov
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: webmock
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - '>='
-      - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.4'
 description: Official OmniAuth strategy for authenticating against the Michigan State
   University MSUnet OAuth2 provider.
 email:
 - tm@msu.edu
+- atomaka@msu.edu
 executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
+- ".gitignore"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.md
@@ -125,6 +85,8 @@ files:
 - lib/omniauth-msunet/version.rb
 - lib/omniauth/strategies/msunet.rb
 - omniauth-msunet.gemspec
+- spec/omniauth/strategies/msunet_spec.rb
+- spec/spec_helper.rb
 homepage: https://gitlab.msu.edu/msu-middleware-group/omniauth-msunet
 licenses:
 - MSU
@@ -135,18 +97,20 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.3
+rubygems_version: 2.6.2
 signing_key: 
 specification_version: 4
 summary: Michigan State University MSUnet OmniAuth strategy.
-test_files: []
+test_files:
+- spec/omniauth/strategies/msunet_spec.rb
+- spec/spec_helper.rb