omniauth-linkedin 0.0.8 → 0.1.0

data/example/config.ru

@@ -2,6 +2,9 @@ require 'bundler/setup'
 require 'sinatra/base'
 require 'omniauth-linkedin'
 
+ENV['LINKEDIN_CONSUMER_KEY'] = "eumx4m8w39qb"
+ENV['LINKEDIN_CONSUMER_SECRET'] = "PczJNDDLYic6kQOL"
+
 class App < Sinatra::Base
   get '/' do
     redirect '/auth/linkedin'
@@ -18,7 +21,7 @@ class App < Sinatra::Base
   end
 end
 
-use Rack::Session::Cookie
+use Rack::Session::Cookie, :secret => "change_me"
 
 use OmniAuth::Builder do
   #note that the scope is different from the default

data/lib/omniauth-linkedin/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Linkedin
-    VERSION = "0.0.8"
+    VERSION = "0.1.0"
   end
 end

data/lib/omniauth/strategies/linkedin.rb

@@ -19,14 +19,19 @@ module OmniAuth
       uid{ raw_info['id'] }
 
       info do
+        name = [raw_info['firstName'], raw_info['lastName']].compact.join(' ').strip || nil
+        name = nil_if_empty(name)
         {
+          :name => name,
           :email => raw_info['emailAddress'],
+          :nickname => name,
           :first_name => raw_info['firstName'],
           :last_name => raw_info['lastName'],
-          :name => "#{raw_info['firstName']} #{raw_info['lastName']}",
-          :headline => raw_info['headline'],
+          :location => parse_location(raw_info['location']),
           :description => raw_info['headline'],
           :image => raw_info['pictureUrl'],
+          :phone => nil,
+          :headline => raw_info['headline'],
           :industry => raw_info['industry'],
           :urls => {
             'public_profile' => raw_info['publicProfileUrl']
@@ -47,6 +52,33 @@ module OmniAuth
         options.request_params[:scope] = options.scope.gsub("+", " ")
         super
       end
+
+      private
+
+      def parse_location(location_hash = {})
+        location_hash ||= {}
+        location_name = extract_location_name(location_hash)
+        country_code = extract_country_code(location_hash)
+        build_location_value(location_name, country_code)
+      end
+
+      def extract_location_name(location_hash = {})
+        nil_if_empty(location_hash["name"])
+      end
+
+      def extract_country_code(location_hash = {})
+        country_hash = location_hash["country"] || {}
+        country_code = nil_if_empty(country_hash["code"])
+        country_code = (country_code ? country_code.upcase : nil)
+      end
+
+      def build_location_value(location_name, country_code)
+        nil_if_empty([location_name, country_code].compact.join(', '))
+      end
+
+      def nil_if_empty(value)
+        (value.nil? || value.empty?) ? nil : value
+      end
     end
   end
 end

data/spec/omniauth/strategies/linkedin_spec.rb

@@ -36,4 +36,24 @@ describe "OmniAuth::Strategies::LinkedIn" do
       subject.uid.should eq('123')
     end
   end
+
+  context 'returns info hash conformant with omniauth auth hash schema' do
+    before :each do
+      subject.stub(:raw_info) { {} }
+    end
+
+    context 'and therefore has all the necessary fields' do
+      it {subject.info.should have_key :name}
+      it {subject.info.should have_key :name}
+      it {subject.info.should have_key :email}
+      it {subject.info.should have_key :nickname}
+      it {subject.info.should have_key :first_name}
+      it {subject.info.should have_key :last_name}
+      it {subject.info.should have_key :location}
+      it {subject.info.should have_key :description}
+      it {subject.info.should have_key :image}
+      it {subject.info.should have_key :phone}
+      it {subject.info.should have_key :urls}
+    end
+  end
 end

data/todo.txt

@@ -0,0 +1 @@
+- need some more tests to make sure location can be parsed correctly

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-linkedin
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.1.0
   prerelease: 
 platform: ruby
 authors:
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2012-08-16 00:00:00.000000000 Z
+date: 2013-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth-oauth
@@ -113,6 +113,7 @@ files:
 - omniauth-linkedin.gemspec
 - spec/omniauth/strategies/linkedin_spec.rb
 - spec/spec_helper.rb
+- todo.txt
 homepage: https://github.com/skorks/omniauth-linkedin
 licenses: []
 post_install_message: 
@@ -125,18 +126,22 @@ required_ruby_version: !ruby/object:Gem::Requirement
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 2699125881048178184
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
   - - ! '>='
     - !ruby/object:Gem::Version
       version: '0'
+      segments:
+      - 0
+      hash: 2699125881048178184
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.21
+rubygems_version: 1.8.24
 signing_key: 
 specification_version: 3
 summary: LinkedIn strategy for OmniAuth.
-test_files:
-- spec/omniauth/strategies/linkedin_spec.rb
-- spec/spec_helper.rb
+test_files: []