omniauth-line-v2_1 0.0.0 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: cb969635fc2b09065bebf5373d123f43986a6730036a34329a2d53e6a64cae6e
-  data.tar.gz: b78c3a7a5d50a89d6ed15c533467d40c3588be0cf4c05799e957a36994b85ac4
+  metadata.gz: 32152b111920b320e068b3038339245e0a7f8b7bf3b42481b07f33276a770afb
+  data.tar.gz: 9424e8c32ba957214cb9583ab3c094544d0cc0500a26b4b425330775e840401c
 SHA512:
-  metadata.gz: beb775ade24ca083c3732d52a9b3428731d929ce6726170d23813f85f264e841059ed9db1a81de6a0fb963224c5015a4c7595b761bba8d5f427a150f6ace83df
-  data.tar.gz: e6d6e1548574c50864d9b49fc445222dda932c94933c9aa96f15803c7d067ce7e1ba7075daf12578c7bc84efb8b2cb5f150590ff730f31987317130d59727567
+  metadata.gz: 96b6264a13cbd4e4a9645dcd57ca1e9a0403d04989654b65beab55568f72ac17e2ecfc1631895622b56b311c2c46d1e420728789a3781d06526e8355bb1d7629
+  data.tar.gz: f9cbd122a9ca71a835f0c4bb3c48e157a75c7164e283efbac7df689a02d9473b94b554a2c8065e3da3e6b3f04308424a7daedca65efd93c96113d8871a461264

data/CHANGELOG.md

@@ -1,5 +1,15 @@
 # Changelog
 
+## [1.1.0] - 2025-08-02
+
+- Refactor: Refactor `OmniAuth::Strategies::LineV21#authorize_params`
+- Test: Update test
+
+## [1.0.0] - 2025-08-01
+
+- New: Generate nonce parameter automatically for security
+- New: Call fail! when ID token verification response contains error
+
 ## [0.0.0] - 2025-07-26
 
 - Initial release

data/README.md

@@ -108,8 +108,7 @@ After successful authentication, the auth hash will be available in `request.env
     raw_info: {
       sub: 'U4af4980629...',
       name: 'Taro Line',
-      picture: 'https://profile.line-scdn.net/...',
-      email: 'taro.line@example.com'
+      picture: 'https://profile.line-scdn.net/...'
     },
     id_token: 'eyJhbGciOiJIUzI1NiJ9...',
     id_info: {

data/lib/omniauth/line_v2_1/version.rb

@@ -2,6 +2,6 @@
 
 module OmniAuth
   module LineV21
-    VERSION = '0.0.0'
+    VERSION = '1.1.0'
   end
 end

data/lib/omniauth/strategies/line_v2_1.rb

@@ -56,15 +56,16 @@ module OmniAuth
         options[:redirect_uri] || (full_host + callback_path)
       end
 
-      def authorize_params
+      def authorize_params # rubocop:disable Metrics/AbcSize
         super.tap do |params|
-          %w[scope state nonce prompt bot_prompt].each do |v|
-            params[v.to_sym] = request.params[v] if request.params[v]
+          options[:authorize_options].each do |key|
+            params[key] = request.params[key.to_s] unless empty?(request.params[key.to_s])
           end
           params[:scope] ||= DEFAULT_SCOPE
+          params[:nonce] ||= SecureRandom.hex(24)
           params[:response_type] = 'code'
-          session['omniauth.state'] = params[:state] if params[:state]
-          session['omniauth.nonce'] = params[:nonce] if params[:nonce]
+          session['omniauth.state'] = params[:state] unless empty?(params[:state])
+          session['omniauth.nonce'] = params[:nonce] unless empty?(params[:nonce])
         end
       end
 
@@ -73,10 +74,14 @@ module OmniAuth
       def prune!(hash)
         hash.delete_if do |_, value|
           prune!(value) if value.is_a?(Hash)
-          value.nil? || (value.respond_to?(:empty?) && value.empty?)
+          empty?(value)
         end
       end
 
+      def empty?(value)
+        value.nil? || (value.respond_to?(:empty?) && value.empty?)
+      end
+
       def id_token_info
         return @id_token_info if defined?(@id_token_info)
 
@@ -93,9 +98,9 @@ module OmniAuth
           id_token: id_token,
           client_id: options.client_id
         }
-        params[:nonce] = session['omniauth.nonce'] if session['omniauth.nonce']
+        params[:nonce] = session.delete('omniauth.nonce') if session['omniauth.nonce']
 
-        client.request(
+        response = client.request(
           :post,
           ID_TOKEN_VERIFY_URL,
           headers: {
@@ -103,9 +108,12 @@ module OmniAuth
           },
           body: URI.encode_www_form(params)
         ).parsed
+
+        fail!(:id_token_verification_failed, CallbackError.new(:id_token_verification_failed, response['error_description'])) if response['error']
+
+        response
       rescue StandardError => e
-        log :error, "ID token verification failed: #{e.message}"
-        nil
+        fail!(:id_token_verification_failed, e)
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-line-v2_1
 version: !ruby/object:Gem::Version
-  version: 0.0.0
+  version: 1.1.0
 platform: ruby
 authors:
 - Masahiro
@@ -52,15 +52,15 @@ files:
 - lib/omniauth-line-v2_1.rb
 - lib/omniauth/line_v2_1/version.rb
 - lib/omniauth/strategies/line_v2_1.rb
-homepage: https://github.com/cadenza-tech/omniauth-line-v2_1/tree/v0.0.0
+homepage: https://github.com/cadenza-tech/omniauth-line-v2_1/tree/v1.1.0
 licenses:
 - MIT
 metadata:
-  homepage_uri: https://github.com/cadenza-tech/omniauth-line-v2_1/tree/v0.0.0
-  source_code_uri: https://github.com/cadenza-tech/omniauth-line-v2_1/tree/v0.0.0
-  changelog_uri: https://github.com/cadenza-tech/omniauth-line-v2_1/blob/v0.0.0/CHANGELOG.md
+  homepage_uri: https://github.com/cadenza-tech/omniauth-line-v2_1/tree/v1.1.0
+  source_code_uri: https://github.com/cadenza-tech/omniauth-line-v2_1/tree/v1.1.0
+  changelog_uri: https://github.com/cadenza-tech/omniauth-line-v2_1/blob/v1.1.0/CHANGELOG.md
   bug_tracker_uri: https://github.com/cadenza-tech/omniauth-line-v2_1/issues
-  documentation_uri: https://rubydoc.info/gems/omniauth-line-v2_1/0.0.0
+  documentation_uri: https://rubydoc.info/gems/omniauth-line-v2_1/1.1.0
   funding_uri: https://patreon.com/CadenzaTech
   rubygems_mfa_required: 'true'
 rdoc_options: []