omniauth-launchpad 0.0.1 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ffc66ef2a2bad8e4209bdd82da5d5630119e108b
-  data.tar.gz: 508eee24e8f3a0f6a8eac9c6a77feb5d70edf072
+  metadata.gz: 8d070daeb3e1490ec25e3392882228c6688e3746
+  data.tar.gz: 152c9448d0a5180956e052fea005c739aaae31b6
 SHA512:
-  metadata.gz: 6a24c601fb669238dcaafb4f8c4d7219554267caa8d5b21797a56c30e68a941cadac276718b1fae3a5c5f0a54e4873eea401cfcc147be4e506f8a743371f0b81
-  data.tar.gz: a64270682397b08cbf43b6d6acecba996b82b9ce09832ab100cb98893376de50e5edbd94a4ef00361ef2440ec943ce8762262f84a0669737491a8ebf50338fab
+  metadata.gz: f21c0175ec7f1896cceab351a18e530efda254787949f6f04fd43996f05fb9552ab38bb3104e9d6b49d1c30d53118c55e32c56563204d27d0cd759f2a0ee9a71
+  data.tar.gz: e38f53fe5cb0224ccb6972c4c4e1987b1104d7da786f09755a629b82c14c2db7d35399daec006dc3a2842109104cecf51625dbdf127f1b1d189cd2c5d8fc6125

data/.rspec

@@ -0,0 +1,2 @@
+--color
+--require spec_helper

data/.travis.yml

@@ -0,0 +1,14 @@
+before_install:
+  - gem update --system 2.1.11
+language: ruby
+rvm:
+  - "1.9.2"
+  - "1.9.3"
+  - "2.0.0"
+  - "2.1.0"
+  - "rbx"
+  - "jruby"
+matrix:
+  allow_failures:
+    - rvm: "rbx"
+    - rvm: "jruby"

data/README.md

@@ -1,6 +1,7 @@
 # Omniauth::Launchpad
+Build status: [![Build Status](https://travis-ci.org/joaopapereira/omniauth-launchpad.png?branch=master)](https://travis-ci.org/joaopapereira/omniauth-launchpad)
 
-TODO: Write a gem description
+This gem allows the user to login with the launchpad account
 
 ## Installation
 
@@ -20,11 +21,16 @@ Or install it yourself as:
 
 ## Usage
 
-TODO: Write usage instructions here
+Add the middleware to a Rails app in config/initializers/omniauth.rb:
+```
+Rails.application.config.middleware.use OmniAuth::Builder do
+  provider :launchpad, CONSUMER_KEY
+end
+```
 
 ## Contributing
 
-1. Fork it ( https://github.com/[my-github-username]/omniauth-launchpad/fork )
+1. Fork it ( https://github.com/joaopapereira/omniauth-launchpad/fork )
 2. Create your feature branch (`git checkout -b my-new-feature`)
 3. Commit your changes (`git commit -am 'Add some feature'`)
 4. Push to the branch (`git push origin my-new-feature`)

data/Rakefile

@@ -1,2 +1,5 @@
 require "bundler/gem_tasks"
+require File.join('rspec', 'core', 'rake_task')
 
+RSpec::Core::RakeTask.new(:spec)
+task :default => :spec

data/lib/omniauth/launchpad/version.rb

@@ -1,5 +1,5 @@
 module Omniauth
   module Launchpad
-    VERSION = "0.0.1"
+    VERSION = "0.1.0"
   end
 end

data/lib/omniauth/strategies/launchpad.rb

@@ -24,7 +24,6 @@ module OmniAuth
       }
       def initialize(app, consumer_key="babun", options={}, &block)
         options[:oauth_consumer_key] = consumer_key
-        options[:oauth_consumer_secret] = consumer_secret
         super(app, consumer_key, nil, options, &block)
       end
     
@@ -52,28 +51,27 @@ module OmniAuth
         { raw_user_info: raw_user_info }
       end
       def request_phase
-        puts "Request info: #{options.request_param}"
           request_options = {:oauth_consumer_key => options[:oauth_consumer_key], :realm => "https://api.launchpad.net/"}
-            request_options.merge!(options[:authorize_params])
-          
-            request_token = consumer.get_request_token({:oauth_callback => callback_url}, request_options)
-            session['oauth'] ||= {}
-            session['oauth'][name.to_s] = {'callback_confirmed' => request_token.callback_confirmed?, 'request_token' => request_token.token, 'request_secret' => request_token.secret}
-            r = Rack::Response.new
-          
-            if request_token.callback_confirmed?
-              r.redirect(request_token.authorize_url)
-            else
-              r.redirect(request_token.authorize_url(:oauth_callback => callback_url))
-            end
-            @request_token = request_token
-            r.finish
-          
-            rescue ::Timeout::Error => e
-              fail!(:timeout, e)
-            rescue ::Net::HTTPFatalError, ::OpenSSL::SSL::SSLError => e
-              fail!(:service_unavailable, e)
+          request_options.merge!(options[:authorize_params])
+        
+          request_token = consumer.get_request_token({:oauth_callback => callback_url}, request_options)
+          session['oauth'] ||= {}
+          session['oauth'][name.to_s] = {'callback_confirmed' => request_token.callback_confirmed?, 'request_token' => request_token.token, 'request_secret' => request_token.secret}
+          r = Rack::Response.new
+        
+          if request_token.callback_confirmed?
+            r.redirect(request_token.authorize_url)
+          else
+            r.redirect(request_token.authorize_url(:oauth_callback => callback_url))
           end
+          @request_token = request_token
+          r.finish
+        
+          rescue ::Timeout::Error => e
+            fail!(:timeout, e)
+          rescue ::Net::HTTPFatalError, ::OpenSSL::SSL::SSLError => e
+            fail!(:service_unavailable, e)
+      end
     end
   end
 end

data/omniauth-launchpad.gemspec

@@ -17,8 +17,9 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
+  spec.required_ruby_version = '>= 1.9.2'
 
-  spec.add_development_dependency "bundler", "~> 1.7"
+  spec.add_development_dependency "bundler"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency 'rspec'
   spec.add_development_dependency 'webmock'
@@ -27,8 +28,5 @@ Gem::Specification.new do |spec|
   
   spec.add_runtime_dependency 'omniauth', '>= 1.1.1'
   spec.add_runtime_dependency 'omniauth-oauth'
-  #spec.add_runtime_dependency 'faraday'
-  #spec.add_runtime_dependency 'faraday_middleware'
-  #spec.add_runtime_dependency 'simple_oauth'
   spec.add_runtime_dependency 'multi_json', '~> 1.3'
 end

data/spec/omniauth/strategies/launchpad_spec.rb

@@ -0,0 +1,137 @@
+require 'spec_helper'
+require 'omniauth-launchpad'
+
+describe OmniAuth::Strategies::Launchpad do
+  def app
+    Rack::Builder.new {
+      use OmniAuth::Test::PhonySession
+      use OmniAuth::Builder do
+        provider :launchpad, "testing-launchpad"
+      end
+      run lambda { |env| [404, {'Content-Type' => 'text/plain'}, [env.key?('omniauth.auth').to_s]] }
+    }.to_app
+  end
+    def strategy
+    # return the parameters to a Rack::Builder map call:
+    [OmniAuth::Strategies::Launchpad.new, 'bamm']
+  end
+  def session
+    last_request.env['rack.session']
+  end
+
+  before do
+    stub_request(:post, 'https://launchpad.net/+request-token').
+      to_return(:body => "oauth_token=yourtoken&oauth_token_secret=yoursecret&oauth_callback_confirmed=true")
+  end
+  it 'can be camel-cased' do
+    OmniAuth::Utils.camelize( 'launchpad' ).should == 'Launchpad'
+  end
+
+  describe '/auth/launchpad' do
+    context 'successful' do
+      before do
+        get '/auth/launchpad'
+      end
+
+      it 'should redirect to authorize_url' do
+        last_response.should be_redirect
+        last_response.headers['Location'].should == 'https://launchpad.net/+authorize-token?oauth_token=yourtoken'
+      end
+
+
+      it 'should set appropriate session variables' do
+        session['oauth'].should == {"launchpad"=>{"callback_confirmed"=>true, "request_token"=>"yourtoken", "request_secret"=>"yoursecret"}}
+      end
+    end
+
+    context 'unsuccessful' do
+      before do
+        stub_request(:post, 'https://launchpad.net/+request-token').
+           to_raise(::Net::HTTPFatalError.new(%Q{502 "Bad Gateway"}, nil))
+        get '/auth/launchpad'
+      end
+
+      it 'should call fail! with :service_unavailable' do
+        last_request.env['omniauth.error'].should be_kind_of(::Net::HTTPFatalError)
+        last_request.env['omniauth.error.type'] = :service_unavailable
+      end
+
+      context "SSL failure" do
+        before do
+          stub_request(:post, 'https://launchpad.net/+request-token').
+             to_raise(::OpenSSL::SSL::SSLError.new("SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed"))
+          get '/auth/launchpad'
+        end
+
+        it 'should call fail! with :service_unavailable' do
+          last_request.env['omniauth.error'].should be_kind_of(::OpenSSL::SSL::SSLError)
+          last_request.env['omniauth.error.type'] = :service_unavailable
+        end
+      end
+    end
+  end
+
+  describe '/auth/launchpad/callback' do
+    before do
+      body =<<BODY
+oauth_token=PsK9cpbll1KwehhRDckr&oauth_token_secret=M2hsnmsfEIAjS3bTWg6t8X2GKhlm152PRDjLLmtQdr9C8KFZWPl9c8QbLfWddE0qpz5L56pMKKFKEfv1&lp.context=None
+BODY
+
+      stub_request(:post, 'https://launchpad.net/+request-token').
+        to_return(:body => "oauth_token=yourtoken&oauth_token_secret=yoursecret")
+      stub_request(:post, "https://launchpad.net/+access-token").
+         with(:body =>  hash_including({"oauth_consumer_key"=>"testing-launchpad", 
+                                        "oauth_signature"=>"&yoursecret", 
+                                        "oauth_signature_method"=>"PLAINTEXT", 
+                                        "oauth_token"=>"yourtoken", 
+                                        "oauth_version"=>"1.0"})).
+         to_return(:status => 200, :body => body, :headers => {})
+      stub_request(:get, "https://api.launchpad.net/devel/people/+me").
+        to_return(:status => 302, :headers => {"location" =>"https://api.launchpad.net/devel/~theguy"})
+      stub_request(:get, "https://api.launchpad.net/devel/~theguy").
+        to_return(:status => 200, :body => "bamm")
+        
+       get '/auth/launchpad/callback', {}, {'rack.session' => {'oauth' => {"launchpad" => {'callback_confirmed' => true, 'request_token' => 'yourtoken', 'request_secret' => 'yoursecret'}}}}
+    end
+
+
+    context "bad gateway (or any 5xx) for access_token" do
+      before do
+        stub_request(:post, 'https://launchpad.net/+access-token').
+           to_raise(::Net::HTTPFatalError.new(%Q{502 "Bad Gateway"}, nil))
+        get '/auth/launchpad/callback', {:oauth_verifier => 'dudeman'}, {'rack.session' => {'oauth' => {"launchpad" => {'callback_confirmed' => true, 'request_token' => 'yourtoken', 'request_secret' => 'yoursecret'}}}}
+      end
+
+      it 'should call fail! with :service_unavailable' do
+        last_request.env['omniauth.error'].should be_kind_of(::Net::HTTPFatalError)
+        last_request.env['omniauth.error.type'] = :service_unavailable
+      end
+    end
+
+    context "SSL failure" do
+      before do
+        stub_request(:post, 'https://launchpad.net/+access-token').
+           to_raise(::OpenSSL::SSL::SSLError.new("SSL_connect returned=1 errno=0 state=SSLv3 read server certificate B: certificate verify failed"))
+        get '/auth/launchpad/callback', {:oauth_verifier => 'dudeman'}, {'rack.session' => {'oauth' => {"launchpad" => {'callback_confirmed' => true, 'request_token' => 'yourtoken', 'request_secret' => 'yoursecret'}}}}
+      end
+
+      it 'should call fail! with :service_unavailable' do
+        last_request.env['omniauth.error'].should be_kind_of(::OpenSSL::SSL::SSLError)
+        last_request.env['omniauth.error.type'] = :service_unavailable
+      end
+    end
+  end
+
+  describe '/auth/launchpad/callback with expired session' do
+    before do
+      stub_request(:post, 'https://launchpad.net/+request-token').
+         to_return(:body => "oauth_token=yourtoken&oauth_token_secret=yoursecret")
+      get '/auth/launchpad/callback', {:oauth_verifier => 'dudeman'}, {'rack.session' => {}}
+    end
+
+    it 'should call fail! with :session_expired' do
+      last_request.env['omniauth.error'].should be_kind_of(::OmniAuth::NoSessionError)
+      last_request.env['omniauth.error.type'] = :session_expired
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,15 @@
+$:.unshift File.expand_path('..', __FILE__)
+$:.unshift File.expand_path('../../lib', __FILE__)
+require 'simplecov'
+SimpleCov.start
+require 'rspec'
+require 'rack/test'
+require 'webmock/rspec'
+require 'omniauth'
+require 'omniauth-oauth'
+
+RSpec.configure do |config|
+  config.include WebMock::API
+  config.include Rack::Test::Methods
+  config.extend  OmniAuth::Test::StrategyMacros, :type => :strategy
+end

metadata

@@ -1,29 +1,29 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-launchpad
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.1.0
 platform: ruby
 authors:
 - João Pereira
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-04-04 00:00:00.000000000 Z
+date: 2017-04-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -144,13 +144,12 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - Gemfile
 - LICENSE.txt
 - README.md
 - Rakefile
-- example/Gemfile
-- example/Gemfile.lock
-- example/config.ru
 - example/simple/Gemfile
 - example/simple/Gemfile.lock
 - example/simple/My Runner.run
@@ -160,6 +159,8 @@ files:
 - lib/omniauth/launchpad/version.rb
 - lib/omniauth/strategies/launchpad.rb
 - omniauth-launchpad.gemspec
+- spec/omniauth/strategies/launchpad_spec.rb
+- spec/spec_helper.rb
 homepage: ''
 licenses:
 - MIT
@@ -172,7 +173,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: 1.9.2
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -180,8 +181,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.2
+rubygems_version: 2.6.10
 signing_key: 
 specification_version: 4
 summary: Launchpad login for OmniAuth
-test_files: []
+test_files:
+- spec/omniauth/strategies/launchpad_spec.rb
+- spec/spec_helper.rb

data/example/Gemfile

@@ -1,4 +0,0 @@
-source :rubygems
-gem 'sinatra'
-gem 'omniauth-launchpad', :path => '../../'
-gem 'omniauth'

data/example/Gemfile.lock

@@ -1,36 +0,0 @@
-PATH
-  remote: ../../
-  specs:
-    omniauth-launchpad (0.0.1)
-      multi_json (~> 1.3)
-      omniauth (>= 1.1.1)
-      omniauth-oauth (>= 1.0.1)
-
-GEM
-  remote: http://rubygems.org/
-  specs:
-    hashie (3.4.1)
-    multi_json (1.11.0)
-    oauth (0.4.7)
-    omniauth (1.2.2)
-      hashie (>= 1.2, < 4)
-      rack (~> 1.0)
-    omniauth-oauth (1.0.1)
-      oauth
-      omniauth (~> 1.0)
-    rack (1.6.0)
-    rack-protection (1.5.3)
-      rack
-    sinatra (1.4.6)
-      rack (~> 1.4)
-      rack-protection (~> 1.4)
-      tilt (>= 1.3, < 3)
-    tilt (2.0.1)
-
-PLATFORMS
-  ruby
-
-DEPENDENCIES
-  omniauth
-  omniauth-launchpad!
-  sinatra

data/example/config.ru

@@ -1,43 +0,0 @@
-require 'bundler/setup'
-require 'sinatra/base'
-require 'omniauth'
-require 'launchpad'
-
-
-
-class App < Sinatra::Base
-
-  get '/' do
-    redirect '/auth/launchpad'
-  end
-  # Support both GET and POST for callbacks
-  %w(get post).each do |method|
-    send(method, "/auth/:provider/callback") do
-      # Everything you care about is in env['omniauth.auth']
-      # You'll probably want to keep track of your credential hash somewhere.
-      # Loading it into a client object should be easy:
-      # client.authorization.update_token!(credential_hash)
-      content_type 'application/json'
-      MultiJson.encode(request.env)
-    end
-  end
-  get '/auth/failure' do
-    content_type 'application/json'
-    MultiJson.encode(request.env)
-  end
-end
-
-use Rack::Session::Cookie
-
-use OmniAuth::Builder do
-  provider :launchpad,
-    ENV['CLIENT_ID'],
-    ENV['CLIENT_SECRET'],
-    :scope => [
-      'https://www.googleapis.com/auth/userinfo.profile',
-      'https://www.googleapis.com/auth/plus.me'
-    ],
-    :skip_info => false
-end
-
-run App.new