omniauth-latvija 4.0.0 → 5.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: '09b2671984f3e6cae04fb9c89aa8cee876a1064f'
-  data.tar.gz: 9c2a5f397af09733dc4658633d6a2c438a422ed4
+SHA256:
+  metadata.gz: 9bd3dccbc8a7d0c3085a09fdbdfcade5add5a37957b3feb2bfc39db7a645ff6e
+  data.tar.gz: 6ecb7bd1e3a242e1e7fce010e4902c7937953da93abda12b2567c7fd61e1f2e0
 SHA512:
-  metadata.gz: e6f72751d59002fbd7d5a0b05a2a3e9024f163ac03b476359cbbeb5ac0904f333bd46ddc0e4bf55dde10f34b9489717d9fa9f8c262b5d32c49ff780091283cac
-  data.tar.gz: 806a5ffc9ef76e432a1d0e0e851cef0b5758cda40690bcdefd6647bdd3836f38575b1d18ee2c0a9369f9b6cf0b12344c04673edf9dae033ef4fb669ed792e0fb
+  metadata.gz: 9ce3aac6b6409192882ea39b190dd77b5e364bc038c7204d6bdaeb76b546529eaf9b60c07cb445b36b57216379b9977257775a94bda4b64eaa5f1e3a2392d9df
+  data.tar.gz: 9a951c691b8314fd084a490cbe528e66901bf77da147f6412eeedd7208b334df9998e966c32accf02002c880524cd3e9b9300b97fb1c0c90907e2e79e0051f43

data/README.md

@@ -19,7 +19,7 @@ Provides the following authentication types:
 ## Installation
 
 ```ruby
-gem 'omniauth-latvija', '~> 2.0'
+gem 'omniauth-latvija'
 ```
 
 ## Usage
@@ -47,7 +47,7 @@ Here's an example hash available in `request.env['omniauth.auth']`
 ```ruby
 {
   provider: 'latvija',
-  uid: 'JANIS BERZINS, 12345612345',
+  uid: 'PK:12345612345',
   info: {
     name: 'JANIS BERZINS',
     first_name: 'JANIS',
@@ -56,14 +56,15 @@ Here's an example hash available in `request.env['omniauth.auth']`
   },
   extra: {
     raw_info: {
-      name: 'JANIS BERZINS',
-      first_name: 'JANIS',
-      last_name: 'BERZINS',
-      private_personal_identifier: '12345612345',
+      givenname: 'JANIS',
+      surname: 'BERZINS',
+      privatepersonalidentifier: '12345612345',
+      historical_privatepersonalidentifier: [],
       not_valid_before: '2019-05-09T07:29:41Z',
       not_valid_on_or_after: '2019-05-09T08:29:41Z'
     },
-    authentication_method: 'SWEDBANK'
+    authentication_method: 'SWEDBANK',
+    legacy_uids: ['JANIS BERZINS, 12345612345']
   }
 }
 ```

data/lib/omniauth-latvija/version.rb

@@ -1,5 +1,5 @@
 module OmniAuth
   module Latvija
-    VERSION = '4.0.0'
+    VERSION = '5.0.0'
   end
 end

data/lib/omniauth/strategies/latvija.rb

@@ -34,11 +34,9 @@ module OmniAuth::Strategies
     option :certificate, nil
     option :private_key, nil
 
-    uid { "#{raw_info['givenname']} #{raw_info['surname']}, #{raw_info["privatepersonalidentifier"]}" }
-
     info do
       {
-        name: "#{raw_info['givenname']} #{raw_info['surname']}",
+        name: full_name,
         first_name: raw_info['givenname'],
         last_name: raw_info['surname'],
         private_personal_identifier: raw_info['privatepersonalidentifier']
@@ -48,7 +46,8 @@ module OmniAuth::Strategies
     extra do
       {
         raw_info: raw_info,
-        authentication_method: @response.authentication_method
+        authentication_method: @response.authentication_method,
+        legacy_uids: legacy_uids
       }
     end
 
@@ -85,5 +84,28 @@ module OmniAuth::Strategies
     def raw_info
       @response.attributes
     end
+
+    def uid
+      @response.name_identifier
+    end
+
+    def full_name
+      @full_name ||= "#{raw_info['givenname']} #{raw_info['surname']}"
+    end
+
+    def legacy_uids
+      # UIDs that could have been assigned to this identity by previous versions of the gem, or due to peronal identifier change
+
+      legacy_uids = [
+        "#{full_name}, #{raw_info["privatepersonalidentifier"]}" # generated by gem version <= 4.0
+      ]
+
+      raw_info.fetch('historical_privatepersonalidentifier', []).each do |historical_identifier|
+        legacy_uids << "#{full_name}, #{historical_identifier}" # generated by gem version <= 4.0
+        legacy_uids << "PK:#{historical_identifier}" # due to personal identifier change
+      end
+
+      legacy_uids
+    end
   end
 end

data/lib/omniauth/strategies/latvija/response.rb

@@ -26,23 +26,39 @@ module OmniAuth::Strategies
         end
       end
 
+      def name_identifier
+        @name_identifier ||= begin
+          xml.xpath('//saml:AuthenticationStatement/saml:Subject/saml:NameIdentifier', saml: ASSERTION).text()
+        end
+      end
+
       # A hash of all the attributes with the response.
       # Assuming there is only one value for each key
       def attributes
         @attributes ||= begin
           attrs = {
             'not_valid_before' => not_valid_before,
-            'not_valid_on_or_after' => not_valid_on_or_after
+            'not_valid_on_or_after' => not_valid_on_or_after,
+            'historical_privatepersonalidentifier' => []
           }
 
           stmt_elements = xml.xpath('//a:Attribute', a: ASSERTION)
           return attrs if stmt_elements.nil?
 
           stmt_elements.each_with_object(attrs) do |element, result|
-            name  = element.attribute('AttributeName').value
+            name = element.attribute('AttributeName').value
             value = element.text
 
-            result[name] = value
+            case name
+            when 'privatepersonalidentifier' # person can change their identifier, service will return all the versions
+              if element.attribute('OriginalIssuer') # this is the primary identifier, as returned by third party auth service
+                result[name] = value
+              else
+                result['historical_privatepersonalidentifier'] << value
+              end
+            else
+              result[name] = value
+            end
           end
         end
       end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: omniauth-latvija
 version: !ruby/object:Gem::Version
-  version: 4.0.0
+  version: 5.0.0
 platform: ruby
 authors:
 - Edgars Beigarts
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-05-09 00:00:00.000000000 Z
+date: 2019-11-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: omniauth
@@ -170,7 +170,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.14
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Latvija.lv authentication strategy for OmniAuth